lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(job-array-one-based-index): feature validation round 1 follow-ups

Browse source 
bug-1903 partial (page-token precision fixed in efff6b65), bug-1907
logged (harness setpend/jobrun cannot report not-found), stale
parse_jobid regex comment in repl.c updated.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Rongsong Shen 2026-10-01 15:50:10 +00:00
parent efff6b658f
commit 0f4effe7df
Signed by untrusted user: rshen
GPG key ID: 80533536B0EB651C
5 changed files with 100 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
.wolf/bugs/bug-1903.md
View file

@ -1,8 +1,8 @@
---
id: "bug-1903"
status: "open"
status: "partial"
status_updated: "2026-10-01"
status_note: "newly logged"
status_note: "page-token float64 precision loss for array element IDs fixed in efff6b65; the original GetJobsInfo repeat-first-page symptom with plain jobs is still unexplained"
component: "apiserver"
severity: "wrong-result"
timestamp: "2026-10-01T12:21:25Z"
@ -37,15 +37,17 @@ related: []
- Evidence: not kept (reviewer's temporary probe test, deleted)
## Root cause
TODO: required for fixed/partial
Two separate parts:
1. (found 2026-10-01, fixed) `store/query.go` `findPageTokenIndex` decoded the token with `json.Unmarshal` into `interface{}`, so `unique_job_id` became a float64. Array element IDs set bit 62, where float64 spacing is 1024, so the token no longer named the page's last row: paging skipped rows (N >= 1024) or found no match and restarted at row 0 (1001 <= N <= 1023). `queryControlRowsByJobID`, `FetchJobList` and `GetJobByIDs` page until the token is empty, so the restart case loops forever.
2. (open) The originally observed repeat-the-first-page with plain jobs and a small `limit` in `GetJobsInfo` is not explained by part 1 for IDs below 2^53; cause not yet found.
## Fix
TODO: required for fixed/partial
Part 1: efff6b65. `findPageTokenIndex` decodes with `json.Decoder.UseNumber()` and converts integers to int64 (floats stay float64). Part 2: not yet fixed.
## Verification
- Test: TODO: name + file; RED before the fix, GREEN after
- Suites: TODO: suite results and build profile
- Live: TODO: soak/deploy run, or n/a and why
- Test: (part 1) `TestPaginateRowsArrayElementIDsRoundTripPageToken` in `src/frontend/apiserver/store/query_test.go`; RED before the fix (2452 of 2500 rows), GREEN after
- Suites: apiserver store/utils/controllers go test ok (CGO_ENABLED=0)
- Live: n/a (unit-level; part 2 still needs a reproduction)
## References
- Related: bug-1898 (found while fixing it)

58
.wolf/bugs/bug-1907.md Normal file
View file

@ -0,0 +1,58 @@
---
id: "bug-1907"
status: "open"
status_updated: "2026-10-01"
status_note: "newly logged"
component: "controller"
severity: "wrong-result"
timestamp: "2026-10-01T15:49:05Z"
last_seen: "2026-10-01T15:49:05Z"
occurrences: 1
files: ["src/controller/src/job.c", "src/harness/test.c"]
tags: ["harness", "job-control", "not-found", "job-array"]
related: ["bug-1896"]
---
# bug-1907: harness setpend and jobrun cannot report not-found: the controller acks status 0 first
## Description
**Observed:**
Found by code reading, no failing run captured. Both controller handlers reply before looking the job up:
```
src/controller/job.c:2246 handle_jobdispatch: init_reply_by_req(); reply.status = 0; xce_reply(...) /* then the work */
src/controller/job.c:3869 do_set_preason: init_reply_by_req(); reply.status = 0; xce_reply(...) /* then the work */
```
So harness `jobrun -j <id>` and `setpend -j <id>` succeed for a job (or array element) that does not exist.
**Expected:** like the other single-job commands, `jobrun`/`setpend` on an unknown job ID report "not found" (job-array-one-based-index Requirements 4.7 and 5.13).
**Impact:** wrong result: a test script that targets a wrong element (e.g. `$jobid[0]` on a new array) passes silently instead of failing.
**Found by:** review (job-array-one-based-index task 4.3 implementation notes and feature validation, 2026-10-01)
## Environment
- OS: no /etc/os-release; Docker container; NixOS kernel; kernel Linux 6.18.33 x86_64
- libc: glibc 2.42-47 (interpreter /nix/store/wb6rhpznjfczwlwx23zmdrrw74bayxw4-glibc-2.42-47/lib/ld-linux-x86-64.so.2)
- Toolchain: gcc (GCC) 15.2.0, meson 1.9.1
- Build: asan (src/build.jai)
- Code: scheduler-framework @ efff6b65-dirty
- Deployment: any (controller request handling)
## Reproduction
1. Start a controller (xce-deploy-ha) and run `xce_test` against it.
2. `jobrun -j 0-0-1-5` (an ID that was never submitted) and `setpend` with `-j 0-0-1-5`: both report success (expected from the code; not run).
3. Compare `jobkill -j 0-0-1-5`, which reports not found.
- Frequency: deterministic (by code; not run live, 2026-10-01)
- Evidence: not kept (code references above)
## Root cause
TODO: required for fixed/partial
## Fix
TODO: required for fixed/partial
## Verification
- Test: TODO: name + file; RED before the fix, GREEN after
- Suites: TODO: suite results and build profile
- Live: TODO: soak/deploy run, or n/a and why
## References
- Related: none