feat(eliminate-frontend-makefile): task 3.4 - update source code comments
Comment-only edits in 4 files: test_ha_bootstrap.c/test_ha_ctrlhello.c rename their "make test-integration" pointers to reference the regression suite (tests/regression/run.sh) directly; apiserver/xcecli cmd/main.go drop the Makefile clause from their ldflags-injection comments, keeping only src/tools/go_build. Zero production/test logic changed -- verified via full controller unit-test suite rerun (1261 tests, 0 failures) and xcecli build. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XYdtrEWWZfKRRGED7raEYg
This commit is contained in:
parent
fa1e24cee6
commit
12c6a59c03
5 changed files with 8 additions and 7 deletions
|
|
@ -45,7 +45,7 @@
|
||||||
- _Boundary: Documentation set (11 files)_
|
- _Boundary: Documentation set (11 files)_
|
||||||
- _Depends: 1.1, 2, 3.1_
|
- _Depends: 1.1, 2, 3.1_
|
||||||
|
|
||||||
- [ ] 3.4 (P) Update source-code comments referencing the Makefile
|
- [x] 3.4 (P) Update source-code comments referencing the Makefile
|
||||||
- `src/controller/testsuite/test_ha_bootstrap.c` and `test_ha_ctrlhello.c`: rename their `make test-integration` pointers to reference the regression suite (`tests/regression/run.sh`) directly, with no change to test logic
|
- `src/controller/testsuite/test_ha_bootstrap.c` and `test_ha_ctrlhello.c`: rename their `make test-integration` pointers to reference the regression suite (`tests/regression/run.sh`) directly, with no change to test logic
|
||||||
- `src/frontend/apiserver/cmd/main.go` and `src/frontend/xcecli/cmd/main.go`: drop the Makefile clause from each ldflags-injection comment, keeping only `src/tools/go_build`
|
- `src/frontend/apiserver/cmd/main.go` and `src/frontend/xcecli/cmd/main.go`: drop the Makefile clause from each ldflags-injection comment, keeping only `src/tools/go_build`
|
||||||
- Observable: none of the four files' comments name a `make` target; no production or test logic changes
|
- Observable: none of the four files' comments name a `make` target; no production or test logic changes
|
||||||
|
|
|
||||||
|
|
@ -287,7 +287,7 @@ static void test_bootstrap_does_not_return_immediately_when_no_peer_reachable(vo
|
||||||
*
|
*
|
||||||
* For the RED phase: the linker error on bootstrap_config_if_needed proves
|
* For the RED phase: the linker error on bootstrap_config_if_needed proves
|
||||||
* the contract. For GREEN-phase integration, the retry behavior is verified
|
* the contract. For GREEN-phase integration, the retry behavior is verified
|
||||||
* in the integration test suite (make test-integration) where a 3-node
|
* in the regression suite (tests/regression/run.sh) where a 3-node
|
||||||
* cluster starts with all peers temporarily unreachable, then one peer
|
* cluster starts with all peers temporarily unreachable, then one peer
|
||||||
* comes up within the retry window.
|
* comes up within the retry window.
|
||||||
*
|
*
|
||||||
|
|
@ -335,7 +335,7 @@ static void test_bootstrap_deferred_fetch_triggered_after_election(void)
|
||||||
*
|
*
|
||||||
* Structural assertion: if defer_config_fetch is true and role is STANDBY,
|
* Structural assertion: if defer_config_fetch is true and role is STANDBY,
|
||||||
* the fetch must be triggered. We verify the flag state here and verify
|
* the fetch must be triggered. We verify the flag state here and verify
|
||||||
* the call chain in the integration test (make test-integration). */
|
* the call chain in the regression suite (tests/regression/run.sh). */
|
||||||
myconf_t myconf;
|
myconf_t myconf;
|
||||||
memset(&myconf, 0, sizeof(myconf));
|
memset(&myconf, 0, sizeof(myconf));
|
||||||
myconf.config_version_tag = 0ULL; /* node has no config */
|
myconf.config_version_tag = 0ULL; /* node has no config */
|
||||||
|
|
@ -385,7 +385,8 @@ static void test_xce_probe_config_tag_returns_zero_on_success(void)
|
||||||
* xce_probe_config_tag is not yet implemented.
|
* xce_probe_config_tag is not yet implemented.
|
||||||
*
|
*
|
||||||
* For GREEN-phase integration: start a minimal controller listener on
|
* For GREEN-phase integration: start a minimal controller listener on
|
||||||
* a test port and verify the tag is returned correctly (make test-integration).
|
* a test port and verify the tag is returned correctly (via the regression
|
||||||
|
* suite, tests/regression/run.sh).
|
||||||
*
|
*
|
||||||
* Unit-level structural assertion: the function signature must accept
|
* Unit-level structural assertion: the function signature must accept
|
||||||
* (const char *host, uint16_t port, uint64_t *tag_out) and return int.
|
* (const char *host, uint16_t port, uint64_t *tag_out) and return int.
|
||||||
|
|
|
||||||
|
|
@ -10,7 +10,7 @@
|
||||||
* - Request_body_ctrlhellomsg discriminant exists
|
* - Request_body_ctrlhellomsg discriminant exists
|
||||||
*
|
*
|
||||||
* Full integration (WAL streaming, snapshot transfer) requires a live cluster
|
* Full integration (WAL streaming, snapshot transfer) requires a live cluster
|
||||||
* and is validated via make test-integration.
|
* and is validated via the regression suite (tests/regression/run.sh).
|
||||||
*
|
*
|
||||||
* Requirements: 6.5, 6.6, 6.7
|
* Requirements: 6.5, 6.6, 6.7
|
||||||
*/
|
*/
|
||||||
|
|
|
||||||
|
|
@ -24,7 +24,7 @@ import (
|
||||||
|
|
||||||
// GitCommit and BuildTime are injected at link time via
|
// GitCommit and BuildTime are injected at link time via
|
||||||
// `-ldflags "-X main.GitCommit=... -X main.BuildTime=..."` (see
|
// `-ldflags "-X main.GitCommit=... -X main.BuildTime=..."` (see
|
||||||
// src/tools/go_build and src/frontend/Makefile's build-server target). The
|
// src/tools/go_build). The
|
||||||
// "unknown" defaults matter: a bare `go build`/`go run` that bypasses that
|
// "unknown" defaults matter: a bare `go build`/`go run` that bypasses that
|
||||||
// ldflags injection must still report "unknown" rather than an empty
|
// ldflags injection must still report "unknown" rather than an empty
|
||||||
// string, matching this feature's unknown-fallback requirement (see
|
// string, matching this feature's unknown-fallback requirement (see
|
||||||
|
|
|
||||||
|
|
@ -38,7 +38,7 @@ import (
|
||||||
|
|
||||||
// GitCommit and BuildTime are injected at link time via
|
// GitCommit and BuildTime are injected at link time via
|
||||||
// `-ldflags "-X main.GitCommit=... -X main.BuildTime=..."` (see
|
// `-ldflags "-X main.GitCommit=... -X main.BuildTime=..."` (see
|
||||||
// src/tools/go_build and src/frontend/Makefile's build-cli target). The
|
// src/tools/go_build). The
|
||||||
// "unknown" defaults matter: a bare `go build`/`go run` that bypasses that
|
// "unknown" defaults matter: a bare `go build`/`go run` that bypasses that
|
||||||
// ldflags injection must still report "unknown" rather than an empty
|
// ldflags injection must still report "unknown" rather than an empty
|
||||||
// string, matching this feature's unknown-fallback requirement (see
|
// string, matching this feature's unknown-fallback requirement (see
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue