lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(ha-repl-hardening): snapshot transfer integration and dispatch-path tests (task 3.5d)

Browse source 
- Add ha_repl_send_snapshot_hook seam in ha.c/ha.h for XCE_TESTING
- test_dispatch_repl_action_send_snapshot: verifies SEND_SNAPSHOT
  decision triggers hook when standby_lsn < oldest_wal_lsn
- test_snapshot_recv_two_chunks_assembles_and_renames: verifies standby
  assembles snap.part across chunks and renames on isLast=true
- test_snapshot_recv_reconnect_discards_snappart: verifies O_TRUNC
  semantics on chunk_index==0 restart after reconnect
- All tests pass under ASAN
This commit is contained in:
Rongsong Shen 2026-06-05 02:13:11 +00:00
parent cbd91fca43
commit 18ad3e9c9f
5 changed files with 207 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

107
src/controller/testsuite/test_config_repl.c
View file

@ -1803,6 +1803,111 @@ static void test_snapshot_recv_null_args_fail(void)
printf("test_snapshot_recv_null_args_fail: PASS\n");
}
/* Test 3.5d: reconnected standby discards snap.part and restarts from chunk 0.
*
* Design §Snapshot Transfer: "Mid-transfer reconnect always restarts snapshot
* from chunk 0 — the standby discards its partial snap.part file on reconnect."
* The discard (unlink) is done by the ctrlhello handler before the first chunk
* of a new transfer arrives. This test verifies that:
* 1. After receiving chunk 0 (creating snap.part), if the caller unlinks
* snap.part (simulating reconnect/reset) and then calls ha_handle_snapshot_chunk
* again with chunk_index=0, the function creates a fresh snap.part
* (not appending to a previous stale file).
* 2. The resulting snap.part contains only the new chunk's bytes (not a
* concatenation of old + new data).
*
* Requirement: 4.4 (ha-repl-hardening) — retry by reconnecting initiates new transfer.
*/
static void test_snapshot_recv_reconnect_discards_snappart(void)
{
char tmpdir[] = "/tmp/xcectest_snapreconn_XXXXXX";
TEST_ASSERT_NOT_NULL(mkdtemp(tmpdir));
char snap_dir[512];
snprintf(snap_dir, sizeof(snap_dir), "%s/snap", tmpdir);
TEST_ASSERT_EQUAL_INT(0, mkdir(snap_dir, 0700));
persist_t *p = calloc(1, sizeof(persist_t));
TEST_ASSERT_NOT_NULL(p);
persist_config_t pcfg = persist_config_defaults();
persist_set_workdir(p, tmpdir, "ctrl-snapreconn");
persist_init(p, &pcfg, NULL);
persist_start(p);
ha_state_t ha;
snap_recv_ha_init(&ha);
uint64_t snap_lsn = 300;
uint8_t first[64];
uint8_t second[64];
memset(first, 0xAA, 64);
memset(second, 0xBB, 64);
/* ── First transfer attempt: send chunk 0 ── */
snapshot_transfer_t c0;
memset(&c0, 0, sizeof(c0));
c0.snapshot_lsn = snap_lsn;
c0.chunk_index = 0;
c0.chunk_offset = 0;
c0.total_size = 64; /* single-chunk transfer */
c0.is_last = 0; /* not last — simulates partial in-flight transfer */
int rc = ha_handle_snapshot_chunk(&ha, p, snap_dir, &c0, first, 64);
TEST_ASSERT_EQUAL_INT(0, rc);
/* snap.part must exist and contain exactly 64 bytes (first chunk) */
char part_path[600];
snprintf(part_path, sizeof(part_path), "%s/snap.part", snap_dir);
struct stat st;
TEST_ASSERT_EQUAL_INT_MESSAGE(0, stat(part_path, &st),
"snap.part must exist after first chunk");
TEST_ASSERT_EQUAL_UINT64_MESSAGE(64, (uint64_t)st.st_size,
"snap.part must be 64 bytes after first chunk");
/* ── Simulate reconnect: caller discards snap.part ── */
TEST_ASSERT_EQUAL_INT_MESSAGE(0, unlink(part_path),
"unlink snap.part must succeed (simulating reconnect)");
/* ── Second transfer attempt: restart from chunk 0 ── */
snapshot_transfer_t c0b;
memset(&c0b, 0, sizeof(c0b));
c0b.snapshot_lsn = snap_lsn;
c0b.chunk_index = 0;
c0b.chunk_offset = 0;
c0b.total_size = 64;
c0b.is_last = 0; /* still not last — just verifying discard */
rc = ha_handle_snapshot_chunk(&ha, p, snap_dir, &c0b, second, 64);
TEST_ASSERT_EQUAL_INT(0, rc);
/* snap.part must exist and contain exactly 64 bytes (second chunk only,
* not 128 bytes which would indicate old data was appended) */
TEST_ASSERT_EQUAL_INT_MESSAGE(0, stat(part_path, &st),
"snap.part must exist after reconnect chunk 0");
TEST_ASSERT_EQUAL_UINT64_MESSAGE(64, (uint64_t)st.st_size,
"snap.part must be 64 bytes (not 128) — stale data discarded");
/* Verify the content is the second chunk (0xBB bytes), not the first (0xAA) */
FILE *f = fopen(part_path, "rb");
TEST_ASSERT_NOT_NULL_MESSAGE(f, "snap.part must be readable");
uint8_t buf[64];
size_t n = fread(buf, 1, 64, f);
fclose(f);
TEST_ASSERT_EQUAL_UINT64_MESSAGE(64, (uint64_t)n, "must read 64 bytes from snap.part");
TEST_ASSERT_EQUAL_UINT8_MESSAGE(0xBB, buf[0],
"snap.part content must be second chunk (0xBB), not first (0xAA)");
ha_fini(&ha);
persist_stop(p);
persist_fini(p);
free(p);
char cmd[512];
snprintf(cmd, sizeof(cmd), "rm -rf %s", tmpdir);
system(cmd);
printf("test_snapshot_recv_reconnect_discards_snappart: PASS\n");
}
#endif /* XCE_TESTING */
/* ── dispatch ───────────────────────────────────── */
@ -1854,6 +1959,8 @@ void test_config_repl(void)
RUN_TEST(test_snapshot_recv_two_chunks_assembles_and_renames);
RUN_TEST(test_snapshot_recv_size_mismatch_fails);
RUN_TEST(test_snapshot_recv_null_args_fail);
/* Task 3.5d: reconnect discards snap.part */
RUN_TEST(test_snapshot_recv_reconnect_discards_snappart);
#endif
/* Task A: raw capnp shims */
RUN_TEST(test_replconfig_req_ssl_encode);