lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(controller): clusterconfig-schema-split task 2.3 — remove dead port defaulting

Browse source 
Removes SET_DEFAULT_IF_UNSET(c->port, 0, 9990) from fill_default_cluster_config()
in myconf.c and config_repl.c, now dead since cluster_config_t.port was removed
in task 1.2 and cluster_open_listener stopped reading it in task 2.1. All of
src/controller/{cluster,myconf,config_repl}.c now compile clean.
This commit is contained in:
Rongsong Shen 2026-07-21 04:29:28 +00:00
parent 81fecb497c
commit 1fa784434f
3 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.kiro/specs/clusterconfig-schema-split/tasks.md
View file

@ -45,7 +45,7 @@
- _Depends: 1.2_ - _Depends: 1.2_
- _Boundary: Debug-Dump Component (cluster.c)_ - _Boundary: Debug-Dump Component (cluster.c)_
- [ ] 2.3 Remove the now-dead `ClusterConfig` port defaulting in `myconf.c` and `config_repl.c` - [x] 2.3 Remove the now-dead `ClusterConfig` port defaulting in `myconf.c` and `config_repl.c`
- Delete the `SET_DEFAULT_IF_UNSET(c->port, 0, 9990)` call in `myconf.c` - Delete the `SET_DEFAULT_IF_UNSET(c->port, 0, 9990)` call in `myconf.c`
- Delete the equivalent `SET_DEFAULT_IF_UNSET(c->port, 0, 9990)` call in `config_repl.c` - Delete the equivalent `SET_DEFAULT_IF_UNSET(c->port, 0, 9990)` call in `config_repl.c`
- Observable: `myconf.c` and `config_repl.c` compile without referencing `cluster_config_t`'s `port` member - Observable: `myconf.c` and `config_repl.c` compile without referencing `cluster_config_t`'s `port` member

1
src/controller/config_repl.c
View file

@ -584,7 +584,6 @@ static void *s_probe_ssl_ctx = NULL;
static void fill_default_cluster_config(cluster_config_t *c) static void fill_default_cluster_config(cluster_config_t *c)
{ {
SET_DEFAULT_IF_UNSET(c->port, 0, 9990);
SET_DEFAULT_IF_UNSET(c->heartbeat_interval, 0, 5); SET_DEFAULT_IF_UNSET(c->heartbeat_interval, 0, 5);
SET_DEFAULT_IF_UNSET(c->fetch_job_interval, 0, 10); SET_DEFAULT_IF_UNSET(c->fetch_job_interval, 0, 10);
} }

1
src/controller/myconf.c
View file

@ -71,7 +71,6 @@ static int cluster_hook_fun(int type, int situation, int detail, void* data,
static void fill_default_cluster_config(cluster_config_t* c) static void fill_default_cluster_config(cluster_config_t* c)
{ {
SET_DEFAULT_IF_UNSET(c->port, 0, 9990);
SET_DEFAULT_IF_UNSET(c->heartbeat_interval, 0, 5); SET_DEFAULT_IF_UNSET(c->heartbeat_interval, 0, 5);
SET_DEFAULT_IF_UNSET(c->fetch_job_interval, 0, 10); SET_DEFAULT_IF_UNSET(c->fetch_job_interval, 0, 10);
} }