chore(buglog): bug-1885..1889 fixed
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
9c51de88c6
commit
7b001cb0f7
6 changed files with 214 additions and 36 deletions
|
|
@ -1,8 +1,8 @@
|
|||
---
|
||||
id: "bug-1885"
|
||||
status: "open"
|
||||
status: "fixed"
|
||||
status_updated: "2026-09-29"
|
||||
status_note: "newly logged"
|
||||
status_note: ""
|
||||
component: "scheduler"
|
||||
severity: "leak"
|
||||
timestamp: "2026-09-29T09:48:44Z"
|
||||
|
|
@ -11,6 +11,7 @@ occurrences: 1
|
|||
files: ["src/scheduler/src/driver.c", "src/scheduler/src/decision.c"]
|
||||
tags: ["scheduler", "leak", "decision"]
|
||||
related: ["bug-1884"]
|
||||
fix_commits: ["d21b3d8f"]
|
||||
---
|
||||
|
||||
# bug-1885: scheduler normal mode never frees decision structs: 64 bytes leaked per published decision
|
||||
|
|
@ -46,15 +47,15 @@ cbuf_get(&(sched->core.decisions), &decision);
|
|||
- Evidence: not kept; code reading
|
||||
|
||||
## Root cause
|
||||
TODO: required for fixed/partial
|
||||
`xce_sched_driver_run_normal_mode_round()` (driver.c) drains each decision from `core->decisions`, records it and passes it to `on_decision`, and never frees the struct `make_*_decision()` (decision.c) allocates.
|
||||
|
||||
## Fix
|
||||
TODO: required for fixed/partial
|
||||
The round frees the decision struct after the callback returns (d21b3d8f). Its allocation/pend reason belong to the job; the publish callback passes those pointers on and the recorder copies, so nothing keeps the struct. Tests with their own drain loops (test_core_full_cycle.c, test_core_session.c, test_snapshot_save_load.c) are unaffected.
|
||||
|
||||
## Verification
|
||||
- Test: TODO: name + file; RED before the fix, GREEN after
|
||||
- Suites: TODO: suite results and build profile
|
||||
- Live: TODO: soak/deploy run, or n/a and why
|
||||
- Test: test_round_frees_decision_after_callback in src/scheduler/testsuite/test_driver_session_ordering.c (drives the real round with a stand-in allocator emitting one PEND; checks the struct is freed via __asan_address_is_poisoned and the reason is not): RED before, GREEN after
|
||||
- Suites: ASAN debug build (src/xce.build.discrete), `meson test --no-suite xceadmin`: 117/117 OK, 0 sanitizer reports; xcelib_test 695 tests 0 failures (2026-09-29)
|
||||
- Live: 3-round sequential HA soak on rebuilt ASAN binaries (/home/claude/tmp/xce-bug1885-soak, 2026-09-29): PASS, 15 jobs, zero job loss, all 3 nodes led; SIMVERIFY 4 files 0 mismatches; each recording replays with detect_leaks=1 at exit 0, 0 mismatches; no sanitizer report in the scheduler or controller stderr
|
||||
|
||||
## References
|
||||
- Related: bug-1884
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue