chore(buglog): bug-1885..1889 fixed

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

.wolf/bugs/bug-1887.md

@@ -1,8 +1,8 @@
 ---
 id: "bug-1887"
-status: "open"
+status: "fixed"
 status_updated: "2026-09-29"
-status_note: "newly logged"
+status_note: ""
 component: "lib"
 severity: "wrong-result"
 timestamp: "2026-09-29T09:48:49Z"
@@ -11,6 +11,7 @@ occurrences: 1
 files: ["src/lib/xce_resreq.peg", "src/lib/resreq.c"]
 tags: ["lib", "resreq", "parser"]
 related: ["bug-1884"]
+fix_commits: ["b5712c05"]
 ---
 
 # bug-1887: resreq parser ignores a primary's select/rusage parse error and accepts the job without that clause
@@ -45,15 +46,15 @@ produced during a normal replay fixture (its job's resreq parsed "OK").
 - Evidence: not kept; LeakSanitizer stack from the bug-1884 fixture (strdup in parse_select error path under core_build_job)
 
 ## Root cause
-TODO: required for fixed/partial
+The `primary_resreq` action in src/lib/xce_resreq.peg ignored `parse_resreq_primary()`'s result and nothing set `has_error`, so `parse_resreq()` succeeded for a primary whose select/rusage clause failed to parse and the job kept no such clause. Confirmed with a probe (2026-09-29): `select[type==]`, `select[mem>]`, `select[type==any && ]` all returned rc=1 with select NULL; `select[gpu>1]` with no gpu resource likewise.
 
 ## Fix
-TODO: required for fixed/partial
+A malformed clause now fails the whole resreq and `parse_resreq()` returns the clause's own message (b5712c05). A select naming an unregistered resource is still dropped rather than rejected: parse_select() reports it as -ENOENT (new select_context_t.unknown_resource) and the action lets it pass, because jobs rely on it -- the scheduler's own "type == any" default among them when no "type" resource is registered (making it fatal failed 36 scheduler suites). Whether an unknown resource in a select should reject the job is left as a separate decision. Making syntax errors fatal exposed bug-1888.
 
 ## Verification
-- Test: TODO: name + file; RED before the fix, GREEN after
-- Suites: TODO: suite results and build profile
-- Live: TODO: soak/deploy run, or n/a and why
+- Test: test_resreq_primary_select_error_fails_parse in src/lib/testsuite/test_resreq.c (xkvmgr resmgr with type/mem; syntax errors incl. inside a compound fail with a message; unknown resource still parses with select NULL; valid select kept): RED before (all accepted), GREEN after
+- Suites: ASAN debug build (src/xce.build.discrete), `meson test --no-suite xceadmin`: 117/117 OK, 0 sanitizer reports; xcelib_test 695 tests 0 failures (2026-09-29)
+- Live: 3-round sequential HA soak on rebuilt ASAN binaries (/home/claude/tmp/xce-bug1885-soak, 2026-09-29): PASS, 15 jobs, zero job loss, all 3 nodes led; SIMVERIFY 4 files 0 mismatches; each recording replays with detect_leaks=1 at exit 0, 0 mismatches; no sanitizer report in the scheduler or controller stderr
 
 ## References
 - Related: bug-1884