lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(buglog): log bug-1969 (autoscaler forks from a multi-threaded process)

Browse source 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Rongsong Shen 2026-10-10 13:36:02 +00:00
parent 6dd70f1091
commit 832e397351
Signed by untrusted user: rshen
GPG key ID: 80533536B0EB651C
2 changed files with 90 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

24
.wolf/buglog.json
View file

@ -18735,6 +18735,30 @@
"record": ".wolf/bugs/bug-1968.md",
"gitea_issue": 399,
"gitea_synced_status": "open"
},
{
"id": "bug-1969",
"status": "open",
"status_updated": "2026-10-10",
"status_note": "newly logged",
"component": "autoscaler",
"severity": "hang",
"timestamp": "2026-10-10T13:29:02Z",
"last_seen": "2026-10-10T13:29:02Z",
"occurrences": 1,
"error_message": "autoscaler forks from a multi-threaded process and runs unsafe code in the child (plug_mgr.c)\n\n**Observed:** (source reading, 2026-10-10; found while introducing the no-fork rule, `.kiro/steering/tech.md` \"Process Creation\")\nThe autoscaler is multi-threaded (`scaler.c:589`/`:596` start `scaler_monitor` and `scaler_demand_handler` with `pthread_create`). `plug_mgr.c` runs a provider script with `fork()` and, in the child, calls functions that take locks or allocate before `execl()`:\n```c\npid = fork(); /* plug_mgr.c:441 */\n...\n} else if (pid == 0) {\n fd = open(out_file, ...);\n if (fd == -1) { ERROR(\"Create %s failed\", out_file); exit(EXIT_FAILURE); }\n my_snprintf(cmd, sizeof(cmd), \"%s/scripts/%s\", ...);\n ...\n export_env(prov); /* setenv(): malloc */\n ret = execl(\"/bin/sh\", \"sh\", cmd, \"-f\", in_file, (char*)NULL);\n if (ret == -1) { ERROR(\"execl() %s failed\", cmd); exit(EXIT_FAILURE); }\n```\nIf another thread holds the malloc arena or logger lock at the moment of `fork()`, the child deadlocks and the parent's `waitpid()` never returns; `exit()` also runs atexit handlers and flushes stdio copied from the parent.\n\n**Expected:** the autoscaler starts provider scripts with `posix_spawn()` (output redirect via file actions, environment passed as `envp`), or forks only with async-signal-safe code before `exec` and `_exit()` on failure, so the no-fork rule can cover `src/autoscaler`.\n**Impact:** hang: an intermittent deadlocked provider-script child blocks the scaling thread in `waitpid()`. The autoscaler is excluded from the no-fork rule only because it is not finalized; this must be fixed before it ships.\n**Found by:** audit for the no-fork rule, 2026-10-10.",
"file": "src/autoscaler/scaler/plug_mgr.c",
"root_cause": "TODO: required for fixed/partial",
"fix": "TODO: required for fixed/partial\n\nVerification:\n- Test: TODO: name + file; RED before the fix, GREEN after\n- Suites: TODO: suite results and build profile\n- Live: TODO: soak/deploy run, or n/a and why",
"tags": [
"autoscaler",
"fork",
"threads",
"deadlock"
],
"related_bugs": [],
"fix_commits": [],
"record": ".wolf/bugs/bug-1969.md"
}
]
}