test(raft-adapter-conformance): dormant AppendEntries sender stays uncalled in production

New test drives repl_broadcast and ha_stream_wal_to_standby through
real production fixtures (reused from tasks 2.3/6.2), asserts both
actually fired (non-vacuous), and asserts
ha_send_append_entries_stub_call_count stays 0 throughout -- the
Requirement 3.3 non-regression guard. RED-verified: manually invoking
ha_cb_send_append_entries_for_test inside the test reliably trips the
assertion; reverted for GREEN.

1064 -> 1065 tests, 0 failures. Task 4 (dormant sender documentation +
guard) now complete.
This commit is contained in:
Rongsong Shen 2026-07-29 15:35:08 +00:00
parent 6d798df35d
commit 87ce7be917
2 changed files with 95 additions and 1 deletions

View file

@ -55,7 +55,7 @@
- Observable: the counter exists and is queryable from a test; the doc-comment names both the dormant path and the live substitute explicitly
- _Requirements: 3.3_
- [ ] 4.2 Test that the dormant sender stays uncalled in production
- [x] 4.2 Test that the dormant sender stays uncalled in production
- Drive the production heartbeat/replication path end-to-end in a test and assert the new call counter stays at zero
- In the same test, confirm `repl_broadcast`/`ha_stream_wal_to_standby` did fire for the same scenario, proving the assertion isn't vacuous
- Observable: the test fails if a future change accidentally gives `raft_send_append_entries` a production caller