chore(buglog): harness batch fixed (da1a663f): bug-1574/1702/1703/1705/1707-1710/1712/1777/1793/1796/1797

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Rongsong Shen 2026-09-28 04:17:31 +00:00
parent da1a663f05
commit 8cadeeb2d0
Signed by untrusted user: rshen
GPG key ID: 80533536B0EB651C
14 changed files with 221 additions and 156 deletions

View file

@ -1,16 +1,17 @@
---
id: "bug-1710"
status: "open"
status_updated: "2026-09-24"
status_note: "xce_test hello -c <=0 reports vacuous success"
status: "fixed"
status_updated: "2026-09-28"
status_note: ""
component: "controller"
severity: "unknown"
timestamp: "2026-08-26T09:32:18Z"
last_seen: "2026-09-19T09:00:00Z"
occurrences: 1
files: ["src/controller/testsuite/test.c:1341 (rc=0 init)", ":1351 (count=atoi(optarg)", "unchecked)", ":1367 (while count>0 loop)", ":1373 (return rc)"]
files: ["src/harness/test.c"]
tags: ["controller", "testsuite", "xce_test", "cmd_hello", "silent-failure", "cli-ux-audit"]
related: []
fix_commits: ["da1a663f"]
legacy: true
---
@ -29,10 +30,12 @@ _Not recorded (migrated from buglog.json)._
No validation that count is >=1 before entering the loop; the initial success value is never overwritten when the loop body never executes.
## Fix
NOT YET FIXED. Recommended: reject count<=0 with an explicit error instead of falling through to a silent vacuous success.
hello's -c is parsed with cmdutil_parse_long() and must be >= 1; 0, negative or non-numeric is a usage error.
## Verification
_Not recorded (migrated from buglog.json)._
- Test: test_hello_nonpositive_count_rejected in src/harness/testsuite/test_test_cli.c: RED before the fix (exit 0, nothing sent), GREEN after
- Suites: harness 6/6 (asan): harness_unit_test 141/0, cmdutil 14/0, resval_typeresolve 7/0, joblist_display 22/0, join_worker_args 7/0, listrow_json 12/0
- Live: n/a; xce_test is a client tool and every case above runs without a controller
## References
_Not recorded (migrated from buglog.json)._