lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(libxce-alloc-preason-equality): NULL-safe str_eq helper in libxce utils (task 1.1)

Browse source 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Rongsong Shen 2026-09-28 09:21:04 +00:00
parent 094577f245
commit 8f25c1c3f3
Signed by untrusted user: rshen
GPG key ID: 80533536B0EB651C
4 changed files with 56 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/include/utils.h
View file

@ -57,6 +57,11 @@
#define float_equal(a, b) (fabs((a) - (b)) < float_near_zero)
/* NULL-safe string equality: non-zero iff a and b are both NULL, or both
* non-NULL and strcmp(a, b) == 0; zero otherwise (exactly one NULL, or
* different contents). Reads only; never modifies either argument. */
extern int str_eq(const char* a, const char* b);
#define STR(x) _STR(x)
#define _STR(x) #x

40
src/lib/testsuite/test_utils.c
View file

@ -426,6 +426,42 @@ test_xce_format_units_value_both_mode_renders_raw_and_human(void)
TEST_ASSERT_EQUAL_STRING(expected, buf);
}
/* str_eq: NULL-safe string equality (libxce-alloc-preason-equality
* task 1.1, Requirements 1.5 / 2.3, design Decision 5). */
static void test_str_eq_both_null_are_equal(void)
{
TEST_ASSERT_TRUE(str_eq(NULL, NULL));
}
static void test_str_eq_one_null_is_not_equal_either_order(void)
{
TEST_ASSERT_FALSE(str_eq(NULL, "cpu"));
TEST_ASSERT_FALSE(str_eq("cpu", NULL));
/* An empty string is still non-NULL: it must not equal NULL. */
TEST_ASSERT_FALSE(str_eq(NULL, ""));
TEST_ASSERT_FALSE(str_eq("", NULL));
}
static void test_str_eq_equal_strings_are_equal(void)
{
/* Distinct buffers with the same content, so the result cannot come
* from pointer identity. */
char a[] = "node01";
char b[] = "node01";
TEST_ASSERT_TRUE(str_eq(a, b));
TEST_ASSERT_TRUE(str_eq(a, a));
TEST_ASSERT_TRUE(str_eq("", ""));
}
static void test_str_eq_different_strings_are_not_equal(void)
{
TEST_ASSERT_FALSE(str_eq("node01", "node02"));
TEST_ASSERT_FALSE(str_eq("node0", "node01"));
TEST_ASSERT_FALSE(str_eq("node01", "node0"));
TEST_ASSERT_FALSE(str_eq("", "x"));
}
void test_utils(void)
{
printf("\n>> utils test\n\n");
@ -455,4 +491,8 @@ void test_utils(void)
RUN_TEST(test_xce_format_units_value_raw_mode_renders_bare_value);
RUN_TEST(test_xce_format_units_value_human_mode_renders_scaled_string_alone);
RUN_TEST(test_xce_format_units_value_both_mode_renders_raw_and_human);
RUN_TEST(test_str_eq_both_null_are_equal);
RUN_TEST(test_str_eq_one_null_is_not_equal_either_order);
RUN_TEST(test_str_eq_equal_strings_are_equal);
RUN_TEST(test_str_eq_different_strings_are_not_equal);
}

6
src/lib/utils.c
View file

@ -146,6 +146,12 @@ void free_argv(char** argv, int argc) { FREE_ARGV(argv, argc); }
int get_myname(char* name, size_t size) { return gethostname(name, size); }
int str_eq(const char* a, const char* b)
{
if (a == NULL || b == NULL) return a == b;
return strcmp(a, b) == 0;
}
char* frame_symbol(int k)
{
#if defined(__linux__)