From 8fe2f1f96cec600df2ca09173c0d6ca699e496dd Mon Sep 17 00:00:00 2001 From: Rongsong Shen Date: Fri, 12 Jun 2026 03:41:21 +0000 Subject: [PATCH] =?UTF-8?q?chore(ha-commit-engine):=20mark=20spec=20implem?= =?UTF-8?q?ented=20=E2=80=94=20validate-impl=20GO?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .kiro/specs/ha-commit-engine/spec.json | 9 +++++---- .kiro/steering/roadmap.md | 2 +- .wolf/memory.md | 3 +++ 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.kiro/specs/ha-commit-engine/spec.json b/.kiro/specs/ha-commit-engine/spec.json index be27494b..307b8f9a 100644 --- a/.kiro/specs/ha-commit-engine/spec.json +++ b/.kiro/specs/ha-commit-engine/spec.json @@ -1,9 +1,9 @@ { "feature_name": "ha-commit-engine", "created_at": "2026-06-11T09:07:03Z", - "updated_at": "2026-06-11T09:07:03Z", + "updated_at": "2026-06-12T01:10:00-07:00", "language": "en", - "phase": "tasks-generated", + "phase": "implemented", "umbrella": "ha-consistency-invariants", "approvals": { "requirements": { @@ -19,5 +19,6 @@ "approved": true } }, - "ready_for_implementation": true -} + "ready_for_implementation": true, + "note": "All 12 tasks implemented 2026-06-11/12 via /kiro-impl autonomous mode (each task independently reviewed). kiro-validate-impl: GO. Suite: 46 groups / 467 tests / 0 failures. Deferred follow-ups recorded in tasks.md Implementation Notes (6.1): LSN-0 interim, 6 pre-existing leak groups, persist.c:1151 stale comment, n_peers==0 legacy-path advisory. Next sub-spec: ha-commit-barrier-rollout." +} \ No newline at end of file diff --git a/.kiro/steering/roadmap.md b/.kiro/steering/roadmap.md index 6ef5c1a1..a3612982 100644 --- a/.kiro/steering/roadmap.md +++ b/.kiro/steering/roadmap.md @@ -13,7 +13,7 @@ XCE is in the persistence + HA transformation (branch `persistent_ha`). Governin > `[x]` = spec generated (requirements/design/tasks approved, ready for implementation). Implementation tracked via each spec's tasks.md; implement in roadmap order (cross-spec review 2026-06-11: four specs touch ha_dispatch_gate / raft_cb_become_follower in disjoint-but-adjacent regions). -- [x] ha-commit-engine — commit.c per-LSN majority engine + quorum accounting fixes, wired behind job submit. Dependencies: none. (specs done 2026-06-11: 7 reqs / 4 components / 11 sub-tasks) +- [x] ha-commit-engine — commit.c per-LSN majority engine + quorum accounting fixes, wired behind job submit. Dependencies: none. (specs done 2026-06-11; **IMPLEMENTED 2026-06-12**: 12/12 tasks, validate-impl GO, 467 tests green; deferred follow-ups in its tasks.md §Implementation Notes) - [x] ha-commit-barrier-rollout — classification table, commit-first-then-reply sweep, RETAIN facts, config barrier, idempotency guards. Dependencies: ha-commit-engine. (specs done 2026-06-11: 5 reqs / 6 components / 16 sub-tasks; verified classification supersedes umbrella table for STOP/RESUME/UPDATE/FAIL) - [x] ha-single-leader-role — promotion no-op + own-term gate, CTRL_PRIMARY_COMMITTING removal. Dependencies: ha-commit-engine, ha-commit-barrier-rollout (HARD: barrier before state removal). (specs done 2026-06-11: 2 reqs / 7 components / 11 sub-tasks) - [x] ha-convergence-recovery — demotion truncate+self-restart, rejoin reconciliation, egress watermark filter, ACK-driven catch-up, quorum logging. Dependencies: ha-commit-engine (E2E additionally needs ha-single-leader-role). (specs done 2026-06-11: 9 reqs / 7 components / 13 sub-tasks) diff --git a/.wolf/memory.md b/.wolf/memory.md index 88d0fb0f..172574cc 100644 --- a/.wolf/memory.md +++ b/.wolf/memory.md @@ -961,3 +961,6 @@ | 00:36 | task 6.1 validation: full controller suite 46 groups / 467 tests 0 failures; 3 bug-411 baseline tests fixed (test files only); legacy-path audit clean; 6 pre-existing leak groups inventoried | test_p2_integration.c, test_ha_repl_ack.c, test_ha_rdhup_integration.c | success | ~60k | | 17:51 | Edited .kiro/specs/ha-commit-engine/tasks.md | inline fix | ~19 | | 17:51 | Edited .kiro/specs/ha-commit-engine/tasks.md | modified RECORD() | ~433 | +| 03:45 | kiro-validate-impl ha-commit-engine: GO — 433+99 tests 0 FAIL (bug-411-aware count), cross-task wiring/lock-order/boundary clean, 1 LOW drift (commit.h includes persist.h vs fwd-decl) | .kiro/specs/ha-commit-engine/, src/controller/{commit,repl,ha,cluster,persist}.c | validated | ~45k | +| 01:15 | /kiro-impl ha-commit-engine COMPLETE: 12/12 tasks, 10 commits (d5a0f9c..95a10ce), validate-impl GO, suite 467/0 | commit.c+wiring | sub-spec 1 of 4 done | ~1.5M | +| 20:41 | Edited .kiro/steering/roadmap.md | inline fix | ~77 |