lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs: bug-1909..1912 fixed; controller-peers-env-fallback gap notes resolved

Browse source 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Rongsong Shen 2026-10-03 13:07:37 +00:00
parent ef6e562cde
commit 91782e4089
Signed by untrusted user: rshen
GPG key ID: 80533536B0EB651C
6 changed files with 272 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.kiro/specs/controller-peers-env-fallback/tasks.md
View file

@ -141,3 +141,4 @@
- (3.2 → 3.3) The file-wide `shellcheck disable=SC2329` must stay (cases and helpers run via the `"$fn"` registry and `trap`); the SC2034 disable now covers only the `HARNESS_BIN` line — remove it once the harness cases use it.
- (5.2) Environment-limited completion: the new `[scheduler-no-peers]` check passes in both scripts with the variable set and unset (RED reproduced: with the variable set and no `unset`, the scheduler took the HA path and the check failed). Neither script exits 0 here: both stop at the apiserver `go build` (GOPROXY=off, no Go module cache), and `test-version-startup-consistency.sh` also fails its scheduler commit-id check on any dirty tree — pre-existing, logged as bug-1909. A full pass of both scripts still needs a machine with the Go module cache and a clean tree (or a bug-1909 fix); carry this into 5.3.
- (5.3) At HEAD 353b16dd (ASAN, `src/xce.build`): `xce-build.sh all --incremental` exit 0 — meson C tests 127/0, scheduler 16/0, Go unit tests ok, xceadmin 364 passed, no ASAN/LSan reports; regression script 33/33 (twice). Environment-limited like 5.2: both version scripts pass every scheduler check incl. `[scheduler-no-peers]` but exit 1 at the apiserver `go build` (GOPROXY=off), and `test-version-startup-consistency.sh` also hits bug-1909 (it asserts `--version` and the startup log "must never disagree", while the dirty-fingerprint spec keeps `-dirty` in the log — a conflict between two earlier specs, not this feature).
- (post-validation, ef6e562c) The 5.2/5.3 environment limits are resolved: the version scripts now build the apiserver with `-mod=vendor` (bug-1910) and accept the dirty-content-fingerprint pairing (bug-1909), so both exit 0 here on a dirty tree with `XCE_CONTROLLER_PEERS` set. Also fixed: the worker `-l` + `-h`/`--version` leak (bug-1911) and `xce_parse_peers()` whitespace handling to match xceadmin (bug-1912). Regression script now 35 cases.