chore(ha-prevote): record validation GO + commit-barrier-timeout learning
This commit is contained in:
parent
e6b234a6a4
commit
a8840dbba5
2 changed files with 776 additions and 23 deletions
|
|
@ -9,11 +9,16 @@
|
|||
<!-- How the user likes things done. Code style, tools, patterns, communication. -->
|
||||
|
||||
## Key Learnings
|
||||
- (2026-06-15, ha-rejoin bug-340) A killed+restarted controller loops elections forever because the PRIMARY never evicts the dead/wedged outbound standby endpoint. primary_heartbeat_fn (ha.c) has two steps: (1) NOP each ep in ha->standby_endpoints, (2) reconnect to any peer NOT present in standby_endpoints. A wedged ep (peer died → handle_error did EPOLL_CTL_DEL but left it in the array; epoll MOD then returns ENOENT → the `WARN endpoint_update_epoll rc1=-1` spam) makes step 2 think the peer is still connected → reconnect SUPPRESSED → restarted node never gets a ctrlhello → re-elects every heartbeat_timeout (term climbs unbounded). xce_nop_req returns >=0 on enqueue even when the epoll re-arm fails, so the heartbeat layer can't see the wedge. FIX: evict in step 1 using endpoint_t.ts_last_in (existing wall-clock field, stamped by handle_input) — if ts_last_in>0 && now-ts_last_in>heartbeat_timeout, zarray_del from standby_endpoints + repl_remove_standby; reconnect then re-establishes the channel and ctrl-1 settles via ha_discover_primary (NO term gate — accepts any primary msg while ELECTING regardless of its own high term). Gotchas: (a) ha_arm_heartbeat_timeout_vtask ALREADY resets last_activity=now, so 'become_follower doesn't reset liveness' is NOT a bug — the ~timeout loop period proves the watchdog is correct; the sole cause is the broken channel. (b) standby_endpoints holds TWO ep types (promoted vote_ep_ctx_t with ctx!=NULL, and heartbeat standby_ep_ctx_t with ctx==NULL) sharing first 4 fields; don't free vote-ep data (UAF — live vctx pointers). (c) Run one suite: controller_unit_test -t test_ha_liveness, ASAN_OPTIONS=detect_leaks=0.
|
||||
- (2026-06-15, ha-election bug-339) Candidate-advertised RequestVote LSN MUST equal the voter-side freshness floor. Voter floor = ha_vote_self_freshness(ha, config_tag, applied_lsn) = max(applied_lsn, last_known_committed_lsn) (cluster.c OPCode_requestVote). On a STANDBY, persist.committed_lsn NEVER advances (only the primary commit engine writes it at persist.c:1192); standbys advance applied_lsn (ha_apply_wal_catchup_entry) + last_known_committed_lsn (heartbeat replies). So a candidate that advertises persist.committed_lsn under-advertises vs its own floor → after a primary dies, every surviving standby advertises stale-low LSN while each peer's floor is high → freshness gate (cand_lsn<my_lsn) denies on BOTH sides → no quorum → infinite RDHUP→ELECTING→STANDBY loop, terms climb in lockstep, nobody ever become_leader. Boot path (myapp.c:217) already uses applied_lsn; only the RDHUP failover path (ha_on_primary_ctrl_fd_rdhup) was inconsistent. Fix: compute cand_tag/cand_lsn via ha_vote_self_freshness once and feed BOTH the elect_ctx (votes[0]+self_*) AND the ha_rdhup_election_hook args. Symmetric advertised==floor guarantees the freshest node is granted by all peers. Diagnostic signature in logs: both nodes only raft_cb_become_follower (never become_leader) + RDHUP every ~heartbeat_timeout.
|
||||
- (2026-06-14, election-safety) ha_on_primary_ctrl_fd_rdhup MUST mirror the ha_start_election_async no-config voter-only guard: a config-less node (myconf->config_version_tag==0) with candidates_count>1 must NOT start an RDHUP re-election (it would tie-grant with another tag=0 node — freshness gate only denies a LOWER tag — and elect a config-less primary that pushes an empty config). Guard sits AFTER the WAL-truncate block, BEFORE elect_ctx alloc/hook/raft_on_leader_lost; sets role=CTRL_STANDBY and returns. RDHUP integration/failover tests that assert election-after-RDHUP use make_cluster/memset which leaves config_version_tag=0 + candidates_count=2 — they were incidentally testing the buggy condition; give them a nonzero tag (0x1234) so they exercise the legitimate CONFIGURED-node path. RDHUP handlers called with c==NULL early-return before the guard (unit-mode tests assert only the CTRL_ELECTING transition). CTRL_PRIMARY enum==0, CTRL_STANDBY==1, CTRL_ELECTING==3 (test printf "role=0==CTRL_PRIMARY" is expected). Full controller suite: meson driver SIGTERMs at 300s — run ./xce.build/controller/controller_unit_test directly with ASAN_OPTIONS=detect_leaks=0.
|
||||
- (2026-06-13, barrier-rollout 5.2) push_config_to_standbys now RETURNS the configAck barrier result (0/-ETIMEDOUT/-EINVAL), push count via acked_out; the configAck branch of repl_wait_majority_ack reads entry_lsn as the push tag and r->ce->n_peers (set-once, lock-free) as the denominator, ce==NULL -> -EINVAL fail-loud. ha.c/join.c streaming pushes discard the return BY DESIGN (log-only); only do_upgrade_config_with_bytes treats it as authoritative.
|
||||
|
||||
- [2026-06-12] Census parsing caveat: controller_unit_test logs (tinylog) and Unity result lines BOTH go to stdout and can splice mid-line under the multi-threaded config-push tests — a distinct-Unity-line count silently drops spliced results. Robust census = union of Unity result names AND the `test_x: PASS` printf lines, cross-checked against the per-group `N Tests M Failures` summary blocks (which are splice-immune).
|
||||
- [2026-06-12] Config-barrier test trick: when a test needs a covering config ACK for a tag only known AFTER conf_save_config hashes the re-encoded blob (upgradeConfig path), pre-ack with acked_config_lsn = UINT64_MAX — covers any push tag under both legacy (>0) and per-push (>= tag) counting.
|
||||
- [2026-06-12] A zeroed stack cbuf_t DEADLOCKS on cbuf_put (ncap==0 → len==ncap → cond_wait forever); any fixture driving do_upgrade_config_with_bytes' restart path must cbuf_init(&c->wbuf, …) first.
|
||||
- [2026-06-13, single-leader-role 1.1] A WAL type with value 31..99 (below WAL_ENTRY_TYPE_MAX=100) is observationally IDENTICAL to a generic entry in the current tree for append (persist_wal_async writes any type), apply_wal_entry (common-path LSN advance via `default:` arm), and replay_wal (its OWN type filter only skips `type > WAL_CHECKPOINT(100)`). So a behavioral RED test for "WAL_NOOP append/apply works" PASSES even before WAL_NOOP exists. The ONLY genuinely-broken behavior pre-impl is wal_classify (totality `assert(0)` aborts on the unclassified value). RED carrier for append/apply cases = couple them to `wal_classify(WAL_NOOP)→RETAIN` via the fork helper (the enum value + classify row land in the SAME task 1.2 change per design).
|
||||
- [2026-06-13] persist_t starts current_lsn==0 (calloc-zeroed; persist_init does NOT reset it). The FIRST persist_wal_async gets lsn==0; in replay_wal the `hdr.lsn <= from_lsn` (0<=0) skip means current_lsn never advances for a lone first entry. Replay fixtures asserting an LSN advance must write a preceding entry (or otherwise land the entry-under-test at lsn>0). replay_wal (persist.c:783) is SEPARATE from apply_wal_entry and has its own zero-region detector (`lsn==0 && type==0 && payload_len==0 → break`) and type filter.
|
||||
- Census EXACT method (2026-06-12): count DISTINCT Unity `file:line:test:PASS` triples (`grep -aoE` + sort -u), not raw `2mPASS` occurrences — tinylog interleaving garbles ~9 verdict lines per run and duplicates others; distinct-triple count matched the 494-baseline arithmetic exactly (495 after task 4.3's +1).
|
||||
- repl registry reconnect semantics: repl_remove_standby vacates the slot (ep=NULL, keeps last_disconnected_lsn guard); repl_add_standby reuses the first empty slot and memsets it (acked_lsn=0). With both standbys removed, majority_candidate_locked zero-fills to n_peers-1 → candidate 0 → committed_lsn frozen (RETAIN entries safely pending); after re-add, ONE covering ack = 2-of-3 majority.
|
||||
- repl_wait_majority_ack walAck track is engine-only since barrier-rollout 2.2: entry_lsn==0 returns 0 immediately (documented once-per-lifetime LSN-0 first entry), everything else delegates to commit_submit unconditionally — ce==NULL surfaces as -EINVAL from commit_submit (unreachable in production; cluster_init_phase2 always wires the engine). The counting loop that remains in the function is configAck-ONLY (no self-count, n_active==0 shortcut is Req 8.5 config behavior). persist_wal_sync_append's residual non-engine branch can only store committed_lsn for the LSN-0 no-op case. (2026-06-12, task 2.2)
|
||||
|
|
@ -53,6 +58,15 @@
|
|||
- makeJob needs job_obj_init() once per process AND xce_job_t.submit != NULL; makeString needs xstring_table_init (test_worker_join.c inits it unguarded at group entry — probe makeString for NULL before initialising to stay -t-selection safe).
|
||||
- (2026-06-13, barrier-rollout 6.1) mark_job_start/finish/fail/update are STATIC in job.c — testsuite reaches them ONLY via the non-static wrappers on_job_start/on_job_finish/on_job_fail (and on_job_postdone → mark_job_update). Those wrappers `return 0` unconditionally regardless of mark_job_* rc, so the guard's "success-no-op rc" observable is asserted on the wrapper rc (== 0). No public caller produces a terminal→non-terminal UPDATE (on_job_postdone OR's PDONE = forward; job_ctrl SIGCONT only clears suspend bits) — mark_job_start (state := JOB_STAT_RUN) is the faithful publicly-reachable terminal-clearing witness for the shared backward rule. current_lsn is the "did a hook fire / WAL append" oracle: a guarded-out no-op runs no hooks → no persist_wal_async → current_lsn frozen; combine with cbrp_count_jobstate_entries (on-disk scan) + a key_find live-state read. Controller suite baseline 2026-06-13: 502 distinct PASS triples pre-6.1; +3 with 6.1's 2 preservation pins landing green (forward-update, PERR-merge) = 505, 3 FAIL = the 3 new RED guard tests.
|
||||
|
||||
- (2026-06-13, single-leader-role 2.2) The own-term promotion noop uses `persist_wal_async(&c->persist, WAL_NOOP, NULL, 0)` which ALWAYS calls repl_broadcast → xce_wal_batch_req_raw(s->ep) for every registered, non-catch-up standby. Any test fixture that registers fake `int` endpoints (the `g_*_eps[]` pattern) via repl_add_standby MUST install `repl_broadcast_send_hook` (drop hook) before driving a real append, or ASAN aborts with global-buffer-overflow reading ep->peer (offset 36 past the 4-byte int). Precedent: test_commit_engine.c ce_drop_send_hook, test_p2_integration.c p2_drop_send_hook. The task-2.1 fixture lifecycle_cluster_setup (test_ha_role_lifecycle.c) OMITS this hook AND off-by-ones the current_lsn prime (sets appended_lsn+1; persist_wal_async takes current_lsn then ++, so to land the noop at `appended_lsn` the prime must be `appended_lsn`). Both are fixture bugs (bug-477/478), out of ha.c boundary. Production noop_lsn = current_lsn-1 read under p->lock AFTER the append is correct.
|
||||
- (2026-06-13, single-leader-role 2.2) raft_cb_become_leader does NOT call ha_do_promote — the raft FSM already synced ha->term at entry (~ha.c:463 atomic_store of the raft-reported term); calling ha_do_promote would double-increment (research §4 finding 2). The CTRL_PRIMARY store sits OUTSIDE the `if(c)` block so the c==NULL test shim reaches it. The non-raft road (ha_promote_to_primary) DOES call ha_do_promote (it owns its term). Both roads share ha_register_persist_hooks (BEFORE noop append) + ha_arm_own_term_gate (noop + commit_set_writable_lsn).
|
||||
|
||||
- (2026-06-13, single-leader-role COMPLETE 11/11, validate-impl GO) `CTRL_PRIMARY_COMMITTING` REMOVED — `ctrl_role_t` now 4 values (CTRL_PRIMARY=0, CTRL_STANDBY=1, CTRL_INIT=2, CTRL_ELECTING=3). Deleted without replacement: `committing_timeout_fn` (60s watchdog), `ha_check_majority_convergence`, `ha_repl_ack_received`/`repl_ack_count`, `committing_timeout_ms`/`HA_DEFAULT_COMMITTING_TIMEOUT_MS`. `OPCode_replCatchUpDone` is now a gate-allowed INFO no-op. Dispatch-gate PRIMARY branch + barrier-rollout fact allowlist preserved byte-for-byte; commit.c consumed with ZERO diff. Repo-wide completion grep (`CTRL_PRIMARY_COMMITTING|PRIMARY_COMMITTING|committing_timeout|repl_ack_count|ha_repl_ack_received|ha_check_majority_convergence`, excl .git/.kiro/specs) = ZERO.
|
||||
- (2026-06-13) OPERATIONAL: controller meson test wrapper ROUTINELY hits its 300s timeout under load (barrier commit-deadline waits) — `Timeout: 1` is NOT a failure. Authoritative green = direct binary `src/xce.build/controller/controller_unit_test` (EXIT 0, every group "N Tests 0 Failures"). A pre-existing ~153KB suite-wide LSan leak is SUPPRESSED by `ASAN_OPTIONS=detect_leaks=0` at controller/meson.build:163 — LSan exit=1 only appears on a RAW direct-binary run without that env; baseline, reproduces at pre-spec commits, not a per-change regression.
|
||||
- (2026-06-14, reserve-lsn-0 / bug-543 FIX) LSN 0 is now RESERVED as the none/empty sentinel — `persist_init()` sets `current_lsn = 1` on a fresh store (persist.c, the ONLY fresh-init site; recovery overwrites from snapshot/WAL tip). First-ever WAL entry (promotion NOOP) is lsn 1. This was a ONE-LINE production change + a comment block; everything downstream ALREADY treated 0 as "none/empty" and lsn>=1 as real, so NO change was needed in commit.c (highest_appended_lsn `current_lsn>0?-1:0`, commit_submit rejects lsn 0, wait_done writable_lsn==0=gate-off), the streamer (`hdr.lsn>standby_lsn`: 1>0=true now streams the first entry → no hole), ha.c own-term gate (noop_lsn=current_lsn-1=1, writable_lsn=1 effective), or the wire/capnp format. The pre-alloc zero-region sentinel `hdr.lsn==0 && type==0 && payload_len==0` (persist.c:874, config_repl.c:1580, truncate:1666) is STRENGTHENED — no real entry is ever lsn 0. Segment naming follows current_lsn at open time, so the first segment is `seg-...001.wal` (not 000); recovery/truncate scan by sscanf, no hard-coded seg-000 assumption.
|
||||
- (2026-06-14, reserve-lsn-0 TEST FALLOUT) Base-shift broke tests that did a "priming append so the entry lands at LSN >= 1" — that priming was ONLY to escape the old lsn-0 special-case and is now redundant. Fix = REMOVE the priming append so the real entry lands at lsn 1 (test_commit_engine tests 32/34, test_commit_barrier_rollout fact-hook, test_commit_barrier_reply cbrp_setup, test_p2_integration single_node) OR bump a hard-coded `current_lsn==1` assertion to `==2` if the priming must stay (test_egress_filter ef_setup). The ENGINE-LESS walAck path only "worked" via `repl_wait_majority_ack`'s `entry_lsn==0 → return 0` hatch (repl.c:437); with the first entry now lsn 1 it routes to `commit_submit(ce=NULL)` → -EINVAL, so engine-less commit tests MUST wire a commit engine (test_p2_integration test 9: added commit_engine_init(n_peers=3) + repl_set_commit_engine + commit_engine_fini). Tests asserting RELATIVE lsn (lsn_before+1, current_lsn>0, h1.lsn>h0.lsn) or byte-offset truncation math are base-shift-immune.
|
||||
- (2026-06-13, kiro-impl process) A RED-only test pin is only valid if its OWN impl task can turn it green via the SAME seam the test drives. Misfires caught in review: boot-replay pin RED on an lsn-0 `replay_wal` skip artifact; hooks pin via the `c==NULL` raft shim where `ha_register_persist_hooks(&c->hooksys)` can never run (re-point to the real-cluster `ha_promote_to_primary` seam). Deleting machinery → DELETE the machinery-subject tests (design "no shims, rewritten or deleted not stubbed"), never add file-local no-op stubs. Unity runner prints the PREVIOUS passing test's file:line as a stale prefix on FAIL lines → attribute failures by test NAME.
|
||||
|
||||
## Do-Not-Repeat
|
||||
|
||||
<!-- Mistakes made and corrected. Each entry prevents the same mistake recurring. -->
|
||||
|
|
@ -60,6 +74,8 @@
|
|||
|
||||
- [2026-06-09] Do NOT make the duplicate-vote deny candidate-agnostic ("term-only deny"). Raft §5.2 grants iff votedFor ∈ {Nil, candidateId} — same-candidate re-grant must stay idempotent (network retransmission path). An uncommitted ha.c change did this and broke test_vote_granted_to_same_candidate_same_term; ha.c must match raft.c's Step 4 semantics (deny only a DIFFERENT candidate in the same term). See bug-338.
|
||||
- [2026-06-09] The "self" voted_for_name placeholder only exists in test mode; production raft_cb_persist records the node's REAL name for a self-vote. Any check for "did I vote for myself" must compare against BOTH "self" and c->myconf->name (see myapp.c leader_known).
|
||||
- [2026-06-15] SOLVED (bug-563): "jobsub ok but joblist/workerlist empty on the HA primary; reslist works". ROOT CAUSE: `cluster_start()` is the ONLY setter of `c->running = 1` and it is ORPHANED — zero callers (grep `cluster_start(`). The HA `myapp_run` path starts iomgr/vtaskmgr/delaymgr/persist itself but never calls `cluster_start`, so `c->running` stays 0 on the primary. `check_controller()` (the streaming gate `xce_reply_get` uses for joblist/workerlist) returns `-EINVAL` when `!c->running`; `xce_reply_get` then sets the chunk count `nc = 0`, shipping an EMPTY list even though `collect_jobs()` found the rows. `reslist` passes `checkf=NULL` so it bypasses the gate — that asymmetry is the tell. Single-node "works" because the legacy `cluster_init` path called `cluster_start`. FIX: `c.running = 1;` in `myapp_run()` after `persist_start()` (src/controller/myapp.c). RULE: when only SOME list ops are empty but the data is present server-side, check the `xce_reply_get` `check_*` predicate — a `<0` return silently zeroes the chunk (`nc=0`), not an error. To prove it: log `nc`/`checkstatus` in the `xce_reply_get` send loop. Reproduce HA bugs locally with `/xce-build` + a 3-node deploy-ha under ASAN rather than theorizing. (My earlier UAF/stale-binary guess here was WRONG — disproven by "crash gone, binary current".) Still-latent: `cluster_start` also armed `check_workers_timeout` (delaymgr) — that side-effect remains unrestored on the HA path.
|
||||
- [2026-06-14] A partially-initialized `xce_reply_t` is a UAF hazard. The Cap'n-C generated `encode_RequestReply` (controller.capnp.c) reads the COMMON TRAILER fields (`redirectHost`, `redirectPort`) on EVERY reply regardless of `data_which` — `redirect_host` is `strlen`'d whenever `!= NULL`. Handlers declare `xce_reply_t reply;` on the stack and only set status/data, so those trailer fields were stack garbage; a garbage `redirect_host` aliasing a freed capnp segment = heap-use-after-free (seen on the OPCode_nop/state-report path, cluster.c). FIX (bug-562): `init_reply_by_req()` now `memset`s the whole struct first. RULE: any xce_reply_t built WITHOUT init_reply_by_req (e.g. ha_send_wal_ack_reply) MUST memset it. Generated union encoders are not safe to feed a partially-init struct — common/trailer fields are always serialized.
|
||||
|
||||
- [2026-06-04] capnpc-c 1.0.1 has a bug with `:group` inside a `union` when `$C.codecgen` is active: the encode/decode generator emits `d->FIELDNAME` (flat) instead of `d->data.GROUPNAME.FIELDNAME`, AND places the case as dead code after the prior `break`. Do NOT use inline `:group` in a union that has `$C.codecgen`. Instead, define a named outer struct (`struct Foo $C.mapname("foo_t")`) and reference it as a pointer union member. The named struct generates correct `encode_Foo_ptr`/`decode_Foo_ptr` calls. The `read_RequestReply`/`write_RequestReply` wire layer works correctly with groups but the codec layer does not.
|
||||
|
||||
|
|
@ -90,8 +106,14 @@
|
|||
- (2026-06-11, ha-convergence-recovery spec) `repl_complete_catchup` (repl.c:521) has NO production caller — `in_catch_up` is set by broadcast-overflow eviction (repl.c:240) and never cleared; re-inclusion trigger is wired by the ACK-driven catch-up continuation.
|
||||
- (2026-06-11) Scheduler-bound job egress has TWO seams, not one: full push `xcesched_push_jobs` (sched.c:169, on scheduler join) AND incremental JOB_NEW push `sched_job_new_fun`→`xcesched_push_joblist` (sched.c:236-248). Status reads (apiserver.c:83, opget.c:173) share `collect_jobs` (dataex.c:294) and must stay unfiltered per umbrella deviation.
|
||||
- (2026-06-11) No saved-argv/execv machinery exists anywhere in src/controller or src/lib — demotion self-restart is net-new; `job_t` is a thin wrapper `{ xce_job_t job; }` at src/include/xce/types.h:483-485 (controller-local fields go on the wrapper, wire type untouched).
|
||||
- (2026-06-16, ha-prevote impl) The controller `"controller test"` 300s TIMEOUT under `meson test` is a WALL-CLOCK WRAPPER ARTIFACT, not a hang/failure: running the binary directly (`ASAN_OPTIONS=detect_leaks=0 ./xce.build/controller/controller_unit_test`) completes all 564 tests incl. the slow `test_commit_barrier_reply` (61 tests, real 500ms commit barriers) with 0 failures. For a true controller pass/fail, run the binary directly (no cap) or filter with `-t <suite>`; do NOT treat the meson timeout as a regression. ha-prevote feature COMPLETE: 11 tasks, raft suite 123/0, controller 564/0, real-vote path byte-for-byte unchanged (0 raft.c deletions), commits 0d66026..e6b234a.
|
||||
- (2026-06-15, ha-prevote design review) PRODUCTION vote-reply tally path = `raft_on_vote_reply` in the raft library, NOT `ha_elect_ctx_t`. `vote_reply_dispatch` (ha.c ~2630-2650) calls `raft_on_vote_reply` directly in production; the `ha_elect_ctx_t` / `handle_request_vote_reply` / `ha_elect_evaluate_and_signal` path runs ONLY behind `#ifdef XCE_TESTING` via `xce_vote_reply_hook` (plus the startup/first-boot `ha_elect_ctx_t.done` semaphore). The raft library owns quorum tracking and fires `on_become_leader`/`on_become_follower`. Do-Not-Repeat: when mirroring the election reply path, mirror `raft_on_vote_reply` (raft lib), not `ha_elect_ctx_t`. (An earlier exploration mislabeled ha_elect_ctx_t as the operative tally; caught in design validation.)
|
||||
- (2026-06-15, user decision, ha-prevote RN-2) Leader-stickiness window for PreVote = reuse `ha_heartbeat_is_fresh()` / `heartbeat_timeout_ms` (10s), gated on role==CTRL_STANDBY. Rationale: the stickiness window MUST equal XCE's failure-detection window or you get either a disruption gap (window too short) or a liveness stall (window too long). XCE splits textbook Raft's overloaded "election timeout" — `HEARTBEAT_TIMEOUT_MS` (10s) is the leader-failure detector; `ELECTION_TIMEOUT_MS` (5s) is only the candidate vote-collection deadline. Raft's "minimum election timeout" disruption rule maps to HEARTBEAT_TIMEOUT_MS, NOT ELECTION_TIMEOUT_MS. Reusing it keeps stickiness == failure-detect == existing real-vote gate (`raft_cb_vote_eligible`), one predicate; role-gate handles RDHUP/connection-loss for free. A shorter window buys no failover speedup (nobody campaigns before failure-detect anyway; real crashes RDHUP immediately) and only opens a disruption gap on flaky links. Rejected a separate `prevote_stickiness_ms` constant (lets the two timeouts drift). Full comparison table in .kiro/specs/ha-prevote/research.md §6.
|
||||
- (2026-06-15, user decision, ha-prevote) Product is PRE-RELEASE: no backward/rolling-upgrade compatibility is required for any HA/wire change. All controllers in a cluster deploy from the same build, so there is no mixed-version (old-binary ↔ new-binary) cluster. Wire-format changes (new capnp opcodes/fields, vote-RPC changes) may be made freely without negotiation/fallback paths. Do NOT raise inter-version compat as a requirement or research item. (Dropped RN-5 from ha-prevote/research.md on this basis.)
|
||||
|
||||
- commit_submit(COMMIT_MODE_RETAIN) is REGISTRATION-FREE (commit.c:233-239, verified 2026-06-11): returns 0 immediately, records NOTHING per entry — commit state derives entirely from registry watermarks at ACK time. RETAIN routing at the hook seam therefore has NO engine-side observable distinct from the append itself; tests of RETAIN routing must assert classification + non-blocking return + lsn > committed_lsn pending + ACK-driven advancement, never a fake "registered" counter. (ha-commit-barrier-rollout 1.1)
|
||||
- XCE_TESTING fail-fast (assert/abort) paths are testable via fork(): child silences stderr, calls the guarded fn, _exit(0); parent asserts WIFSIGNALED && WTERMSIG == SIGABRT. Precedent: lib testsuite test.c:1783; ASAN-compatible with detect_leaks=0. (ha-commit-barrier-rollout 1.1)
|
||||
- ha_has_write_quorum (ha.c:1507) is STATIC — testsuite reaches it only through ha_dispatch_gate(ha, opcode) (extern-declared in test files, pattern: test_ha_repl_ack.c). Gate fixtures: ha_init + n_peers + atomic role store + heap zarray standby_endpoints (test_ha_connection_reuse.c pattern). Catch-up exclusion at the gate is untestable until the ha_state_t.repl back-pointer lands (ha-commit-engine 4.2) — assert via repl_active_standby_count instead. (2026-06-11, task 4.1)
|
||||
- persist_commit_barrier watermark = current_lsn - 1 (matching persist.c:1021 persist_wal_sync_append read); covered ⇔ current_lsn == 0 OR committed_lsn >= current_lsn - 1. Design §Commit Barrier Helper "lsn = p->current_lsn" is shorthand — the parenthetical persist.c:1019-1021 reference pins it to current_lsn - 1 (engine clamps committed to highest appended, so waiting on current_lsn itself would never complete). (2026-06-12, task 2.1)
|
||||
|
||||
- (2026-06-13, single-leader-role 4.2) ha_dispatch_gate's OUTER `default: return 0` ADMITS — so after deleting the `case CTRL_PRIMARY_COMMITTING:` block, a role manually set to COMMITTING falls through to admit (not NOT_READY). That is exactly why test_ha_startup.c:test_dispatch_gate_committing_denies_job_ops flips from PASS→FAIL (Expected -10013 Was 0) — category-(a), 5.1-owned. The 6 PRIMARY||COMMITTING compound sites in ha.c: raft_cb_vote_eligible(~215), handle_request_vote term-stepdown(~1984)+role-deny(~2004), peer_ctrl_msg_handler case label(~2820), vote_ep_err_handler(~3088), primary_heartbeat_fn re-arm(~3883). Collapsing all to PRIMARY-only makes a manually-COMMITTING test role a NON-leader. Census after 4.2: exactly 5 FAIL, ALL COMMITTING-state category-(a) (test_ha_startup ×2, test_ha_rdhup_integration, test_ha_repl_push, test_ha_connection_reuse), zero category-(b). enum value CTRL_PRIMARY_COMMITTING=4 stays in ha.h (5.2 deletes it); no ha.c CODE branches on it post-4.2 (only comments in 2.2/3.1-owned functions remain). Unity attributes vote-gate cases to test_ha_failover.c by group UNITY_BEGIN — locate by NAME. FAIL bytes: `name:\x1b[41mFAIL\x1b[0m` (color BETWEEN ':' and FAIL) — grep raw `FAIL`, count was exactly 5.
|
||||
|
|
|
|||
777
.wolf/memory.md
777
.wolf/memory.md
|
|
@ -255,35 +255,16 @@
|
|||
> Consolidated session (0 actions)
|
||||
|
||||
## Session: 2026-06-05 18:57
|
||||
> Consolidated session (102 actions)
|
||||
> Consolidated session (0 actions)
|
||||
|
||||
## Session: 2026-06-08 01:03
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
> Consolidated session (0 actions)
|
||||
|
||||
## Session: 2026-06-08 01:14
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
> Consolidated session (0 actions)
|
||||
|
||||
## Session: 2026-06-08 05:57
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 06:10 | Edited .kiro/specs/election-iomgr-refactor/research.md | expanded (+10 lines) | ~187 |
|
||||
| 06:10 | Edited .kiro/specs/ha-config-bootstrap/research.md | expanded (+13 lines) | ~295 |
|
||||
| 06:11 | Edited .kiro/specs/ha-heartbeat-liveness/research.md | expanded (+12 lines) | ~332 |
|
||||
| 06:11 | Edited .kiro/specs/ha-peer-connection-reuse/research.md | expanded (+14 lines) | ~341 |
|
||||
| 06:12 | Edited .kiro/specs/ha-repl-hardening/research.md | expanded (+15 lines) | ~475 |
|
||||
| 06:12 | Edited .kiro/specs/raft-library/research.md | expanded (+14 lines) | ~534 |
|
||||
| 06:13 | Edited .kiro/specs/resval-id-decoupling/research.md | modified mirroring() | ~445 |
|
||||
| 06:14 | Edited .kiro/specs/scheduler-controller-msg-gap/research.md | expanded (+14 lines) | ~374 |
|
||||
| 06:14 | Edited .kiro/specs/worker-join-refactor/research.md | expanded (+14 lines) | ~325 |
|
||||
| 06:14 | Session end: 9 writes across 1 files (research.md) | 34 reads | ~73897 tok |
|
||||
| 06:48 | Session end: 9 writes across 1 files (research.md) | 37 reads | ~82775 tok |
|
||||
| 17:00 | Created src/docs/cluster-config-split-analysis.md | — | ~2983 |
|
||||
| 17:01 | Session end: 10 writes across 2 files (research.md, cluster-config-split-analysis.md) | 38 reads | ~98190 tok |
|
||||
> Consolidated session (13 actions)
|
||||
|
||||
## Session: 2026-06-09 21:12
|
||||
|
||||
|
|
@ -1030,3 +1011,753 @@
|
|||
| 05:14 | task 7.2 GO/NO-GO: full controller suite green under ASAN | xce.build | 480 PASS / 0 FAIL, prod xce_controller linked, ordering+classification+retention+config-barrier evidence recorded | ~25k |
|
||||
| 22:25 | Edited .kiro/steering/roadmap.md | inline fix | ~216 |
|
||||
| 22:25 | Created ../../../../../claude/.claude/projects/-home-rshen-projects-xce-xce/memory/project_ha_consistency_invariants.md | — | ~600 |
|
||||
| 22:26 | Session end: 16 writes across 5 files (tasks.md, test_commit_barrier_reply.c, job.c, roadmap.md, project_ha_consistency_invariants.md) | 20 reads | ~141734 tok |
|
||||
|
||||
## Session: 2026-06-13 23:20
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 23:33 | Created src/controller/testsuite/test_ha_role_lifecycle.c | — | ~3971 |
|
||||
| 23:33 | Edited src/controller/meson.build | 2→3 lines | ~28 |
|
||||
| 23:34 | Edited src/controller/testsuite/controller_test.c | 2→3 lines | ~29 |
|
||||
| 23:34 | Edited src/controller/testsuite/controller_test.c | 2→3 lines | ~23 |
|
||||
| 23:41 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | added 4 condition(s) | ~324 |
|
||||
| 23:41 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | expanded (+8 lines) | ~203 |
|
||||
| 23:41 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | expanded (+7 lines) | ~184 |
|
||||
| 06:47 | task 1.1 RED: WAL_NOOP no-op tests (4 cases) | controller/testsuite/test_ha_role_lifecycle.c, controller/meson.build, controller/testsuite/controller_test.c | build green, 4 cases RED, 0 unrelated regressions | ~38k |
|
||||
| 00:06 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | added 1 condition(s) | ~1490 |
|
||||
| 07:11 | rewrote ha-single-leader-role task 1.1 Case 3 boot-replay RED to pin WAL_NOOP classify contract (leading WAL_JOB_START→noop at lsn>0) instead of lsn-0 fixture artifact | src/controller/testsuite/test_ha_role_lifecycle.c | all 4 noop cases RED via shared carrier; 0 unrelated regressions | ~9k |
|
||||
| 00:30 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~12 |
|
||||
| 00:32 | Edited src/include/wal_types.h | 3→4 lines | ~60 |
|
||||
| 00:32 | Edited src/controller/persist.c | expanded (+6 lines) | ~101 |
|
||||
| 00:32 | Edited src/controller/persist.c | 3→8 lines | ~107 |
|
||||
| 00:45 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~10 |
|
||||
| 00:56 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | modified 1() | ~298 |
|
||||
| 00:58 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | added 2 condition(s) | ~7236 |
|
||||
| 08:04 | task 2.1 RED: appended 7 direct-promotion+own-term-gate cases (seams: raft_cb_become_leader_for_test for 1-3; ha_promote_to_primary+real cluster for 4-7) | test_ha_role_lifecycle.c | 6 RED (cases 1,2,3,5,6,7-field), case4 green regression-pin, 140 other PASS | ~22k |
|
||||
| 01:17 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | modified XCE_TESTING() | ~899 |
|
||||
| 01:17 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | removed 60 lines | ~120 |
|
||||
| 01:18 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | modified XCE_TESTING() | ~934 |
|
||||
| 01:31 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~21 |
|
||||
| 01:35 | Edited src/controller/ha.c | 3→7 lines | ~103 |
|
||||
| 01:35 | Edited src/controller/ha.c | modified role() | ~231 |
|
||||
| 01:36 | Edited src/controller/ha.c | modified top() | ~262 |
|
||||
| 01:38 | Edited src/controller/ha.c | added 1 condition(s) | ~1259 |
|
||||
| 14:30 | task 2.2 rewrite raft_cb_become_leader → direct CTRL_PRIMARY + extracted ha_register_persist_hooks + ha_arm_own_term_gate(noop+writable_lsn); rewrote ha_promote_to_primary to share the sequence | src/controller/ha.c | compiles clean; cases 1,2 GREEN; cases 3-7 BLOCKED by task-2.1 fixture defects (bug-477 broadcast crash, bug-478 off-by-one prime) | ~40k |
|
||||
| 01:56 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | added error handling | ~356 |
|
||||
| 01:56 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | modified XCE_TESTING() | ~92 |
|
||||
| 01:56 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | modified XCE_TESTING() | ~40 |
|
||||
| 01:57 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | expanded (+6 lines) | ~206 |
|
||||
| 01:57 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 5→7 lines | ~124 |
|
||||
| 01:57 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 5→6 lines | ~108 |
|
||||
| 02:25 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~20 |
|
||||
| 02:25 | Edited .kiro/specs/ha-single-leader-role/tasks.md | modified FAIL() | ~653 |
|
||||
| 02:36 | Edited src/controller/testsuite/test_ha_start_election_async.c | 4→6 lines | ~127 |
|
||||
| 02:36 | Edited src/controller/testsuite/test_ha_start_election_async.c | modified test_single_node_shortcircuit_evaluates_immediately() | ~614 |
|
||||
| 02:37 | Edited src/controller/ha.c | modified XCE_TESTING() | ~782 |
|
||||
| 02:38 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 3→4 lines | ~23 |
|
||||
| 02:38 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | modified XCE_TESTING() | ~1455 |
|
||||
| 02:39 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 1→4 lines | ~61 |
|
||||
| 02:45 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | expanded (+6 lines) | ~192 |
|
||||
| 09:57 | task 3.1 verify: legacy ha_elect_evaluate_and_signal direct-PRIMARY symmetry already in working tree; built+tested controller | ha.c, test_ha_role_lifecycle.c, test_ha_start_election_async.c | GREEN: 3 target tests PASS, 8 expected-RED (tasks 4.1/5.1 scope), 0 category-(b), ASAN clean | ~45k |
|
||||
| 03:15 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~25 |
|
||||
| 03:16 | Edited .kiro/specs/ha-single-leader-role/tasks.md | 1→3 lines | ~391 |
|
||||
| 03:18 | Edited src/controller/ha.c | reduced (-7 lines) | ~15 |
|
||||
| 03:18 | Edited src/controller/ha.c | 4→3 lines | ~45 |
|
||||
| 03:19 | Edited src/controller/ha.c | removed 16 lines | ~28 |
|
||||
| 03:19 | Edited src/controller/ha.c | 8→8 lines | ~121 |
|
||||
| 03:19 | Edited src/controller/ha.c | 3→2 lines | ~8 |
|
||||
| 03:19 | Edited src/controller/ha.c | removed 63 lines | ~22 |
|
||||
| 03:19 | Edited src/controller/ha.c | reduced (-6 lines) | ~67 |
|
||||
| 03:19 | Edited src/controller/ha.c | modified if() | ~168 |
|
||||
| 03:20 | Edited src/controller/ha.c | 2→2 lines | ~41 |
|
||||
| 03:20 | Edited src/controller/ha.c | removed 41 lines | ~20 |
|
||||
| 03:20 | Edited src/controller/ha.c | removed 64 lines | ~21 |
|
||||
| 03:20 | Edited src/controller/ha.h | — | ~0 |
|
||||
| 03:20 | Edited src/controller/ha.h | reduced (-7 lines) | ~22 |
|
||||
| 03:21 | Edited src/controller/ha.h | 4→5 lines | ~87 |
|
||||
| 03:21 | Edited src/controller/ha.c | 5→5 lines | ~96 |
|
||||
| 03:21 | Edited src/controller/ha.c | 4→5 lines | ~86 |
|
||||
| 03:22 | Edited src/controller/meson.build | 5→3 lines | ~30 |
|
||||
| 03:22 | Edited src/controller/testsuite/controller_test.c | 5→3 lines | ~32 |
|
||||
| 03:22 | Edited src/controller/testsuite/controller_test.c | 5→3 lines | ~25 |
|
||||
| 03:24 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | modified stub_phase2() | ~223 |
|
||||
| 03:25 | Edited src/controller/testsuite/test_ha_role.c | modified XCE_TESTING() | ~164 |
|
||||
| 03:25 | Edited src/controller/testsuite/test_ha_role.c | modified XCE_TESTING() | ~150 |
|
||||
| 10:35 | task 4.1: deleted force-promotion watchdog + ack/convergence machinery (committing_timeout_fn, committing_timeout_fn_for_test, committing_timeout_ctx_t, ha_check_majority_convergence, ha_repl_ack_received); replCatchUpDone→INFO no-op; deleted test_ha_repl_ack.c + test_ha_evaluate_committing.c + meson/runner entries; stubbed deleted symbols in test_ha_role.c + test_ha_rdhup_integration.c to resolve compile break | ha.c, ha.h, meson.build, controller_test.c, test_ha_role.c, test_ha_rdhup_integration.c | build clean, grep-gate zero, 13 RED all category-(a) | ~30k |
|
||||
| 04:41 | Edited src/controller/testsuite/test_ha_role.c | removed 230 lines | ~182 |
|
||||
| 04:42 | Edited src/controller/testsuite/test_ha_role.c | removed 136 lines | ~286 |
|
||||
| 04:42 | Edited src/controller/testsuite/test_ha_role.c | modified cases() | ~172 |
|
||||
| 04:42 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 10→9 lines | ~157 |
|
||||
| 04:42 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | reduced (-39 lines) | ~158 |
|
||||
| 04:43 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | modified deleted() | ~139 |
|
||||
| 04:43 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | reduced (-40 lines) | ~171 |
|
||||
| 04:43 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | modified deleted() | ~155 |
|
||||
| 04:43 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 6→8 lines | ~135 |
|
||||
| 04:43 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 1→4 lines | ~77 |
|
||||
| 04:44 | Edited src/controller/testsuite/test_ha_connection_reuse.c | reduced (-27 lines) | ~118 |
|
||||
| 04:44 | Edited src/controller/testsuite/test_ha_connection_reuse.c | removed 88 lines | ~155 |
|
||||
| 04:44 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 4→5 lines | ~82 |
|
||||
| 04:45 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 6→6 lines | ~77 |
|
||||
| 04:45 | Edited src/controller/testsuite/test_ha_role.c | 2→2 lines | ~42 |
|
||||
| 04:45 | Edited src/controller/testsuite/test_ha_role.c | 3→3 lines | ~62 |
|
||||
| 04:46 | Edited src/controller/testsuite/test_ha_role.c | 5→5 lines | ~105 |
|
||||
| 04:46 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 7→7 lines | ~137 |
|
||||
| 04:46 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 4→4 lines | ~77 |
|
||||
| 04:46 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | modified deleted() | ~42 |
|
||||
| 04:46 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 3→3 lines | ~50 |
|
||||
| 04:46 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 4→4 lines | ~81 |
|
||||
| 04:47 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | modified deleted() | ~41 |
|
||||
| 11:53 | task 4.1 remediation: removed 3 no-op shims + 7 machinery-subject test cases, excised 2 ack calls | test_ha_role.c, test_ha_rdhup_integration.c, test_ha_connection_reuse.c | build CLEAN, only 5.1-owned COMMITTING-state RED | ~30k |
|
||||
| 05:04 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~20 |
|
||||
| 05:04 | Edited .kiro/specs/ha-single-leader-role/tasks.md | added error handling | ~374 |
|
||||
| 05:07 | Edited src/controller/ha.c | removed 21 lines | ~7 |
|
||||
| 05:08 | Edited src/controller/ha.c | 4→4 lines | ~30 |
|
||||
| 05:08 | Edited src/controller/ha.c | modified if() | ~91 |
|
||||
| 05:08 | Edited src/controller/ha.c | primary() → votes() | ~158 |
|
||||
| 05:08 | Edited src/controller/ha.c | 4→3 lines | ~48 |
|
||||
| 05:08 | Edited src/controller/ha.c | 3→2 lines | ~21 |
|
||||
| 05:08 | Edited src/controller/ha.c | modified if() | ~28 |
|
||||
| 05:09 | Edited src/controller/ha.c | 2→2 lines | ~22 |
|
||||
| 05:09 | Edited src/controller/ha.c | modified gate() | ~31 |
|
||||
| 05:10 | Edited src/controller/ha.c | 4→3 lines | ~56 |
|
||||
| 05:10 | Edited src/controller/ha.c | 2→2 lines | ~31 |
|
||||
| 05:10 | Edited src/controller/ha.c | 2→2 lines | ~40 |
|
||||
| 05:10 | Edited src/controller/ha.c | 2→2 lines | ~36 |
|
||||
| 05:11 | Edited src/controller/ha.c | 3→3 lines | ~35 |
|
||||
| 05:12 | Edited src/controller/ha.c | 2→2 lines | ~20 |
|
||||
| 05:12 | Edited src/controller/testsuite/test_ha_vote_gate.c | modified verify() | ~68 |
|
||||
| 05:12 | Edited src/controller/testsuite/test_ha_vote_gate.c | modified test_primary_role_denies_fresher_same_term_challenger() | ~388 |
|
||||
| 05:13 | Edited src/controller/testsuite/test_ha_vote_gate.c | 5→5 lines | ~60 |
|
||||
| 12:26 | task 4.2: deleted dispatch-gate COMMITTING branch + collapsed 6 role predicates to PRIMARY; retargeted vote-gate test | ha.c, test_ha_vote_gate.c | build green, vote-gate+barrier-rollout PASS, 5 COMMITTING-state cases RED (5.1-owned) | ~9k |
|
||||
| 05:59 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~22 |
|
||||
| 05:59 | Edited .kiro/specs/ha-single-leader-role/tasks.md | 1→3 lines | ~245 |
|
||||
| 06:04 | Edited src/controller/testsuite/test_ha_role.c | TEST_ASSERT_EQUAL_UINT32() → CTRL_PRIMARY() | ~426 |
|
||||
| 06:04 | Edited src/controller/testsuite/test_ha_role.c | 3→2 lines | ~12 |
|
||||
| 06:04 | Edited src/controller/testsuite/test_ha_role.c | modified 3() | ~81 |
|
||||
| 06:04 | Edited src/controller/testsuite/test_ha_role.c | 2→2 lines | ~31 |
|
||||
| 06:05 | Edited src/controller/testsuite/test_ha_role.c | modified 3() | ~58 |
|
||||
| 06:05 | Edited src/controller/testsuite/test_ha_vote_gate.c | 3→3 lines | ~60 |
|
||||
| 06:06 | Edited src/controller/testsuite/test_commit_barrier_rollout.c | tested() → CTRL_PRIMARY() | ~46 |
|
||||
| 06:06 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 4→3 lines | ~17 |
|
||||
| 06:06 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 2→2 lines | ~40 |
|
||||
| 06:07 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 4→4 lines | ~72 |
|
||||
| 06:07 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 3→3 lines | ~58 |
|
||||
| 06:07 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 3→2 lines | ~37 |
|
||||
| 06:07 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 4→5 lines | ~91 |
|
||||
| 06:08 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 6→5 lines | ~88 |
|
||||
| 06:08 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 5→5 lines | ~102 |
|
||||
| 06:09 | Edited src/controller/testsuite/test_ha_start_election_async.c | 2→2 lines | ~41 |
|
||||
| 06:09 | Edited src/controller/testsuite/test_ha_start_election_async.c | 3→2 lines | ~11 |
|
||||
| 06:09 | Edited src/controller/testsuite/test_ha_start_election_async.c | 9→9 lines | ~153 |
|
||||
| 06:09 | Edited src/controller/testsuite/test_ha_start_election_async.c | 7→7 lines | ~146 |
|
||||
| 06:10 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 2→2 lines | ~29 |
|
||||
| 06:10 | Edited src/controller/testsuite/test_ha_connection_reuse.c | "err_handler: ep must be r" → "err_handler: ep must be r" | ~27 |
|
||||
| 06:10 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 3→2 lines | ~11 |
|
||||
| 06:10 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 6→6 lines | ~101 |
|
||||
| 06:11 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 3→4 lines | ~69 |
|
||||
| 06:11 | Edited src/controller/testsuite/test_ha_repl_push.c | 16→17 lines | ~228 |
|
||||
| 06:11 | Edited src/controller/testsuite/test_ha_repl_push.c | 2→2 lines | ~31 |
|
||||
| 06:11 | Edited src/controller/testsuite/test_ha_repl_push.c | 2→2 lines | ~40 |
|
||||
| 06:12 | Edited src/controller/testsuite/test_ha_repl_push.c | 3→2 lines | ~11 |
|
||||
| 06:12 | Edited src/controller/testsuite/test_ha_repl_push.c | test_committing_calls_ctrlhello_push() → test_promotion_calls_ctrlhello_push() | ~89 |
|
||||
| 06:12 | Edited src/controller/testsuite/test_ha_repl_push.c | 13→13 lines | ~123 |
|
||||
| 06:12 | Edited src/controller/testsuite/test_ha_repl_push.c | entry() → promotion() | ~85 |
|
||||
| 06:12 | Edited src/controller/testsuite/test_ha_repl_push.c | 4→4 lines | ~72 |
|
||||
| 06:12 | Edited src/controller/testsuite/test_ha_repl_push.c | 2→2 lines | ~27 |
|
||||
| 06:14 | Edited src/controller/testsuite/test_ha_startup.c | modified test_dispatch_gate_primary_no_quorum_denies_job_ops() | ~409 |
|
||||
| 06:14 | Edited src/controller/testsuite/test_ha_startup.c | 3→3 lines | ~26 |
|
||||
| 06:14 | Edited src/controller/testsuite/test_ha_startup.c | 2→2 lines | ~41 |
|
||||
| 06:14 | Edited src/controller/testsuite/test_ha_startup.c | 5→4 lines | ~30 |
|
||||
| 06:14 | Edited src/controller/testsuite/test_ha_startup.c | modified test_nonblocking_single_node_election_enters_primary_directly() | ~291 |
|
||||
| 06:15 | Edited src/controller/testsuite/test_ha_startup.c | 3→3 lines | ~59 |
|
||||
| 06:15 | Edited src/controller/testsuite/test_ha_startup.c | inline fix | ~21 |
|
||||
| 06:16 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 3→4 lines | ~69 |
|
||||
| 06:16 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 3→2 lines | ~11 |
|
||||
| 06:16 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 7→8 lines | ~138 |
|
||||
| 06:17 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 8→9 lines | ~132 |
|
||||
| 06:17 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | inline fix | ~22 |
|
||||
| 06:17 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 3→3 lines | ~64 |
|
||||
| 06:17 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 4→4 lines | ~74 |
|
||||
| 06:17 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | test_rdhup_committing_fires_replication_hooks() → test_rdhup_promotion_fires_replication_hooks() | ~96 |
|
||||
| 06:17 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | COMMITTING() → primary() | ~106 |
|
||||
| 06:17 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | modified deleted() | ~66 |
|
||||
| 06:18 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 7→7 lines | ~115 |
|
||||
| 06:31 | Edited src/controller/testsuite/test_ha_startup.c | modified test_dispatch_gate_primary_no_quorum_denies_job_ops() | ~478 |
|
||||
| 06:59 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~18 |
|
||||
| 06:59 | Edited .kiro/specs/ha-single-leader-role/tasks.md | 1→2 lines | ~202 |
|
||||
| 07:01 | Edited src/controller/ha.h | 4→3 lines | ~54 |
|
||||
| 07:01 | Edited src/controller/ha.h | 3→2 lines | ~14 |
|
||||
| 07:01 | Edited src/controller/ha.h | 3→2 lines | ~28 |
|
||||
| 07:01 | Edited src/controller/ha.h | 3→2 lines | ~47 |
|
||||
| 07:02 | Edited src/controller/ha.h | 3→2 lines | ~50 |
|
||||
| 07:02 | Edited src/controller/ha.h | 2→2 lines | ~32 |
|
||||
| 07:02 | Edited src/controller/ha.h | 4→4 lines | ~48 |
|
||||
| 07:02 | Edited src/controller/ha.h | 3→3 lines | ~49 |
|
||||
| 07:02 | Edited src/controller/ha.h | 3→3 lines | ~64 |
|
||||
| 07:02 | Edited src/controller/ha.h | 3→3 lines | ~55 |
|
||||
| 07:03 | Edited src/controller/cluster.c | 3→2 lines | ~22 |
|
||||
| 07:03 | Edited src/controller/cluster.c | CTRL_PRIMARY_COMMITTING() → CTRL_PRIMARY() | ~35 |
|
||||
| 07:03 | Edited src/lib/raft/raft.c | 4→4 lines | ~75 |
|
||||
| 07:03 | Edited src/controller/cluster.c | inline fix | ~18 |
|
||||
| 07:04 | Edited src/controller/ha.c | 9→8 lines | ~97 |
|
||||
| 07:04 | Edited src/controller/ha.c | 3→3 lines | ~64 |
|
||||
| 07:04 | Edited src/controller/ha.c | inline fix | ~24 |
|
||||
| 07:04 | Edited src/controller/ha.c | modified 1() | ~38 |
|
||||
| 07:04 | Edited src/controller/ha.c | 2→2 lines | ~39 |
|
||||
| 07:04 | Edited src/controller/ha.c | 2→2 lines | ~34 |
|
||||
| 07:05 | Edited src/controller/ha.c | 3→3 lines | ~59 |
|
||||
| 07:05 | Edited src/controller/ha.c | 3→3 lines | ~62 |
|
||||
| 07:05 | Edited src/controller/ha.c | inline fix | ~21 |
|
||||
| 07:05 | Edited src/controller/ha.c | 2→2 lines | ~47 |
|
||||
| 07:05 | Edited src/controller/ha.c | modified if() | ~43 |
|
||||
| 07:05 | Edited src/controller/ha.c | 2→2 lines | ~37 |
|
||||
| 07:06 | Edited src/controller/testsuite/test_ha_role.c | 3→3 lines | ~52 |
|
||||
| 07:06 | Edited src/controller/testsuite/test_ha_role.c | 7→4 lines | ~41 |
|
||||
| 07:06 | Edited src/controller/testsuite/test_commit_barrier_rollout.c | 3→2 lines | ~11 |
|
||||
| 07:06 | Edited src/controller/testsuite/test_commit_engine.c | 3→2 lines | ~11 |
|
||||
| 07:07 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 6→6 lines | ~101 |
|
||||
| 07:07 | Edited src/controller/testsuite/test_ha_connection_reuse.c | 5→5 lines | ~91 |
|
||||
| 07:07 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 3→3 lines | ~60 |
|
||||
| 07:07 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 5→5 lines | ~76 |
|
||||
| 07:07 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 4→4 lines | ~74 |
|
||||
| 07:07 | Edited src/controller/testsuite/test_ha_role_lifecycle.c | 5→5 lines | ~88 |
|
||||
| 14:20 | task 5.2 keystone deletion: removed CTRL_PRIMARY_COMMITTING enum + 4 fields/macro + cluster.c init; swept all COMMITTING comments (ha.h/cluster.c/raft.c/ha.c/tests); removed live repl_ack_count assert + committing_timeout_ms test inits | ha.h,cluster.c,raft.c,ha.c,test_ha_role.c,test_commit_engine.c,test_commit_barrier_rollout.c,test_ha_connection_reuse.c,test_ha_role_lifecycle.c | grep gate ZERO, direct binary EXIT=0 10 suites 0 Failures | ~22k |
|
||||
| 07:41 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~25 |
|
||||
| 07:41 | Edited .kiro/specs/ha-single-leader-role/tasks.md | modified references() | ~199 |
|
||||
| 07:43 | Edited .kiro/steering/ha-async-io.md | inline fix | ~48 |
|
||||
| 07:43 | Edited .kiro/steering/ha-async-io.md | "CTRL_PRIMARY_COMMITTING →" → "s own-term commit rule (§" | ~154 |
|
||||
| 07:44 | Edited .kiro/steering/ha-async-io.md | only() → opcodes() | ~68 |
|
||||
| 07:44 | Edited .kiro/steering/ha-async-io.md | inline fix | ~17 |
|
||||
| 07:54 | Edited src/controller/CLAUDE.md | inline fix | ~28 |
|
||||
| 07:54 | Edited .claude/skills/xce-deploy-ha/SKILL.md | inline fix | ~29 |
|
||||
| 07:54 | Edited src/docs/cluster-config-split-analysis.md | 3→2 lines | ~20 |
|
||||
| 07:55 | Edited .kiro/steering/roadmap.md | inline fix | ~73 |
|
||||
| 07:55 | Edited .kiro/steering/roadmap.md | inline fix | ~67 |
|
||||
| --:-- | task 6.1 docs: synced steering+contributor docs to three-state model + own-term gate | ha-async-io.md, src/controller/CLAUDE.md, xce-deploy-ha/SKILL.md, cluster-config-split-analysis.md, roadmap.md | both COMMITTING grep gates zero in doc dirs | ~6k |
|
||||
| 07:58 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~21 |
|
||||
| 15:13 | task 6.2 completion gate: zero-residue grep PASS + controller 167/0 direct-binary green | src/controller/.ha.c.~undo-tree~ (deleted) | READY_FOR_REVIEW | ~12k |
|
||||
| 08:14 | Edited .kiro/specs/ha-single-leader-role/tasks.md | inline fix | ~15 |
|
||||
| 08:31 | Edited ../../../../../claude/.claude/projects/-home-rshen-projects-xce-xce/memory/project_ha_consistency_invariants.md | "XCE HA Raft+CP umbrella —" → "XCE HA Raft+CP umbrella —" | ~42 |
|
||||
| 08:31 | Edited ../../../../../claude/.claude/projects/-home-rshen-projects-xce-xce/memory/project_ha_consistency_invariants.md | 2→2 lines | ~460 |
|
||||
| 08:32 | Edited ../../../../../claude/.claude/projects/-home-rshen-projects-xce-xce/memory/MEMORY.md | inline fix | ~74 |
|
||||
|
||||
## Session — kiro-impl ha-single-leader-role COMPLETE (11/11, validate GO)
|
||||
Implemented sub-spec 3/4 of ha-consistency-invariants autonomously (per-task implementer→reviewer subagents, atomic commits). Removed CTRL_PRIMARY_COMMITTING (ctrl_role_t 5→4); election winner→CTRL_PRIMARY directly; own-term WAL_NOOP gate at promotion (commit_set_writable_lsn); deleted force-promotion watchdog + convergence/ack machinery. One shared promotion sequence for raft + legacy paths. Commits 6df1283..e558a62. Final grep gate ZERO, controller ASAN suite green (167/0 direct binary). Review caught: lsn-0 replay RED artifact, c==NULL hooks-pin seam mismatch, shims-instead-of-delete (rejected per design), 2 latent fixture bugs (bug-477/478) surfaced only at GREEN, plus independent baseline reproduction confirming a pre-existing LSan leak was NOT a regression. Next: ha-convergence-recovery.
|
||||
| 08:34 | Session end: 213 writes across 26 files (test_ha_role_lifecycle.c, meson.build, controller_test.c, tasks.md, wal_types.h) | 43 reads | ~209093 tok |
|
||||
|
||||
## Session: 2026-06-14 17:21
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
|
||||
## Session: 2026-06-14 17:26
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
|
||||
## Session: 2026-06-14 17:26
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 17:29 | Edited src/include/xce/types.h | modified struct() | ~102 |
|
||||
| 17:30 | Edited src/controller/include/cluster.h | 2→3 lines | ~17 |
|
||||
| 17:30 | Edited src/controller/include/cluster.h | modified recovery() | ~273 |
|
||||
| 17:30 | Edited src/controller/include/cluster.h | 2→1 lines | ~15 |
|
||||
| 17:33 | Created src/controller/testsuite/test_egress_filter.c | — | ~4082 |
|
||||
| 17:33 | Edited src/controller/testsuite/test_egress_filter.c | 6→7 lines | ~38 |
|
||||
| 17:34 | Edited src/controller/testsuite/test_egress_filter.c | modified call_job_hook_new() | ~142 |
|
||||
| 17:34 | Edited src/controller/testsuite/test_egress_filter.c | modified call_job_hook() | ~159 |
|
||||
| 17:34 | Edited src/controller/testsuite/test_egress_filter.c | inline fix | ~4 |
|
||||
| 17:34 | Edited src/controller/testsuite/controller_test.c | 1→2 lines | ~22 |
|
||||
| 17:34 | Edited src/controller/testsuite/controller_test.c | 3→4 lines | ~25 |
|
||||
| 17:35 | Edited src/controller/meson.build | 2→3 lines | ~25 |
|
||||
| 17:35 | Edited src/controller/testsuite/test_egress_filter.c | stubs() → here() | ~45 |
|
||||
| 17:37 | Edited src/controller/testsuite/test_egress_filter.c | added 4 condition(s) | ~772 |
|
||||
| 17:38 | Edited src/controller/testsuite/test_egress_filter.c | 3→4 lines | ~22 |
|
||||
| 17:45 | Edited src/controller/testsuite/test_egress_filter.c | modified ef_make_job() | ~162 |
|
||||
| 17:46 | Edited src/controller/testsuite/test_egress_filter.c | 8→13 lines | ~115 |
|
||||
| 17:53 | Edited src/controller/testsuite/test_egress_filter.c | 5→6 lines | ~49 |
|
||||
| 17:54 | Edited src/controller/testsuite/test_egress_filter.c | 2→3 lines | ~33 |
|
||||
| 17:54 | Edited src/controller/testsuite/test_egress_filter.c | 2→3 lines | ~32 |
|
||||
| 17:54 | Edited src/controller/testsuite/test_egress_filter.c | 3→4 lines | ~44 |
|
||||
| 17:54 | Edited src/controller/testsuite/test_egress_filter.c | 2→3 lines | ~37 |
|
||||
| 18:01 | Edited src/controller/testsuite/test_egress_filter.c | expanded (+8 lines) | ~159 |
|
||||
| 18:07 | Edited src/controller/testsuite/test_egress_filter.c | 12→16 lines | ~228 |
|
||||
| 18:13 | Edited src/controller/testsuite/test_egress_filter.c | expanded (+7 lines) | ~246 |
|
||||
| 01:22 | RED tests for commit-gated scheduler egress (task 1.1): submit_lsn field + cluster.h decls + test_egress_filter.c (6 tests, 4 fail RED) | types.h, cluster.h, test_egress_filter.c, controller_test.c, meson.build | build OK, 4 new tests FAIL RED, pre-existing suites green | ~45k |
|
||||
| 18:40 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~20 |
|
||||
| 18:46 | Edited src/controller/persist.c | added 1 condition(s) | ~366 |
|
||||
| 18:46 | Edited src/controller/job.c | modified record() | ~182 |
|
||||
| 18:46 | Edited src/controller/job.c | modified recovery() | ~124 |
|
||||
| 18:46 | Edited src/controller/persist.c | 4→6 lines | ~82 |
|
||||
| 18:47 | Edited src/controller/persist.c | 1→3 lines | ~52 |
|
||||
| 18:47 | Edited src/controller/persist.c | 5→3 lines | ~57 |
|
||||
| 18:47 | Edited src/controller/include/cluster.h | inline fix | ~21 |
|
||||
| 18:47 | Edited src/controller/testsuite/test_repl_apply.c | modified restore_job() | ~63 |
|
||||
| 18:49 | Created src/controller/egress.c | — | ~1018 |
|
||||
| 18:49 | Edited src/controller/meson.build | 5→6 lines | ~23 |
|
||||
| 18:49 | Edited src/controller/meson.build | 13→14 lines | ~52 |
|
||||
| 18:50 | Edited src/controller/sched.c | modified recovery() | ~118 |
|
||||
| 18:50 | Edited src/controller/sched.c | added 5 condition(s) | ~472 |
|
||||
| 18:51 | Edited src/controller/egress.c | 10→14 lines | ~90 |
|
||||
| 18:51 | Edited src/controller/testsuite/test_egress_filter.c | added 1 condition(s) | ~628 |
|
||||
| 18:51 | Edited src/controller/testsuite/test_egress_filter.c | ef_unlock_jobs() → ef_unlock_committed() | ~67 |
|
||||
| 18:52 | Edited src/controller/testsuite/test_egress_filter.c | ef_unlock_jobs() → ef_unlock_committed() | ~43 |
|
||||
| 18:52 | Edited src/controller/testsuite/test_egress_filter.c | ef_unlock_jobs() → ef_unlock_committed() | ~45 |
|
||||
| 18:52 | Edited src/controller/testsuite/test_egress_filter.c | ef_unlock_jobs() → ef_unlock_committed() | ~63 |
|
||||
| 18:52 | Edited src/controller/testsuite/test_egress_filter.c | 2→2 lines | ~33 |
|
||||
| 18:52 | Edited src/controller/testsuite/test_egress_filter.c | modified GREEN() | ~155 |
|
||||
| 18:52 | Edited src/controller/testsuite/test_egress_filter.c | "\n>> commit-gated schedul" → "\n>> commit-gated schedul" | ~21 |
|
||||
| 02:13 | task 1.2 GREEN egress filter: live+replay submit_lsn tagging, watermark predicate, sched-bound exports gated | persist.c,job.c,egress.c,sched.c,cluster.h,test_egress_filter.c | 6/6 egress green, 0 regressions | ~45k |
|
||||
| 19:33 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~24 |
|
||||
| 19:33 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~16 |
|
||||
| 19:33 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | expanded (+7 lines) | ~434 |
|
||||
| 19:40 | Edited src/controller/ha.h | modified contract() | ~481 |
|
||||
| 19:40 | Edited src/controller/ha.h | expanded (+41 lines) | ~536 |
|
||||
| 19:40 | Edited src/controller/ha.c | modified raft_cb_become_follower_for_test() | ~216 |
|
||||
| 19:41 | Created src/controller/ha_convergence.c | — | ~798 |
|
||||
| 19:42 | Edited src/controller/meson.build | 4→5 lines | ~19 |
|
||||
| 19:42 | Edited src/controller/meson.build | 5→7 lines | ~49 |
|
||||
| 19:42 | Edited src/controller/testsuite/controller_test.c | 1→2 lines | ~22 |
|
||||
| 19:42 | Edited src/controller/testsuite/controller_test.c | 3→4 lines | ~25 |
|
||||
| 19:44 | Created src/controller/testsuite/test_demotion_convergence.c | — | ~6010 |
|
||||
| 19:45 | Edited src/controller/testsuite/test_demotion_convergence.c | 3→5 lines | ~85 |
|
||||
| 19:45 | Edited src/controller/testsuite/test_demotion_convergence.c | 3→4 lines | ~65 |
|
||||
| 19:46 | Edited src/controller/testsuite/test_demotion_convergence.c | 39→35 lines | ~470 |
|
||||
| 02:55 | ha-convergence-recovery task 2.1 RED: demotion-convergence + self-restart tests | test_demotion_convergence.c (new), ha_convergence.c (new RED scaffold), ha.h, ha.c, meson.build, controller_test.c | RED confirmed: 4 new behavioral cases FAIL (1.1 hooks-disable, 1.2/1.3/1.6 schedule+truncate+restart, 1.4 fatal-hook, 1.7/2.4 replay), 2 non-PRIMARY regression cases PASS; 8 adjacent suites 0 failures | ~70k |
|
||||
| 20:12 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~21 |
|
||||
| 20:12 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | 1→3 lines | ~415 |
|
||||
| 20:16 | Edited src/controller/main.c | modified controller_saved_argv() | ~482 |
|
||||
| 20:17 | Created src/controller/ha_convergence.c | — | ~2299 |
|
||||
| 20:17 | Edited src/controller/ha_convergence.c | 13→17 lines | ~83 |
|
||||
| 20:18 | Edited src/controller/ha.h | modified XCE_TESTING() | ~267 |
|
||||
| 20:18 | Edited src/controller/ha.c | added 3 condition(s) | ~735 |
|
||||
| 20:18 | Edited src/controller/testsuite/test_demotion_convergence.c | modified test_demotion_from_electing_no_truncation_no_restart() | ~39 |
|
||||
| 20:18 | Edited src/controller/testsuite/test_demotion_convergence.c | modified test_demotion_from_init_no_truncation_no_restart() | ~462 |
|
||||
| 20:19 | Edited src/controller/testsuite/test_demotion_convergence.c | 3→4 lines | ~69 |
|
||||
| 20:28 | Edited src/controller/persist.c | added 1 condition(s) | ~339 |
|
||||
| 03:33 | task 2.2 GREEN: demotion convergence + self-restart primitive | main.c, ha.c, ha.h, ha_convergence.c, persist.c, test_demotion_convergence.c | demotion suite 7/7 + no regression | ~24k |
|
||||
| 20:46 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~24 |
|
||||
| 20:46 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~22 |
|
||||
| 20:47 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | modified up() | ~483 |
|
||||
| 20:51 | Edited src/controller/ha.h | modified reconciliation() | ~180 |
|
||||
| 20:51 | Edited src/controller/ha.h | modified XCE_TESTING() | ~471 |
|
||||
| 20:52 | Edited src/controller/ha_convergence.c | modified if() | ~306 |
|
||||
| 20:52 | Edited src/controller/cluster.c | 9→4 lines | ~66 |
|
||||
| 20:53 | Edited src/controller/cluster.c | modified cluster_apply_ctrlhello_reply() | ~355 |
|
||||
| 20:53 | Edited src/controller/include/cluster.h | expanded (+9 lines) | ~169 |
|
||||
| 20:54 | Edited src/controller/testsuite/test_demotion_convergence.c | modified XCE_TESTING() | ~2992 |
|
||||
| 20:55 | Edited src/controller/testsuite/test_demotion_convergence.c | 5→4 lines | ~43 |
|
||||
| 20:55 | Edited src/controller/testsuite/test_demotion_convergence.c | 2→3 lines | ~58 |
|
||||
| 20:57 | Edited src/controller/cluster.c | removed 24 lines | ~11 |
|
||||
| 20:57 | Edited src/controller/include/cluster.h | removed 12 lines | ~13 |
|
||||
| 20:57 | Edited src/controller/ha_convergence.c | modified stores() | ~409 |
|
||||
| 20:58 | Edited src/controller/ha.h | expanded (+11 lines) | ~170 |
|
||||
| 20:58 | Edited src/controller/testsuite/test_demotion_convergence.c | 2→1 lines | ~20 |
|
||||
| 21:18 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~19 |
|
||||
| 21:21 | Edited src/controller/ha_convergence.c | added 7 condition(s) | ~1627 |
|
||||
| 21:21 | Edited src/controller/ha_convergence.c | modified trigger() | ~270 |
|
||||
| 21:31 | Edited src/controller/testsuite/test_demotion_convergence.c | added 1 condition(s) | ~440 |
|
||||
| 04:34 | task 3.2 GREEN: ha_rejoin_reconcile (clamp+once-guard+deferred truncate/restart) + intake trigger; fixed ASAN UAF in test harness dc_run_pending_task (dequeue) | ha_convergence.c, test_demotion_convergence.c | 11/11 demotion+rejoin green, 5 spot-check suites green, no regression | ~18k |
|
||||
| 21:52 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~16 |
|
||||
| 21:52 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~14 |
|
||||
| 21:52 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | modified up() | ~369 |
|
||||
| 21:57 | Edited src/controller/ha.h | added error handling | ~386 |
|
||||
| 21:57 | Edited src/controller/ha.h | added error handling | ~594 |
|
||||
| 21:57 | Edited src/controller/ha_convergence.c | modified XCE_TESTING() | ~432 |
|
||||
| 21:58 | Edited src/controller/meson.build | 3→4 lines | ~38 |
|
||||
| 21:58 | Edited src/controller/testsuite/controller_test.c | 2→3 lines | ~35 |
|
||||
| 21:58 | Edited src/controller/testsuite/controller_test.c | 4→5 lines | ~36 |
|
||||
| 22:00 | Created src/controller/testsuite/test_convergence_verification.c | — | ~5761 |
|
||||
| 05:08 | task 4.1 RED: ACK-driven catch-up continuation tests | test_convergence_verification.c (new), ha.h, ha_convergence.c, meson.build, controller_test.c | RED confirmed: 4 continuation/single-flight/parity FAIL, heartbeat-pin PASS, no regression | ~22k |
|
||||
| 22:16 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~22 |
|
||||
| 22:23 | Edited src/controller/ha.h | added error handling | ~482 |
|
||||
| 22:24 | Edited src/controller/config_repl.c | added error handling | ~2248 |
|
||||
| 22:25 | Edited src/controller/ha.c | modified if() | ~211 |
|
||||
| 22:25 | Edited src/controller/ha_convergence.c | modified XCE_TESTING() | ~285 |
|
||||
| 22:45 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~18 |
|
||||
| 22:45 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~21 |
|
||||
| 22:49 | Edited src/controller/ha.h | modified continuation() | ~408 |
|
||||
| 22:50 | Edited src/controller/ha.h | modified sites() | ~453 |
|
||||
| 22:50 | Edited src/controller/ha.h | modified scaffold() | ~392 |
|
||||
| 22:50 | Edited src/controller/ha_convergence.c | modified XCE_TESTING() | ~175 |
|
||||
| 22:51 | Edited src/controller/ha_convergence.c | modified ha_log_quorum_transition() | ~265 |
|
||||
| 22:51 | Edited src/controller/testsuite/test_convergence_verification.c | 4→5 lines | ~89 |
|
||||
| 22:52 | Edited src/controller/testsuite/test_convergence_verification.c | added 1 condition(s) | ~2686 |
|
||||
| 22:52 | Edited src/controller/testsuite/test_convergence_verification.c | expanded (+7 lines) | ~167 |
|
||||
| 05:58 | task 5.1 RED: quorum-transition logging tests + ha_log_quorum_transition decl/stub + quorum_lost field + emission-count seam | ha.h, ha_convergence.c, testsuite/test_convergence_verification.c | build OK, 4 new tests FAIL (RED), 5 pre-existing 4.x tests pass | ~40k |
|
||||
| 23:07 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~18 |
|
||||
| 23:08 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | 1→2 lines | ~263 |
|
||||
| 23:12 | Edited src/controller/ha_convergence.c | added 6 condition(s) | ~848 |
|
||||
| 23:12 | Edited src/controller/ha.c | modified backstop() | ~112 |
|
||||
| 23:13 | Edited src/controller/ha.c | modified observability() | ~116 |
|
||||
| 23:13 | Edited src/controller/ha.c | modified observability() | ~93 |
|
||||
| 23:13 | Edited src/controller/ha.c | modified observability() | ~127 |
|
||||
| 23:31 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~11 |
|
||||
| 23:31 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~15 |
|
||||
| 23:31 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | modified up() | ~230 |
|
||||
| 23:36 | Edited src/controller/testsuite/test_convergence_verification.c | added 1 condition(s) | ~354 |
|
||||
| 23:37 | Edited src/controller/testsuite/test_convergence_verification.c | added error handling | ~3406 |
|
||||
| 23:37 | Edited src/controller/testsuite/test_convergence_verification.c | expanded (+8 lines) | ~172 |
|
||||
| 23:38 | Edited src/controller/testsuite/test_convergence_verification.c | 2→3 lines | ~56 |
|
||||
| 23:38 | Edited src/controller/testsuite/test_convergence_verification.c | 1→2 lines | ~36 |
|
||||
| 23:39 | Edited src/controller/testsuite/test_convergence_verification.c | removed 33 lines | ~17 |
|
||||
| 23:40 | Edited src/controller/testsuite/test_convergence_verification.c | added error handling | ~364 |
|
||||
| 06:46 | task 6.1 regression pins: fan-out/snapshot/degraded-gate/re-inclusion | test_convergence_verification.c | 4 pins PASS, no prod change, 13/13 suite OK | ~28k |
|
||||
| 23:56 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | 2→2 lines | ~49 |
|
||||
| 07:12 | task7 full controller ASAN regression+audit: 50 suites/524 tests green, 0 fail, 0 ASAN mem err (aggregate meson hit known 300s SIGTERM on slow commit-barrier suites, NOT a regression; suite-by-suite green). Audits PASS: read paths unfiltered, commit.c untouched, become-follower non-PRIMARY guarded | testsuite (no prod changes) | green | ~30k |
|
||||
| 00:27 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | inline fix | ~13 |
|
||||
| 00:28 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | 1→2 lines | ~188 |
|
||||
| 00:28 | Edited .kiro/specs/ha-convergence-recovery/tasks.md | modified wired() | ~393 |
|
||||
| 00:29 | Session end: 141 writes across 19 files (types.h, cluster.h, test_egress_filter.c, controller_test.c, meson.build) | 39 reads | ~194003 tok |
|
||||
| 00:55 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | expanded (+6 lines) | ~114 |
|
||||
| 00:55 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 4→9 lines | ~131 |
|
||||
| 00:56 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | modified SAFETY() | ~1169 |
|
||||
| 00:56 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 3→7 lines | ~104 |
|
||||
| 01:02 | Edited src/controller/ha.c | added 1 condition(s) | ~498 |
|
||||
| 01:04 | Edited src/controller/testsuite/test_ha_failover.c | expanded (+8 lines) | ~271 |
|
||||
| 08:10 | election-safety fix: RDHUP voter-only guard for config-less node (TDD RED→GREEN) | src/controller/ha.c, testsuite/test_ha_rdhup_integration.c, testsuite/test_ha_failover.c | controller full suite 0 failures, 0 ASAN | ~9k |
|
||||
| 01:34 | Edited src/controller/testsuite/test_ha_vote_gate.c | modified test() | ~240 |
|
||||
| 01:35 | Edited src/controller/testsuite/test_ha_vote_gate.c | added error handling | ~2377 |
|
||||
| 01:35 | Edited src/controller/testsuite/test_ha_vote_gate.c | expanded (+7 lines) | ~134 |
|
||||
| 01:35 | Edited src/controller/ha.h | modified XCE_TESTING() | ~371 |
|
||||
| 01:35 | Edited src/controller/ha.c | added 2 condition(s) | ~308 |
|
||||
| 01:42 | Edited src/controller/ha.c | modified if() | ~229 |
|
||||
| 01:42 | Edited src/controller/cluster.c | expanded (+8 lines) | ~251 |
|
||||
| 02:02 | Session end: 154 writes across 22 files (types.h, cluster.h, test_egress_filter.c, controller_test.c, meson.build) | 42 reads | ~201128 tok |
|
||||
| 02:29 | Created src/controller/testsuite/test_coldstart_lsn0.c | — | ~3563 |
|
||||
| 02:29 | Edited src/controller/meson.build | 2→3 lines | ~26 |
|
||||
| 02:29 | Edited src/controller/testsuite/controller_test.c | modified setUp() | ~32 |
|
||||
| 02:29 | Edited src/controller/testsuite/controller_test.c | 3→4 lines | ~26 |
|
||||
| 02:48 | Edited src/controller/persist.c | expanded (+16 lines) | ~336 |
|
||||
| 02:49 | Created src/controller/testsuite/test_coldstart_lsn0.c | — | ~4296 |
|
||||
| 02:51 | Edited src/controller/testsuite/test_egress_filter.c | 7→9 lines | ~169 |
|
||||
| 02:51 | Edited src/controller/testsuite/test_p3_hardening.c | 4→6 lines | ~125 |
|
||||
| 02:53 | Edited src/controller/testsuite/test_p2_integration.c | 5→6 lines | ~103 |
|
||||
| 02:53 | Edited src/controller/testsuite/test_p2_integration.c | 6→5 lines | ~98 |
|
||||
| 02:59 | Edited src/controller/testsuite/test_commit_engine.c | persist_wal_async() → needed() | ~195 |
|
||||
| 02:59 | Edited src/controller/testsuite/test_commit_engine.c | 8→8 lines | ~110 |
|
||||
|
||||
## Session: 2026-06-14 03:00
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 03:00 | Edited src/controller/testsuite/test_commit_barrier_rollout.c | 5→5 lines | ~92 |
|
||||
| 03:00 | Edited src/controller/testsuite/test_p2_integration.c | persist_wal_async() → append() | ~90 |
|
||||
| 03:02 | Edited src/controller/testsuite/test_p2_integration.c | expanded (+10 lines) | ~245 |
|
||||
| 03:02 | Edited src/controller/testsuite/test_p2_integration.c | 7→8 lines | ~87 |
|
||||
| 03:03 | Edited src/controller/testsuite/test_commit_barrier_reply.c | 8→9 lines | ~130 |
|
||||
| 10:00 | reserve-lsn-0 fix: persist_init current_lsn=1 (lsn 0 reserved sentinel) — fixes bug-543 WAL hole + uncommittable cold-start NOOP + own-term gate | persist.c | 1-line prod change + comment; streamer/commit/ha unchanged | ~3k |
|
||||
| 10:05 | reframed test_coldstart_lsn0.c to reserved-0 contract (H1 first NOOP lsn1 commits, H3 gate effective, H3b gate blocks, H4 no-hole [1,2]) | test_coldstart_lsn0.c | 6/6 green incl H4 | ~2k |
|
||||
| 10:10 | base-shift test fallout: removed redundant priming appends + wired engine in test 9 | test_commit_engine, test_commit_barrier_rollout, test_commit_barrier_reply, test_p2_integration, test_egress_filter, test_p3_hardening (comments) | all green | ~4k |
|
||||
| 03:56 | Edited src/controller/testsuite/test_convergence_verification.c | modified ha_evaluate_repl_action() | ~1646 |
|
||||
| 03:57 | Edited src/controller/testsuite/test_convergence_verification.c | 6→6 lines | ~111 |
|
||||
| 03:57 | Edited src/controller/testsuite/test_convergence_verification.c | committed() → wal_tip() | ~252 |
|
||||
| 03:57 | Edited src/controller/testsuite/test_convergence_verification.c | 2→7 lines | ~104 |
|
||||
| 03:58 | Edited src/controller/ha.h | modified tree() | ~220 |
|
||||
| 03:58 | Edited src/controller/ha.h | 15→17 lines | ~249 |
|
||||
| 03:58 | Edited src/controller/ha.c | modified committed_lsn() | ~461 |
|
||||
| 03:59 | Edited src/controller/ha.c | 14→14 lines | ~191 |
|
||||
| 03:59 | Edited src/controller/ha.c | modified XCE_TESTING() | ~370 |
|
||||
| 04:00 | Edited src/controller/ha.h | 3→4 lines | ~75 |
|
||||
| 04:00 | Edited src/controller/ha.h | 14→16 lines | ~255 |
|
||||
| 11:12 | stream-uncommitted-tail: wal_tip boundary in ha_evaluate_repl_action + cold-start tests | ha.c ha.h test_convergence_verification.c | 15 suites green, 0 ASAN | ~40k |
|
||||
| 04:38 | Edited src/controller/testsuite/test_convergence_verification.c | modified test_empty_standby_fresh_cluster_streams_not_snapshot() | ~552 |
|
||||
| 04:38 | Edited src/controller/testsuite/test_convergence_verification.c | 2→3 lines | ~53 |
|
||||
| 04:44 | Edited src/controller/ha.c | 3→3 lines | ~54 |
|
||||
| 04:45 | Edited src/controller/ha.c | modified 0() | ~172 |
|
||||
| 04:45 | Edited src/controller/testsuite/test_convergence_verification.c | modified test_pin_evaluate_repl_action_snapshot_below_oldest_wal() | ~865 |
|
||||
| 04:45 | Edited src/controller/testsuite/test_convergence_verification.c | modified boundary() | ~384 |
|
||||
| 04:47 | Edited src/controller/repl.c | 5→10 lines | ~167 |
|
||||
| 04:47 | Edited src/controller/testsuite/test_p2_integration.c | expanded (+15 lines) | ~279 |
|
||||
| 05:23 | Edited src/controller/testsuite/test_repl_apply.c | 8→10 lines | ~45 |
|
||||
| 05:23 | Edited src/controller/testsuite/test_repl_apply.c | added 8 condition(s) | ~840 |
|
||||
| 05:24 | Edited src/controller/testsuite/test_repl_apply.c | modified test_repl_write_persists_and_recovers() | ~1665 |
|
||||
| 05:25 | Edited src/include/persist.h | expanded (+15 lines) | ~318 |
|
||||
| 05:26 | Edited src/controller/persist.c | added 13 condition(s) | ~1074 |
|
||||
| 05:26 | Edited src/controller/ha.c | added 1 condition(s) | ~420 |
|
||||
| 12:54 | standby persists replicated WAL before ACK (persist_wal_write_replicated + ha_apply_single_entry wiring) | persist.c, ha.c, persist.h, test_repl_apply.c | 4 new tests + 16 suites green, 0 ASAN | ~25k |
|
||||
| 06:12 | Session end: 30 writes across 10 files (test_commit_barrier_rollout.c, test_p2_integration.c, test_commit_barrier_reply.c, test_convergence_verification.c, ha.h) | 24 reads | ~100349 tok |
|
||||
| 07:03 | Edited src/controller/testsuite/test.c | 6→7 lines | ~54 |
|
||||
| 07:03 | Edited src/controller/testsuite/test.c | 7→9 lines | ~135 |
|
||||
| 07:03 | Edited src/controller/testsuite/test.c | added 2 condition(s) | ~478 |
|
||||
| 07:05 | Session end: 33 writes across 11 files (test_commit_barrier_rollout.c, test_p2_integration.c, test_commit_barrier_reply.c, test_convergence_verification.c, ha.h) | 26 reads | ~101063 tok |
|
||||
| 07:26 | Edited src/controller/ha.c | modified raft_cb_become_follower_with_cluster_for_test() | ~282 |
|
||||
| 07:27 | Edited src/controller/ha.h | expanded (+13 lines) | ~218 |
|
||||
| 07:29 | Edited src/controller/testsuite/test_convergence_verification.c | added 2 condition(s) | ~1887 |
|
||||
| 07:29 | Edited src/controller/testsuite/test_convergence_verification.c | expanded (+6 lines) | ~92 |
|
||||
| 07:30 | Edited src/controller/ha.c | expanded (+10 lines) | ~211 |
|
||||
| 14:42 | fix: vote-send sets votes[].peer → promotion registers standbys in replicator (fixes NOT_READY/no-quorum) | ha.c, ha.h, test_convergence_verification.c | GREEN: 2 new tests + 12 critical suites + full controller suite all pass, no ASAN | ~9k |
|
||||
| 08:02 | Session end: 38 writes across 11 files (test_commit_barrier_rollout.c, test_p2_integration.c, test_commit_barrier_reply.c, test_convergence_verification.c, ha.h) | 30 reads | ~106131 tok |
|
||||
| 12:53 | Edited src/controller/testsuite/test_cluster_persist.c | modified test_persist_config_defaults_sync_timeout_ms() | ~143 |
|
||||
| 12:54 | Edited src/include/config.h | 50 → 500 | ~12 |
|
||||
| 12:54 | Edited src/include/myconf.h | 2→3 lines | ~57 |
|
||||
| 12:55 | Edited src/controller/main.c | 2→3 lines | ~28 |
|
||||
| 12:55 | Edited src/controller/main.c | 3→3 lines | ~18 |
|
||||
| 12:55 | Edited src/controller/main.c | 4→5 lines | ~25 |
|
||||
| 12:55 | Edited src/controller/main.c | 3→5 lines | ~76 |
|
||||
| 12:56 | Edited src/controller/main.c | added 1 condition(s) | ~83 |
|
||||
| 12:56 | Edited src/controller/main.c | 1→2 lines | ~45 |
|
||||
| 12:56 | Edited src/controller/main.c | 1→2 lines | ~28 |
|
||||
| 12:56 | Edited src/controller/cluster.c | added 1 condition(s) | ~80 |
|
||||
| 20:02 | raise DEFAULT_SYNC_TIMEOUT_MS 50→500 + --sync-timeout-ms CLI flag | config.h, main.c, myconf.h, cluster.c, test_cluster_persist.c | RED→GREEN; timeout suites unaffected (explicit timeouts) | ~12k |
|
||||
| 13:23 | Session end: 49 writes across 16 files (test_commit_barrier_rollout.c, test_p2_integration.c, test_commit_barrier_reply.c, test_convergence_verification.c, ha.h) | 38 reads | ~122956 tok |
|
||||
| 16:13 | Session end: 49 writes across 16 files (test_commit_barrier_rollout.c, test_p2_integration.c, test_commit_barrier_reply.c, test_convergence_verification.c, ha.h) | 39 reads | ~122956 tok |
|
||||
|
||||
## Session: 2026-06-14 16:46
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 17:04 | Edited src/lib/testsuite/test_request.c | modified test_init_reply_by_req_zeroes_reply() | ~478 |
|
||||
| 17:05 | Edited src/lib/request.c | modified init_reply_by_req() | ~195 |
|
||||
| 00:10 | Fix UAF in encode_RequestReply: zero-init reply in init_reply_by_req (root-cause of ctrl-2 ASAN crash + downstream empty joblist) + RED/GREEN regression test | src/lib/request.c, src/lib/testsuite/test_request.c | 99/99 lib tests pass; test goes RED without fix | ~32k |
|
||||
| 17:10 | Session end: 2 writes across 2 files (test_request.c, request.c) | 11 reads | ~14367 tok |
|
||||
| 18:27 | Session end: 2 writes across 2 files (test_request.c, request.c) | 12 reads | ~14367 tok |
|
||||
|
||||
## Session: 2026-06-15 01:16
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 09:17 | Diagnosed "jobsub ok but joblist empty": traced to deployed binary lacking the UNCOMMITTED bug-562 memset → live encode_RequestReply UAF corrupts jobmgr heap. Ruled out HA routing/iterator/removal. | src/lib/request.c, .wolf/buglog.json(bug-563), .wolf/cerebrum.md | diagnosed, fix=commit+rebuild+redeploy under ASAN | ~large |
|
||||
|
||||
## Session: 2026-06-15 02:29
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 09:31 | verify bug-562 init_reply_by_req memset fix + regression test | src/lib/request.c, test_request.c | lib build green 1/1, test_init_reply_by_req_zeroes_reply PASS under ASAN; fix still uncommitted | ~6k |
|
||||
| 02:38 | Edited src/controller/opget.c | modified if() | ~70 |
|
||||
| 02:38 | Edited src/controller/opget.c | expanded (+10 lines) | ~140 |
|
||||
| 02:38 | Edited src/controller/opget.c | modified do_reply_joblist() | ~54 |
|
||||
| 02:38 | Edited src/controller/job.c | expanded (+13 lines) | ~193 |
|
||||
| 02:43 | Edited src/lib/request.c | modified if() | ~83 |
|
||||
| 02:48 | Edited src/controller/myapp.c | modified if() | ~250 |
|
||||
| 02:49 | Edited src/lib/request.c | removed 4 lines | ~12 |
|
||||
| 02:49 | Edited src/controller/job.c | removed 14 lines | ~19 |
|
||||
| 02:49 | Edited src/controller/opget.c | modified do_reply_joblist() | ~30 |
|
||||
| 02:50 | Edited src/controller/opget.c | modified if() | ~26 |
|
||||
| 02:50 | Edited src/controller/opget.c | removed 15 lines | ~25 |
|
||||
| 02:57 | Session end: 11 writes across 4 files (opget.c, job.c, request.c, myapp.c) | 4 reads | ~965 tok |
|
||||
| 03:02 | Edited src/controller/cluster.c | modified cluster_run() | ~219 |
|
||||
| 03:03 | Edited src/controller/myapp.c | removed 12 lines | ~22 |
|
||||
| 03:05 | Session end: 13 writes across 5 files (opget.c, job.c, request.c, myapp.c, cluster.c) | 5 reads | ~1223 tok |
|
||||
| 03:08 | Session end: 13 writes across 5 files (opget.c, job.c, request.c, myapp.c, cluster.c) | 5 reads | ~1223 tok |
|
||||
|
||||
## Session: 2026-06-15 03:30
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 03:46 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | added error handling | ~990 |
|
||||
| 03:46 | Edited src/controller/ha.c | added 1 condition(s) | ~513 |
|
||||
| 03:46 | Edited src/controller/ha.c | 5→4 lines | ~62 |
|
||||
| 10:55 | RCA+fix: infinite election loop after primary death — RDHUP candidate advertised stale persist.committed_lsn vs voter floor max(applied_lsn,last_known_committed); TDD RED→GREEN | src/controller/ha.c, testsuite/test_ha_rdhup_integration.c | bug-339 fixed, 7 rdhup + 36 election tests pass | ~45k |
|
||||
| 03:56 | Created ../../../../../claude/.claude/projects/-home-rshen-projects-xce-xce/memory/project_ha_vote_freshness_invariant.md | — | ~523 |
|
||||
| 03:56 | Edited ../../../../../claude/.claude/projects/-home-rshen-projects-xce-xce/memory/MEMORY.md | modified 339() | ~154 |
|
||||
| 03:56 | Session end: 5 writes across 4 files (test_ha_rdhup_integration.c, ha.c, project_ha_vote_freshness_invariant.md, MEMORY.md) | 9 reads | ~66100 tok |
|
||||
| 03:58 | Edited src/controller/myapp.c | expanded (+8 lines) | ~210 |
|
||||
|
||||
## Session: 2026-06-15 04:00
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 11:08 | Follow-up (bug-339): boot election path now also uses ha_vote_self_freshness (was raw applied_lsn) — both election paths symmetric with voter floor | src/controller/myapp.c | clean build, all 8 election/vote/failover suites 0 failures | ~8k |
|
||||
| 04:10 | Edited .kiro/steering/product.md | "raft.c" → "src/lib/raft/" | ~115 |
|
||||
| 04:10 | Edited .kiro/steering/product.md | 4→7 lines | ~143 |
|
||||
| 04:10 | Session end: 2 writes across 1 files (product.md) | 7 reads | ~6669 tok |
|
||||
| 04:10 | Edited .kiro/steering/tech.md | "raft.c" → "src/lib/raft/" | ~75 |
|
||||
| 04:10 | Edited .kiro/steering/structure.md | modified library() | ~54 |
|
||||
| 04:11 | Session end: 4 writes across 3 files (product.md, tech.md, structure.md) | 7 reads | ~6838 tok |
|
||||
|
||||
## Session: 2026-06-15 07:41
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 07:44 | Edited src/controller/ha.c | added 3 condition(s) | ~833 |
|
||||
| 07:44 | Edited src/controller/ha.c | expanded (+9 lines) | ~206 |
|
||||
| 07:45 | Edited src/controller/ha.c | reduced (-8 lines) | ~75 |
|
||||
| 07:46 | Edited src/controller/testsuite/test_ha_liveness.c | modified evicts() | ~1136 |
|
||||
| 07:46 | Edited src/controller/testsuite/test_ha_liveness.c | 3→6 lines | ~87 |
|
||||
| 14:48 | RCA+fix: kill+restart ctrl loops elections forever — primary never evicted wedged outbound standby ep → reconnect suppressed → restarted node never heartbeated. Added liveness eviction (ts_last_in stale) in primary_heartbeat_fn. TDD RED→GREEN | src/controller/ha.c, testsuite/test_ha_liveness.c | bug-340 fixed; 17 liveness + all HA suites pass | ~70k |
|
||||
| 07:49 | Session end: 5 writes across 2 files (ha.c, test_ha_liveness.c) | 1 reads | ~9623 tok |
|
||||
| 15:25 | LIVE VERIFY 3-node deploy: bug-340 eviction FIRES on wedge (SIGSTOP standby -> "standby[2] silent for 12s — evicting dead endpoint" -> reconnect). kill+restart of primary AND standby both rejoin cleanly, no loop. Failover (bug-339) works. committed_lsn=9 survived failovers; cluster reconverges even after freeze/resume. | /tmp/xce-deploy | PASS (joblist display empty = separate read-path quirk, data committed) | ~120k |
|
||||
| 08:25 | Session end: 5 writes across 2 files (ha.c, test_ha_liveness.c) | 2 reads | ~9623 tok |
|
||||
| 23:39 | (b) joblist gap = NOT a bug. Verified live: works on fresh cluster (submit+immediate list shows all jobs) AND after failover (new primary ctrl-2 replays WAL->jobmgr, all 4 jobs visible). Earlier empty = transient during SIGSTOP/SIGCONT churn (demotion-convergence truncate+self-restart recovery window). Enabling fix = uncommitted c->running=1 in cluster_run (cluster.c in-progress work), functioning. | live deploy | RESOLVED no code change | ~40k |
|
||||
| 16:41 | Session end: 5 writes across 2 files (ha.c, test_ha_liveness.c) | 6 reads | ~9623 tok |
|
||||
| 16:46 | Created .kiro/specs/ha-prevote/spec.json | — | ~127 |
|
||||
| 16:46 | Created .kiro/specs/ha-prevote/requirements.md | — | ~1220 |
|
||||
| 23:46 | (c) kiro-spec-init ha-prevote: created spec.json + requirements.md (Raft PreVote for disruptive-rejoin edge; mechanism confirmed raft.c:125-134 term-adoption-before-gate) | .kiro/specs/ha-prevote/ | spec scaffolded, requirements phase next | ~10k |
|
||||
| 16:47 | Session end: 7 writes across 4 files (ha.c, test_ha_liveness.c, spec.json, requirements.md) | 6 reads | ~11058 tok |
|
||||
|
||||
## Session: 2026-06-15 16:51
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 16:56 | Created .kiro/specs/ha-prevote/requirements.md | — | ~3845 |
|
||||
| 16:56 | Created .kiro/specs/ha-prevote/spec.json | — | ~130 |
|
||||
| 23:52 | kiro requirements: ha-prevote (Raft PreVote phase) | .kiro/specs/ha-prevote/requirements.md | 7 reqs, review gate passed | ~6k |
|
||||
| 16:57 | Session end: 2 writes across 2 files (requirements.md, spec.json) | 13 reads | ~7508 tok |
|
||||
| 17:04 | Created .kiro/specs/ha-prevote/research.md | — | ~3623 |
|
||||
| 23:58 | kiro gap-analysis: ha-prevote | .kiro/specs/ha-prevote/research.md | hybrid (Opt C) rec, M/Medium, 5 research items | ~7k |
|
||||
| 17:04 | Session end: 3 writes across 3 files (requirements.md, spec.json, research.md) | 15 reads | ~12655 tok |
|
||||
| 17:10 | Edited .kiro/specs/ha-prevote/research.md | 2→3 lines | ~202 |
|
||||
| 17:11 | Session end: 4 writes across 3 files (requirements.md, spec.json, research.md) | 15 reads | ~12871 tok |
|
||||
| 17:14 | Session end: 4 writes across 3 files (requirements.md, spec.json, research.md) | 15 reads | ~12871 tok |
|
||||
| 17:18 | Edited .kiro/specs/ha-prevote/research.md | inline fix | ~43 |
|
||||
| 17:18 | Edited .kiro/specs/ha-prevote/research.md | expanded (+40 lines) | ~1287 |
|
||||
| 00:14 | ha-prevote RN-2 resolved: stickiness=heartbeat_timeout_ms (Opt 1) | research.md, cerebrum.md | comparison table added, decision logged | ~3k |
|
||||
| 17:19 | Session end: 6 writes across 3 files (requirements.md, spec.json, research.md) | 16 reads | ~17774 tok |
|
||||
| 17:25 | Created .kiro/specs/ha-prevote/design.md | — | ~6859 |
|
||||
| 17:26 | Edited .kiro/specs/ha-prevote/research.md | expanded (+25 lines) | ~881 |
|
||||
| 17:26 | Created .kiro/specs/ha-prevote/spec.json | — | ~128 |
|
||||
| 00:30 | kiro design: ha-prevote | design.md, research.md, spec.json | new opcodes reuse vote structs, reuse eligibility+collection, defer defense-in-depth; review gate passed | ~9k |
|
||||
| 17:26 | Session end: 9 writes across 4 files (requirements.md, spec.json, research.md, design.md) | 21 reads | ~35393 tok |
|
||||
| 18:26 | Session end: 9 writes across 4 files (requirements.md, spec.json, research.md, design.md) | 22 reads | ~36483 tok |
|
||||
| 20:00 | Edited .kiro/specs/ha-prevote/design.md | 2→3 lines | ~141 |
|
||||
| 20:00 | Edited .kiro/specs/ha-prevote/design.md | 2→3 lines | ~69 |
|
||||
| 20:00 | Edited .kiro/specs/ha-prevote/design.md | inline fix | ~145 |
|
||||
| 20:00 | Edited .kiro/specs/ha-prevote/design.md | inline fix | ~12 |
|
||||
| 20:00 | Edited .kiro/specs/ha-prevote/design.md | 2→2 lines | ~156 |
|
||||
| 20:01 | Edited .kiro/specs/ha-prevote/design.md | 5→5 lines | ~510 |
|
||||
| 20:01 | Edited .kiro/specs/ha-prevote/design.md | 2→2 lines | ~158 |
|
||||
| 20:01 | Edited .kiro/specs/ha-prevote/design.md | 4→5 lines | ~106 |
|
||||
| 20:01 | Edited .kiro/specs/ha-prevote/design.md | inline fix | ~49 |
|
||||
| 20:01 | Edited .kiro/specs/ha-prevote/design.md | 11→11 lines | ~399 |
|
||||
| 20:02 | Edited .kiro/specs/ha-prevote/design.md | "ha_elect_ctx_t" → "raft_on_pre_vote_reply" | ~56 |
|
||||
| 20:02 | Edited .kiro/specs/ha-prevote/design.md | "ha_elect_evaluate_and_sig" → "raft_on_pre_vote_reply" | ~34 |
|
||||
| 20:02 | Edited .kiro/specs/ha-prevote/design.md | "ha_elect_evaluate_and_sig" → "pre_vote_reply_dispatch" | ~24 |
|
||||
| 20:02 | Edited .kiro/specs/ha-prevote/design.md | "ha_elect_ctx_t.votes[].re" → "raft_state_t" | ~66 |
|
||||
| 20:02 | Edited .kiro/specs/ha-prevote/design.md | "raft_state_t" → "raft_on_pre_vote_reply" | ~80 |
|
||||
| 20:02 | Edited .kiro/specs/ha-prevote/design.md | inline fix | ~51 |
|
||||
| 20:02 | Edited .kiro/specs/ha-prevote/design.md | inline fix | ~86 |
|
||||
| 20:05 | Created .kiro/specs/ha-prevote/tasks.md | — | ~2118 |
|
||||
| 20:06 | Edited .kiro/specs/ha-prevote/tasks.md | tests() → hook() | ~325 |
|
||||
| 20:07 | Edited .kiro/specs/ha-prevote/tasks.md | 6→6 lines | ~172 |
|
||||
| 20:07 | Created .kiro/specs/ha-prevote/spec.json | — | ~126 |
|
||||
| 00:55 | ha-prevote: design fixes (tally->raft lib) + tasks generated | design.md, tasks.md, spec.json | 6 major / 11 sub tasks, sanity review PASS after 1 fix pass, all 27 reqs covered, auto-approved | ~7k |
|
||||
| 20:07 | Session end: 30 writes across 5 files (requirements.md, spec.json, research.md, design.md, tasks.md) | 27 reads | ~56776 tok |
|
||||
|
||||
## Session: 2026-06-16 20:32
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 20:40 | Edited src/schema/controller.capnp | 3→5 lines | ~26 |
|
||||
|
||||
## Session: 2026-06-16 20:41
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
|
||||
## Session: 2026-06-16 20:48
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
|
||||
## Session: 2026-06-16 20:49
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 20:50 | Edited .kiro/steering/roadmap.md | 1→3 lines | ~346 |
|
||||
| 20:50 | Session end: 1 writes across 1 files (roadmap.md) | 1 reads | ~2732 tok |
|
||||
|
||||
## Session: 2026-06-16 20:55
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
|
||||
## Session: 2026-06-16 20:56
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
|
||||
## Session: 2026-06-16 20:57
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 20:59 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~16 |
|
||||
| 21:00 | Session end: 1 writes across 1 files (tasks.md) | 0 reads | ~17 tok |
|
||||
| 21:01 | Edited src/lib/raft/raft.h | modified enum() | ~101 |
|
||||
| 21:01 | Edited src/lib/raft/raft.h | expanded (+7 lines) | ~212 |
|
||||
| 21:02 | Edited src/lib/raft/raft.h | expanded (+8 lines) | ~172 |
|
||||
| 21:02 | Edited src/lib/raft/raft.h | modified callbacks() | ~69 |
|
||||
| 21:02 | Edited src/lib/raft/raft.h | expanded (+7 lines) | ~134 |
|
||||
| 21:02 | Edited src/lib/raft/raft.h | modified INVARIANT() | ~541 |
|
||||
| 04:03 | task 1.2: PreVote scaffolding (types/state/callback/decls) | src/lib/raft/raft.h | header-only, libxce test OK | ~6k |
|
||||
| 21:07 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~21 |
|
||||
| 21:08 | Edited .kiro/specs/ha-prevote/tasks.md | modified bodies() | ~297 |
|
||||
| 01:40 | kiro-impl ha-prevote foundation: tasks 1.1+1.2 | controller.capnp, raft.h | both APPROVED by review, committed 0d66026/449b8e9; pre-existing c->running fix split to 646aa69 | ~8k |
|
||||
| 21:09 | Session end: 9 writes across 2 files (tasks.md, raft.h) | 3 reads | ~14740 tok |
|
||||
| 21:18 | Edited src/lib/testsuite/test_raft.c | added error handling | ~1850 |
|
||||
| 21:18 | Edited src/lib/testsuite/test_raft.c | expanded (+8 lines) | ~128 |
|
||||
| 21:19 | Edited src/lib/raft/raft.c | added 6 condition(s) | ~520 |
|
||||
| 21:24 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~14 |
|
||||
| 21:26 | Edited src/lib/testsuite/test_raft.c | expanded (+8 lines) | ~147 |
|
||||
| 21:26 | Edited src/lib/testsuite/test_raft.c | added 2 condition(s) | ~162 |
|
||||
| 21:26 | Edited src/lib/testsuite/test_raft.c | 3→4 lines | ~65 |
|
||||
| 21:27 | Edited src/lib/testsuite/test_raft.c | modified test_begin_pre_vote_uses_prospective_term_not_persisted() | ~1707 |
|
||||
| 21:27 | Edited src/lib/testsuite/test_raft.c | expanded (+8 lines) | ~130 |
|
||||
| 21:27 | Edited src/lib/raft/raft.c | added 4 condition(s) | ~453 |
|
||||
| 04:30 | task 2.2: raft_begin_pre_vote candidate-side PreVote start (TDD: 6 RED→GREEN tests, pure: no term/voted_for/role/persist) | src/lib/raft/raft.c, src/lib/testsuite/test_raft.c | 111 raft tests pass, 0 fail | ~12k |
|
||||
| 21:33 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~14 |
|
||||
| 21:36 | Edited src/lib/testsuite/test_raft.c | added 1 condition(s) | ~2106 |
|
||||
| 21:36 | Edited src/lib/testsuite/test_raft.c | expanded (+10 lines) | ~165 |
|
||||
| 21:37 | Edited src/lib/raft/raft.c | added 10 condition(s) | ~790 |
|
||||
| 21:45 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~12 |
|
||||
| 21:49 | Edited src/controller/testsuite/test_ha_vote_gate.c | 7→8 lines | ~56 |
|
||||
| 21:50 | Edited src/controller/testsuite/test_ha_vote_gate.c | added error handling | ~3581 |
|
||||
| 21:50 | Edited src/controller/testsuite/test_ha_vote_gate.c | expanded (+9 lines) | ~158 |
|
||||
| 21:51 | Edited src/controller/testsuite/test_ha_vote_gate.c | 4→4 lines | ~44 |
|
||||
| 21:57 | Edited src/controller/cluster.c | added 10 condition(s) | ~1576 |
|
||||
| 21:57 | Edited src/controller/cluster.c | ha_heartbeat_is_fresh() → heartbeat() | ~402 |
|
||||
| 22:20 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~23 |
|
||||
| 22:21 | Edited .kiro/specs/ha-prevote/tasks.md | 1→3 lines | ~403 |
|
||||
| 22:26 | Created src/controller/testsuite/test_ha_prevote.c | — | ~3448 |
|
||||
| 22:26 | Edited src/controller/meson.build | 1→2 lines | ~18 |
|
||||
| 22:27 | Edited src/controller/testsuite/controller_test.c | 2→3 lines | ~29 |
|
||||
| 22:27 | Edited src/controller/testsuite/controller_test.c | 2→3 lines | ~23 |
|
||||
| 22:27 | Edited src/controller/ha.c | 2→3 lines | ~39 |
|
||||
| 22:28 | Edited src/controller/ha.c | added 11 condition(s) | ~884 |
|
||||
| 22:28 | Edited src/controller/ha.c | 3→4 lines | ~63 |
|
||||
| 22:28 | Edited src/controller/ha.c | added 1 condition(s) | ~393 |
|
||||
| 22:30 | Edited src/controller/ha.c | added 17 condition(s) | ~3511 |
|
||||
| 22:30 | Edited src/controller/ha.h | expanded (+19 lines) | ~322 |
|
||||
| 22:33 | Edited src/controller/ha.c | modified pre_vote_reply_dispatch() | ~146 |
|
||||
| 22:44 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~17 |
|
||||
| 22:44 | Edited .kiro/specs/ha-prevote/tasks.md | 1→2 lines | ~232 |
|
||||
| 22:50 | Created src/controller/testsuite/test_ha_failover_prevote.c | — | ~3890 |
|
||||
| 22:50 | Edited src/controller/meson.build | 2→3 lines | ~30 |
|
||||
| 22:50 | Edited src/controller/testsuite/controller_test.c | 2→3 lines | ~31 |
|
||||
| 22:50 | Edited src/controller/testsuite/controller_test.c | 2→3 lines | ~25 |
|
||||
| 22:50 | Edited src/controller/testsuite/test_ha_failover_prevote.c | modified struct() | ~156 |
|
||||
| 22:51 | Edited src/controller/testsuite/test_ha_failover_prevote.c | 7→7 lines | ~47 |
|
||||
| 22:52 | Edited src/controller/ha.c | modified from() | ~1241 |
|
||||
| 22:52 | Edited src/controller/ha.c | added 3 condition(s) | ~417 |
|
||||
| 22:53 | Edited src/controller/ha.c | added 1 condition(s) | ~310 |
|
||||
| 22:53 | Edited src/controller/ha.h | expanded (+12 lines) | ~172 |
|
||||
| 22:59 | Edited src/controller/ha.c | modified XCE_TESTING() | ~230 |
|
||||
| 23:28 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~22 |
|
||||
| 23:29 | Edited .kiro/specs/ha-prevote/tasks.md | 1→2 lines | ~223 |
|
||||
| 23:32 | Edited src/controller/ha.c | added 5 condition(s) | ~723 |
|
||||
| 23:33 | Edited src/controller/ha.c | added 1 condition(s) | ~431 |
|
||||
| 23:33 | Edited src/controller/ha.c | modified caller() | ~76 |
|
||||
| 23:33 | Edited src/controller/ha.c | 3→8 lines | ~151 |
|
||||
| 23:33 | Edited src/controller/ha.c | modified peer_ctrl_msg_handler_for_test() | ~225 |
|
||||
| 23:34 | Edited src/controller/testsuite/test_ha_prevote.c | expanded (+27 lines) | ~464 |
|
||||
| 23:34 | Edited src/controller/testsuite/test_ha_prevote.c | modified 1() | ~896 |
|
||||
| 06:43 | task 5.1 wire preVoteReply route in peer_ctrl_msg_handler (STANDBY+pre_vote_in_progress) → pre_vote_reply_decode_and_dispatch → pre_vote_reply_dispatch; removed __attribute__((used)) | ha.c, test_ha_prevote.c | daemon+tests build; new real-transport test PASS, 0 FAIL | ~7k |
|
||||
|
||||
## Session: 2026-06-16 23:44
|
||||
|
||||
| Time | Action | File(s) | Outcome | ~Tokens |
|
||||
|------|--------|---------|---------|--------|
|
||||
| 23:46 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~19 |
|
||||
| 23:50 | Edited src/controller/testsuite/test_ha_prevote.c | added 1 condition(s) | ~3130 |
|
||||
| 06:50 | ha-prevote task 5.2: frozen-rejoin no-op scenario tests | test_ha_prevote.c | 2 new tests PASS (voter-deny-no-adoption + candidate-no-majority-noop); 9/9 suite, failover+vote_gate green | ~9k |
|
||||
| 23:54 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~14 |
|
||||
| 23:58 | Edited src/controller/testsuite/test_ha_prevote.c | added error handling | ~3528 |
|
||||
| 00:08 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~15 |
|
||||
| 00:12 | Edited src/lib/testsuite/test_raft.c | modified tests() | ~3830 |
|
||||
| 00:12 | Edited src/lib/testsuite/test_raft.c | expanded (+6 lines) | ~132 |
|
||||
| 00:13 | Edited .kiro/specs/ha-prevote/research.md | expanded (+54 lines) | ~945 |
|
||||
| 00:17 | Edited .kiro/specs/ha-prevote/tasks.md | inline fix | ~16 |
|
||||
| 02:30 | kiro-impl ha-prevote: ALL 11 tasks done (2.1-6.1) | raft+ha+cluster+tests | every task review-APPROVED + committed; raft suite 123/0, controller 563/0 | ~60k |
|
||||
| 02:50 | kiro-validate-impl ha-prevote: GO | full suites | raft 123/0, controller 564/0 (direct binary, no real fail), smoke OK, 27/27 reqs, boundary clean | ~5k |
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue