From c454f0652d7e1e788a18292effad35c36b02a321 Mon Sep 17 00:00:00 2001 From: Rongsong Shen Date: Sun, 6 Sep 2026 10:07:49 +0000 Subject: [PATCH] test(resreq-maxtasks-wiring): fix deferred queue-priority assertion test_info_job_reports_state_queue_priority now expects "Tasks: min = 1, max = 1" instead of the pre-fix "min = 0, max = 0" incidental byproduct (a fixture's parse_select() failing on an unregistered "type" resource used to leave the primary's task-count fields at memset-zero; apply_job_task_count() now correctly overwrites them to the job's real submitted default of 1/1). This was the one deferred item tracked in tasks.md's Implementation Notes since task 2.1. Full-suite regression confirmed clean: scheduler/controller/worker suites pass except the pre-existing, unrelated bug-1758 (predates this feature, attributed to a separate spec). A full /xce-build all also surfaces bug-1723, a pre-existing lib-suite fixture-teardown leak dating to before this feature and outside Requirement 5.1's named scope (scheduler/controller/worker) -- confirmed untouched by any of this feature's commits. Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01XYdtrEWWZfKRRGED7raEYg --- .kiro/specs/resreq-maxtasks-wiring/tasks.md | 2 +- src/scheduler/testsuite/test_repl_breakpoints_inspection.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.kiro/specs/resreq-maxtasks-wiring/tasks.md b/.kiro/specs/resreq-maxtasks-wiring/tasks.md index fc47dbad..316d7057 100644 --- a/.kiro/specs/resreq-maxtasks-wiring/tasks.md +++ b/.kiro/specs/resreq-maxtasks-wiring/tasks.md @@ -78,7 +78,7 @@ - _Requirements: 5.5_ - [ ] 5. Validation: full non-regression confirmation -- [ ] 5.1 Run and confirm the full existing scheduler, controller, and worker test suites +- [x] 5.1 Run and confirm the full existing scheduler, controller, and worker test suites - Re-run the complete existing suites and confirm every assertion still passes unmodified except for the intentional test changes made in this feature's own tasks - Observable: a clean full-suite pass recorded as this feature's non-regression evidence - _Requirements: 2.3, 5.1_ diff --git a/src/scheduler/testsuite/test_repl_breakpoints_inspection.c b/src/scheduler/testsuite/test_repl_breakpoints_inspection.c index 89e1009f..8a8b18fe 100644 --- a/src/scheduler/testsuite/test_repl_breakpoints_inspection.c +++ b/src/scheduler/testsuite/test_repl_breakpoints_inspection.c @@ -732,7 +732,7 @@ static void test_info_job_reports_state_queue_priority(void) * skeleton is the real, deterministic format_resreq() output for this * fixture -- not a placeholder standing in for it. */ TEST_ASSERT_NOT_NULL(strstr(captured, "resreq=Primary:")); - TEST_ASSERT_NOT_NULL(strstr(captured, "Tasks: min = 0, max = 0")); + TEST_ASSERT_NOT_NULL(strstr(captured, "Tasks: min = 1, max = 1")); TEST_ASSERT_NOT_NULL(strstr(captured, "Rusages:")); TEST_ASSERT_NULL(strstr(captured, "resreq=set")); TEST_ASSERT_NULL(strstr(captured, "resreq=(none)"));