lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(buglog): mark bug-1979 fixed (00f81c5a)

Browse source 
Co-Authored-By: Claude Code <noreply@anthropic.com>
This commit is contained in:
lei.chen 2026-10-29 03:22:46 +00:00
parent 00f81c5aa8
commit d710f56eaa
2 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
.wolf/buglog.json
View file

@ -222,15 +222,15 @@
},
{
"id": "bug-1979",
"status": "open",
"status": "fixed",
"status_updated": "2026-10-29",
"status_note": "newly logged",
"status_note": "",
"component": "scheduler",
"severity": "crash",
"timestamp": "2026-10-29T03:16:20Z",
"last_seen": "2026-10-29T03:16:20Z",
"occurrences": 1,
"error_message": "sched_test makeResource() implicitly declared in test.c TU -- pointer truncated to int, dereference(made) SEGVs\n\n**Observed:**\n`ASAN_OPTIONS=detect_leaks=1 ./scheduler/testsuite/sched_test` SEGVs in\n`dereference` after all 17 tests PASS:\n\n```\n==659821==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000258\n #0 in dereference ../subprojects/librtti/src/ref.c:31\n #1 in test_unsatisfy_external_skips_inuse_shared_leg ../scheduler/testsuite/test.c:826\n```\n\n**Expected:** the test's teardown `dereference(made)` releases the\nrefcount-1 resource object registered by `makeResource()`.\n\n**Impact:** sched_test cannot run with leak detection enabled (the\n`xce-build.sh all` manual direct-run step); crashes after a clean PASS.\n\n**Found by:** ASAN direct run while closing out the\nfeature/license-resources -> working merge verification.",
"error_message": "makeResource() implicitly declared in sched_test -- pointer truncated, dereference SEGVs\n\n**Observed:**\n`ASAN_OPTIONS=detect_leaks=1 ./scheduler/testsuite/sched_test` SEGVs in\n`dereference` after all 17 tests PASS:\n\n```\n==659821==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000258\n #0 in dereference ../subprojects/librtti/src/ref.c:31\n #1 in test_unsatisfy_external_skips_inuse_shared_leg ../scheduler/testsuite/test.c:826\n```\n\n**Expected:** the test's teardown `dereference(made)` releases the\nrefcount-1 resource object registered by `makeResource()`.\n\n**Impact:** sched_test cannot run with leak detection enabled (the\n`xce-build.sh all` manual direct-run step); crashes after a clean PASS.\n\n**Found by:** ASAN direct run while closing out the\nfeature/license-resources -> working merge verification.",
"file": "src/scheduler/testsuite/test.c",
"root_cause": "`test.c` never includes `resobj.h` and has no local extern, so\n`makeResource()` is an *implicitly declared* function in this TU\n(gnu17 + this gcc emits only a warning; the build proceeds). An implicit\ndeclaration returns `int`: the real 64-bit pointer `0x50b000000118` is\ntruncated to 32-bit `eax` (`0x118`) and sign-extended back\n(`cltq` visible in the disassembly right after the\n`call makeResource`), so `made == 0x118` -- garbage.\n\nThe bug was introduced with the test itself (E2 Phase 1, 2fcacac2) but\nlay dormant: the test only ever did `TEST_ASSERT_NOT_NULL(made)`\n(`0x118 != NULL` always passes) and `key_find`-re-derived the real\npointer into `r` for the flag overwrite. The merge-verification leak fix\nadded `dereference(made)` in the teardown -- the FIRST real use of the\ntruncated pointer -- which turned the latent defect into a SEGV.",
"fix": "`#include \"resobj.h\"` in src/scheduler/testsuite/test.c (the header that\ndeclares `extern xce_resource_t* makeResource(var, xce_resource_t*)`),\nplus the leak fixes that motivated the teardown:\nsymmetric single `xvec_init`/`xvec_fini` for `uncomitted`, memset-only\n`unmeet` (`sched_check_shared_satisfy_()` xvec_idval_init()s it itself),\nand the collect-then-dereference teardown\n(`dereference(made)` -> `destroy(core.resmgr)` -> `xstring_table_fini()`,\nmirroring `xce_sched_core_fini()`/core.c:405).\n\nVerification:\n- Test: test_unsatisfy_external_skips_inuse_shared_leg\n (src/scheduler/testsuite/test.c); the SEGV itself was the RED state\n (deterministic, both full-run and single-test mode), GREEN after the\n include: rc=0, 17/17 PASS, zero leak reports under\n `ASAN_OPTIONS=detect_leaks=1`, single-test mode too.\n- Suites: `meson test --suite controller` 6/6 OK; full\n `xce-build.sh all` re-run pending at logging time.\n- Live: n/a (unit test only).",
@ -241,7 +241,9 @@
"external-license-resources"
],
"related_bugs": [],
"fix_commits": [],
"fix_commits": [
"00f81c5a"
],
"record": ".wolf/bugs/bug-1979.md"
}
]