docs(buglog): P0 defects fixed (bug-1936..bug-1955; 1936 and 1955 partial), bug-1956 cannot-reproduce

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Rongsong Shen 2026-10-10 09:15:15 +00:00
parent d3da314041
commit e5a0e42b66
Signed by untrusted user: rshen
GPG key ID: 80533536B0EB651C
22 changed files with 353 additions and 266 deletions

View file

@ -1,8 +1,8 @@
---
id: "bug-1941"
status: "open"
status: "fixed"
status_updated: "2026-10-10"
status_note: "newly logged"
status_note: ""
component: "controller"
severity: "wrong-result"
timestamp: "2026-10-10T08:14:48Z"
@ -11,6 +11,7 @@ occurrences: 1
files: ["src/controller/job.c"]
tags: ["controller", "job-control", "host-status"]
related: []
fix_commits: ["f244661b"]
---
# bug-1941: xce_controller refuses kill/stop/resume of running jobs on hosts whose status is not exactly OK
@ -40,15 +41,16 @@ Any other status bit (CLOSED_BY_ADMIN, BUSY, UNAVAIL...) makes the control reque
- Frequency: deterministic (by code reading; confirmed by the RED test of the fix)
- Evidence: the code sites quoted in Description; no logs kept.
## Root cause
TODO: required for fixed/partial
`job_ctrl()` (`src/controller/job.c`) sent control only if `w->host.status == 0` and returned `-errno` otherwise. Pre-existing FIXME.
## Fix
TODO: required for fixed/partial
`job.c`: new `job_ctrl_to_host()` sends whenever the worker is connected (endpoint present, not UNAVAIL), so CLOSED/CLOSED_BY_ADMIN/BUSY/locked hosts work; an unknown or unconnected host fails with `-E_XCE_BAD_WORKER` and an error log naming it.
## Verification
- Test: TODO: name + file; RED before the fix, GREEN after
- Suites: TODO: suite results and build profile
- Live: TODO: soak/deploy run, or n/a and why
- Test: `test_jc_connected_flagged_host_is_controllable` and `test_jc_unconnected_host_fails_with_bad_worker` (`src/controller/testsuite/test_job_ctrl_hosts.c`): RED `:239: FAIL: Expected 0 Was -2 (status 0x100000)` and `Expected -10002 Was -22`, GREEN after (asserts the decoded request in the worker send queue).
- Suites: `xce-build.sh all asan xce.build --incremental` on the merged branch, 2026-10-10: all C suites Ok 155 / Fail 0, frontend Go unit tests ok, xceadmin tests ok; apiserver `CGO_ENABLED=0 go test ./...` (incl. middleware, router, cmd) ok
- Live: n/a: unit/fixture-level verification only; no live deployment was run (follow-up)
## References
- Related: none
- Fix commit: `f244661b` (on `scheduler-framework`; worker-branch original in the merge)
- Review: `.kiro/reviews/project-gap-review-2026-10-10.md`