docs(buglog): P0 defects fixed (bug-1936..bug-1955; 1936 and 1955 partial), bug-1956 cannot-reproduce
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
d3da314041
commit
e5a0e42b66
22 changed files with 353 additions and 266 deletions
|
|
@ -1,8 +1,8 @@
|
|||
---
|
||||
id: "bug-1949"
|
||||
status: "open"
|
||||
status: "fixed"
|
||||
status_updated: "2026-10-10"
|
||||
status_note: "newly logged"
|
||||
status_note: ""
|
||||
component: "apiserver"
|
||||
severity: "security"
|
||||
timestamp: "2026-10-10T08:15:09Z"
|
||||
|
|
@ -11,6 +11,7 @@ occurrences: 1
|
|||
files: ["src/frontend/apiserver/controllers/rbac_check.go", "src/frontend/apiserver/middleware/whitelist.go", "src/frontend/apiserver/controllers/response.go"]
|
||||
tags: ["apiserver", "security", "middleware"]
|
||||
related: []
|
||||
fix_commits: ["42a402a5"]
|
||||
---
|
||||
|
||||
# bug-1949: apiserver RequirePermission and IP whitelist write an error but do not abort the request
|
||||
|
|
@ -35,15 +36,16 @@ On a bad token `RequirePermission` returns an error response without `Abort()` (
|
|||
- Frequency: deterministic (by code reading; confirmed by the RED test of the fix)
|
||||
- Evidence: the code sites quoted in Description; no logs kept.
|
||||
## Root cause
|
||||
TODO: required for fixed/partial
|
||||
`RequirePermission` (`controllers/rbac_check.go`) and `WhitelistIPMiddleware` (`middleware/whitelist.go`) wrote an error via `ReturnError` without `ctx.Abort()`.
|
||||
|
||||
## Fix
|
||||
TODO: required for fixed/partial
|
||||
`ctx.Abort()` added at both sites and on ValidateHandler's request-body check; a bad token in RequirePermission now answers 401 (was 500). `ReturnError` stays non-aborting (documented): `hosts.go` relies on `ctx.IsAborted()` after a helper's error. Follow-up: `ControlHost` can still write twice if reached.
|
||||
|
||||
## Verification
|
||||
- Test: TODO: name + file; RED before the fix, GREEN after
|
||||
- Suites: TODO: suite results and build profile
|
||||
- Live: TODO: soak/deploy run, or n/a and why
|
||||
- Test: `TestRequirePermission_AbortsOnInvalidToken` (`controllers/rbac_abort_test.go`): RED `handler ran after RequirePermission failed (status 500)`; `TestWhitelistIPMiddleware_AbortsOnFailure/unparsable_client_IP`: RED `handler ran after the IP whitelist rejected`; GREEN after.
|
||||
- Suites: `xce-build.sh all asan xce.build --incremental` on the merged branch, 2026-10-10: all C suites Ok 155 / Fail 0, frontend Go unit tests ok, xceadmin tests ok; apiserver `CGO_ENABLED=0 go test ./...` (incl. middleware, router, cmd) ok
|
||||
- Live: n/a: unit/fixture-level verification only; no live deployment was run (follow-up)
|
||||
|
||||
## References
|
||||
- Related: none
|
||||
- Fix commit: `42a402a5` (on `scheduler-framework`; worker-branch original in the merge)
|
||||
- Review: `.kiro/reviews/project-gap-review-2026-10-10.md`
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue