docs(buglog): P0 defects fixed (bug-1936..bug-1955; 1936 and 1955 partial), bug-1956 cannot-reproduce

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

.wolf/bugs/bug-1952.md

@@ -1,8 +1,8 @@
 ---
 id: "bug-1952"
-status: "investigating"
+status: "fixed"
 status_updated: "2026-10-10"
-status_note: "suspected from source reading; confirm with a test before fixing"
+status_note: ""
 component: "apiserver"
 severity: "security"
 timestamp: "2026-10-10T08:15:16Z"
@@ -11,6 +11,7 @@ occurrences: 1
 files: ["src/frontend/apiserver/controllers/users.go"]
 tags: ["apiserver", "security", "rbac"]
 related: []
+fix_commits: ["a80768f3"]
 ---
 
 # bug-1952: apiserver user role changes check a narrower rbac:control grant only against the target user
@@ -35,15 +36,16 @@ Suspected (needs verification): in add/delete roles for a user, a non-`all` `rba
 - Frequency: deterministic (by code reading; confirmed by the RED test of the fix)
 - Evidence: the code sites quoted in Description; no logs kept.
 ## Root cause
-TODO: required for fixed/partial
+`UserController.AddRolesForUser`/`DeleteRolesForUser` (`controllers/users.go`) only checked whether the target was the caller for a non-`all` `rbac:control` grant; `self` is an accepted rbac scope (`models/roles.go:78`), so a user holding only `rbac:control` scope `self` could grant itself `cluster_admin`.
 
 ## Fix
-TODO: required for fixed/partial
+`canChangeUserRoles`: changing anyone's roles (the caller's included) requires an `rbac:control` grant with scope `all`, checked over all grants before deduplication; anything else gets 403. Follow-up: any `rbac:control` scope can still create roles and add permissions to a role the caller holds (`roles.go`), the same escalation by another route.
 
 ## Verification
-- Test: TODO: name + file; RED before the fix, GREEN after
-- Suites: TODO: suite results and build profile
-- Live: TODO: soak/deploy run, or n/a and why
+- Test: `TestAddRolesForUser_SelfScopeCannotGrantItselfRoles` (`controllers/users_rbac_test.go`): RED `privilege escalation: mallory (rbac:control scope self) granted itself cluster_admin (status 200)`, GREEN after; plus `TestDeleteRolesForUser_SelfScopeRejected`, `TestUserRoleChanges_AllScopeAllowed`.
+- Suites: `xce-build.sh all asan xce.build --incremental` on the merged branch, 2026-10-10: all C suites Ok 155 / Fail 0, frontend Go unit tests ok, xceadmin tests ok; apiserver `CGO_ENABLED=0 go test ./...` (incl. middleware, router, cmd) ok
+- Live: n/a: unit/fixture-level verification only; no live deployment was run (follow-up)
 
 ## References
-- Related: none
+- Fix commit: `a80768f3` (on `scheduler-framework`; worker-branch original in the merge)
+- Review: `.kiro/reviews/project-gap-review-2026-10-10.md`