lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(bug-1731): fire HOOK_DETAIL_JOB_START/JOB_EXIT on WAL apply

Browse source 
apply_committed_entry() (persist.c), the single seam that applies every
committed WAL entry, only ever fired the generic HOOK_DETAIL_JOB_UPDATE
for job-state changes -- HOOK_DETAIL_JOB_START/JOB_EXIT were
permanently dead code, since job.c only ever fires them at
HOOK_BEFORE_EVENT (for WAL-append purposes). This left sched_job_start_
fun/sched_job_exit_fun (sched.c) and apiserver_job_start_fun/
apiserver_job_exit_fun (apiserver.c) unreachable, and the Go apiserver's
already-wired OnJobFinished handler permanently starved of data -- a
finished job's state could stay stuck (e.g. showing RUN) in the
scheduler's own view and the apiserver never learned a job finished.

The wire format was already enriched by bug-1697/bug-1689 with the
pidinfo/exit_info data these hooks need, so this closes the gap rather
than requiring new wire work. WAL_JOB_FINISH now fires
HOOK_DETAIL_JOB_EXIT; WAL_JOB_START now fires HOOK_DETAIL_JOB_START,
gated on a call-scoped decode flag rather than the transition result
(WAL_JOB_START applies as a no-op duplicate for every real job in
production per bug-1697, so gating on the transition result would make
it dead code again). WAL_JOB_FAIL -> HOOK_DETAIL_JOB_FAIL has the same
gap and is left as a follow-up.

Also includes this investigation's supporting changes: a DEBUG3 log-
retention bump (main.c, both controller and scheduler) so race-condition
evidence survives a live burst without rotating out, and DEBUG3-gated
diagnostic trace logging at the two points a job-update notification
can fire or silently drop (job.c, sched.c).

Live-verified end to end on a real deployed cluster: scheduler-side
sched_job_state_change now fires for RUN and EXIT states, and the
apiserver's OnJobFinished -- previously never invoked in production --
now correctly updates job status on completion.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019QxaSzHRB7pmYFp4cVnwkA
This commit is contained in:
Rongsong Shen 2026-08-29 11:29:10 +00:00
parent 42e1eeaa29
commit ebe691c3ed
No known key found for this signature in database
GPG key ID: 5BCDAAE0123E9FE2
9 changed files with 521 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/controller/sched.c
View file

@ -445,10 +445,28 @@ static int sched_job_update_fun(int type, int situation, void* data, va_list ap)
switch (situation) {
case HOOK_AFTER_EVENT:
rc = notify(c, c->sched.ep, &xdata);
/* TEMP diagnostic (bug-1731 job-finish-notify-loss
* investigation): fires for BOTH the deferred-apply source
* (apply_committed_entry(), persist.c) and the live-rusage
* source (update_job_rusages(), job.c) -- both route through
* this one function. jobid+state+rc together distinguish
* which source fired and whether notify() itself reported
* success. DEBUG3-gated -- see bug-1731's own "re-add before
* next occurrence" recommendation; the DEBUG3 log-retention
* bump (bug-1731 support, main.c) exists so this survives a
* live burst without rotating out. */
TRACE("DIAG sched_job_update_fun: jobid=%ld state=0x%x rc=%d",
(long)job->job.jobid, (unsigned)job->job.state, rc);
break;
default:
break;
}
} else {
/* TEMP diagnostic (bug-1731): scheduler disconnected at the exact
* moment this notification was due -- silently dropped today. */
TRACE("DIAG sched_job_update_fun: jobid=%ld state=0x%x -- "
"c->sched.ep is NULL, notify SKIPPED",
(long)job->job.jobid, (unsigned)job->job.state);
}
mylock_unlock(&(c->sched.lock));