chore(wolf): checkpoint buglog.json (964 bugs)

This commit is contained in:
Rongsong Shen 2026-08-18 13:43:20 +00:00
parent 1364664769
commit f348451fbe
Signed by: rshen
SSH key fingerprint: SHA256:8Vf2pZ3h6rJa7EhGK+WaAQ9Mta/apZvteW6g9U/WKKk

View file

@ -17310,6 +17310,26 @@
],
"occurrences": 1,
"last_seen": "2026-08-18T13:00:00Z"
},
{
"id": "bug-1583",
"timestamp": "2026-08-18T13:35:00.000Z",
"error_message": "Live task 8.1 run (resource-value-verification, comprehensive e2e validation): injecting resupdate -n totally-fake-resource-xyz -v 1 (a deliberately-unregistered resource name) alongside 9 genuinely-registered names -- the controller correctly rejects it (resval_typeresolve/update_resval's key_find(c->resmgr,...) returns -ENOENT, never written to w->host.resvals, confirmed empty via a direct resval query) and the scheduler correctly discards it (core_events.c's RESVALS_DELTA handler logs 'xce_core_push_events RESVALS_DELTA: unknown resource totally-fake-resource-xyz, skipping' at WARN and never applies it) -- but the apiserver's OnResourceLocationUpdated (src/frontend/apiserver/backend/handler.go:92) has NO such validation: it logged 'resource-location stored {\"resource\": \"totally-fake-resource-xyz\", \"host\": \"resverify-worker\", \"value\": 1}' and unconditionally called store.ResourceLocations.Put() for it, live-confirmed in apiserver.log.",
"file": "src/frontend/apiserver/backend/handler.go",
"root_cause": "do_update_resvals() (src/controller/opupd.c:10-51) fires XCE_CONTROLLER_HOOK_RESOURCE/HOOK_DETAIL_RESOURCE_UPDATE with the FULL, RAW, UNFILTERED xce_resval_list_t from the client RPC -- BEFORE update_resval_list() runs its own per-item validity check, and the HOOK_AFTER_EVENT fire (the one both sched_resource_hook_fun (sched.c:609-639) and apiserver_resource_hook_fun (apiserver.c:545-581) act on) still passes that same unfiltered list, since update_resval_list() only applies/logs per-item failures internally -- it never mutates or filters the list object itself. So both the scheduler and the apiserver receive a raw push containing EVERY submitted resource name, valid or not, regardless of whether the controller's own update_resval()->key_find(c->resmgr,...) accepted it. The scheduler's core_events.c independently re-validates each pushed name against its own resource table before applying (WARN + skip on unknown) -- but OnResourceLocationUpdated (handler.go:92-115) does zero such validation; it stores whatever ResourceName/Location/value it's handed, unconditionally. This is a genuine 3-way inconsistency: controller rejects+never-stores, scheduler rejects+discards+logs, apiserver silently accepts+stores forever.",
"fix": "NOT FIXED -- discovered incidentally during resource-value-verification task 8.1's comprehensive live e2e validation run (deliberately injecting one unregistered resource name alongside the default 9-resource set to prove the run-level FAIL path). Explicitly out of task 8.1's boundary (validation-only, no code changes) and out of the resource-value-verification feature's boundary generally (design.md 'Out of Boundary' section explicitly excludes 'the controller's resval-forwarding hooks' and scopes handler.go's own change to exactly one logger.Debug() call after the pre-existing store.ResourceLocations.Put() -- the Put() call and its lack of validation both predate this feature). A real fix would add a registered-resource-name check to OnResourceLocationUpdated (or, more centrally, filter the notify() payload in do_update_resvals()/sched_resource_hook_fun/apiserver_resource_hook_fun to only include items update_resval_list() actually accepted) before persisting to store.ResourceLocations -- worth a dedicated follow-up task, does not block resource-value-verification's own completion (the skill's own verdict logic already correctly ignores/skip-checks rejected names via injection-results.tsv's accept/reject accounting, so this apiserver-side phantom-store gap does not affect task 8.1's or 7.1's PASS/FAIL correctness).",
"tags": [
"apiserver",
"resval",
"validation-gap",
"data-integrity",
"resource-value-verification",
"handler.go",
"OnResourceLocationUpdated"
],
"related_bugs": [],
"occurrences": 1,
"last_seen": "2026-08-18T13:35:00.000Z"
}
]
}