lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(scheduler): drop parjob's unused skip_bad_worker_

Browse source 
Cause: parjob's allocation now draws candidate hosts from the shared
sched_host_iter_next() (host_iter.c) instead of its own
sched_collect_workers() loop, so skip_bad_worker_ lost its only caller
(the compiler warns it is unused). seqjob's copy was already removed when
it moved onto the shared iterators (b18c5f78).

Fix: remove it. Its only check (a NULL worker) is done by
sched_host_iter_next(), which is also where host filtering now lives
(closed hosts, bug-1939; unavailable and reconciling hosts, bug-1963).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Rongsong Shen 2026-10-10 10:29:06 +00:00
parent 3224e90683
commit f389845701
Signed by untrusted user: rshen
GPG key ID: 80533536B0EB651C
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/scheduler/src/plugins/parjob_allocator.c
View file

@ -37,16 +37,6 @@ static void parjob_allocator_fini(xce_sched_plugin_t* plugin)
FREEUP(plugin);
}
static int skip_bad_worker_(xce_sched_worker_t* w)
{
if (w == NULL) {
return 1;
}
/* add more check here */
return 0;
}
/*
* parjob_prepare_allocation - task 4.2 (Req 4 AC 5/AC 6): populates
* ctx->alloc_req.host/ctx->alloc_req.shared for whichever bucket/host is