lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(raft-adapter-conformance): route post-connect vote/PreVote failures to production tally

Browse source 
Splits vote_ep_err_handler into a real-vote handler and a new
pre_vote_ep_err_handler, each registered at its existing (already
separate) connection-setup call site. Extracts the identical
CTRL_PRIMARY-role cleanup into a shared vote_ep_handle_promoted_disconnect
helper, behavior unchanged.

Each handler's election-phase branch now routes a post-connect failure
(RDHUP/SSL-error/remote-close after connect, before any reply) through
the same production tally the connect-time failure branches already
use (vote_reply_dispatch / pre_vote_reply_dispatch, bug-1423/1424's
fix), instead of the legacy handle_request_vote_reply that never
updated the tally. Closes the one failure window bug-1423 didn't cover.

1060 -> 1061 tests, 0 failures. PreVote-specific test coverage is
task 3.2's scope (pre_vote_reply_dispatch has no hook seam analogous
to xce_vote_reply_hook; verified only by code symmetry + full-suite
regression here).
This commit is contained in:
Rongsong Shen 2026-07-29 13:53:25 +00:00
parent 65afa04aaf
commit fce73b5b58
3 changed files with 160 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.kiro/specs/raft-adapter-conformance/tasks.md
View file

@ -32,7 +32,7 @@
- _Depends: 2.1, 2.2_
- [ ] 3. Core: vote and pre-vote endpoint failure routing
- [ ] 3.1 (P) Split the shared vote-endpoint error handler and route post-connect failures to the production tally
- [x] 3.1 (P) Split the shared vote-endpoint error handler and route post-connect failures to the production tally
- Split `vote_ep_err_handler` into a real-vote handler (registered at its existing connection-setup call site) and a `pre_vote_ep_err_handler` (registered at its existing, separate PreVote connection-setup call site)
- Extract the identical `CTRL_PRIMARY`-role cleanup branch (standby-endpoint deregistration, `repl_remove_standby`, quorum-transition logging) into one shared helper called by both, unchanged in behavior
- Change each handler's election-phase branch to route a post-connect failure through the same production tally path already used for connect-time failures (`vote_reply_dispatch` for the real-vote handler, `pre_vote_reply_dispatch` for the pre-vote handler) instead of the legacy `handle_request_vote_reply`