test(scheduler-sim-reconcile-terminal-guard): task 1.1 - RED tests for terminal guard
Adds two failing tests formalizing bug-1764's reproduction: a job driven to JOB_STAT_DONE (and, separately, JOB_STAT_EXIT) via a real xce_core_push_events() JOB_STATE_CHANGE call correctly has its allocs/accounts nulled by the existing end-of-life cleanup, but sim_reconcile_unaccounted_jobs() then wrongly resurrects both fields when presented with a stray DISPATCH entry for that same jobid, since its trigger checks only job->accounts == NULL with no state check. The pre-existing eager-capture regression test, test_reconcile_captures_non_run_state_job_when_dispatch_recorded, already covers Requirement 1.2's "PEND job's early DISPATCH still captured" case explicitly and needed no duplicate. No production code touched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YAWMhfRJFnmmnG8h97yUDd
This commit is contained in:
parent
f854d9facd
commit
ff05c37bca
2 changed files with 192 additions and 2 deletions
|
|
@ -1,7 +1,7 @@
|
|||
# Implementation Plan
|
||||
|
||||
- [ ] 1. Core: terminal-state guard on job reconciliation
|
||||
- [ ] 1.1 Write failing tests for the terminal-state guard
|
||||
- [x] 1.1 Write failing tests for the terminal-state guard
|
||||
- Cover: a job driven to JOB_STAT_DONE via xce_core_push_events() (confirming allocs/accounts are nulled by the existing cleanup), then presented with a decoded_session carrying a DISPATCH entry for that job id, must leave allocs/accounts NULL after sim_reconcile_unaccounted_jobs() runs; the same scenario with JOB_STAT_EXIT instead of JOB_STAT_DONE; a PEND job's early-recorded DISPATCH entry is still captured exactly as today (explicit regression guard, not just relying on the pre-existing suite)
|
||||
- Observable: the new test cases for DONE/EXIT fail against today's sim_reconcile_unaccounted_jobs(), which resurrects allocs/accounts on any job with accounts == NULL regardless of state
|
||||
- _Requirements: 1.1, 1.2, 1.3_
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue