lei.chen/myxce
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(skills): note join's corrected maxmem default at bare-join call sites

Browse source 
Non-functional: a repo-wide audit of every xce_test consumer against the
xce-test-cli-ux spec's completed changes (confirmation prompts, joblist/
reslist format fixes, stream routing, join's maxmem default, qctrl/getconf
fixes) found zero functional breaks -- every script drives xce_test via
piped non-interactive stdin (Req 9.4 auto-skips confirmation prompts) and
either checks exit codes/structured markers or already redirects 2>&1.

Add a one-line comment at each of the three bare `join` (no -m) call
sites noting the default changed from a stale 64 bytes to the correct
64MB (bug-1557), for future-reader clarity -- harmless in all three since
none of these synthetic hosts are ever scheduled against.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019jaMf9QEwpugH2W9KAuc7f
This commit is contained in:
Rongsong Shen 2026-09-10 10:01:02 +00:00
parent a83d7087f2
commit ffca959ed9
No known key found for this signature in database
GPG key ID: 5BCDAAE0123E9FE2
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
.claude/skills/xce-test-ha/run-ha-soak.sh
View file

@ -1530,6 +1530,10 @@ run_config_upgrade_round() {
# Context note).
log "config-upgrade: joining synthetic host $host"
local jout
# bare `join` (no -m) picks up xce_test's default maxmem, corrected by
# bug-1557 (xce-test-cli-ux spec) from a stale 64 bytes to 64MB -- harmless
# here since this host is only used for hostctrl/admin-status checks below,
# never scheduled against.
jout="$(printf 'set masters %s\nset myname %s\nworker\njoin\nquit\n' "$MASTERS" "$host" | xtest)"
echo "$jout" | grep -q "host join ok" \
|| fail "config-upgrade: synthetic host $host failed to join: $jout"
@ -2508,7 +2512,9 @@ run_array_soak_round() {
# Completion: jstart + jfinish — the same wire-level worker-fact
# primitives --factstream already uses (job.c's on_job_start/
# on_job_finish require only that the job exists in jobmgr, not a real
# scheduler/worker handshake).
# scheduler/worker handshake). Bare `join` (no -m) again picks up the
# corrected 64MB default (bug-1557, xce-test-cli-ux spec) -- harmless,
# this host is never scheduled against.
out_complete="$(printf 'set masters %s\nset myname arraysoak\nworker\njoin\njstart -j %s\njfinish -j %s -c 0\nquit\n' \
"$MASTERS" "$id_complete" "$id_complete" | xtest)"
[ "$(printf '%s\n' "$out_complete" | grep -c "^ok$")" -eq 2 ] \

4
.claude/skills/xce-test-resources/run-resource-verify.sh
View file

@ -522,6 +522,10 @@ inject_resources() {
done
local script
# bare `join` (no -m) picks up xce_test's default maxmem, corrected by
# bug-1557 (xce-test-cli-ux spec) from a stale 64 bytes to 64MB -- harmless
# here since resupdate below overwrites every resource value this script
# actually cares about.
script="$(printf 'set masters %s\nset myname %s\nworker\njoin\nresupdate%s\n!%s\nquit\n' \
"$PEERS" "$WORKER_HOST" "$resupdate_line" "$ctrl_check_cmd")"