Commit graph

2 commits

Author SHA1 Message Date
a81f2a249c fix(controller-tests): make Unity test-file attribution and counters consistent suite-wide
Only 21 of 86 test_*.c group functions called their own nested
UNITY_BEGIN()/UNITY_END(). Each nested call reset Unity's global
NumberOfTests/TestFailures counters, so controller_test.c's final
`return UNITY_END();` -- the value meson test actually gates on --
only ever reflected whichever small window of tests ran since the
LAST nested reset, silently discarding pass/fail evidence for
everything before it (measured: 16 of 972 total tests in one run).
The same nested-BEGIN calls also caused PASS/FAIL banners to show
the wrong source file for tests in files that don't reset it
themselves (Unity.TestFile just carries over from whichever group
last called UNITY_BEGIN()).

Fix: replace every nested UNITY_BEGIN() with UnitySetTestFile(__FILE__)
(sets file attribution only, no counter reset) and drop the matching
UNITY_END(); add the same UnitySetTestFile(__FILE__) as the first
statement to the other group functions that had neither. The 2
genuinely standalone binaries (test_job_array_sched_push.c,
test_job_array_apiserver_push.c -- each has its own int main(), not
registered via controller_test.c's TEST() macro) are untouched.

Verified: single consolidated summary now reads
"972 Tests 0 Failures 0 Ignored OK", exactly matching the
ground-truth RUN_TEST call-site count across all 83 registered
group files (976 total minus 4 belonging to the 2 standalone
binaries). Every PASS/FAIL banner now names its own true source
file. Full xce-build.sh all regression pass clean (Ok: 9, Fail: 0).

No production code touched -- test-harness plumbing only.
2026-07-17 14:49:12 +00:00
837c35c255 test(raft-drive-async): network-partition soak primitive + RED/GREEN scenario (task 4.1)
Add in-process partition blackhole primitive (no privilege required):
- Evict partitioned peer from standby_endpoints so reconnect fires
- RED mode: reconnect connect parks in gate → blocks delaymgr tick
  (proves pre-change build heartbeat stalls on unreachable peer)
- GREEN mode: real offload path runs → slowlane_submit non-blocking
  → tick returns promptly → survivor heartbeats continue every tick
- Heal: re-add peer, both standbys receive heartbeats post-heal

Requirements: 7.1, 7.2, 7.3, 7.4
Boundary: PartitionTest

Co-Authored-By: Claude <noreply@anthropic.com>
2026-06-29 04:37:20 +00:00