--- id: "bug-1621" status: "fixed" status_updated: "2026-09-24" status_note: "" component: "lib" severity: "leak" timestamp: "2026-08-22T08:12:00Z" last_seen: "2026-09-19T09:00:00Z" occurrences: 1 files: ["src/lib/misc.c (free_host_account)"] tags: ["memory-leak", "asan", "leaksanitizer", "free_host_account", "xcealloc", "scheduler", "resource-accounting", "scheduler-sim-decision-parity", "pre-existing", "out-of-scope"] related: ["bug-1723"] legacy: true --- # bug-1621: LeakSanitizer (run with ASAN_OPTIONS=detect_leaks=1, overriding this test suite's own… ## Description LeakSanitizer (run with ASAN_OPTIONS=detect_leaks=1, overriding this test suite's own detect_leaks=0 convention): 'Direct leak of 8 byte(s) ... #1 make_host_account ../lib/xcealloc.c:119 #2 make_job_account ../lib/xcealloc.c:188' -- an xce_host_account_t's `host` field (strdup'd in make_host_account(), src/lib/xcealloc.c:119) is never freed. ## Environment _Not recorded (migrated from buglog.json)._ ## Reproduction _Not recorded (migrated from buglog.json)._ ## Root cause free_host_account() (src/lib/misc.c) frees acct->accounts[] (each via free_res_account()) and then FREEUP(acct) itself, but never FREEUP(acct->host) -- the strdup'd host string make_host_account() (src/lib/xcealloc.c:119, `haccount->host = strdup(halloc->host);`) allocates. Pre-existing, NOT introduced by scheduler-sim-decision-parity task 2.3: confirmed by tracing the leak's allocation stack, which bottoms out in make_job_account()/make_host_account() (xcealloc.c) -- the exact same tree-building code the LIVE dispatch path already uses (scheduler.c's sched_commit_decision() -> make_job_account()), so this leak equally exists on the live, production dispatch path today, just previously undetected because src/scheduler/testsuite/meson.build runs this whole suite with ASAN_OPTIONS=detect_leaks=0 (fixtures are deliberately not torn down in this test family, per test file header conventions -- masks this along with every other intentional fixture leak). ## Fix FIXED (2026-09-08, follow-up session). Applied exactly the fix this entry already recommended: added FREEUP(acct->host); to free_host_account() (src/lib/misc.c), immediately before FREEUP(acct) -- mirrors free_res_account()'s existing FREEUP(acct->resname) pattern in the same file. Discovered as the remaining residual leak while fixing bug-1723's test-cleanup gaps: after adding the missing free_JobAlloc_ptr()/free_HostAlloc_list() calls those two tests needed, xcelib_test still leaked 12 bytes/2 allocations (exactly 2x "host0"/"host1", 6 bytes each) at make_host_account (xcealloc.c:119) via make_job_account -- this exact function/line. Since free_host_account() is called from free_job_account(), which real production dispatch code uses (scheduler.c, core_events.c), this fix has genuine production value, not just test-cleanliness. Verified: xcelib_test now 1/1 Ok with zero LeakSanitizer reports; full xce-build.sh all asan --incremental: 94/94 Ok, zero regressions. ## Verification _Not recorded (migrated from buglog.json)._ ## References - Related: bug-1723