No description
Rongsong Shen
0e96a69f7d
The oldest unresolved bug in this project's tracker (first sighted 2026-06-20): controller_unit_test intermittently hung for the full 300s meson timeout with no crash/ASAN report, never previously caught live under gdb. Live-reproduced this session (first attempt): thread 1 stuck forever in commit_engine_fini() -> pthread_cond_destroy() (test_commit_barrier_ rollout.c's jap_teardown), while two fsync_worker threads sat parked in pthread_cond_timedwait on the same persist_t. Root cause: several test teardown functions called commit_engine_fini() BEFORE persist_stop() -- the exact opposite of commit_engine_fini()'s own documented contract. This let the live background fsync_worker thread call back into commit_on_durable_advance() while commit_engine_fini() was mid-destroy of the engine's lock/condvar -- a genuine TOCTOU race with no synchronization between the two threads. This is the same race already root-caused once for a SEGV symptom in bug-1452 (2026-07-19, test_persist_truncate.c) and partially re-fixed in bug-1687 (2026-08-25, cbrp_teardown) -- but never swept across all affected files. Bug-1452's own remediation note explicitly flagged test_demotion_convergence.c as a known, unfixed instance; that flag went unactioned until now. Fix: insert persist_stop() immediately before commit_engine_fini() at 21 confirmed-vulnerable sites across 12 files (test_apply_pump.c, test_apply_pump_integration.c, test_commit_barrier_rollout.c, test_commit_durability.c, test_commit_engine.c, test_convergence_verification.c, test_demotion_convergence.c, test_egress_filter.c, test_ha_role_lifecycle.c, test_job_array_fence.c, test_job_array_replay_fence.c, test_p2_integration.c) -- the same pattern bug-1452/1687 already established. persist_stop() is idempotent (guarded by an atomic "already running" check), so each fixture's own pre-existing persist_stop() call becomes a safe no-op. No production code changed. Known remaining exposure, documented but not fixed this session: test_config_repl.c (~23 sites) and test_term_safety_adapter.c (~5 sites) have the same ordering bug in their own teardown helpers, flagged as follow-up. Verified: full controller suite run 4 times total (once as part of the fix, three further independent sequential runs) -- Ok:6 Fail:0 every time, 38-42s wall clock each run, no hang, nowhere near the 300s timeout. 1220/1220 individual controller_unit_test cases pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QxaSzHRB7pmYFp4cVnwkA |
||
|---|---|---|
| .claude | ||
| .kiro | ||
| .wolf | ||
| docs/superpowers/plans | ||
| raft | ||
| reports | ||
| scripts | ||
| src | ||
| .clang-format | ||
| .gitignore | ||
| .mcp.json | ||
| .opencode.json | ||
| CHANGES.md | ||
| CLAUDE.md | ||
| README.md | ||
1. commit 规则
- 每个人 fork 自己的 branch， 从自己的 branch 做 PR，review 完再 commit
2. code format
2.1. C
推荐使用 clang-format，公共配置放在源码里面 xce/.clang-format
（理论上直接使用源码里面 xce/.clang-format 文件格式不会变）
2.1.1. vscode 可以在配置中加上如下内容
"C_Cpp.clang_format_style": "WebKit",
"C_Cpp.clang_format_fallbackStyle": "WebKit",
2.1.2. vim & emacs
clang-format -style="{BasedOnStyle: webkit}" -i XX.c
2.2. golang
使用默认 gofmt
3. build environment and build (example of ubuntu)
3.1 build environment
- Install nix package management tool
sh <(curl -L https://nixos.org/nix/install) --daemon
- Edit /etc/nix/nix.conf to make sure
experimental-features = nix-command flakes
sandbox = true
sandbox-fallback = false
substituters = https://mirrors.ustc.edu.cn/nix-channels/store https://cache.nixos.org https://cache.nixos.org/
trusted-users = root <your account>
make sure that you have restarted nix-daemon service after you have changed /etc/nix/nix.conf
- Install socat and config ssh (for clone by ssh protocol)
nix profile add nixpkgs#socat
.ssh/config
Host gitea.shenrs.eu
HostName gitea.shenrs.eu
IdentityFile ~/.ssh/id_ed25519
ProxyCommand socat - openssl-connect:gitea.shenrs.eu:2022,snihost=gitea.shenrs.eu,verify=0
3.2 checkout source code
3.3 build (for package and release)
cd xce/src
# for build debug version
nix build --option sandbox false .#xcecore_debug
# for normal build
nix build --option sandbox false .#xcecore
You can find the generated binaries at =result= directory
3.4 build (for daily develop)
cd xce/src
nix develop
# using meson to generated build configuration (debug and address sanitize)
meson setup build --buildtype=debug -Db_sanitize=address
# run meson to build
meson compile -C build
# The generated files will be in build/
3.5 build AppImage package
cd xce/src
nix bundle --bundler github:ralismark/nix-appimage --option sandbox false .#xce
This will create all in one AppImage file which contains everything for package delivery.
4. misc
4.1. Windows remap ctrl and alt key
create a reg file, e.g. remapkey.reg
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Keyboard Layout]
"Scancode Map"=hex:00,00,00,00,00,00,00,00,05,00,00,00,38,00,1d,00,1d,00,38,00,38,e0,1d,e0,1d,e0,38,e0,00,00,00,00
then double click remapkey.reg to import it. Restart OS.