myxce/src/scheduler/testsuite/test_repl_event_echo.c
Rongsong Shen 94115b0024
fix(scheduler): sim mode force-dispatched recorded decisions past live capacity (bug-1836, bug-1838)
User-reported: replaying a captured session dispatched 44 single-slot jobs
onto a 22-slot host. Root cause traced through two layers:

- bug-1836: sim_reconcile_unaccounted_jobs() (the "Recorded-Decision
  Reconciliation" backstop) force-applied any recorded DISPATCH decision
  it found, with zero live capacity check. Added
  sim_reconciled_alloc_fits_capacity(), reusing the same
  sched_check_host_satisfy()/sched_check_shared_satisfy() admission checks
  the live picker/allocator path already uses.

- bug-1838: even with that gate, reconciliation still preempted every
  freshly-PEND job before the live picker/allocator got a turn each round
  -- unnecessary now that scheduler-sim-live-allocation gave sim mode the
  same real, capacity-checked picker/allocator threads normal mode uses.
  Narrowed reconciliation's trigger back to JOB_IS_RUN-only (undoing a
  2026-09-11 widening whose own justification no longer holds), so a
  freshly-pushed job now always flows through the same live, verified
  decision path as normal mode. Reconciliation now only ever fires for a
  job already RUN from before the replay's own observation window --
  the one case structurally invisible to the live picker.

Also logged (bug-1837, not fixed here, needs its own design decision):
sim_reconcile_unaccounted_jobs() calls a picker's on_dispatch() hook from
the driver thread instead of the allocator thread plugin.h documents it
belonging to -- currently inert since the only real picker plugin happens
to lock internally, but not contract-safe for a future lock-free one.

Fixing bug-1838 required re-examining every test exercising the old
PEND-inclusive trigger; several needed their fixtures corrected to
register a real worker (harmless before any capacity check existed), and
others needed their actual intent re-derived and their assertions
inverted or restated now that a PEND job is never eligible for
reconciliation. Dated correction notes added in place to the
scheduler-sim-eager-reconciliation spec, matching its own existing
2026-09-11 correction-note precedent.

Verified: full scheduler suite 85/85, independently re-confirmed by
running the four most affected binaries directly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-21 09:50:27 +00:00

937 lines
36 KiB
C

/*
* test_repl_event_echo.c - contract test for the interactive simulation
* REPL's Event Echo Gate component (scheduler-sim-repl-verbosity spec, task
* 3.1, Requirements 1 and 3.5/3.6): mode-aware suppression of routine
* per-event chatter during `continue`, and ending an active Round Rollup
* collapsed range before a structural event's own line or a breakpoint
* interruption is shown.
*
* Split into its own file rather than appended to
* test_repl_execution_control.c -- see design.md's own
* "**Correction (post-review, task 3.1)**" note in its "New/Modified Test
* Files" section: that file was already 937 lines (over this project's
* 800-line cap) before this feature began, and landing this task's four
* behavioral cases there per the original plan would have pushed it well
* past 1300 lines -- the same reasoning that already split Round Rollup's
* own tests into test_repl_round_rollup.c (task 2.1). Following that same
* established convention, this file duplicates (rather than shares via a
* new header) whatever pre-existing static fixture helpers it needs from
* test_repl_execution_control.c/test_repl_round_rollup.c.
*
* Fixture strategy and white-box #include set: identical to
* test_repl_round_rollup.c/test_repl_execution_control.c (see those files'
* own header comments) -- this file exercises the same real
* sched_sim_driver_run() end-to-end, forked-child, real-stdout-capture
* technique.
*
* bug-1595 jobid-safety discipline: NONE of this file's fixtures push,
* mutate, or reference any job or jobid at all. Every event used below
* (QUEUE_UPDATE, WORKERS_PUSH) is deliberately job-free, so the specific
* "a filler event's jobid accidentally mutates the real job under test"
* failure mode bug-1595 logged has no surface to occur on here at all --
* a stronger guarantee than merely using a distinct filler jobid.
*
* THIS TASK (3.1) IS RED-PHASE ONLY: the classification/range-ending
* behavior under test does not exist yet in xce_repl_on_event() (repl_break.c)
* today -- that unconditionally echoes every event before its breakpoint
* check (bug-1595's own fix), with no reference to sim->repl_state->mode and
* no call to repl_round_collapse_flush() anywhere in repl_break.c (task 3.2,
* a separate later task, adds both). Unlike test_repl_round_rollup.c's own
* RED-phase story (which referenced a not-yet-defined extern to force a
* link-time failure), every symbol this file references already exists
* today (repl_round_collapse_flush() was implemented by task 2.2) -- so
* every test below builds and links cleanly today but FAILS ITS OWN RUNTIME
* ASSERTIONS, because today's REPL echoes unconditionally in both modes and
* never calls repl_round_collapse_flush() from repl_break.c at all. Verified
* concretely (not assumed) against a real incremental build before this
* task was reported done -- see this task's own Status Report.
*
* Assumed output contract this file pins (matches design.md's Event Echo
* Gate component and test_repl_round_rollup.c's own "Assumed output
* contract" precedent):
* - Routine events (RESVALS_DELTA, JOB_STATE_CHANGE, JOB_UPDATE,
* QUEUE_UPDATE, JOB_RUSAGE) print their existing "[sim] event: <TYPE>
* ..." line (repl_print_event_summary(), repl_break.c) ONLY while
* sim->repl_state->mode == XCE_REPL_MODE_STEP; under
* XCE_REPL_MODE_CONTINUE that line must not appear at all.
* - Structural events (CONFIG_PUSH, JOBS_PUSH, WORKERS_PUSH,
* RESOURCES_PUSH, RESVALS_FULL) print that line in EVERY mode, and --
* before printing it -- the Event Echo Gate calls
* repl_round_collapse_flush() so any active Round Rollup collapsed
* range is closed and printed first (Requirement 3.5).
* - A breakpoint match (checked on every event, any classification) still
* interrupts continue-mode execution and prints "[sim] hit breakpoint
* ..." (repl_break.c's existing format), and -- before that line --
* also calls repl_round_collapse_flush() first (Requirement 3.6).
* - Tests use strstr()/pointer-order comparisons on captured real stdout,
* the same technique test_repl_round_rollup.c's own tests establish.
*/
#include <errno.h>
#include <limits.h>
#include <stdatomic.h>
#include <stdbool.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/wait.h>
#include <unistd.h>
#include <unity/unity.h>
#include "controller.capnp.h"
#include "kvmgr.h"
#include "scheduler.h"
#include "xstring.h"
/* Pull in the real functions under test into this TU (white-box #include,
* same convention as test_repl_round_rollup.c/test_repl_execution_control.c/
* test_repl_breakpoints_inspection.c). */
#include "../src/core.c"
#include "../src/core_clock.c"
#include "../src/core_events.c"
#include "../src/core_session.c"
#include "../src/decision.c"
#include "../src/plugin.c"
#include "../src/plugins/builtin_fcfs.c"
#include "../src/recording.c"
#include "../src/recording_session.c"
#include "../src/repl.c"
#include "../src/repl_fmt.c"
#include "../src/repl_rollup.c"
#include "../src/repl_break.c"
#include "../src/repl_info.c"
#include "../src/repl_params.c"
#include "../src/sim.c"
#include "../src/sim_loop.c"
#include "../src/sim_picker.c" /* bug-1567: sched_sim_driver_run() now calls sim_bootstrap_picker() (sim_loop.c-cap sibling) as an extern -- undefined reference at link time otherwise */
#include "../src/sim_limit.c" /* bug-1825: sched_sim_driver_run() now also calls sim_bootstrap_limit_plugin() (sim_loop.c-cap sibling, sim_picker.c's own bug-1567 precedent) as an extern -- undefined reference at link time otherwise */
#include "../src/sim_record.c"
#include "../src/sim_verify.c"
#include "../src/snapshot.c"
#include "../src/snapshot_load.c"
#include "../src/snapshot_wire.c"
void kill_sched_job(void* arg) { (void)arg; }
void kill_sched_queue(void* arg) { (void)arg; }
void kill_sched_worker(void* arg) { (void)arg; }
void kill_sched_user(void* arg) { (void)arg; }
void kill_sched_project(void* arg) { (void)arg; }
void kill_sched_resval(xce_val_t* val) { (void)val; }
/* repl_info.c (scheduler-sim-diagnostics spec, task 2.1) now calls
* limit_get_configured_limits() (plugins/limit.c, not part of this TU) to
* resolve `info limit`'s name/all argument -- link-satisfying stub only,
* same rationale as kill_sched_job()/kill_sched_resval() above; this
* file's own fixtures never register the limit plugin, so NULL
* (limit_get_configured_limits()'s own documented "plugin absent" return)
* is also the behaviorally correct answer here, not just a link
* placeholder. repl_info_limit() itself is not yet wired into
* repl_cmd_info() (task 4), so no test in this file can reach it anyway. */
var limit_get_configured_limits(xce_sched_core_t* core)
{
(void)core;
return NULL;
}
/* scheduler-sim-diagnostics spec, task 3.1: repl_info.c now also calls
* limit_get_usage_instances() (plugins/limit.c, not part of this TU) to
* read a limit's live usage instances -- identical link-satisfying stub,
* same rationale as limit_get_configured_limits() immediately above; this
* file's own fixtures never register the limit plugin, so NULL
* (limit_get_usage_instances()'s own documented "plugin absent" return) is
* also the behaviorally correct answer here, not just a link placeholder. */
var limit_get_usage_instances(xce_sched_core_t* core)
{
(void)core;
return NULL;
}
/* scheduler-sim-diagnostics spec, task 6 (bug-1825): sim_loop.c's
* sched_sim_driver_run() now also calls sim_bootstrap_limit_plugin()
* (sim_limit.c, pulled into this TU via the #include above), which in
* turn calls limit_new_plugin() (plugins/limit.c, not part of this TU) --
* identical link-satisfying stub rationale as limit_get_configured_
* limits()/limit_get_usage_instances() immediately above. Returning NULL
* here is also the behaviorally correct answer, not just a link
* placeholder: sim_bootstrap_limit_plugin() already handles a NULL
* limit_new_plugin() return gracefully (logs an ERROR, registers nothing,
* returns) -- the exact same "out of memory" path sim_bootstrap_picker()
* (sim_picker.c) takes for a NULL builtin_fcfs_new_plugin() -- so this
* file's fixtures simply end up with no limit plugin registered, same
* observable state as before this task. */
xce_sched_plugin_t* limit_new_plugin(void)
{
return NULL;
}
/* limit_seed_config() (plugins/limit.c, not part of this TU) -- bug-1825
* remediation round 2's new honestly-typed config-seed entry point.
* sim_bootstrap_limit_plugin() (sim_limit.c) only calls it after
* plugin_register_core() has already succeeded against a real, non-NULL
* limit_new_plugin() plugin -- unreachable in this file since the
* limit_new_plugin() stub immediately above always returns NULL, but the
* symbol must still resolve at link time. Same link-satisfying-stub
* rationale as limit_new_plugin() immediately above. */
int limit_seed_config(xce_sched_plugin_t* plugin, xce_sched_core_t* core,
xce_conf4sched_t* config)
{
(void)plugin;
(void)core;
(void)config;
return 0;
}
/* resource-accounting.md's reconciliation (resource.c, not linked here --
* this file only #includes core_events.c). core_events.c's
* XCE_CORE_EVENT_JOB_RUSAGE handler calls this whenever job->accounts !=
* NULL; link-satisfying stub only, same rationale as every other stub in
* this block (see test_job_update.c's identical stub). */
int sched_reconcile_job_resource_usage(xce_sched_core_t* c,
xce_job_account_t* a,
xce_job_rusages_t* r)
{
(void)c; (void)a; (void)r; return 0;
}
void sched_worker_release_host_ctx(xce_sched_worker_t* w) { (void)w; }
int sched_fill_limit_requests(xce_sched_alloc_req_t* alloc_req,
xlist_t* limits, xlist_t* rusages, int nhosts,
int nslots)
{
(void)alloc_req;
(void)limits;
(void)rusages;
(void)nhosts;
(void)nslots;
return 0;
}
/* sched_sim_driver_run()'s (sim_loop.c, scheduler-sim-decision-parity task
* 2.1) new round-boundary call to the relocated sched_account_jobs()
* (core.h) -- a no-op stand-in here since this file does not link
* scheduler.c/resource.c, same rationale test_sim_equivalence.c's own copy
* documents. */
int sched_account_jobs(xce_sched_core_t* core)
{
(void)core;
return 0;
}
/* bug-1836 (scheduler-driver-equivalence fix, Recorded-Decision
* Reconciliation capacity gate): link-satisfying stubs, mirroring this
* file's existing sched_account_jobs() no-op precedent immediately above --
* sim_loop.c's sim_reconcile_unaccounted_jobs() now also calls
* sched_check_host_satisfy()/sched_check_shared_satisfy() (resource.c) to
* re-validate a recorded decision against live capacity, and
* sched_charge_account() (resource.c) to keep that check's own view of
* capacity up to date across multiple candidates in the same round. This
* file never exercises real resource contention (same rationale as the
* existing sched_account_jobs()/sched_ctx_get_uncomit_host() no-ops), so
* the satisfy checks trivially always succeed and the charge call is a
* no-op. */
int sched_check_host_satisfy(xce_sched_core_t* core, xce_sched_worker_t* w,
xvec_t* uncomitted, xvec_idval_t* wanted,
xvec_idval_t* unmeet)
{
(void)core;
(void)w;
(void)uncomitted;
(void)wanted;
(void)unmeet;
return 1;
}
int sched_check_shared_satisfy(xce_sched_core_t* core, xvec_t* uncomitted,
xvec_idval_t* wanted, xvec_idval_t* unmeet)
{
(void)core;
(void)uncomitted;
(void)wanted;
(void)unmeet;
return 1;
}
int sched_charge_account(xce_sched_core_t* core, xce_job_account_t* acct)
{
(void)core;
(void)acct;
return 0;
}
int sched_uncharge_account(xce_sched_core_t* core, xce_job_account_t* acct)
{
(void)core;
(void)acct;
return 0;
}
/* Real reimplementation of schedobj.c's sched_resolve_job_picker -- same
* copy test_sim_alt_events.c/test_sim_verify.c/test_sim_event_loop.c/
* test_repl_execution_control.c/test_repl_round_rollup.c each carry
* (schedobj.c is not linked here: it would need plugin_register(), which
* requires a genuine xce_scheduler_t* neither this file's fixtures nor
* sim_loop.c's own core-scoped registration path have, Req 5 AC 17). */
int sched_resolve_job_picker(xce_sched_core_t* core, xce_sched_plugin_t** out)
{
xce_sched_plugin_t* plugin = NULL;
int rc = 0;
if ((core == NULL) || (out == NULL)) {
return -EINVAL;
}
*out = NULL;
if (core->job_pick_plugin == NULL) {
return -EINVAL;
}
lock(core->plugins, RTTI_LOCK_READ);
rc = key_find(core->plugins, core->job_pick_plugin, (void**)&plugin);
unlock(core->plugins);
if (rc <= 0) {
return (rc < 0) ? rc : -ENOENT;
}
if ((plugin == NULL) || (plugin->picker_iface == NULL)
|| (plugin->picker_iface->next_job == NULL)
|| (plugin->picker_iface->begin_session == NULL)
|| (plugin->picker_iface->end_session == NULL)
|| (plugin->picker_iface->on_dispatch == NULL)
|| (plugin->picker_iface->on_pend == NULL)) {
return -EINVAL;
}
*out = plugin;
return 0;
}
/* scheduler-sim-live-allocation spec, task 4.1: sim_loop.c's real
* sched_sim_driver_run() (white-box #include'd into this TU above) now
* spawns sched_job_picker()/sched_allocator() (sched_election.c) directly
* instead of its own, now-removed sim_picker_thread_fn() -- an undefined
* reference at link time in this white-box TU otherwise, since
* sched_election.c's own sched_allocator() calls the REAL
* sched_make_allocation()/sched_commit_decision() (scheduler.c), neither
* part of this file's own hand-picked white-box #include set (this file's
* own header comment lists that set). This file's own test(s) do not
* exercise genuine resource-matching allocation, so this link-satisfying
* pair faithfully reproduces the exact PEND-only contract the REMOVED
* sim_picker_thread_fn() itself used to provide -- split across the SAME
* two-thread jbuf hand-off the real production pair now uses (one
* producer, one consumer, matching the project's jbuf capacity-1
* rendezvous invariant) instead of the old single fused thread -- so this
* file's own existing assertions are unaffected by this task's production
* change. Genuine resource-based dispatch through the real, unmodified
* sched_job_picker()/sched_allocator() pair is proved separately by
* test_sim_live_allocation.c (task 4.1's own dedicated fixture, which
* links the real scheduler_srcs instead of white-boxing individual files,
* precisely so it can reach the real allocation chain this stub
* deliberately does not). */
void* sched_job_picker(void* arg)
{
xce_sched_core_t* core = (xce_sched_core_t*)arg;
xce_sched_plugin_t* picker = NULL;
for (;;) {
int go = 0;
uint64_t jobid = 0;
cbuf_get(&(core->wbuf), &go);
if (sched_resolve_job_picker(core, &picker) < 0) {
jobid = 0;
cbuf_put(&(core->jbuf), &jobid);
continue;
}
picker->picker_iface->begin_session(picker);
for (;;) {
xce_sched_job_t* job = picker->picker_iface->next_job(picker);
if (job == NULL) {
break;
}
jobid = job->jobid;
cbuf_put(&(core->jbuf), &jobid);
}
jobid = 0;
cbuf_put(&(core->jbuf), &jobid);
picker->picker_iface->end_session(picker);
}
return NULL;
}
void* sched_allocator(void* arg)
{
xce_sched_core_t* core = (xce_sched_core_t*)arg;
xce_sched_plugin_t* picker = NULL;
for (;;) {
uint64_t jobid = 0;
xce_decision_t* decision = NULL;
xce_sched_job_t* job;
cbuf_get(&(core->jbuf), &jobid);
if (jobid == 0) {
decision = NULL;
cbuf_put(&(core->decisions), &decision);
continue;
}
job = sched_get_job(core, jobid);
if (job == NULL) {
continue;
}
(void)sched_resolve_job_picker(core, &picker);
if (picker != NULL) {
picker->picker_iface->on_pend(picker, job->jobid);
}
decision = make_pend_decision(make_pendreason(job->jobid));
cbuf_put(&(core->decisions), &decision);
}
return NULL;
}
/* scheduler-sim-live-allocation spec, task 4.1 (bug-1829 fix): sim_loop.c's
* real sched_sim_driver_run() (white-box #include'd into this TU above) now
* also calls sim_bootstrap_seqjob_allocator()/sim_bootstrap_parjob_
* allocator() (sim_alloc.c) -- undefined references at link time in this
* white-box TU otherwise, since neither symbol is part of this file's own
* hand-picked white-box #include set. This file's own test(s) exercise the
* link-satisfying sched_job_picker()/sched_allocator() stub pair above
* (which never reaches real primary allocation), so a true no-op is the
* correct, behavior-preserving stand-in here -- the real bootstrap logic is
* exercised separately by test_sim_live_allocation.c (task 4.1's own
* dedicated fixture, which links the real scheduler_srcs). */
void sim_bootstrap_seqjob_allocator(xce_sched_sim_driver_t* sim)
{
(void)sim;
}
void sim_bootstrap_parjob_allocator(xce_sched_sim_driver_t* sim)
{
(void)sim;
}
void setUp(void) { return; }
void tearDown(void) { return; }
/* ---------------------------------------------------------------------- */
/* Fixture helpers -- duplicated from test_repl_round_rollup.c/ */
/* test_repl_execution_control.c (same techniques test_sim_alt_events.c/ */
/* test_sim_verify.c already establish), per this file family's established*/
/* split convention (see header comment above): copied, not shared via a */
/* new header. */
/* ---------------------------------------------------------------------- */
static void make_tmp_dir(char* out, size_t out_len, const char* suffix)
{
char tmpl[PATH_MAX];
snprintf(tmpl, sizeof(tmpl), "/tmp/sched_replexec%s_XXXXXX", suffix);
TEST_ASSERT_NOT_NULL(mkdtemp(tmpl));
TEST_ASSERT_TRUE(strlen(tmpl) < out_len);
strcpy(out, tmpl);
}
static void build_fixture_scheduler(xce_scheduler_t* sched, char* record_dir)
{
int rc;
memset(sched, 0, sizeof(*sched));
mylock_init(&(sched->record_lock));
rc = xce_sched_core_init(&(sched->core));
TEST_ASSERT_EQUAL_INT(0, rc);
sched->core.job_pick_plugin = (char*)"builtin_fcfs";
sched->record_dir = record_dir;
}
static FILE* write_header_and_snapshot(char* out_path, size_t out_path_len,
const char* suffix)
{
char record_dir[PATH_MAX];
xce_scheduler_t sched;
int rc;
make_tmp_dir(record_dir, sizeof(record_dir), suffix);
build_fixture_scheduler(&sched, record_dir);
rc = sched_record_start(&sched, "fixture.replay");
TEST_ASSERT_EQUAL_INT(0, rc);
TEST_ASSERT_TRUE(strlen(sched.record_file_path) < out_path_len);
strcpy(out_path, sched.record_file_path);
return sched.record_file;
}
static void append_queue_update_event(FILE* f, uint64_t ts,
const char* queue_name)
{
xce_queue_t queue;
replay_event_t src;
struct capn c;
struct capn_segment* cs;
ReplayEvent_ptr p;
memset(&queue, 0, sizeof(queue));
queue.queue = (char*)queue_name;
queue.status = QUEUE_STAT_OPEN;
queue.priority = 1;
memset(&src, 0, sizeof(src));
src.ts = ts;
src.body_which = ReplayEvent_body_queueUpdate;
src.body.queue_update = &queue;
capn_init_malloc(&c);
cs = capn_root(&c).seg;
encode_ReplayEvent_ptr(cs, &p, &src);
capn_setp(capn_root(&c), 0, p.p);
TEST_ASSERT_EQUAL_INT(0, write_capnp_message(f, &c));
capn_free(&c);
}
/* append_workers_push_event - a structural event (WORKERS_PUSH, per
* design.md's Event Echo Gate classification list), encoded the same
* minimal-zeroed-wire-struct way append_jobs_push_event()
* (test_repl_round_rollup.c) builds a JOBS_PUSH: only the fields
* core_upsert_worker()/core_build_worker() (core_events.c) actually read
* (w->name, w->status, w->nresvals_to_sched) are set; everything else stays
* zeroed/NULL, which every encode_*_ptr() step along this path (encode_
* Worker(), encode_HostAttrs_ptr(), encode_TimeWindow_ptr(), encode_
* Threshold_list(), encode_NameValue_list() -- controller.capnp.c) already
* tolerates by design (same null-safety this file family's job/queue
* fixtures already rely on). Deliberately job-free -- see this file's own
* header comment on bug-1595 jobid safety. */
static void append_workers_push_event(FILE* f, uint64_t ts,
const char* worker_name)
{
xce_worker_t worker;
xce_worker_t* workers[1];
xce_workers_data_t workers_data;
replay_event_t src;
struct capn c;
struct capn_segment* cs;
ReplayEvent_ptr p;
memset(&worker, 0, sizeof(worker));
worker.name = (char*)worker_name;
workers[0] = &worker;
memset(&workers_data, 0, sizeof(workers_data));
workers_data.n_total = 1;
workers_data.count = 1;
workers_data.workers = workers;
memset(&src, 0, sizeof(src));
src.ts = ts;
src.body_which = ReplayEvent_body_workersPush;
src.body.workers_push = &workers_data;
capn_init_malloc(&c);
cs = capn_root(&c).seg;
encode_ReplayEvent_ptr(cs, &p, &src);
capn_setp(capn_root(&c), 0, p.p);
TEST_ASSERT_EQUAL_INT(0, write_capnp_message(f, &c));
capn_free(&c);
}
static void append_replay_session(FILE* f, uint64_t begin_round)
{
struct capn c;
struct capn_segment* cs;
ReplaySession_ptr sp;
capn_init_malloc(&c);
cs = capn_root(&c).seg;
sp = new_ReplaySession(cs);
ReplaySession_set_beginRound(sp, begin_round);
capn_setp(capn_root(&c), 0, sp.p);
TEST_ASSERT_EQUAL_INT(0, write_capnp_message(f, &c));
capn_free(&c);
}
static void append_end_of_stream_marker(FILE* f)
{
replay_event_t src;
struct capn c;
struct capn_segment* cs;
ReplayEvent_ptr p;
memset(&src, 0, sizeof(src));
src.body_which = ReplayEvent_body_endSession;
capn_init_malloc(&c);
cs = capn_root(&c).seg;
encode_ReplayEvent_ptr(cs, &p, &src);
capn_setp(capn_root(&c), 0, p.p);
TEST_ASSERT_EQUAL_INT(0, write_capnp_message(f, &c));
capn_free(&c);
}
static void write_text_file(const char* path, const char* content)
{
FILE* f = fopen(path, "w");
TEST_ASSERT_NOT_NULL(f);
TEST_ASSERT_TRUE(fputs(content, f) >= 0);
fclose(f);
}
static char* read_whole_file(const char* path)
{
FILE* f = fopen(path, "rb");
long len;
char* buf;
TEST_ASSERT_NOT_NULL(f);
TEST_ASSERT_EQUAL_INT(0, fseek(f, 0, SEEK_END));
len = ftell(f);
TEST_ASSERT_TRUE(len >= 0);
rewind(f);
buf = (char*)malloc((size_t)len + 1);
TEST_ASSERT_NOT_NULL(buf);
if (len > 0) {
TEST_ASSERT_EQUAL_INT((int)len, (int)fread(buf, 1, (size_t)len, f));
}
buf[len] = '\0';
fclose(f);
return buf;
}
/* build_round_marker - the bounds+count PREFIX of the Round Rollup's own
* pinned collapsed-range format (test_repl_round_rollup.c's own header
* comment documents the full format this file only needs the prefix of),
* e.g. build_round_marker(buf, sz, 1, 2) -> "round 1-2 (2 round(s)". Used
* as a strstr() needle to locate a flushed collapsed range in captured
* output and compare its position against another line's. */
static void build_round_marker(char* out, size_t outsz, uint64_t start_round,
uint64_t end_round)
{
snprintf(out, outsz, "round %llu-%llu (%llu round(s)",
(unsigned long long)start_round, (unsigned long long)end_round,
(unsigned long long)(end_round - start_round + 1));
}
/* child_run_repl_and_exit / run_repl_fixture_and_capture - the same fork/
* freopen/waitpid/capture shape test_repl_round_rollup.c's own pair
* establishes (itself following child_continue_then_inspect()/Test 2 in
* test_repl_execution_control.c): run a scripted command sequence to
* completion against a real sched_sim_driver_run(), capturing real stdout. */
static void child_run_repl_and_exit(const char* replay_path,
const char* script_path,
const char* capture_path)
{
xce_sched_sim_driver_t sim;
sched_sim_args_t args;
if (freopen(script_path, "r", stdin) == NULL) {
_exit(120);
}
if (freopen(capture_path, "w", stdout) == NULL) {
_exit(121);
}
memset(&sim, 0, sizeof(sim));
memset(&args, 0, sizeof(args));
args.replay_path = replay_path;
args.sim_start_ts = SCHED_SIM_START_TS_LATEST;
args.sim_speed = 0;
args.interactive = true;
(void)sched_sim_driver_run(&sim, &args);
fflush(stdout);
_exit(111); /* unreachable -- the script's `quit` must already have
* exited */
}
static char* run_repl_fixture_and_capture(const char* replay_path,
const char* script,
const char* aux_suffix)
{
char aux_dir[PATH_MAX];
char script_path[PATH_MAX];
char capture_path[PATH_MAX];
pid_t pid;
int status;
make_tmp_dir(aux_dir, sizeof(aux_dir), aux_suffix);
snprintf(script_path, sizeof(script_path), "%s/script.txt", aux_dir);
snprintf(capture_path, sizeof(capture_path), "%s/capture.out", aux_dir);
write_text_file(script_path, script);
pid = fork();
TEST_ASSERT_TRUE_MESSAGE(pid >= 0, "fork() must succeed");
if (pid == 0) {
child_run_repl_and_exit(replay_path, script_path, capture_path);
_exit(112); /* unreachable -- child_run_repl_and_exit never returns */
}
TEST_ASSERT_EQUAL_INT_MESSAGE(pid, waitpid(pid, &status, 0),
"waitpid must reap the REPL child");
TEST_ASSERT_TRUE_MESSAGE(WIFEXITED(status),
"the REPL child must exit normally via quit's "
"exit(0)");
TEST_ASSERT_EQUAL_INT(0, WEXITSTATUS(status));
return read_whole_file(capture_path);
}
/* ---------------------------------------------------------------------- */
/* Test 1: a routine per-tick event (QUEUE_UPDATE) produces NO individual */
/* echo line while the REPL is executing in continue mode (Req 1.1). */
/* ---------------------------------------------------------------------- */
static void test_routine_event_produces_no_line_under_continue_mode(void)
{
char replay_path[PATH_MAX];
FILE* f;
char* captured;
f = write_header_and_snapshot(replay_path, sizeof(replay_path),
"_eechoroutine");
TEST_ASSERT_NOT_NULL(f);
append_queue_update_event(f, 1000ULL, "normal"); /* routine event */
append_replay_session(f, 2000000000ULL); /* round 1: idle */
append_end_of_stream_marker(f);
fclose(f);
captured = run_repl_fixture_and_capture(replay_path, "continue\nquit\n",
"_eechoroutineaux");
TEST_ASSERT_NULL_MESSAGE(
strstr(captured, "[sim] event: QUEUE_UPDATE"),
"a routine per-tick event (QUEUE_UPDATE) must produce NO individual "
"line while the REPL is executing in continue mode (Requirement "
"1.1)");
free(captured);
printf(
"test_routine_event_produces_no_line_under_continue_mode: PASS\n");
}
/* ---------------------------------------------------------------------- */
/* Test 2: the SAME routine event type still produces a line while */
/* single-stepping -- step mode's per-event detail is unaffected by */
/* continue-mode's suppression (Req 1.2; doubles as a regression check). */
/* ---------------------------------------------------------------------- */
static void test_routine_event_still_prints_in_step_mode(void)
{
char replay_path[PATH_MAX];
FILE* f;
char* captured;
f = write_header_and_snapshot(replay_path, sizeof(replay_path),
"_eechostep");
TEST_ASSERT_NOT_NULL(f);
append_queue_update_event(f, 1000ULL, "normal"); /* same routine event */
append_replay_session(f, 2000000000ULL); /* round 1 */
append_end_of_stream_marker(f);
fclose(f);
captured = run_repl_fixture_and_capture(replay_path, "step\nquit\n",
"_eechostepaux");
TEST_ASSERT_NOT_NULL_MESSAGE(
strstr(captured, "[sim] event: QUEUE_UPDATE"),
"the SAME routine event type must still produce its individual "
"echo line while single-stepping -- step mode's per-event detail "
"is unaffected by continue-mode's suppression (Requirement 1.2)");
free(captured);
printf("test_routine_event_still_prints_in_step_mode: PASS\n");
}
/* ---------------------------------------------------------------------- */
/* Test 3: a structural change (WORKERS_PUSH) still prints a line under */
/* continue-mode execution (Req 1.3), and -- critically -- flushes any */
/* active Round Rollup collapsed range FIRST, so the range's summary */
/* appears in captured output BEFORE the structural event's own line */
/* (Req 3.5). */
/* ---------------------------------------------------------------------- */
static void
test_structural_event_prints_and_flushes_active_collapsed_range(void)
{
char replay_path[PATH_MAX];
FILE* f;
char* captured;
char idle_marker[64];
char* idle_pos;
char* structural_pos;
f = write_header_and_snapshot(replay_path, sizeof(replay_path),
"_eechostruct");
TEST_ASSERT_NOT_NULL(f);
append_queue_update_event(f, 1000ULL, "normal");
append_replay_session(f, 2000000000ULL); /* round 1: idle */
append_replay_session(f, 3000000000ULL); /* round 2: identical (idle)
* outcome -- silently extends
* the active range to rounds
* 1-2 (not yet printed) */
/* Structural event (WORKERS_PUSH), decoded mid-round-3 -- BEFORE round
* 3's own ReplaySession boundary is even reached. Must flush the
* still-active rounds-1-2 idle range and print it BEFORE this event's
* own echoed line (Requirement 3.5). Deliberately job-free (see this
* file's own header comment on bug-1595 jobid safety). */
append_workers_push_event(f, 3500000000ULL, "workerA");
append_replay_session(f, 4000000000ULL); /* round 3: idle again -- a
* fresh active range of its
* own, alone at replay
* completion; per design.md's
* Round Rollup, a lone idle
* round is never printed, so
* this produces no further
* output to confound the
* assertions below */
append_end_of_stream_marker(f);
fclose(f);
captured = run_repl_fixture_and_capture(replay_path, "continue\nquit\n",
"_eechostructaux");
build_round_marker(idle_marker, sizeof(idle_marker), 1, 2);
idle_pos = strstr(captured, idle_marker);
structural_pos = strstr(captured, "[sim] event: WORKERS_PUSH");
TEST_ASSERT_NOT_NULL_MESSAGE(
structural_pos,
"a structural change (WORKERS_PUSH) must still print a line "
"regardless of execution mode, including continue (Requirement "
"1.3)");
TEST_ASSERT_NOT_NULL_MESSAGE(
idle_pos,
"the active collapsed range (rounds 1-2, idle) must be flushed and "
"reported once the structural event ends it (Requirement 3.5)");
TEST_ASSERT_TRUE_MESSAGE(
idle_pos < structural_pos,
"the flushed collapsed range must be printed BEFORE the "
"structural event's own line -- a stale collapsed range and a "
"structural event must never interleave out of order (Requirement "
"3.5)");
free(captured);
printf(
"test_structural_event_prints_and_flushes_active_collapsed_range: "
"PASS\n");
}
/* ---------------------------------------------------------------------- */
/* Test 4: an event matching a breakpoint still interrupts continue-mode */
/* execution regardless of its routine/structural classification (Req */
/* 1.4), and ends any active collapsed range BEFORE the interruption is */
/* shown to the operator (Req 3.6). */
/* ---------------------------------------------------------------------- */
static void
test_breakpoint_hit_ends_active_collapsed_range_before_interruption(void)
{
char replay_path[PATH_MAX];
FILE* f;
char* captured;
char idle_marker[64];
char* idle_pos;
char* breakpoint_pos;
f = write_header_and_snapshot(replay_path, sizeof(replay_path),
"_eechobp");
TEST_ASSERT_NOT_NULL(f);
/* round 1 setup event -- queue "normal" never matches the breakpoint's
* queue=special filter below, so it never itself triggers an
* interruption. */
append_queue_update_event(f, 1000ULL, "normal");
append_replay_session(f, 2000000000ULL); /* round 1: idle */
append_replay_session(f, 3000000000ULL); /* round 2: identical (idle)
* outcome -- silently extends
* the active range to rounds
* 1-2 (not yet printed) */
/* This SECOND queue_update, decoded mid-round-3, is the one the
* breakpoint below actually matches (queue=special). QUEUE_UPDATE is a
* ROUTINE event type (design.md's Event Echo Gate classification) --
* using it here directly proves Requirement 1.4's "regardless of
* whether the event is routine or structural". */
append_queue_update_event(f, 3500000000ULL, "special");
append_replay_session(f, 4000000000ULL); /* never reached -- the
* breakpoint above interrupts
* execution first */
append_end_of_stream_marker(f);
fclose(f);
captured = run_repl_fixture_and_capture(
replay_path, "break QUEUE_UPDATE queue=special\ncontinue\nquit\n",
"_eechobpaux");
build_round_marker(idle_marker, sizeof(idle_marker), 1, 2);
idle_pos = strstr(captured, idle_marker);
breakpoint_pos = strstr(captured, "[sim] hit breakpoint");
TEST_ASSERT_NOT_NULL_MESSAGE(
breakpoint_pos,
"an event matching a breakpoint must still interrupt continue-mode "
"execution regardless of its routine/structural classification "
"(Requirement 1.4)");
TEST_ASSERT_NOT_NULL_MESSAGE(
idle_pos,
"the active collapsed range (rounds 1-2, idle) must be flushed and "
"reported before the breakpoint interruption is shown to the "
"operator (Requirement 3.6)");
TEST_ASSERT_TRUE_MESSAGE(
idle_pos < breakpoint_pos,
"the flushed collapsed range must be printed BEFORE the "
"breakpoint-hit line -- the operator must see the collapsed "
"range's final state before the interactive prompt returns "
"(Requirement 3.6)");
free(captured);
printf(
"test_breakpoint_hit_ends_active_collapsed_range_before_"
"interruption: PASS\n");
}
int main(void)
{
UNITY_BEGIN();
RUN_TEST(test_routine_event_produces_no_line_under_continue_mode);
RUN_TEST(test_routine_event_still_prints_in_step_mode);
RUN_TEST(
test_structural_event_prints_and_flushes_active_collapsed_range);
RUN_TEST(
test_breakpoint_hit_ends_active_collapsed_range_before_interruption);
return UNITY_END();
}