Rongsong Shen
2e8ed8cb4e
Add operational metrics infrastructure for the XCE controller persistence and HA subsystems (design doc P3-7, review A8-007). - src/include/ctrl_metrics.h: declares 7 _Atomic uint64_t metrics with ctrl_ prefix, CTRL_METRIC_INC / CTRL_METRIC_SET macros, ctrl_metric_desc_t descriptor struct, ctrl_metric_descriptors[] table, and ctrl_metrics_init() - src/controller/ctrl_metrics.c: defines the 7 counters/gauges, the descriptor table (7 entries + NULL sentinel), and ctrl_metrics_init() - src/controller/persist.c: #include ctrl_metrics.h; call ctrl_metrics_init() at persist_start() entry; CTRL_METRIC_INC(ctrl_repl_degraded_count) when repl_wait_ack returns < 0 (degraded / local-only durability mode) - src/controller/meson.build: add ctrl_metrics.c to xce_controller and controller_unit_test source lists; add test_ctrl_metrics.c to test sources - src/controller/testsuite/test_ctrl_metrics.c: 5 TDD-first Unity tests covering init-zeros, increment, set/overwrite gauge, descriptor sentinel count, and transient-stuck counter accumulation — all PASS
88 lines
3.2 KiB
C
88 lines
3.2 KiB
C
/* test_ctrl_metrics.c — P3-7: Metrics infrastructure unit tests
|
|
*
|
|
* TDD: these tests are written FIRST to drive the implementation.
|
|
* They verify:
|
|
* - ctrl_metrics_init() zeroes all 7 counters/gauges
|
|
* - CTRL_METRIC_INC increments atomically
|
|
* - CTRL_METRIC_SET writes and overwrites a gauge
|
|
* - The descriptor table has exactly 7 entries + NULL sentinel
|
|
* - ctrl_transient_jobs_stuck counter accumulates correctly
|
|
*/
|
|
#define _GNU_SOURCE
|
|
#include <stdatomic.h>
|
|
#include <stdint.h>
|
|
#include <stdio.h>
|
|
|
|
#include <unity/unity.h>
|
|
|
|
#include "ctrl_metrics.h"
|
|
|
|
/* ------------------------------------------------------------------ */
|
|
/* Tests */
|
|
/* ------------------------------------------------------------------ */
|
|
|
|
static void test_metrics_init_zeros_all_counters(void)
|
|
{
|
|
ctrl_metrics_init();
|
|
TEST_ASSERT_EQUAL_UINT64(0, atomic_load(&ctrl_repl_degraded_count));
|
|
TEST_ASSERT_EQUAL_UINT64(0, atomic_load(&ctrl_split_brain_detected));
|
|
TEST_ASSERT_EQUAL_UINT64(0, atomic_load(&ctrl_async_events_lost));
|
|
TEST_ASSERT_EQUAL_UINT64(0, atomic_load(&ctrl_transient_jobs_stuck));
|
|
TEST_ASSERT_EQUAL_UINT64(0, atomic_load(&ctrl_wal_bytes));
|
|
TEST_ASSERT_EQUAL_UINT64(0, atomic_load(&ctrl_checkpoint_duration_ms));
|
|
TEST_ASSERT_EQUAL_UINT64(0, atomic_load(&ctrl_repl_lag_lsn));
|
|
printf("test_metrics_init_zeros_all_counters: PASS\n");
|
|
}
|
|
|
|
static void test_metrics_increment_repl_degraded(void)
|
|
{
|
|
ctrl_metrics_init();
|
|
CTRL_METRIC_INC(ctrl_repl_degraded_count);
|
|
CTRL_METRIC_INC(ctrl_repl_degraded_count);
|
|
TEST_ASSERT_EQUAL_UINT64(2, atomic_load(&ctrl_repl_degraded_count));
|
|
printf("test_metrics_increment_repl_degraded: PASS\n");
|
|
}
|
|
|
|
static void test_metrics_set_gauge(void)
|
|
{
|
|
ctrl_metrics_init();
|
|
CTRL_METRIC_SET(ctrl_wal_bytes, 1024 * 1024);
|
|
TEST_ASSERT_EQUAL_UINT64(1024 * 1024, atomic_load(&ctrl_wal_bytes));
|
|
CTRL_METRIC_SET(ctrl_wal_bytes, 0);
|
|
TEST_ASSERT_EQUAL_UINT64(0, atomic_load(&ctrl_wal_bytes));
|
|
printf("test_metrics_set_gauge: PASS\n");
|
|
}
|
|
|
|
static void test_metrics_descriptor_table_has_sentinel(void)
|
|
{
|
|
/* The descriptor table must end with a NULL-name sentinel
|
|
* and contain exactly 7 real entries. */
|
|
int i = 0;
|
|
while (ctrl_metric_descriptors[i].name != NULL)
|
|
i++;
|
|
TEST_ASSERT_EQUAL_INT(7, i);
|
|
printf("test_metrics_descriptor_table_has_sentinel: PASS\n");
|
|
}
|
|
|
|
static void test_transient_jobs_stuck_counter(void)
|
|
{
|
|
ctrl_metrics_init();
|
|
/* Simulate 3 stuck transient jobs */
|
|
for (int j = 0; j < 3; j++)
|
|
CTRL_METRIC_INC(ctrl_transient_jobs_stuck);
|
|
TEST_ASSERT_EQUAL_UINT64(3, atomic_load(&ctrl_transient_jobs_stuck));
|
|
printf("test_transient_jobs_stuck_counter: PASS\n");
|
|
}
|
|
|
|
/* ------------------------------------------------------------------ */
|
|
/* Suite entry point (called from controller_test.c) */
|
|
/* ------------------------------------------------------------------ */
|
|
|
|
void test_ctrl_metrics(void)
|
|
{
|
|
RUN_TEST(test_metrics_init_zeros_all_counters);
|
|
RUN_TEST(test_metrics_increment_repl_degraded);
|
|
RUN_TEST(test_metrics_set_gauge);
|
|
RUN_TEST(test_metrics_descriptor_table_has_sentinel);
|
|
RUN_TEST(test_transient_jobs_stuck_counter);
|
|
}
|