Rongsong Shen
701901079e
repl_print_limit_usage()/repl_print_limit_usage_per_host() (repl_info.c) passed vres->vres->name (a synthesized compound scope-instance name, e.g. "limits2/u=rshen/q=xce/p=") to the byte-value classifier instead of the limit's actual constrained resource name -- so a byte-valued limit's usage amounts never got recognized as byte-valued, regardless of the underlying formatting machinery already working correctly. Fixed both call sites to pass the limit's own resname (limit->val.resname / vres->limit->val.resname) instead. Added tests proving human-readable rendering for both the cluster-wide/GLOBAL path and a percentage-based per-host limit (Requirement 6 AC 6.4: a percentage-of-byte-resource limit's resolved absolute amount is human-formatted too). Discovered and confirmed (implementer + independent reviewer): the fix landed with zero pre-existing test failures, not the handful design.md predicted -- those assertions used whole-number fixture values with bare strstr() substring checks, which still match the new, longer human-augmented output by coincidence of formatting. Documented in tasks.md; task 10.1 will strengthen those assertions to genuinely exercise the fix rather than pass by accident. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLSNJhNoULvVcUhXEFafQC |
||
|---|---|---|
| .. | ||
| settings | ||
| specs | ||
| steering | ||