Rongsong Shen
7b274ec0df
bug-1820's own fix assumed sudo always forks exactly one direct child that IS the real target, and looked for it via `pgrep -P $PID` (direct children only). On a real host, sudo commonly interposes an additional "monitor" process between the invoked sudo and the actual target (sudo -> monitor -> target, three processes, not two -- standard sudo 1.8.7+ architecture for signal/exit-status relay) -- a shape this sandbox's own simpler sudo build doesn't reproduce, which is why bug-1820 verified clean here but still left the real worker orphaned on the reporting user's box. `pgrep -P` found and killed the monitor (a direct child) while the actual worker (the monitor's own child, not a direct child of the pidfile'd PID) survived untouched. Replaces the parent/child tree-walking approach entirely with a depth-independent identity-based re-scan: both generated scripts now search system-wide (pgrep -f) for any still-running process whose own cmdline matches the worker's distinguishing identity (-n $NAME plus this deploy's -l $TOP/logs -- the same two args start-worker.sh's own "already running" guard checks) and kill every match directly, however many hops deep it landed. No longer needs to know or guess sudo's internal process-tree depth. Live-verified: regression-checked against this sandbox's own real (2-level) sudo deploy (still clean), and built + killed a synthetic 3-level process tree modeled on the user's exact live report, confirming the deepest process is found directly and the intermediate hop then exits on its own once its child is gone. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLSNJhNoULvVcUhXEFafQC |
||
|---|---|---|
| .. | ||
| appimage | ||
| deploy-ha.sh | ||
| go_build | ||
| test-build-version-regression.sh | ||
| test-commit-durability.sh | ||
| test-dirty-fingerprint-distinguishability.sh | ||
| test-dirty-fingerprint-nix-production-path.sh | ||
| test-dirty-fingerprint-startup-log-unchanged.sh | ||
| test-heartbeat-tolerance.sh | ||
| test-version-startup-consistency.sh | ||
| test-xceadmin-build-install-version.sh | ||
| xce-build.sh | ||