No description
Rongsong Shen
bfe69b1e85
Using gdb (SIGQUIT all-thread backtrace on the wedged nodes), nailed the round-4 blocker to a deterministic ABBA lock-order deadlock in src/lib async dispatch — identical on both wedged survivors: - io_worker (netio.c:672): holds ep->lock, blocks on q->lock (vtask_enq->dataq_enq) - vdispatcher dataq_deq (dataq.c:65): holds q->lock, blocks on ep->lock via the vtask_eligible (vtaskmgr.c:255) -> endpoint_is_task_blocked (netio.c:1001) cb io_worker wedges -> node stops accepting/answering PreVotes -> two restarted survivors can't elect -> round-4 stall. The release SIGSEGV is the same ep/q race corrupting under churn. Defect: dataq_deq runs its match callback while holding q->lock, and the callback takes ep->lock — inverting io_worker's ep->lock->q->lock order. Minimal fix: make ep->busy atomic + lockless in endpoint_is_task_blocked (or io_worker drops ep->lock before dataq_enq, or one global lock order). Ownership: src/lib async-I/O dispatch (vtaskmgr/dataq/netio) = raft-drive-async / core libxce, a Non-Goal of this spec. Per upstream-ownership protocol, routed to raft-drive-async (bug-1282); 7.2 stays blocked until the dispatch lock-order is repaired, then re-run the gate. The gate worked as designed — 7.2 must be GREEN before raft-drive-async flips dispatch flags ON, and it caught a real dispatch deadlock. Task 5.4 (root-cause + assign ownership) is DONE. Consensus correctness (Phase-2/5.2/5.3) is unaffected. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019dbTHR9CsEYK9RsqmQpQpC |
||
|---|---|---|
| .claude | ||
| .kiro | ||
| .wolf | ||
| docs/superpowers/plans | ||
| ha/data | ||
| raft | ||
| src | ||
| .clang-format | ||
| .gitignore | ||
| .mcp.json | ||
| .opencode.json | ||
| CLAUDE.md | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| uninstall-code-review-graph.sh | ||
1. commit 规则
- 每个人 fork 自己的 branch， 从自己的 branch 做 PR，review 完再 commit
2. code format
2.1. C
推荐使用 clang-format，公共配置放在源码里面 xce/.clang-format
（理论上直接使用源码里面 xce/.clang-format 文件格式不会变）
2.1.1. vscode 可以在配置中加上如下内容
"C_Cpp.clang_format_style": "WebKit",
"C_Cpp.clang_format_fallbackStyle": "WebKit",
2.1.2. vim & emacs
clang-format -style="{BasedOnStyle: webkit}" -i XX.c
2.2. golang
使用默认 gofmt
3. build environment and build (example of ubuntu)
3.1 build environment
- Install nix package management tool
sh <(curl -L https://nixos.org/nix/install) --daemon
- Edit /etc/nix/nix.conf to make sure
experimental-features = nix-command flakes
sandbox = true
sandbox-fallback = false
substituters = https://mirrors.ustc.edu.cn/nix-channels/store https://cache.nixos.org https://cache.nixos.org/
trusted-users = root <your account>
make sure that you have restarted nix-daemon service after you have changed /etc/nix/nix.conf
- Install socat and config ssh (for clone by ssh protocol)
nix profile add nixpkgs#socat
.ssh/config
Host gitea.shenrs.eu
HostName gitea.shenrs.eu
IdentityFile ~/.ssh/id_ed25519
ProxyCommand socat - openssl-connect:gitea.shenrs.eu:2022,snihost=gitea.shenrs.eu,verify=0
3.2 checkout source code
3.3 build (for package and release)
cd xce/src
# for build debug version
nix build --option sandbox false .#xcecore_debug
# for normal build
nix build --option sandbox false .#xcecore
You can find the generated binaries at =result= directory
3.4 build (for daily develop)
cd xce/src
nix develop
# using meson to generated build configuration (debug and address sanitize)
meson setup build --buildtype=debug -Db_sanitize=address
# run meson to build
meson compile -C build
# The generated files will be in build/
3.5 build AppImage package
cd xce/src
nix bundle --bundler github:ralismark/nix-appimage --option sandbox false .#xce
This will create all in one AppImage file which contains everything for package delivery.
4. misc
4.1. Windows remap ctrl and alt key
create a reg file, e.g. remapkey.reg
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Keyboard Layout]
"Scancode Map"=hex:00,00,00,00,00,00,00,00,05,00,00,00,38,00,1d,00,1d,00,38,00,38,e0,1d,e0,1d,e0,38,e0,00,00,00,00
then double click remapkey.reg to import it. Restart OS.