No description
Rongsong Shen
c0b0c7d1de
repl_add_standby()'s "find first empty slot" scan treated any ep==NULL slot as available, with no awareness that a disconnected slot can still hold an unexpired bug-1147 WAL-retention guard (last_disconnected_lsn, set by repl_remove_standby, meant to be cleared only by repl_expire_disconnect_slots once snap_interval_s genuinely elapses). The scan could pick a guard-holding slot over a genuinely virgin one purely by lower index, then unconditionally memset it -- destroying the guard before trim_wal_segments/repl_trim_lsn could ever honor it. Confirmed via 2/2 reproducible live 3-node soak runs (config-upgrade- snapshot task 8.9's new --config-upgrade-wal-trim mode): a killed standby's still-needed WAL segment got trimmed out from under it. Now a two-pass scan: prefer a genuinely virgin slot; only fall back to reusing a guard-holding slot (oldest last_disconnect_time first, to discard the least remaining protection) when no virgin slot exists -- logged via WARN() so the discarded guard is operator-visible rather than silent. Defense-in-depth at the slot-allocation layer, independent of whatever triggers a given repl_add_standby call (a separate, not-fully-root-caused ha.c reconnect-sweep defect is the specific trigger seen in the soak, out of this fix's scope). Independently reviewed across two rounds: round 1 flagged the exhausted-fallback path silently discarding a guard with zero logging; remediated with a WARN() matching this file's existing repl_broadcast convention, empirically confirmed to fire only on the fallback path with correct content. Suite: 1028 -> 1030 tests, 0 failures (net of this fix; final combined total with bug-1472 landing concurrently: 1033 tests, 0 failures). |
||
|---|---|---|
| .claude | ||
| .kiro | ||
| .wolf | ||
| docs/superpowers/plans | ||
| raft | ||
| reports | ||
| scripts | ||
| src | ||
| .clang-format | ||
| .gitignore | ||
| .mcp.json | ||
| .opencode.json | ||
| CLAUDE.md | ||
| README.md | ||
1. commit 规则
- 每个人 fork 自己的 branch， 从自己的 branch 做 PR，review 完再 commit
2. code format
2.1. C
推荐使用 clang-format，公共配置放在源码里面 xce/.clang-format
（理论上直接使用源码里面 xce/.clang-format 文件格式不会变）
2.1.1. vscode 可以在配置中加上如下内容
"C_Cpp.clang_format_style": "WebKit",
"C_Cpp.clang_format_fallbackStyle": "WebKit",
2.1.2. vim & emacs
clang-format -style="{BasedOnStyle: webkit}" -i XX.c
2.2. golang
使用默认 gofmt
3. build environment and build (example of ubuntu)
3.1 build environment
- Install nix package management tool
sh <(curl -L https://nixos.org/nix/install) --daemon
- Edit /etc/nix/nix.conf to make sure
experimental-features = nix-command flakes
sandbox = true
sandbox-fallback = false
substituters = https://mirrors.ustc.edu.cn/nix-channels/store https://cache.nixos.org https://cache.nixos.org/
trusted-users = root <your account>
make sure that you have restarted nix-daemon service after you have changed /etc/nix/nix.conf
- Install socat and config ssh (for clone by ssh protocol)
nix profile add nixpkgs#socat
.ssh/config
Host gitea.shenrs.eu
HostName gitea.shenrs.eu
IdentityFile ~/.ssh/id_ed25519
ProxyCommand socat - openssl-connect:gitea.shenrs.eu:2022,snihost=gitea.shenrs.eu,verify=0
3.2 checkout source code
3.3 build (for package and release)
cd xce/src
# for build debug version
nix build --option sandbox false .#xcecore_debug
# for normal build
nix build --option sandbox false .#xcecore
You can find the generated binaries at =result= directory
3.4 build (for daily develop)
cd xce/src
nix develop
# using meson to generated build configuration (debug and address sanitize)
meson setup build --buildtype=debug -Db_sanitize=address
# run meson to build
meson compile -C build
# The generated files will be in build/
3.5 build AppImage package
cd xce/src
nix bundle --bundler github:ralismark/nix-appimage --option sandbox false .#xce
This will create all in one AppImage file which contains everything for package delivery.
4. misc
4.1. Windows remap ctrl and alt key
create a reg file, e.g. remapkey.reg
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Keyboard Layout]
"Scancode Map"=hex:00,00,00,00,00,00,00,00,05,00,00,00,38,00,1d,00,1d,00,38,00,38,e0,1d,e0,1d,e0,38,e0,00,00,00,00
then double click remapkey.reg to import it. Restart OS.