makeGroup()'s existing-group update path (hit whenever a config-push re-applies a group name that already has members, e.g. a retried config push during controller failover) released xce_g_member_t.u.name via FREEUP() (plain free()). u.name is allocated by makeString(), an rtti-managed, refcounted pointer that is not a malloc()-base address -- freeing it directly corrupts the heap. group_killer() in the same file already releases the identical field correctly via dereference(). Switch both FREEUP(m->u.name) call sites to dereference(m->u.name) to match. Add a regression test that re-applies config for the same group name twice, reproducing the exact ASAN bad-free at group.c:234 pre-fix. This is the root cause of the reproducible xce_scheduler "free(): invalid pointer" SIGABRT crashes seen during 3-attempt controller-failover config-push retries (8 confirmed core dumps). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
466 lines
9.6 KiB
C
466 lines
9.6 KiB
C
#include <errno.h>
|
|
#include <rtti.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
#include "group.h"
|
|
#include "kvmgr.h"
|
|
#include "utils.h"
|
|
#include "xce/types.h"
|
|
#include "xstring.h"
|
|
|
|
typedef struct {
|
|
|
|
} group_private_t;
|
|
|
|
static void group_killer(xce_group_t* g)
|
|
{
|
|
int i;
|
|
|
|
if (g == NULL) {
|
|
return;
|
|
}
|
|
|
|
for (i = 0; i < g->members.count; i++) {
|
|
xce_g_member_t* m = (xce_g_member_t*)xlist_get(&(g->members), i);
|
|
|
|
if (!m->is_group) {
|
|
dereference(m->u.name);
|
|
}
|
|
FREEUP(m);
|
|
}
|
|
|
|
for (i = 0; i < g->ex_members.count; i++) {
|
|
xce_g_member_t* m = (xce_g_member_t*)xlist_get(&(g->ex_members), i);
|
|
|
|
if (!m->is_group) {
|
|
dereference(m->u.name);
|
|
}
|
|
FREEUP(m);
|
|
}
|
|
|
|
for (i = 0; i < g->affecteds.count; i++) {
|
|
xce_group_t* g1 = (xce_group_t*)xlist_get(&(g->affecteds), i);
|
|
|
|
xlist_del(&(g1->members), g);
|
|
xlist_del(&(g1->ex_members), g);
|
|
}
|
|
|
|
xlist_fini(&(g->members));
|
|
xlist_fini(&(g->ex_members));
|
|
xlist_fini(&(g->affecteds));
|
|
|
|
dereference(g->name);
|
|
}
|
|
|
|
xce_g_member_t* make_g_member(var mgr, char* name)
|
|
{
|
|
xce_g_member_t* m = NULL;
|
|
xce_group_t* g = NULL;
|
|
|
|
if ((mgr == NULL) || (name == NULL)) {
|
|
errno = EINVAL;
|
|
return NULL;
|
|
}
|
|
|
|
m = (xce_g_member_t*)calloc(1, sizeof(*m));
|
|
if (m == NULL) {
|
|
return NULL;
|
|
}
|
|
|
|
g = get_group(mgr, name);
|
|
if (g != NULL) {
|
|
m->is_group = 1;
|
|
m->u.g = g;
|
|
} else {
|
|
m->is_group = 0;
|
|
m->u.name = makeString(name);
|
|
}
|
|
|
|
return m;
|
|
}
|
|
|
|
static int update_group_dirty(xce_group_t* g)
|
|
{
|
|
int i;
|
|
int count = 0;
|
|
|
|
for (i = 0; i < g->affecteds.count; i++) {
|
|
xce_group_t* g1 = (xce_group_t*)xlist_get(&(g->affecteds), i);
|
|
|
|
if (g1 == NULL) {
|
|
continue;
|
|
}
|
|
|
|
g1->dirty = 1;
|
|
count++;
|
|
|
|
count += update_group_dirty(g1);
|
|
}
|
|
|
|
return count;
|
|
}
|
|
|
|
static int init_group_by_config(xce_group_t* g, var mgr,
|
|
xce_group_config_t* g_config)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < g_config->members.count; i++) {
|
|
char* g_name = g_config->members.data[i];
|
|
xce_g_member_t* m = make_g_member(mgr, g_name);
|
|
|
|
if (m == NULL) {
|
|
continue;
|
|
}
|
|
|
|
xlist_store(&(g->members), m);
|
|
if (m->is_group) {
|
|
xlist_store(&(m->u.g->affecteds), g);
|
|
}
|
|
}
|
|
|
|
for (i = 0; i < g_config->ex_members.count; i++) {
|
|
char* g_name = g_config->ex_members.data[i];
|
|
xce_g_member_t* m = make_g_member(mgr, g_name);
|
|
|
|
if (m == NULL) {
|
|
continue;
|
|
}
|
|
|
|
xlist_store(&(g->ex_members), m);
|
|
if (m->is_group) {
|
|
xlist_store(&(m->u.g->affecteds), g);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static size_t group_datasize(va_list ap)
|
|
{
|
|
size_t sz = sizeof(xce_group_t);
|
|
|
|
return sz;
|
|
}
|
|
|
|
static int group_init(meta_obj_t* obj, va_list ap)
|
|
{
|
|
xce_group_t* g = RTTI_OBJ_TO_DATA(xce_group_t, obj);
|
|
var mgr = va_arg(ap, var);
|
|
xce_group_config_t* config = va_arg(ap, xce_group_config_t*);
|
|
char* g_name = va_arg(ap, char*);
|
|
int rc;
|
|
|
|
if ((mgr == NULL) || (config == NULL)) {
|
|
return -EINVAL;
|
|
}
|
|
|
|
lock(mgr, RTTI_LOCK_WRITE);
|
|
rc = key_add(mgr, (void*)g_name, (void*)g);
|
|
unlock(mgr);
|
|
|
|
if (rc < 0) {
|
|
return rc;
|
|
}
|
|
|
|
xlist_init(&(g->affecteds), 4);
|
|
xlist_init(&(g->members), 4);
|
|
xlist_init(&(g->ex_members), 4);
|
|
|
|
g->name = makeString(g_name);
|
|
g->dirty = 0;
|
|
|
|
init_group_by_config(g, mgr, config);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static void group_destroy(meta_obj_t* obj)
|
|
{
|
|
xce_group_t* g = RTTI_OBJ_TO_DATA(xce_group_t, obj);
|
|
|
|
group_killer(g);
|
|
}
|
|
|
|
static typeinfo_t group_type = { .name = "group",
|
|
.privateSize = sizeof(group_private_t),
|
|
.dataSize = (datasize_fn_t)group_datasize,
|
|
.init = (obj_init_fn_t)group_init,
|
|
.destroy = (obj_destroy_fn_t)group_destroy,
|
|
.interfaces = {} };
|
|
|
|
xce_group_t* makeGroup(var mgr, xce_group_config_t* config,
|
|
char* default_g_name)
|
|
{
|
|
xce_group_t* g = NULL;
|
|
char* g_name = NULL;
|
|
int rc = 0;
|
|
|
|
if ((mgr == NULL) || (config == NULL)) {
|
|
errno = EINVAL;
|
|
|
|
return NULL;
|
|
}
|
|
|
|
g_name = config->name;
|
|
if ((g_name == NULL) || (strlen(g_name) == 0)) {
|
|
g_name = default_g_name;
|
|
}
|
|
|
|
if (g_name == NULL) {
|
|
errno = EINVAL;
|
|
return NULL;
|
|
}
|
|
|
|
lock(mgr, RTTI_LOCK_READ);
|
|
rc = key_find(mgr, (void*)g_name, (void**)&g);
|
|
unlock(mgr);
|
|
|
|
if ((rc < 0) && (rc != -ENOENT)) {
|
|
errno = -rc;
|
|
return NULL;
|
|
}
|
|
|
|
if (g != NULL) {
|
|
int i;
|
|
|
|
for (i = 0; i < g->members.count; i++) {
|
|
xce_g_member_t* m = (xce_g_member_t*)xlist_get(&(g->members), i);
|
|
if (m == NULL) {
|
|
continue;
|
|
}
|
|
if (m->is_group == 0) {
|
|
dereference(m->u.name);
|
|
}
|
|
|
|
FREEUP(m);
|
|
}
|
|
g->members.count = 0;
|
|
|
|
for (i = 0; i < g->ex_members.count; i++) {
|
|
xce_g_member_t* m = (xce_g_member_t*)xlist_get(&(g->ex_members), i);
|
|
if (m == NULL) {
|
|
continue;
|
|
}
|
|
if (m->is_group == 0) {
|
|
dereference(m->u.name);
|
|
}
|
|
|
|
FREEUP(m);
|
|
}
|
|
g->ex_members.count = 0;
|
|
g->dirty = 1;
|
|
|
|
init_group_by_config(g, mgr, config);
|
|
|
|
return g;
|
|
}
|
|
|
|
g = makeInstance(&group_type, mgr, config, g_name);
|
|
|
|
return g;
|
|
}
|
|
|
|
int groupmgr_init(var* mgr, int nslots, int delta)
|
|
{
|
|
xce_group_config_t all = { .name = "all" };
|
|
xce_group_config_t empty = { .name = "empty" };
|
|
xce_group_t* g = NULL;
|
|
kvmgr_params_t params = { .key_type = KVMGR_KEY_STRING,
|
|
.nslots = nslots,
|
|
.delta = delta,
|
|
.datakiller = destroy };
|
|
|
|
*mgr = makeInstance(&xkvmgr_type, ¶ms);
|
|
if ((*mgr) == NULL) {
|
|
return -errno;
|
|
}
|
|
|
|
/* create builtin all group */
|
|
g = makeGroup(*mgr, &all, NULL);
|
|
if (g == NULL) {
|
|
return -errno;
|
|
}
|
|
|
|
/* create builtin empty group */
|
|
g = makeGroup(*mgr, &empty, NULL);
|
|
if (g == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
int groupmgr_add(var mgr, xce_group_t* g)
|
|
{
|
|
int rc = 0;
|
|
|
|
lock(mgr, RTTI_LOCK_WRITE);
|
|
rc = key_add(mgr, (void*)g->name, (void*)g);
|
|
unlock(mgr);
|
|
|
|
return rc;
|
|
}
|
|
|
|
xce_group_t* groupmgr_lock(var mgr, char* name, int op)
|
|
{
|
|
int rc;
|
|
xce_group_t* g = NULL;
|
|
|
|
lock(mgr, RTTI_LOCK_READ);
|
|
rc = key_find(mgr, (void*)name, (void**)&g);
|
|
unlock(mgr);
|
|
|
|
if (rc <= 0) {
|
|
return NULL;
|
|
}
|
|
|
|
return g;
|
|
}
|
|
|
|
void groupmgr_del(var mgr, xce_group_t* g)
|
|
{
|
|
lock(mgr, RTTI_LOCK_WRITE);
|
|
key_del(mgr, (void*)g->name);
|
|
unlock(mgr);
|
|
|
|
return;
|
|
}
|
|
|
|
xce_group_t* get_group(var mgr, char* name)
|
|
{
|
|
xce_group_t* g = NULL;
|
|
int rc = 0;
|
|
|
|
if ((mgr == NULL) || (name == NULL)) {
|
|
return NULL;
|
|
}
|
|
|
|
lock(mgr, RTTI_LOCK_READ);
|
|
rc = key_find(mgr, (void*)name, (void**)&g);
|
|
unlock(mgr);
|
|
|
|
if (rc <= 0) {
|
|
return NULL;
|
|
}
|
|
|
|
return g;
|
|
}
|
|
|
|
int fmt_group(char* buf, int len, xce_group_t* g)
|
|
{
|
|
int i, pos;
|
|
|
|
if (strcmp(g->name, "all") == 0) {
|
|
return snprintf(buf, len, "all");
|
|
}
|
|
|
|
if (strcmp(g->name, "empty") == 0) {
|
|
return snprintf(buf, len, "[]");
|
|
}
|
|
|
|
snprintf(buf, len, "[");
|
|
pos = strlen(buf);
|
|
|
|
for (i = 0; i < g->members.count; i++) {
|
|
xce_g_member_t* m = (xce_g_member_t*)xlist_get(&(g->members), i);
|
|
|
|
if (m == NULL) {
|
|
continue;
|
|
}
|
|
|
|
snprintf(buf + pos, len - pos, "%s ",
|
|
(m->is_group) ? m->u.g->name : m->u.name);
|
|
pos = strlen(buf);
|
|
}
|
|
|
|
for (i = 0; i < g->ex_members.count; i++) {
|
|
xce_g_member_t* m = (xce_g_member_t*)xlist_get(&(g->ex_members), i);
|
|
|
|
if (m == NULL) {
|
|
continue;
|
|
}
|
|
|
|
snprintf(buf + pos, len - pos, "~%s ",
|
|
(m->is_group) ? m->u.g->name : m->u.name);
|
|
pos = strlen(buf);
|
|
}
|
|
|
|
while ((pos > 0) && (buf[pos - 1] == ' ')) {
|
|
pos--;
|
|
}
|
|
|
|
snprintf(buf + pos, len - pos, "]");
|
|
|
|
return strlen(buf);
|
|
}
|
|
|
|
static int check_in_member(xce_g_member_t* m, va_list ap)
|
|
{
|
|
char* name = va_arg(ap, char*);
|
|
|
|
if ((m == NULL) || (name == NULL)) {
|
|
return 0;
|
|
}
|
|
|
|
if (m->is_group) {
|
|
if (is_in_group(m->u.g, name)) {
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
if (strcmp(m->u.name, name) == 0) {
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int is_in_group(xce_group_t* g, char* name)
|
|
{
|
|
if ((g == NULL) || (name == NULL)) {
|
|
return -EINVAL;
|
|
}
|
|
|
|
/* everything should be in all group */
|
|
if (strcmp(g->name, "all") == 0) {
|
|
return 1;
|
|
}
|
|
|
|
/* nothing is in empty group */
|
|
if (strcmp(g->name, "empty") == 0) {
|
|
return 0;
|
|
}
|
|
|
|
if (strcmp(g->name, name) == 0) {
|
|
return 1;
|
|
}
|
|
|
|
if (xlist_find(&(g->ex_members), (xlist_find_fn_t)check_in_member, name)
|
|
!= NULL) {
|
|
return 0;
|
|
}
|
|
|
|
if (xlist_find(&(g->members), (xlist_find_fn_t)check_in_member, name)
|
|
!= NULL) {
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int is_group_all(xce_group_t* g)
|
|
{
|
|
if (g == NULL) {
|
|
return 0;
|
|
}
|
|
|
|
if (g->name == NULL) {
|
|
return 0;
|
|
}
|
|
|
|
return (strcmp(g->name, "all") == 0);
|
|
}
|