No description
Rongsong Shen
f3b6e6ae3b
Both fixes are real and independently verified; the drive-async flags (g_drive_async_snapshot_offload, g_drive_async_peerctrl_dispatch_enabled) stay at their production-default OFF -- see the tasks.md session note for why the flip itself doesn't land in this commit. 1. Snapshot-lane borrowed-endpoint hazard (task 3.2, bug-1197 family): ha_snapshot_send_dispatch now takes endpoint_ref(ep) before submitting to the slow lane, released on every non-lane terminal path and by snapshot_lane_fn on completion. Reuses the general bug-1298 endpoint refcount system (standby-ep teardown already routes through endpoint_unref via cluster.c's endpoint_killer) -- a concurrent RDHUP teardown can now only drop the owner's reference while a transfer is in flight, never free the ep out from under it. New test: test_snapshot_offload_holds_endpoint_ref_across_transfer (RED->GREEN). 2. Catch-up streamer WAL_CHECKPOINT bug (found while verifying #1 via a live soak, pre-existing, unrelated to the drive-async flags): ha_stream_wal_ to_standby had no filter for WAL_CHECKPOINT markers -- local-only bookkeeping that still consumes a real LSN slot via persist_write_ checkpoint_marker's own current_lsn++. It shipped one to a catching-up standby, which correctly refused it (persist_wal_write_replicated rejects type==WAL_CHECKPOINT) and got stuck retrying the same LSN forever. Fixed by skipping WAL_CHECKPOINT entirely in the streamer loop, mirroring the existing replay_wal/term-index precedent of treating checkpoint-marker LSNs as invisible gaps. New test: test_wal_stream_skips_checkpoint_marker (RED->GREEN). Attempted flipping both drive-async flags ON after landing these fixes (the "full fix, defer prod flip" decision's prerequisite -- 4.1+4.2 are green). A 6-round --chaotic soak passed clean, but a --force-snapshot soak (a genuinely empty node cold-start rejoin, the one scenario chaotic mode never exercises) surfaced a THIRD, not-yet-root-caused issue: the freshly-wiped node's own self-election appears to race cluster_init_phase2's vtask-pool wiring, then the process hangs silently (no crash, no ASAN report) until killed. Reverted both flags to OFF rather than ship an unproven state -- production behavior is unchanged by this commit. Full controller suite green and both soaks (--force-snapshot, 6-round --chaotic) pass clean with flags OFF, confirming no regression from the two logic fixes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dZVSx3CdBjys9BB6hqpxP |
||
|---|---|---|
| .claude | ||
| .kiro | ||
| .wolf | ||
| docs/superpowers/plans | ||
| ha/data | ||
| raft | ||
| src | ||
| .clang-format | ||
| .gitignore | ||
| .mcp.json | ||
| .opencode.json | ||
| CLAUDE.md | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| uninstall-code-review-graph.sh | ||
1. commit 规则
- 每个人 fork 自己的 branch， 从自己的 branch 做 PR，review 完再 commit
2. code format
2.1. C
推荐使用 clang-format，公共配置放在源码里面 xce/.clang-format
（理论上直接使用源码里面 xce/.clang-format 文件格式不会变）
2.1.1. vscode 可以在配置中加上如下内容
"C_Cpp.clang_format_style": "WebKit",
"C_Cpp.clang_format_fallbackStyle": "WebKit",
2.1.2. vim & emacs
clang-format -style="{BasedOnStyle: webkit}" -i XX.c
2.2. golang
使用默认 gofmt
3. build environment and build (example of ubuntu)
3.1 build environment
- Install nix package management tool
sh <(curl -L https://nixos.org/nix/install) --daemon
- Edit /etc/nix/nix.conf to make sure
experimental-features = nix-command flakes
sandbox = true
sandbox-fallback = false
substituters = https://mirrors.ustc.edu.cn/nix-channels/store https://cache.nixos.org https://cache.nixos.org/
trusted-users = root <your account>
make sure that you have restarted nix-daemon service after you have changed /etc/nix/nix.conf
- Install socat and config ssh (for clone by ssh protocol)
nix profile add nixpkgs#socat
.ssh/config
Host gitea.shenrs.eu
HostName gitea.shenrs.eu
IdentityFile ~/.ssh/id_ed25519
ProxyCommand socat - openssl-connect:gitea.shenrs.eu:2022,snihost=gitea.shenrs.eu,verify=0
3.2 checkout source code
3.3 build (for package and release)
cd xce/src
# for build debug version
nix build --option sandbox false .#xcecore_debug
# for normal build
nix build --option sandbox false .#xcecore
You can find the generated binaries at =result= directory
3.4 build (for daily develop)
cd xce/src
nix develop
# using meson to generated build configuration (debug and address sanitize)
meson setup build --buildtype=debug -Db_sanitize=address
# run meson to build
meson compile -C build
# The generated files will be in build/
3.5 build AppImage package
cd xce/src
nix bundle --bundler github:ralismark/nix-appimage --option sandbox false .#xce
This will create all in one AppImage file which contains everything for package delivery.
4. misc
4.1. Windows remap ctrl and alt key
create a reg file, e.g. remapkey.reg
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Keyboard Layout]
"Scancode Map"=hex:00,00,00,00,00,00,00,00,05,00,00,00,38,00,1d,00,1d,00,38,00,38,e0,1d,e0,1d,e0,38,e0,00,00,00,00
then double click remapkey.reg to import it. Restart OS.