No description
Rongsong Shen
f4103e0efd
A job with no rusage[mem=...] request (reserved=0) was being SKIPPED entirely during reservation-vs-usage reconciliation, on the mistaken assumption that "no reservation" meant "nothing needs charging". It doesn't: this codebase's admission check has no live OS read at decision time (sched_check_host_satisfy_(), resource.c) -- it compares the worker's last-reported "mem" value against this scheduler's OWN tracked resInUse tally, built entirely from summed xce_res_account_t entries. Skipping an unreserved job left its real, live memory consumption permanently invisible to that tally -- an actual over-subscription risk (the scheduler could admit more onto a host than it can support, believing memory was free that a live process was genuinely using), not merely a display gap. Fix: charged = max(reserved, actual) applies to EVERY job, reserved or not. ensure_host_account_by_resname() (resource.c) now creates a fresh reserved=0 account entry (resolving residx via key_find() against core->resmgr, same pattern sched_update_res_accounts() already uses for a fresh account) instead of skipping when a job has no existing entry for a resource. Returns NULL (a genuine no-op) only when the resource isn't registered in the cluster's config at all. Rewrote resource-accounting.md to correct the mechanism it documented: "available" is NOT a live OS read (mem vs the similarly-named but static maxmem was worth naming explicitly too) -- it's worker's last-reported mem minus this scheduler's own resInUse tally, and that tally must include every job's real usage regardless of reservation. Also documented a known, pre-existing property surfaced while correcting this: since mem's own worker report already reflects real consumption and the scheduler's charge is a separate layer that doesn't get cleared on a fresh report, tracking can become conservative over time (under-utilization risk, never over- subscription) -- the same direction slots already accepts, and a separate, larger question than this fix's scope. Replaced test_reconcile_job_resource_usage_skips_when_no_mem_request (asserted the now-wrong skip behavior) with two tests: one proving an unreserved job's real usage is created and charged, one proving a genuine no-op when "mem" isn't a registered resource at all. Full scheduler suite: 55/55 passing, zero regressions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QxaSzHRB7pmYFp4cVnwkA |
||
|---|---|---|
| .claude | ||
| .kiro | ||
| .wolf | ||
| docs/superpowers/plans | ||
| raft | ||
| reports | ||
| scripts | ||
| src | ||
| .clang-format | ||
| .gitignore | ||
| .mcp.json | ||
| .opencode.json | ||
| CHANGES.md | ||
| CLAUDE.md | ||
| README.md | ||
1. commit 规则
- 每个人 fork 自己的 branch， 从自己的 branch 做 PR，review 完再 commit
2. code format
2.1. C
推荐使用 clang-format，公共配置放在源码里面 xce/.clang-format
（理论上直接使用源码里面 xce/.clang-format 文件格式不会变）
2.1.1. vscode 可以在配置中加上如下内容
"C_Cpp.clang_format_style": "WebKit",
"C_Cpp.clang_format_fallbackStyle": "WebKit",
2.1.2. vim & emacs
clang-format -style="{BasedOnStyle: webkit}" -i XX.c
2.2. golang
使用默认 gofmt
3. build environment and build (example of ubuntu)
3.1 build environment
- Install nix package management tool
sh <(curl -L https://nixos.org/nix/install) --daemon
- Edit /etc/nix/nix.conf to make sure
experimental-features = nix-command flakes
sandbox = true
sandbox-fallback = false
substituters = https://mirrors.ustc.edu.cn/nix-channels/store https://cache.nixos.org https://cache.nixos.org/
trusted-users = root <your account>
make sure that you have restarted nix-daemon service after you have changed /etc/nix/nix.conf
- Install socat and config ssh (for clone by ssh protocol)
nix profile add nixpkgs#socat
.ssh/config
Host gitea.shenrs.eu
HostName gitea.shenrs.eu
IdentityFile ~/.ssh/id_ed25519
ProxyCommand socat - openssl-connect:gitea.shenrs.eu:2022,snihost=gitea.shenrs.eu,verify=0
3.2 checkout source code
3.3 build (for package and release)
cd xce/src
# for build debug version
nix build --option sandbox false .#xcecore_debug
# for normal build
nix build --option sandbox false .#xcecore
You can find the generated binaries at =result= directory
3.4 build (for daily develop)
cd xce/src
nix develop
# using meson to generated build configuration (debug and address sanitize)
meson setup build --buildtype=debug -Db_sanitize=address
# run meson to build
meson compile -C build
# The generated files will be in build/
3.5 build AppImage package
cd xce/src
nix bundle --bundler github:ralismark/nix-appimage --option sandbox false .#xce
This will create all in one AppImage file which contains everything for package delivery.
4. misc
4.1. Windows remap ctrl and alt key
create a reg file, e.g. remapkey.reg
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Keyboard Layout]
"Scancode Map"=hex:00,00,00,00,00,00,00,00,05,00,00,00,38,00,1d,00,1d,00,38,00,38,e0,1d,e0,1d,e0,38,e0,00,00,00,00
then double click remapkey.reg to import it. Restart OS.