From 311b9cb0e092cd137ca8197c804a8e2f36fab5e5 Mon Sep 17 00:00:00 2001 From: Jonah Beckford <71855677+jonahbeckford@users.noreply.github.com> Date: Thu, 3 Aug 2023 18:19:55 -0700 Subject: [PATCH] Fix clang-tidy bugprone-macro-parentheses Correct the definition of capnp_use(x) macro. > recommended to surround macro arguments > in the replacement list with parentheses. This > ensures that the argument value is calculated > properly. --- compiler/c++.capnp.c | 2 +- compiler/c.capnp.c | 2 +- compiler/capnpc-c.c | 2 +- compiler/schema.capnp.c | 2 +- compiler/test.capnp.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/compiler/c++.capnp.c b/compiler/c++.capnp.c index f362d4b..f088ac4 100644 --- a/compiler/c++.capnp.c +++ b/compiler/c++.capnp.c @@ -2,7 +2,7 @@ /* AUTO GENERATED - DO NOT EDIT */ #ifdef __GNUC__ # define capnp_unused __attribute__((unused)) -# define capnp_use(x) (void) x; +# define capnp_use(x) (void) (x); #else # define capnp_unused # define capnp_use(x) diff --git a/compiler/c.capnp.c b/compiler/c.capnp.c index 205311c..c94af4c 100644 --- a/compiler/c.capnp.c +++ b/compiler/c.capnp.c @@ -2,7 +2,7 @@ /* AUTO GENERATED - DO NOT EDIT */ #ifdef __GNUC__ # define capnp_unused __attribute__((unused)) -# define capnp_use(x) (void) x; +# define capnp_use(x) (void) (x); #else # define capnp_unused # define capnp_use(x) diff --git a/compiler/capnpc-c.c b/compiler/capnpc-c.c index 649690f..a624890 100644 --- a/compiler/capnpc-c.c +++ b/compiler/capnpc-c.c @@ -1597,7 +1597,7 @@ int main() { fprintf(srcf, "/* AUTO GENERATED - DO NOT EDIT */\n"); fprintf(srcf, "#ifdef __GNUC__\n" "# define capnp_unused __attribute__((unused))\n" - "# define capnp_use(x) (void) x;\n" + "# define capnp_use(x) (void) (x);\n" "#else\n" "# define capnp_unused\n" "# define capnp_use(x)\n" diff --git a/compiler/schema.capnp.c b/compiler/schema.capnp.c index b49645f..8bcbcc5 100644 --- a/compiler/schema.capnp.c +++ b/compiler/schema.capnp.c @@ -2,7 +2,7 @@ /* AUTO GENERATED - DO NOT EDIT */ #ifdef __GNUC__ # define capnp_unused __attribute__((unused)) -# define capnp_use(x) (void) x; +# define capnp_use(x) (void) (x); #else # define capnp_unused # define capnp_use(x) diff --git a/compiler/test.capnp.c b/compiler/test.capnp.c index 6962a3d..97a026c 100644 --- a/compiler/test.capnp.c +++ b/compiler/test.capnp.c @@ -2,7 +2,7 @@ /* AUTO GENERATED - DO NOT EDIT */ #ifdef __GNUC__ # define capnp_unused __attribute__((unused)) -# define capnp_use(x) (void) x; +# define capnp_use(x) (void) (x); #else # define capnp_unused # define capnp_use(x)