wdgzyjx/myxce
1
0
Fork 0
forked from lei.chen/myxce
Code Pull requests Activity

docs: log task 3.3's config-push endpoint race as bug-1381

Browse source 
Cross-references bug-1381 in tasks.md and the ha.c configpush flag comment.
No code behavior change -- push_config_transport_only's race (raw standby
endpoint pointers read/written by unprotected pthread_create workers,
independent of the offload flag) is a distinct, still-open blocker from
bug-1197/bug-1376 (both closed in the prior commit).
This commit is contained in:
Rongsong Shen 2026-07-02 07:24:21 +00:00
parent 1ce007814d
commit 02e46f6ba1
3 changed files with 996 additions and 958 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/controller/ha.c
View file

@ -4349,11 +4349,11 @@ int ha_snapshot_offload_enabled(void)
* that reads/writes those endpoints unprotected for up to CONF_PUSH_TIMEOUT_MS
* — a race that exists TODAY regardless of this flag (the pthread-per-standby
* fan-out is not the io_worker, so "runs inline on io_worker" does not
* actually serialize it against a concurrent RDHUP teardown). Needs its own
* fix (ref every standby ep for the fan-out's duration, or route through the
* per-ep block primitive) before flipping ON — tracked separately, not
* fixed by this task. Until then this offload is exercised only by unit
* tests with a stable (or absent) endpoint set.
* actually serialize it against a concurrent RDHUP teardown). Logged as
* bug-1381 (open). Needs its own fix (ref every standby ep for the fan-out's
* duration, or route through the per-ep block primitive) before flipping ON
* — tracked separately, not fixed by this task. Until then this offload is
* exercised only by unit tests with a stable (or absent) endpoint set.
*
* ONLY the requester-less call sites (post-election promotion, heartbeat-driven
* HA_REPL_PUSH_CONFIG) route through this flag; the admin-upgrade barrier path