feat(ha-commit-barrier-rollout): mark_job_* idempotency/ordering guards (task 6.2)

Guards at the top of mark_job_start/finish/update under the caller's
job lock, before BEFORE_EVENT: duplicate (FINISH on terminal) → INFO
no-op skipping the AFTER_EVENT hook (no WAL append, lsn frozen);
terminal→non-terminal backward (START/UPDATE) → WARN reject preserving
state. Shared job_state_is_backward predicate provably admits every
production forward merge (PDONE/PERR/suspend bit-OR) while rejecting
overwrites. mark_job_fail intentionally unguarded (its merges are
always terminal-forward; job_ctrl pre-gates terminal). 5/5 guard tests
green; full job-lifecycle suite green; census 0 FAIL.
This commit is contained in:
Rongsong Shen 2026-06-13 04:54:36 +00:00
parent 2308389eb1
commit 5522d6f274
3 changed files with 76 additions and 1 deletions

View file

@ -1018,3 +1018,9 @@
| 04:18 | task 6.1 review: RED tests for mark_job_* guards verified | test_commit_barrier_reply.c | APPROVED — 22/3 group, 508/3 census, boundary clean | ~38k |
| 21:19 | Edited .kiro/specs/ha-commit-barrier-rollout/tasks.md | inline fix | ~13 |
| 21:19 | Edited .kiro/specs/ha-commit-barrier-rollout/tasks.md | modified 2() | ~243 |
| 21:23 | Edited src/controller/job.c | modified job_state_is_terminal() | ~330 |
| 21:23 | Edited src/controller/job.c | added 1 condition(s) | ~224 |
| 21:24 | Edited src/controller/job.c | added 1 condition(s) | ~212 |
| 21:24 | Edited src/controller/job.c | added 2 condition(s) | ~294 |
| 04:37 | task 6.2: mark_job_* transition guards (dup no-op / backward reject / forward merge preserved) | src/controller/job.c | 22 ctrl tests 0 fail, 5 guard tests GREEN | ~14k |
| 21:54 | Edited .kiro/specs/ha-commit-barrier-rollout/tasks.md | inline fix | ~11 |