test(ha-commit-engine): full regression green + legacy-path audit (task 6.1)

Fixed the 3 bug-411 baseline failures honestly: stale timeout
expectation updated to the reject-on-timeout contract (engine-wired
fixture, killing power retained); two healthy-primary gate fixtures
populated with standby_endpoints (gate logic untouched). Census: 46
groups / 467 tests / 0 failures standalone under default ASAN.
Audit (reviewer-confirmed, recorded in tasks.md): no production walAck
path reaches the deprecated acked_lsn>0 counting or n_active==0
short-circuit except the documented LSN-0 first entry. Leak inventory
for 6 groups documented as follow-up.
This commit is contained in:
Rongsong Shen 2026-06-12 03:32:19 +00:00
parent f0d6074d4e
commit 95a10cedf3
6 changed files with 785 additions and 295 deletions

File diff suppressed because it is too large Load diff

View file

@ -953,3 +953,11 @@
| 00:25 | Adversarial review of ha-commit-engine task 5.3 (init wiring + sync-append switch): APPROVED — full census exactly 3 baseline fails, RED 32/34→34/34 verified via temp worktree at 6600fd5 | cluster.c, persist.c, cluster_def.h, test_p2_integration.c | approved | ~45k |
| 17:15 | Edited .kiro/specs/ha-commit-engine/tasks.md | inline fix | ~20 |
| 17:16 | Edited .kiro/specs/ha-commit-engine/tasks.md | modified race() | ~342 |
| 17:23 | Edited src/controller/testsuite/test_p2_integration.c | modified test_committed_lsn_does_not_advance_on_timeout() | ~858 |
| 17:23 | Edited src/controller/testsuite/test_ha_repl_ack.c | modified test_repl_ack_after_promote_gate_allows_jobsub() | ~446 |
| 17:23 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | modified test_rdhup_primary_dispatch_gate_opens() | ~404 |
| 17:24 | Edited src/controller/testsuite/test_ha_rdhup_integration.c | 7→10 lines | ~112 |
| 17:24 | Edited src/controller/testsuite/test_ha_repl_ack.c | 4→5 lines | ~27 |
| 00:36 | task 6.1 validation: full controller suite 46 groups / 467 tests 0 failures; 3 bug-411 baseline tests fixed (test files only); legacy-path audit clean; 6 pre-existing leak groups inventoried | test_p2_integration.c, test_ha_repl_ack.c, test_ha_rdhup_integration.c | success | ~60k |
| 17:51 | Edited .kiro/specs/ha-commit-engine/tasks.md | inline fix | ~19 |
| 17:51 | Edited .kiro/specs/ha-commit-engine/tasks.md | modified RECORD() | ~433 |