From ba6fdc575e86a9546cc130fdd24eb314683ab055 Mon Sep 17 00:00:00 2001 From: Rongsong Shen Date: Tue, 21 Jul 2026 04:52:25 +0000 Subject: [PATCH] =?UTF-8?q?feat(controller):=20clusterconfig-schema-split?= =?UTF-8?q?=20task=203=20=E2=80=94=20fix=20test=20fixtures=20for=20shrunk?= =?UTF-8?q?=20cluster=5Fconfig=5Ft?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Drops the two cfg.port = ...; struct-literal assignments in test_commit_barrier_rollout.c and test_config_repl.c (removed field, task 1.2). Repo-wide sweep found no other genuine cluster_config_t literal referencing a removed field. Full clean build now succeeds (153/153 targets) and controller_unit_test passes 976/976 with zero new failures. --- .kiro/specs/clusterconfig-schema-split/tasks.md | 2 +- src/controller/testsuite/test_commit_barrier_rollout.c | 1 - src/controller/testsuite/test_config_repl.c | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.kiro/specs/clusterconfig-schema-split/tasks.md b/.kiro/specs/clusterconfig-schema-split/tasks.md index fc76eda..78bd3cb 100644 --- a/.kiro/specs/clusterconfig-schema-split/tasks.md +++ b/.kiro/specs/clusterconfig-schema-split/tasks.md @@ -53,7 +53,7 @@ - _Depends: 2.1_ - _Boundary: myconf.c, config_repl.c_ -- [ ] 3. (P) Update struct-literal test fixtures for the shrunk `cluster_config_t` +- [x] 3. (P) Update struct-literal test fixtures for the shrunk `cluster_config_t` - Drop the `cfg.port = 9990;` literal at `test_commit_barrier_rollout.c:1359` - Drop the `cfg.port = 9991;` literal at `test_config_repl.c:983` - Grep the full tree for any other direct `cluster_config_t` struct-literal reference to a removed field and update each the same way diff --git a/src/controller/testsuite/test_commit_barrier_rollout.c b/src/controller/testsuite/test_commit_barrier_rollout.c index a9860d3..c976530 100644 --- a/src/controller/testsuite/test_commit_barrier_rollout.c +++ b/src/controller/testsuite/test_commit_barrier_rollout.c @@ -1356,7 +1356,6 @@ static uint8_t *cb5_make_config_blob(size_t *len_out) memset(&cfg, 0, sizeof(cfg)); cfg.clustername = (char *)"cb5-upgrade"; - cfg.port = 9990; cfg.config_generation = 1; capn_init_malloc(&cap); diff --git a/src/controller/testsuite/test_config_repl.c b/src/controller/testsuite/test_config_repl.c index ae61fce..3be6808 100644 --- a/src/controller/testsuite/test_config_repl.c +++ b/src/controller/testsuite/test_config_repl.c @@ -980,7 +980,6 @@ static uint8_t *t43_make_config_blob(size_t *len_out) memset(&cfg, 0, sizeof(cfg)); cfg.clustername = (char *)"t43-upgrade"; - cfg.port = 9991; cfg.config_generation = 1; capn_init_malloc(&cap);