forked from lei.chen/myxce
Rongsong Shen
877741d008
Multi-persona review (coherence, feasibility, adversarial, product-lens) identified 25 findings. Applied 14 fixes: - Fix makeSelectNode key_add return code bug (rc2 → rc3) - Resolve derefSelectNode contradiction: remove function and refcount field, adopt GC-only reclamation model - Add boolean_literal grammar rule (true/false keywords) and SEL_BOOL_LITERAL node type + bval union member - Clarify transform pipeline: makeSelectNode does commutativity swap internally; flattening/const-fold are post-parse tree walks - Complete const-fold rules with annihilation laws - Add SEL_NUM bit-cast semantics (±0 distinction, NaN payloads) - Add resmgr=NULL fallback behavior spec - Add runtime type safety assertions for debug builds - Add GC trigger and session-based scheduler context - Fix section numbering gap (renumber §5.6 → §5.5) - Add gc_sweep_select_nodes/gc_mark_tree to Phase 2 declarations - Update kill_primary_resreq instruction for GC model - Add any keyword semantic inconsistency note (!= vs !(==)) 4 open issues remain for implementation phase: string resource interface, single-goroutine enforcement, kvtab iteration API, CSE benefit quantification. |
||
|---|---|---|
| .. | ||
| autoscaler | ||
| controller | ||
| docs | ||
| frontend | ||
| include | ||
| lib | ||
| nixSupport | ||
| scheduler | ||
| schema | ||
| tools | ||
| worker | ||
| flake.lock | ||
| flake.nix | ||
| meson.build | ||
| meson.options | ||