forked from lei.chen/myxce
No description
Rongsong Shen
b77d412256
ROOT CAUSE (confirmed via live instrumentation — NOT a durability violation): ha_enter_real_election truncated the WAL to last_known_committed_lsn BEFORE the vote. That watermark lags the true commit point (the primary committed LSN 2-5 on a durable majority then died before a heartbeat carried committed=5 to the standby), so the cutoff was 1; persist_truncate_wal_above -> clamp_durable_lsn lowered the standby's durable_lsn 5->1, physically destroying durably-committed entries before the election even computed the safe point. The candidate then advertised floor=1, safe_committed_lsn=1, and the post-election truncate kept only LSN 1. This directly violated the documented rule: 'Never use last_known_committed _lsn for truncation — it may be stale.' FIX: delete the premature truncate. The candidate keeps its full durable log; the ONLY truncates are now the authoritative votes-derived post-election persist_truncate_wal_above(safe_committed_lsn) (raft_cb_become_leader) + the library on_truncate_from (term,lsn) reconcile — both before any commit under the new leader. SAFE (reviewer-verified): a divergent uncommitted tail can only exist at a stale/lower term (single-writer); the library's term-primary (lastLogTerm, lastLogIndex) freshness gate denies such a candidate — correct now that task 3.4 fixed the term axis (the prerequisite). No divergent entry can win-and-commit; no bug-339 election-loop. 177 unit tests + a RED-proven regression test. LIVE: clean failover now preserves committed jobs — walcompare committed-prefix identical across all 3 members, both jobs present on disk, across multiple runs. (Residual harness EXIT 1 is the SEPARATE pre-existing libxce client bug-854: client can't reach the live primary when the dead node is first in the masters list — a client-discovery defect, orthogonal to server-side data safety.) |
||
|---|---|---|
| .claude | ||
| .kiro | ||
| .wolf | ||
| docs/superpowers/plans | ||
| ha/data | ||
| raft | ||
| src | ||
| .clang-format | ||
| .gitignore | ||
| .mcp.json | ||
| .opencode.json | ||
| CLAUDE.md | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| uninstall-code-review-graph.sh | ||
1. commit 规则
- 每个人 fork 自己的 branch， 从自己的 branch 做 PR，review 完再 commit
2. code format
2.1. C
推荐使用 clang-format，公共配置放在源码里面 xce/.clang-format
（理论上直接使用源码里面 xce/.clang-format 文件格式不会变）
2.1.1. vscode 可以在配置中加上如下内容
"C_Cpp.clang_format_style": "WebKit",
"C_Cpp.clang_format_fallbackStyle": "WebKit",
2.1.2. vim & emacs
clang-format -style="{BasedOnStyle: webkit}" -i XX.c
2.2. golang
使用默认 gofmt
3. build environment and build (example of ubuntu)
3.1 build environment
- Install nix package management tool
sh <(curl -L https://nixos.org/nix/install) --daemon
- Edit /etc/nix/nix.conf to make sure
experimental-features = nix-command flakes
sandbox = true
sandbox-fallback = false
substituters = https://mirrors.ustc.edu.cn/nix-channels/store https://cache.nixos.org https://cache.nixos.org/
trusted-users = root <your account>
make sure that you have restarted nix-daemon service after you have changed /etc/nix/nix.conf
- Install socat and config ssh (for clone by ssh protocol)
nix profile add nixpkgs#socat
.ssh/config
Host gitea.shenrs.eu
HostName gitea.shenrs.eu
IdentityFile ~/.ssh/id_ed25519
ProxyCommand socat - openssl-connect:gitea.shenrs.eu:2022,snihost=gitea.shenrs.eu,verify=0
3.2 checkout source code
3.3 build (for package and release)
cd xce/src
# for build debug version
nix build --option sandbox false .#xcecore_debug
# for normal build
nix build --option sandbox false .#xcecore
You can find the generated binaries at =result= directory
3.4 build (for daily develop)
cd xce/src
nix develop
# using meson to generated build configuration (debug and address sanitize)
meson setup build --buildtype=debug -Db_sanitize=address
# run meson to build
meson compile -C build
# The generated files will be in build/
3.5 build AppImage package
cd xce/src
nix bundle --bundler github:ralismark/nix-appimage --option sandbox false .#xce
This will create all in one AppImage file which contains everything for package delivery.
4. misc
4.1. Windows remap ctrl and alt key
create a reg file, e.g. remapkey.reg
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Keyboard Layout]
"Scancode Map"=hex:00,00,00,00,00,00,00,00,05,00,00,00,38,00,1d,00,1d,00,38,00,38,e0,1d,e0,1d,e0,38,e0,00,00,00,00
then double click remapkey.reg to import it. Restart OS.