forked from lei.chen/myxce
No description
Rongsong Shen
c4fd3e1c8f
Live symptom: every write (jobsub) on a healthy 3-node cluster returned E_XCE_NOT_READY (10013) — the primary had no write quorum and committed_lsn was stuck at 0, even though both standbys were connected, heartbeating, streamed, and the primary RECEIVED their WAL ACKs. Root cause: raft_cb_become_leader registers a surviving vote endpoint with repl_add_standby only when ectx->votes[i].peer != NULL, but raft_cb_send_vote_request set votes[i].ep and never votes[i].peer. So at promotion the guard failed, the standbys were added to ha->standby_endpoints (streaming) but NOT to the replicator array c->persist.repl.standbys[] (commit/quorum). Consequently repl_on_ack could not find the ack's ep (slot_idx=-1) -> commit_on_ack never ran -> committed_lsn never advanced; majority_candidate/repl_active_standby_count saw 0 standbys -> no write quorum -> the dispatch gate rejected every write with -XCE_ERR_NOT_READY. (Streaming/persistence worked, which masked it: reslist/workerlist succeed, only writes fail.) Fix: raft_cb_send_vote_request now also sets ectx->votes[votes_idx].peer = peer (the &candidates[peer_idx] pointer already computed for the connect) at the same success site as .ep. peer points into the persistent myconf candidates[]; repl_add_standby copies host/port, so no lifetime dependency. Promotion now registers each surviving vote ep -> standbys enter the replicator -> WAL ACKs advance committed_lsn -> own-term gate opens -> write quorum established. TDD: drive the real raft_cb_become_leader over a real persist/repl/commit fixture and assert repl_active_standby_count post-promotion == N when votes[].peer is set, == 0 when NULL (the bug). Full controller suite green under ASAN; election/commit/ repl/wire untouched apart from the one-line .peer assignment + a test seam. |
||
|---|---|---|
| .claude | ||
| .kiro | ||
| .wolf | ||
| docs/superpowers/plans | ||
| ha/data | ||
| raft | ||
| src | ||
| .clang-format | ||
| .gitignore | ||
| CLAUDE.md | ||
| README.md | ||
1. commit 规则
- 每个人 fork 自己的 branch， 从自己的 branch 做 PR，review 完再 commit
2. code format
2.1. C
推荐使用 clang-format，公共配置放在源码里面 xce/.clang-format
（理论上直接使用源码里面 xce/.clang-format 文件格式不会变）
2.1.1. vscode 可以在配置中加上如下内容
"C_Cpp.clang_format_style": "WebKit",
"C_Cpp.clang_format_fallbackStyle": "WebKit",
2.1.2. vim & emacs
clang-format -style="{BasedOnStyle: webkit}" -i XX.c
2.2. golang
使用默认 gofmt
3. build environment and build (example of ubuntu)
3.1 build environment
- Install nix package management tool
sh <(curl -L https://nixos.org/nix/install) --daemon
- Edit /etc/nix/nix.conf to make sure
experimental-features = nix-command flakes
sandbox = true
sandbox-fallback = false
substituters = https://mirrors.ustc.edu.cn/nix-channels/store https://cache.nixos.org https://cache.nixos.org/
trusted-users = root <your account>
make sure that you have restarted nix-daemon service after you have changed /etc/nix/nix.conf
- Install socat and config ssh (for clone by ssh protocol)
nix profile add nixpkgs#socat
.ssh/config
Host gitea.shenrs.eu
HostName gitea.shenrs.eu
IdentityFile ~/.ssh/id_ed25519
ProxyCommand socat - openssl-connect:gitea.shenrs.eu:2022,snihost=gitea.shenrs.eu,verify=0
3.2 checkout source code
3.3 build (for package and release)
cd xce/src
# for build debug version
nix build --option sandbox false .#xcecore_debug
# for normal build
nix build --option sandbox false .#xcecore
You can find the generated binaries at =result= directory
3.4 build (for daily develop)
cd xce/src
nix develop
# using meson to generated build configuration (debug and address sanitize)
meson setup build --buildtype=debug -Db_sanitize=address
# run meson to build
meson compile -C build
# The generated files will be in build/
3.5 build AppImage package
cd xce/src
nix bundle --bundler github:ralismark/nix-appimage --option sandbox false .#xce
This will create all in one AppImage file which contains everything for package delivery.
4. misc
4.1. Windows remap ctrl and alt key
create a reg file, e.g. remapkey.reg
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Keyboard Layout]
"Scancode Map"=hex:00,00,00,00,00,00,00,00,05,00,00,00,38,00,1d,00,1d,00,38,00,38,e0,1d,e0,1d,e0,38,e0,00,00,00,00
then double click remapkey.reg to import it. Restart OS.