Rongsong Shen
d26ff8870d
The buglog was one 27K-line JSON file whose fields covered only symptom,
root cause and fix, as free text: 2% of entries named the code version a
bug was found on, 12% the build profile, 36% a way to reproduce, and 58% of
the file was OpenWolf hook auto-detections ("Missing guard clause",
"Function not marked async" on .md files).
- .claude/skills/buglog/bug-record.md: the record standard. Eight
sections (Summary as the title, Description, Environment, Reproduction;
Root cause, Fix, Verification, References once fixed), each with the
content it must contain -- e.g. Environment needs the OS, the libc the
failing binary loads (from its ELF interpreter: glibc 2.42 in the nix
shell vs 2.40 on the host), toolchain, build profile and commit.
- .wolf/bugs/<id>.md: 500 records migrated from buglog.json; every field
verified to round-trip. They carry legacy: true and an explicit "not
recorded" where the old log had no such field; component derived from
file paths, severity from keywords (else unknown), fix_commits from
hashes in status_note/fix that git resolves (91 of 463 fixed).
- .wolf/buglog-archive.json: the 710 hook auto-detections, verbatim.
- .wolf/buglog.json is now an index generated from the records, keeping
the fields OpenWolf's hooks and `openwolf bug search` read.
- scripts/buglog.py rewritten: new (template + Environment collected from
the machine and --binary), check, status (refuses a status the record
doesn't support; fixed needs Root cause, Fix, Verification and
--commit hashes git resolves), note, recur, set, show, list, triage,
env, index. 29 unittest cases in scripts/tests/test_buglog.py.
- scripts/git-hooks/pre-commit runs `check --staged`: incomplete staged
records, a legacy record hand-changed to fixed without the fix-time
sections, a new record claiming legacy: true, or a stale index refuse
the commit.
- scripts/gitea-sync.py reads the records: issue body = the record's
sections plus linked fix commits (origin remote, GITEA_COMMIT_REPO to
override), and a body hash so an issue's text is refreshed when the
record changes.
- bug-1866 rewritten to the full standard as the worked example.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
38 lines
2.1 KiB
Markdown
38 lines
2.1 KiB
Markdown
---
|
|
id: "bug-1629"
|
|
status: "fixed"
|
|
status_updated: "2026-09-24"
|
|
status_note: ""
|
|
component: "scheduler"
|
|
severity: "crash"
|
|
timestamp: "2026-08-23T08:12:20"
|
|
last_seen: "2026-09-19T09:00:00Z"
|
|
occurrences: 1
|
|
files: ["src/scheduler/testsuite/test_scheduler_dispatch_commit.c"]
|
|
tags: ["scheduler", "testsuite", "zarray", "resource-accounting", "asan", "scheduler-dispatch-commit", "test-fixture"]
|
|
related: []
|
|
legacy: true
|
|
---
|
|
|
|
# bug-1629: AddressSanitizer SEGV in zarray_get_ex (lib/zarray.c:332) when a test-fixture…
|
|
|
|
## Description
|
|
AddressSanitizer SEGV in zarray_get_ex (lib/zarray.c:332) when a test-fixture xce_res_account_t.residx was never resolved from -1
|
|
|
|
## Environment
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Reproduction
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Root cause
|
|
zarray_get_ex() only guards idx >= array->caps before indexing array->data[idx]; it does NOT guard idx < 0. sched_update_res_accounts() (resource.c) resolves xce_res_account_t.residx from -1 to a real index via key_find()/add_vres() against core->resmgr ONLY when the host lookup (sched_get_worker()) and the surrounding call chain actually run to completion; if a test fixture never pre-registers the resource name in core->resmgr, sched_update_account()/sched_update_res_accounts() silently swallow the resolution failure (return values are discarded by sched_update_account()) and residx stays -1. A -1 index then passes the 'idx >= array->caps' bounds check (false, since caps starts at 0 too) and falls through to array->data[-1], an out-of-bounds/underflow read that ASAN reports as a high-address SEGV rather than a clean bounds error.
|
|
|
|
## Fix
|
|
In the test fixture, pre-register the resource with add_vres(&vres, core.resmgr, RES_NAME, 0) BEFORE calling the real charging path, and use the returned (non-negative) index for get_resvals()/put_resvals() calls, instead of relying on the production code's lazy first-use resolution path inside a minimal test fixture that never loads real resource config.
|
|
|
|
## Verification
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## References
|
|
_Not recorded (migrated from buglog.json)._
|