Rongsong Shen
d26ff8870d
The buglog was one 27K-line JSON file whose fields covered only symptom,
root cause and fix, as free text: 2% of entries named the code version a
bug was found on, 12% the build profile, 36% a way to reproduce, and 58% of
the file was OpenWolf hook auto-detections ("Missing guard clause",
"Function not marked async" on .md files).
- .claude/skills/buglog/bug-record.md: the record standard. Eight
sections (Summary as the title, Description, Environment, Reproduction;
Root cause, Fix, Verification, References once fixed), each with the
content it must contain -- e.g. Environment needs the OS, the libc the
failing binary loads (from its ELF interpreter: glibc 2.42 in the nix
shell vs 2.40 on the host), toolchain, build profile and commit.
- .wolf/bugs/<id>.md: 500 records migrated from buglog.json; every field
verified to round-trip. They carry legacy: true and an explicit "not
recorded" where the old log had no such field; component derived from
file paths, severity from keywords (else unknown), fix_commits from
hashes in status_note/fix that git resolves (91 of 463 fixed).
- .wolf/buglog-archive.json: the 710 hook auto-detections, verbatim.
- .wolf/buglog.json is now an index generated from the records, keeping
the fields OpenWolf's hooks and `openwolf bug search` read.
- scripts/buglog.py rewritten: new (template + Environment collected from
the machine and --binary), check, status (refuses a status the record
doesn't support; fixed needs Root cause, Fix, Verification and
--commit hashes git resolves), note, recur, set, show, list, triage,
env, index. 29 unittest cases in scripts/tests/test_buglog.py.
- scripts/git-hooks/pre-commit runs `check --staged`: incomplete staged
records, a legacy record hand-changed to fixed without the fix-time
sections, a new record claiming legacy: true, or a stale index refuse
the commit.
- scripts/gitea-sync.py reads the records: issue body = the record's
sections plus linked fix commits (origin remote, GITEA_COMMIT_REPO to
override), and a body hash so an issue's text is refreshed when the
record changes.
- bug-1866 rewritten to the full standard as the worked example.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
38 lines
2.6 KiB
Markdown
38 lines
2.6 KiB
Markdown
---
|
|
id: "bug-1722"
|
|
status: "fixed"
|
|
status_updated: "2026-09-24"
|
|
status_note: ""
|
|
component: "lib"
|
|
severity: "crash"
|
|
timestamp: "2026-08-27T00:00:00Z"
|
|
last_seen: "2026-09-19T09:00:00Z"
|
|
occurrences: 1
|
|
files: ["src/lib/xcealloc.c"]
|
|
tags: ["heap-buffer-overflow", "asan", "xcealloc", "multi-host-job", "make_job_account", "make_host_allocs", "pre-existing"]
|
|
related: ["bug-1621"]
|
|
legacy: true
|
|
---
|
|
|
|
# bug-1722: AddressSanitizer heap-buffer-overflow in make_job_account() (src/lib/xcealloc.c:188), WRITE of…
|
|
|
|
## Description
|
|
AddressSanitizer heap-buffer-overflow in make_job_account() (src/lib/xcealloc.c:188), WRITE of size 8 -- found while verifying viability of a proposed scheduler snapshot-allocation-capture fix, not user-reported.
|
|
|
|
## Environment
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Reproduction
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Root cause
|
|
make_job_account() allocates account->accounts via calloc(1, sizeof(xce_host_account_t*)) -- room for exactly 1 host pointer -- but its own loop writes account->accounts[i] for i in [0, jalloc->nhosts), overflowing the heap allocation for any job spanning more than one host. Already reachable from live production dispatch (core_events.c:262, schedobj.c:207, scheduler.c:1444) for any multi-host job, not introduced by this session. Sibling function make_host_allocs() (xcealloc.c:134) has the identical bug shape (calloc(1, ...) vs a loop writing hallocs[i] up to nhosts-1), though every current call site happens to pass nhosts=1 so it has never actually overflowed in production -- still a live footgun for any future 2+-host caller of a public, exported helper.
|
|
|
|
## Fix
|
|
FIXED, TDD RED->GREEN. New test_xcealloc.c (src/lib/testsuite/, wired into libxce_test_src in meson.build + test.c) drives a 2-host xce_job_alloc_t through make_job_account(), reproducing the exact ASAN heap-buffer-overflow at xcealloc.c:188 pre-fix. Fix: both calloc(1, ...) call sites changed to calloc((size_t)nhosts, ...) / calloc((size_t)jalloc->nhosts, ...) -- xcealloc.c:134 (make_host_allocs) and xcealloc.c:180-181 (make_job_account). Also added a covering test for make_host_allocs multi-host correctness. Verified: full libxce test suite 303/303 (was 301, +2 new), scheduler suite 53/54 (1 pre-existing unrelated bug-1560 flake, test_recordstart_symlink_escape_replies_error), controller suite 1211/1213 (2 pre-existing unrelated bug-1561 overlayfs flakes, test_conf_trim_keeps_only_n_versions/test_conf_get_saved_tag_no_config) -- zero regressions, zero new failures.
|
|
|
|
## Verification
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## References
|
|
- Related: bug-1621
|