54 lines
2.8 KiB
Markdown
54 lines
2.8 KiB
Markdown
---
|
|
id: "bug-1965"
|
|
status: "fixed"
|
|
status_updated: "2026-10-10"
|
|
status_note: ""
|
|
component: "build"
|
|
severity: "noise"
|
|
timestamp: "2026-10-10T10:16:14Z"
|
|
last_seen: "2026-10-10T10:16:14Z"
|
|
occurrences: 1
|
|
files: ["src/tools/xce-build.sh"]
|
|
tags: ["build", "tests", "apiserver"]
|
|
related: []
|
|
fix_commits: ["387cc994"]
|
|
gitea_issue: 396
|
|
gitea_synced_status: "fixed"
|
|
gitea_synced_hash: "5bf81a74e44c"
|
|
---
|
|
|
|
# bug-1965: xce-build.sh apiserver skips the middleware, router and cmd Go test packages
|
|
|
|
## Description
|
|
**Observed:** (source reading; follow-up of the 2026-10-10 P0 fixes (bug-1936..1957))
|
|
`xce-build.sh` runs `go test ./store/... ./utils/... ./controllers/... ./backend/...` for the apiserver; `./middleware/...`, `./router/...`, `./cmd/...` (which hold several security tests since bug-1945..1952) are never run by the build.
|
|
|
|
**Expected:** The build runs every apiserver test package.
|
|
**Impact:** Regressions in middleware/router/cmd tests go unnoticed by `/xce-build`.
|
|
**Found by:** follow-up of the 2026-10-10 P0 fixes (bug-1936..1957)
|
|
## Environment
|
|
- OS: no /etc/os-release; Docker container; NixOS kernel; kernel Linux 6.18.33 x86_64
|
|
- libc: glibc 2.42-47 (interpreter /nix/store/wb6rhpznjfczwlwx23zmdrrw74bayxw4-glibc-2.42-47/lib/ld-linux-x86-64.so.2)
|
|
- Toolchain: gcc (GCC) 15.2.0, meson 1.9.1
|
|
- Build: asan (xce.build)
|
|
- Code: scheduler-framework @ 19be145d-dirty
|
|
- Deployment: any (found by source reading; confirmed by the RED test of the fix)
|
|
|
|
## Reproduction
|
|
1. Read `src/tools/xce-build.sh` (apiserver go test line); break a middleware test and run `/xce-build apiserver`: it passes.
|
|
- Frequency: deterministic (by code reading; confirmed by the RED test of the fix)
|
|
- Evidence: the code sites quoted in Description; no logs kept.
|
|
## Root cause
|
|
`src/tools/xce-build.sh` listed `./store/... ./utils/... ./controllers/... ./backend/...` for the apiserver Go tests, so `cmd`, `middleware`, `models` and `router` never ran in the build. Pre-existing.
|
|
|
|
## Fix
|
|
Both apiserver `go test` lines (components `apiserver` and `all`) now run `./...` (vendor excluded automatically).
|
|
|
|
## Verification
|
|
- Test: With a temporary deliberately failing middleware test (not committed): the old script exited 0 without running middleware; the new script exited 1 with `--- FAIL: TestBug1965DeliberatelyBroken` / `FAIL apiserver/middleware`. The merged-branch `all` build log shows `ok apiserver/cmd`, `middleware`, `models`, `router`.
|
|
- Suites: `xce-build.sh all asan xce.build --incremental` on the merged branch, 2026-10-10: C suites Ok 157 / Fail 0; frontend Go tests ok (the build now also runs apiserver cmd, middleware, models and router)
|
|
- Live: n/a: unit/fixture-level verification; no live deployment was run
|
|
|
|
## References
|
|
- Fix commits: `387cc994` (on `scheduler-framework`)
|
|
- Found as a follow-up of the 2026-10-10 P0 fixes (bug-1936..1957)
|