- .claude/settings.json: worktree.baseRef = "head"
- .kiro/specs/scheduler-core/.solomd: session tracking state
- .wolf/{anatomy,cerebrum,memory,token-ledger}.json, hooks/_session.json:
accumulated OpenWolf bookkeeping (includes this session's fmt_jobid work)
- .gitignore: ignore Python __pycache__/*.pyc (scripts/gitea-sync.py) and
.agent-shell/ (session transcripts can capture raw env dumps/secrets --
one already had a live-looking ANTHROPIC_API_KEY in a captured `env`
output; excluded from this commit entirely, never checked in)
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
100 KiB
Cerebrum
OpenWolf's learning memory. General, reusable knowledge only — bug-specific history lives in .wolf/buglog.json, not here. Do not edit manually unless correcting an error. Last updated: 2026-08-16 (condensed from a ~40k-token file; see .wolf/buglog.json for full bug history)
User Preferences
- Run soak tests with specific round counts and deploy directories for precise regression tracking.
- Prefer parallel agent runs for independent analysis work; sequential for dependent tasks.
- Keep test logs for analysis, don't skip intermediate output even if a test hangs.
Key Learnings
-
xcecli Cobra rootCmd location:
src/frontend/xcecli/cmd/main.goimportscmd "xcecli/router"(the import alias iscmd, but the actual package lives atxcecli/router/router.go, package-namedcmd). Cobra'srootCmdis declared there as an unexported package-level var (var rootCmd = &cobra.Command{...}, router.go:21).The only exported symbol is— SUPERSEDED, resolved by build-time-versioning task 4.5 (commitExecute(cm *config.ConfigManager) error, which takes no version param... boundary conflictfb09afe) and confirmed still true as of dirty-content-fingerprint task 4.5 (2026-08-21):Executewas extended toExecute(cm *config.ConfigManager, version string) error, which itself setsrootCmd.Version = version(router.go:29-34) beforerootCmd.Execute(). main.go now composes the full version string (GitCommit/BuildTime, plus task 4.5'scomposeVersionDisplay(GitCommit, DirtyFingerprint)strip-and-append) and passes it intocmd.Execute(configManager, version)— no further router.go changes needed for version-string composition; only main.go is the boundary now. -
Build entry point:
flake.nixlives insrc/, not the repo root. Alwaysnix develop /abs/path/to/src --command bash -c '...'with an explicit path — Bash cwd isn't stable across calls, and a barecd src && nix developcan silently short-circuit. -
Test coverage gaps: documented full-suite commands (
xce-build.sh <component>,make test) each cover only a subset — e.g. a component's default meson run misses newly-added standalone test binaries unless wired into itsRUN_TESTScase, and the CGO/apiserver backend suite needsmake test-backendwith CGO_CFLAGS/LDFLAGS reconstructed via pkg-config (package isc-capnproto, notcapnp_c). A green default build is not proof of full coverage — verify every new test binary actually runs. -
Unity harness: use
UnitySetTestFile(__FILE__)(not nestedUNITY_BEGIN()/UNITY_END()) when multiple test-group files share one binary — nested BEGIN/END resets global counters and can mask most of the real suite exit code. Authoritative green = grep raw testlog for:FAIL:/ word-boundary\bTIMEOUT\b, never trust an aggregateFail:0alone. Also rule out a concurrent competing build/soak against the same build dir before treating a timeout/crash as a regression. -
apiserver zap
encoding: consolestill renders structured fields as trailing JSON:logger.yaml'sconsoleencoder is only for the message/level/time/caller prefix — anyzap.Fields passed tologger.Debug/Info/...still render as a single trailing{"key": val, ...}JSON object at end of line (e.g.... resource-location stored {"resource": "r15m", "host": "resverify-worker", "value": 1.5}), in the exact field-append order from the call site. Don't assumeencoding: consolemeans key=value text — grep/parse trailing zap log fields as a JSON tail block (index()/substr() in bash is fine, no JSON lib needed for a fixed, known field order) regardless of the configured encoding name. -
capnp/typemap conventions: every schema struct gets
$C.mapname(...); for a wire-only concept with no live C struct, hand-define a small matching struct intypemap.h. AData-typed field's generated composite codec is a silent no-op in this backend AND the generated_ptrwrapper doesn't zero-init — an unset field is written as literal uninitialized stack garbage (real crash risk). PreferList(UInt8)+ a$C.maplistcountfield, which this backend does generate real code for. A nested-struct getter can return an unresolved far pointer after a segment round-trip — callcapn_resolve()before reading its scalar fields (Text/Data getters resolve internally and mask this). -
C comments: never write a bare
type*/(pointer type immediately followed by/) inside a/* */block comment — it silently closes the comment early, producing a cascade of unrelated syntax errors elsewhere. Recurred repeatedly; grep new/edited comments for[A-Za-z0-9_]\*/before building. Same failure mode, different trigger (caught before building this time, writingtest_sched_worker_change.c's file header): quoting a piece of source code that itself contains/* ... */(e.g. describing the literal dead#if 0 /*FIXME*/ ... #endifblock fromsched.c) inside your own outer/* */doc comment closes the outer comment at that inner*/too — C block comments never nest. When a doc comment needs to reference literal/* */-bearing source text, paraphrase it (e.g. "a dead #if 0 (FIXME-commented) block") instead of pasting the real comment markers. -
Thread/lock hazards on async-ified single-threaded code: a library/struct built for serialized calling (Raft state, SSL* objects, an epoll batch-dispatch loop) that later gets a "drive it on a thread pool" feature needs its own lock/refcount around the shared state — per-endpoint or per-callback serialization does not imply serialization across different endpoints. A same-thread same-batch use-after-free (one event's handler freeing something a later event in the identical batch still references) can look identical to a genuine cross-thread race.
-
makeString() (lib/xstring.c) is rtti-backed, not malloc/strdup — only free it via its own module's rtti-aware teardown, or don't free it at all; a generic
free()/capnpfree_X()on it is heap corruption. Usestrdup()for fields a generatedfree_X()will free directly. -
Threaded test fixtures: teardown for a fixture with real background threads must run unconditionally before any
TEST_ASSERT_*— a failed assertion longjmps past later code, orphaning the thread and corrupting the next test's fixture memory. -
Live-soak validation discipline: a unit-test-green fix can still be unreachable/dead code in production — always re-run the exact live scenario end-to-end, not just the mechanism fixed. A later, differently-shaped soak failure after a fix isn't automatically a regression from that fix — check whether that failure point was ever exercised before.
-
Sandbox quirks:
/tmpcan be overlayfs with intermittent fdatasync EIO — durability-sensitive tests need a real fs (e.g.~/tmpon ext4). This sandbox'sdatemay resolve to BusyBox (no%N, silently passes it through instead of erroring) — use bash's$EPOCHREALTIME/SECONDSbuiltins for timing instead. -
HA election timer discipline (bug-1562): every early-return branch in a function driven by a one-shot timer (
ha_on_primary_ctrl_fd_rdhup's liveness-watchdog callback) must either re-arm the next timer itself or verify some OTHER live timer is actually still scheduled before skipping the re-arm — checking only elapsed-time-since-last-event (the 5.10b debounce branch) is not the same as checking an election is still in flight (the 5.6 guard's actual role/pre_vote_in_progress check). A silently-dropped re-arm freezes the node with zero CPU/log activity forever (looks identical to a clean idle state, not a crash) — diagnose via/proc/<pid>/task/*/wchan(all threads infutex_do_wait/do_epoll_waitwith no fds beyond listen+epoll = dropped timer, not deadlock) before reaching for gdb (ptrace is blocked in this sandbox,yama ptrace_scope=1+ no ancestor relationship to the target). -
kiro-spec-tasks' independent task-graph sanity review is worth actually dispatching, not skipping as formality: writing
scheduler-sim-repl-verbosity's design, the round-boundary "collapse active output range" logic was placed entirely in repl.c (where the round-boundary hook lives) — but a fresh review subagent (no drafting context) caught that the OTHER two triggers for ending that range (a breakpoint hit, a structural event arriving) are detected in repl_break.c, which had no interface to reach into repl.c's state. This is exactly the class of bug a same-context self-review reliably misses (the drafting mind already "knows" the round-boundary path handles it and doesn't re-derive from the other call sites) — worth the two review rounds it took (RETURN_TO_DESIGN, then NEEDS_FIXES catching a second smaller gap in the same fix) rather than rubber-stamping the first draft. -
Reproducing HA bootstrap bugs: match the user's actual inter-node start stagger exactly — a tight ~0.5s stagger (the
/xce-deploy-haskill's default) can mask a bug that only triggers when a node sits solo for tens of seconds (real peers answering fast enough prevents the trap window from ever closing). Always ask/check the real timestamps before concluding "could not reproduce." -
The sim/replay driver (sim_loop.c) does not fully replicate the normal-mode driver's (driver.c) per-session obligations, and this has now caused two separate real bugs:
xce_core_begin_session()/xce_core_signal_go()(core_session.c) were deliberately split from the older monolithicxce_core_go()(scheduler-core spec task 5.2) specifically so a driver can interleaveplugin_begin_session()/sched_account_jobs()between the resval reset and the picker signal —driver.c:739-749does this correctly;sim_loop.c:680still calls the old monolithicxce_core_go()with zero interleaving slot and never callssched_account_jobs()anywhere (bug-1613: every worker's/shared resource's "used" accounting stays permanently zero in--sim/--interactive, since the per-session resval reset is never followed by re-accumulation). Before trusting any sim-driver behavior that has a normal-mode counterpart, grep the normal-mode driver (driver.c) for the equivalent call and confirm sim_loop.c actually has one too — don't assume parity. -
Scheduler sim REPL has TWO independent, un-gated stdout print paths, not one:
xce_repl_on_event()(repl_break.c,sim->interactive-only) unconditionally echoes every decoded event regardless ofstepvscontinue(bug-1595's fix over-applied — it was requested forsteponly), andsim_print_decision()(sim_loop.c, fires independent of the REPL/breakpoint machinery) reprints an identicalPEND/DISPATCH/PREEMPTline every round a decision recurs, with no dedup and no session/round context on the line. Neither path consultsxce_repl_on_decision()'s existing per-round tally (last_n_dispatch/last_n_pend/last_n_preempt, surfaced only viainfo session). Logged as bug-1609/bug-1610 (not yet fixed) — before touching REPL output volume, check both files, not just repl_break.c. -
A soak's own "excluded"/PASS verdict is not a license to stop reading (bug-1563):
/xce-test-ha --chaotic's verdict deliberately excludesbug924_fdatasync(overlayfs EIO) from pass/fail — but a huge excluded count (300K+ in one run) or a different errno than the documented one (EINVAL, not EIO) is worth a manual look anyway. Found:fsync_worker's retry loop only backs off when NOT pending, and a sustained fdatasync failure makes "pending" permanently true (durable_lsn never advances on failure) — a real busy-spin/livelock, invisible to the soak's own job-loss/divergence checks since the other 2-of-3 standbys still satisfy majority. Lesson: skim excluded/noise counts for magnitude and errno before trusting a documented exclusion covers them. -
Fixing a busy-spin/livelock can unmask a latent notification gap (bug-1564): throttling an unbounded retry loop (bug-1563's fix) removed an accidental fast-repoll that had been quietly covering for
persist_flush()never firingon_durable_advance(only the asyncfsync_workerdid). A deterministic (3/3) new test failure appeared immediately after — always suspect "the old code accidentally covered for a real gap via sheer retry speed" when a correctness fix (removing a spin/race) makes a previously-green test start failing 100% of the time; that's a signal to look for a missing notification/wakeup, not to revert the fix. -
nix devShell Python packages are
PYTHONPATHentries, not merged intopython3's own site-packages (found building a standalone-installable xceadmin wheel):python3 -m venv --system-site-packagesonly inherits the base interpreter's OWN site-packages dir, which is empty in this project's nix shell (python3Packages.click/pycapnp/etc. are each a separate/nix/store/...path added via$PYTHONPATH, confirmed vianix develop … --command sh -c 'echo $PYTHONPATH'). A--system-site-packagesvenv therefore silently CANNOT see them (ModuleNotFoundErrorat runtime, discovered live). Fix: skip venv/pip entirely — extract the wheel directly (python3 -m zipfile -e) and bake the resolved$PYTHONPATHstring into a wrapper script'sexport PYTHONPATH=...at generation time (expand now, not${PYTHONPATH:-}at runtime) — mirrorssrc/xceadmin/meson-install.sh's existing nix-packaging wrapper, which already solved this correctly; I should have grepped for that pattern before reaching for venv the first time. -
src/tools/xce-build.sh'ssetup_build()doesrm -rf "$BUILD_DIR"for every single-component invocation (bug-1565, FIXED):/xce-build xceadminafter/xce-build controllerin the same dir used to silently deletexce_controller/xce_test/etc. Fixed by an opt-in--incrementalflag (meson setup --reconfigurein place instead of wiping) — deliberately NOT the default, since this project's capnp-generationcustom_targethas known missing-dependency-edge races that a full wipe papers over as a loud, retry-fixable failure (skipping the wipe could turn the same gap into silent stale-generated-code instead)./xce-build all(build everything together) remains the simplest option when you don't specifically need incremental speed. -
A never-joined background thread reading a stack-local test fixture is a latent ASAN stack-use-after-return, exposed only by test ORDERING, not by the thread's own logic (2026-08-19, scheduler-core design-review follow-up).
sched_sim_driver_run()(sim_loop.c) spawnssim_picker_thread_fnon a real pthread that is, by this codebase's own documented design, "never joined or cancelled... no sim-driver teardown/fini function exists yet" — it loops forever oncbuf_get(&sim->core.wbuf, ...). Every existing white-box test intest_sim_event_loop.calready called this with a stack-localxce_sched_sim_driver_t sim;, which was ALWAYS a latent stack-use-after-return once the test function returned — it just hadn't been caught, because no test's stack frame had yet been reused by a later frame in a way ASAN's shadow-memory detector caught. Simply INSERTING one new test between two existing ones (no logic change to the existing tests) shifted the stack-reuse pattern enough to make it fire deterministically (reproduced twice). Fix: change the fixture from stack-local tostaticstorage — safe here specifically because (a)sched_sim_driver_start()unconditionallymemset()s the whole struct as its first action so no stale-data leak across runs, and (b) each affected test function is called exactly once per process (verified via grep, no re-entrancy) so a second call's memset can never stomp a still-live zombie thread's cbuf mutex/condvar state from a first call —staticwould be UNSAFE to apply to a helper called more than once while its first zombie thread might still be alive. General lesson: when a background thread spawned by code-under-test is documented as "never joined," any test giving that code a stack-local fixture is a ticking ASAN time bomb regardless of whether it has fired yet — check for exactly this "never joined/cancelled" phrasing in the target function's own comments before adding a new test that changes stack layout/ordering in the same file. -
A plain (non-
--system-site-packages) venv'spip installDOES work for xceadmin's deps, including pycapnp, as long as venv creation +pip install+ running the installed entry point all happen insidenix develop … --command(2026-08-20, build-time-versioning task 6.3, extends the PYTHONPATH entry above rather than contradicting it): unlike the--system-site-packagescase, a plain venv'spip install pycapnpresolves the prebuilt PyPI wheel fresh over the network (confirmed reachable:pypi.org/files.pythonhosted.orgboth resolve in this sandbox) — no PYTHONPATH-visibility problem, since pip is installing its own separate copy into the venv rather than trying to see the nix-injected one. The catch: that PyPI pycapnp wheel dynamically linkslibstdc++.so.6, which the bare host has NO system-wide copy of at all (import capnp→ImportError: libstdc++.so.6: cannot open shared object fileoutside nix) — confirmed the SAME venv/pip-install/import capnpsequence works cleanly when the whole thing (venv creation, pip install, AND the laterpython/entry-point invocation) runs insidenix develop $SRC_DIR --command bash -c '...', which resolves it via the devshell's own environment. Net: use a plain venv + realpip install(matching.claude/skills/xce-build/SKILL.md's own documented "Installing the xceadmin wheel elsewhere" section) for throwaway/test installs where network is available and everything runs undernix develop; reach for the PYTHONPATH-entry's zipfile-extraction wrapper trick instead only for a permanent, no-nix, no-network deployment target (e.g./xce-deploy-ha'sscripts/xceadmin). -
A pipeline into
head -Ncan SIGPIPE-kill the upstream script early underset -o pipefail(bit twice this session: once withtimeout N cmd | head -Nleaving a stale background process running for hours after the harness reported the task "complete", once withxce-build.sh ... | head -3silently truncating a build before it finished writing its wheel). If you need to sanity-check just the first few lines of a long-running command's output, redirect to a file andheadthe file afterward instead of piping directly intohead. -
sim_loop.c(and its*_isolation-audited siblings) genuinely has zero line-budget headroom — its own file header says so explicitly. When a fix needs new logic there, split a new sibling file (bug-1567'ssim_picker.c, following the exact precedent chainsim_loop.c→sim_record.c→repl.c→repl_break.c/repl_info.c→repl_params.c) rather than growing it even slightly. This requires wiring the new file into:scheduler_srcsANDsched_sim_isolation_lib(bothsrc/scheduler/meson.build), a newXCE_SIM_*_PATHmacro (testsuite/meson.build) consumed bytest_sim_isolation.c's 3 per-file text-scan functions, AND every white-box test TU that#includessim_loop.cdirectly (9 files this session — grep#include "../src/sim_loop.c"intestsuite/to find them all) needs the new file#included too or the link fails on the new extern. Mechanical but real work — budget for it. -
controller_unit_test's intermittent SIGSEGV (bug-1553, ~1-in-3 full runs) is a known pre-existing flake, not a new regression — reproduce standalone (./src/build.dbg/controller/controller_unit_test, nomeson testwrapper) a few times before suspecting your own change;meson test'sMALLOC_PERTURB_randomization per invocation is what makes it flaky, not deterministic per-build. -
bug-1568 (FIXED) had TWO independent, unrelated root causes stacked on the same symptom ("info worker" showing 0.00 for real resource values) — worth remembering the general pattern: (1)
xce_core_push_events()'sWORKERS_PUSHcase calledsched_add_worker()(a plainkey_add(), add-only) unconditionally on every push; a worker connecting sends multiple pushes in quick succession, so any push after the first for an already-registered name silently -EEXIST-discarded its resource values — fixed viacore_upsert_worker(), mirroring the existingcore_upsert_queue()add-or-update precedent (core_events.c). (2) Separately,repl_info.c's display code comparedxce_val_t.whichagainstXCE_VAL_NUMERIC(xce/types.h#define, value 1 — a resource-definition value-type constant,xce_resource_t.valtype's own enum) instead ofValue_u_fvalue(controller.capnp.h-generated, value 5 — the real tag every producer in this codebase actually sets onxce_val_t.which) — always false, so it displayed 0.00 regardless of whether (1) was fixed. Lesson: when value-level TRACE at every pipeline hop (push → apply → snapshot save → snapshot load/decode) all show the correct number but the final displayed/returned value is still wrong, the bug is one hop further than "the pipeline" — trace the DISPLAY/formatting code too, don't stop at the data layer. And don't assume two enum families with parallel-looking names (XCE_VAL_*vsValue_u_*) are interchangeable just because both appear nearxce_val_t/.which/.valtype— check which one a given producer actually sets before trusting a comparison against it. -
IFS=$'\t' read(or any single-tab IFS) silently COLLAPSES adjacent/empty fields, just like the default whitespace IFS does -- bash classifies tab (along with space/newline) as "IFS whitespace" for splitting purposes regardless of what IFS is actually set to, soa\tb\t\tc\td(an empty 3rd field) reads back as 3 fields (a,b,c\tdcollapsed) not 4, silently shifting every field after the gap. Found live building resource-value-verification task 7.1'saggregate_verdict()(run-resource-verify.sh) -- its own required synthetic self-test caught it immediately (an UNREACHABLE-layer record's empty*_observedfield shifted every later field by one, corrupting the apiserver classification). Every OTHER tab-delimited TSV already in that file happens to never carry a genuinely-empty field, which is why this never surfaced before. Fix: when a delimited record format can legitimately have an empty field, use a non-whitespace-class separator (e.g. ASCII Unit Separator$'\x1f') instead of tab --IFS=$'\x1f' readdoes NOT collapse/strip, tab-like or space-like IFS always does. -
This Bash tool aborts a multi-line script at the first command returning nonzero, even with
; true/|| trueon that exact line — observed repeatedly withpkillmatching zero processes (a completely normal, expected outcome) silently killing every following line in the same call. Don't chain a possibly-zero-matchpkill/similar with follow-on commands in one Bash call — verify viapgrepfirst (it's just as prone to this, so treat ITS nonzero "no match" the same way) or issue the pkill as its own standalone call and check the result before proceeding. -
nix buildin this sandbox dispatches to a remote builder (ssh://rshen@172.31.109.18) that is NOT reachable from inside the sandbox (2026-08-21, dirty-content-fingerprint task 6.3 review).nix show-config//etc/nix/nix.confinside the sandbox showbuilders =(empty) — the remote dispatch is configured on the nix-daemon side (invisible to ashow-configrun inside the sandbox's mount/network namespace), not discoverable by inspecting client-side config. A plainnix buildtherefore either hangs/times out on SSH connect or falls back to the known bcctool/goproxy.cn failure without ever completing locally. Fix: pass--builders ''to force a fully local build (this sandbox hasmax-jobs = 22, plenty of local capacity) whenever running a realnix build/nix develop-triggered build for verification in this sandbox — don't assume remote-dispatch failure/unreachability is unavoidable or treat it as an automatic excuse to fall back to eval-only/log-only verification; try the local-builder override first, since it can produce a genuinely complete, runnable binary instead of just a build log. -
apiserver's
main.goonly callsRegisterToBackendwhenBackendYamlConfig.Address != ""— checked BEFOREPeersis ever consulted (cmd/main.go:58). Settingapp.yaml'sbackend.peersto a fully-populated HA candidate list while leavingbackend.address/backend.portblank (reasoning "Peers takes priority inside RegisterToBackend anyway, perbackend/config.go's own doc comment") is NOT sufficient — the apiserver silently boots in permanent "stub mode" (logger.Info("Backend not configured")) and never even attempts a connection,peersor not. Caught live while buildingxce-deploy-ha's new apiserver step (resource-value-verification task 3.1): always populateaddress/porttoo (e.g. the first--peerscandidate's host:port) even when also settingpeers— belt-and-suspenders, not redundant, because the two fields gate two different things (whether to connect at all, vs. which candidate(s) to try). -
resource-value-verification task 4.1's scheduler trace-log exact format (
xce_core_push_events()'sXCE_CORE_EVENT_RESVALS_DELTAcase,src/scheduler/src/core_events.c, right afterzarray_put(&(w->resvals), res->idx, rv->val)):TRACE("resval applied host=%s resource=%s value=%f", ...)for numeric (Value_u_fvalue) resources, orvalue=%sforValue_u_svalueones — live-confirmed viaxce-deploy-ha+xce_testworker-contextjoin/resupdate -n r15m -v 12345.5producing exactlyresval applied host=task41-worker resource=r15m value=12345.500000inscheduler.logat-vvv. Task 6.3 (scheduler-side log-tail check) MUST grep forresval applied host=<H> resource=<R> value=<V>— labeledkey=valuefields, no other fixed text to depend on.%fon a normal resource value produces trailing zeros (e.g.12345.500000), not the input's original decimal precision — task 6.3's comparison should parse-and-compare as float, not do a literal string match against the injected value string. -
bug-1572 (NOT FIXED, pre-existing, discovered live task 4.1 round-2):
xce_schedulerdouble-frees on a worker's SECOND periodic resource report for the same resource(s), silently dying with no ASAN output (backgrounded viasetsid nohup ... >/dev/null 2>&1, so the crash report is lost -- only visible as scheduler.log stopping mid-stream +handle_scheduler_leavein the controller log ~1s later). Root cause:core_events.c'sXCE_CORE_EVENT_RESVALS_DELTAcase doeszarray_put(&(w->resvals), res->idx, rv->val)with NOMOVE_PTR(unlike its siblingcore_apply_config_resvals(), which doesMOVE_PTR(val, nv->val)first) -- the samexce_val_t*stays aliased in the decoded request.driver.c'srelease_translated_payload()then unconditionally frees that request's resvals list even whenapplied=1(itsXCE_SCHED_OP_UPDATE_RESVALScase has noif (!applied)guard, unlike the siblingXCE_SCHED_OP_UPDATE_CONFIGcase which explicitly skips the free when applied). Net effect:w->resvals[idx]is left dangling immediately after every successful RESVALS_DELTA batch; the SECOND update to the same index triggers zarray's killer to free the already-freed pointer. Confirms identically on round-1's code (unrelated to the enum-branch bug fixed in that round) -- a live smoke test that only runs one resupdate quickly after deploy will NOT hit this; anything that waits past one real worker's report interval (xcecd_virtual reports ~every 15s) will. When live-testing anything touching RESVALS_DELTA, either run fast (single update, no wait) or expect this crash and don't misattribute it to whatever fix is actually under test. -
src/frontend/Makefile'sbuild-servertarget is missing CGO_CFLAGS/CGO_LDFLAGS (bug-1597, NOT FIXED): unliketest-backend(bug-1558) andapiserver/meson.build,build-server's recipe is a barego buildwith no-I/-Lforclient.h/controller.capnp.h/libxce.a, sonix develop ../ --command make build-serverfails withfatal error: client.h: No such file or directoryregardless of source changes. Confirmed via git-stash A/B that this reproduces identically with or without an unrelated diff, so don't misattribute it to whatever change is under test. Workaround to actually verify compilation: reconstruct CGO_CFLAGS/CGO_LDFLAGS the same waytest-backenddoes (pkg-config for librtti/c-capnproto/openssl/tinylog +-I$BUILD_DIR/lib/-L$BUILD_DIR/lib -lxce,BUILD_DIRdefaulting tosrc/xce.build) and runCGO_ENABLED=1 CGO_CFLAGS=... CGO_LDFLAGS=... go build -o /tmp/apiserver ./cmd/main.godirectly insidenix develop ../— see bug-1597 for the exact one-liner. -
test.c'sset_resval()leavesxce_resval_t.name(and.val->which) uninitialized for theValue_u_svaluefallback path (-n type/-n model/explicit-t stringon an unknown name) — its switch statement has nocase Value_u_svalue:arm, andvals[]is a non-zeroed stack array reused across REPL invocations, so.namecan be garbage, not NULL. Pre-existing (predates resource-value-verification's task 2.1/2.2), explicitly flagged as out-of-scope-to-fix in both tasks' code comments (Requirement 1.4's "preserve byte-for-byte" constraint). When building task 2.2's per-name verification loop on top of this, the safe pattern was to track the submitted name in a separate parallel array (subnames[]) captured directly from the getopt loop's ownresnamevariable (always valid — that pointer is deliberately leaked/never freed, so it stays alive for the whole REPL call) rather than trustingvals[i].name. -
Trap-based cleanup that must survive an async signal (SIGTERM/SIGINT) should combine multiple
pkill -9 -fcalls into ONE alternation pattern, not several sequential invocations, plus a retry-until-verified (pgrep) loop (bug-1575, resource-value-verification task 5.1'srun-resource-verify.sh). Four separate sequentialpkill -9 -f -- "pattern"calls insidecleanup()worked reliably every time when reached via normal control flow (a directfail()/exitcall), but non-deterministically left 1-2 of the four target processes running whencleanup()instead ran from the EXIT trap fired by an externally-delivered SIGTERM translated via a separatetrap 'exit N' TERMhandler -- the exact failure point (which of the 4 pkill calls was "last to complete") varied run to run, consistent with a timing race in the trap-handler code path rather than a pattern-matching bug (each pattern was independently verified correct). Fix: one combinedpkill -9 -f -- "pat1|pat2|pat3|pat4"call (fewer fork/exec round trips through the trap handler) wrapped in a loop that re-checks viapgrep -fand retries (up to ~2s total) until genuinely clean. Verified reliable across 5+ repeated live SIGTERM-mid-deployment interrupts after the fix (zero leftover processes every time), vs. non-deterministic leftovers before it. General lesson: don't trust a cleanup routine's reliability from its NORMAL-completion path alone -- explicitly live-test the signal-interrupted path too, since bash's async-signal-trap execution context can behave differently from the same code reached via ordinary top-to-bottom flow or a plain function call/exit. -
pgrep -f/pkill -frun interactively via this Bash tool can self-match (andpkillcan self-KILL) the invoking Bash-tool call's own wrapper process (bug-1576, discovered repeatedly while diagnosing bug-1575 above -- cost significant back-and-forth before recognized). This harness wraps every Bash call as roughlybash -c "... && eval '<submitted script text>' ...", so the wrapper's own/proc/<pid>/cmdlinecontains the FULL LITERAL TEXT of whatever was submitted -- including any search pattern typed directly into that same script (unavoidable, since testing a pgrep/pkill pattern means typing it). Apgrep -f -- "sometext"that also appears as literal text elsewhere in the SAME submitted command block will match the wrapper too;pkill -9 -fin the same situation can SIGKILL the current Bash call's own shell mid-script, truncating all remaining output with no distinguishing error beyond a generic nonzero/early-stop. Symptoms seen: a match count of "2" when only 1 real process existed; a multi-line diagnostic script silently stopping after the pkill line with no further output. Mitigation: when checking process state from an interactive Bash call, scan/proc/[0-9]*/cmdlinedirectly and eyeball results for the wrapper's own distinctivebash -c "source .../shell-snapshots/... && eval '...'"shape rather than trusting a bare match count; never assume a lone pgrep/pkill match is the real target without checking itsps -o cmdfirst. This does NOT affect a target script's OWN internalpkill -fcalls (e.g. inside a cleanup() function) since that script's own argv is just its invocation line (interpreter + path + args), not its source text. This ALSO bites a from-scratch verification watcher, not just a diagnostic pkill: any background polling loop launched via the interactive Bash tool with the target pattern typed inline in its own command text self-matches too (found live, task 6.1) -- write the pattern into a script FILE and launch that file instead, or check/proc/<pid>/exe(the resolved binary path) rather than grepping/proc/<pid>/cmdlinetext at all. -
xce_test's worker-context injection recipe (resource-value-verification task 6.1, cross-checked against
xce-test-ha/run-ha-soak.sh's extensive prior use of the identical pattern):printf 'set masters %s\nset myname %s\nworker\njoin\nresupdate -n <name> -v <value> [...]\nquit\n' "$PEERS" "$WORKER_HOST" | xtest.set myname <host>is what tags every subsequentresupdate'd value's.hostfield (test.c:config.from = get_setting("myname");set_resval()setsvals[idx].host = get_setting("myname")) -- Requirement 2.2's "tag every resupdate-injected value with the joined worker's own identity" is satisfied entirely by this one setting, no separate flag needed.resupdate_report_one()'s output lines are exact whole-line strings (<name>: accepted/<name>: rejected: unknown resource/<name>: rejected: value mismatch) -- parse withgrep -Fxq(fixed-string, whole-line), not a substring/regex grep, since a short resource name (it,io,ls...) can appear as a literal substring of an unrelated line otherwise. -
A synthetic worker's host-attrs resources (
type/model/cpuf/maxcpus/maxmem/maxswap/maxtmp/ndisks) get RESET to baseline the moment it disconnects -- this is correct, intentional production behavior, not a bug, but it bites any test tool that queries the controller in a SEPARATExce_testprocess/session after the injecting session's ownquit(resource-value-verification task 6.2, bug-1579, not-a-bug/documented).add_hostattrs_resvals()(src/controller/worker.c:260-287) is the fixed N_HOST_ATTRS list;mark_worker_unavail()->apply_worker_dead_mutation()(worker.c:704-716) callsreset_hostattrs_unknown()then re-appliesadd_hostattrs_resvals()on every worker disconnect, by design (a dead worker shouldn't keep advertising stale capacity).run-resource-verify.sh'sinject_resources()(task 6.1) runsjoin;resupdate;quitas ONExce_testprocess -- thequitdisconnects the synthetic worker before ANY later per-layer check (a separatexce_testprocess) can observe it. A live controller-check run against the task's own DEFAULT_RESOURCE_ARGS set showed 8/9 MATCH + 1 false MISMATCH (cpuf, the only host-attrs-colliding name in that default set) -- re-running with the same 8 non-cpufresources gave a clean 8/8 MATCH, confirming the check logic itself is correct and this is purely a worker-disconnect-timing artifact. Only the CONTROLLER-layer check (a liveresvalquery) is exposed to this -- the scheduler/apiserver checks (tasks 6.3/6.4) are trace-log-tail based (read what was logged at apply-time, immune to later disconnect). When choosing/validating a resource name for any live check against this script, cross-check it isn't inworker.c'sN_HOST_ATTRSlist first, or expect a query run in a later, separatexce_testsession to legitimately read back 0/default. UPDATE 2026-08-18 (task 6.2 remediation round 2, reviewer-mandated fix): the default-set instance is now FIXED.DEFAULT_RESOURCE_ARGSswappedcpuf=9.5forr1m=9.5(a periodic/dynamic load-index resource persrc/worker/src/resource_sync.c, confirmed pre-existing/"already-supported" viaresval_typeresolve.c'sresinfo[]table, and NOT inworker.c'sN_HOST_ATTRSlist) -- live-validated clean 9/9 MATCH on the default (no-args) set post-fix, no regression onmem=5-only or mixed accept/reject scenarios. Option (b) (keep the synthetic worker's session connected across all per-layer checks instead ofquitting) was investigated live in this same round and confirmed NOT a simple call-reordering fix:xce_test's REPL has no command path from theworkercontext back to theclientcontext without first callingleave_ctx()(via../cmd_up), which performs the exact same disconnectquitdoes -- making option (b) work would require either a C-levelxce_testchange or a materially riskier bash coprocess restructuring, both out of scope. This class of issue (a host-attrs resource name queried after synthetic-worker disconnect) remains a live risk for any FUTURE task or user-supplied customresource=valueargument namingtype/model/cpuf/maxcpus/maxmem/maxswap/maxtmp/ndisks-- see buglog.json bug-1579 for the full analysis. -
bug-1577 (FIXED, task 6.1):
xce-deploy-ha'sdeploy-ha.shsilently starts a REAL worker daemon (xcecd_virtual) whenever one happens to be built alongside the controller (its own pre-existing opt-in-by-presence convention, predates resource-value-verification) -- a plain/xce-build allleavesxcecd_virtualpresent, soxce-test-resources's own deployment picked one up unconditionally, contradicting Requirement 2.1 ("no real worker daemon process required") and risking bug-1572 (scheduler crash on a resource's 2nd periodic report) on a long-enough run. Fix, without touching deploy-ha.sh (out of that task's boundary): the generatedstart-worker.shreads${XCE_WORKER_BIN:-<real path>}from its OWN inherited environment at run time -- exportXCE_WORKER_BIN=/bin/truebefore invoking the generatedstart-all.sh, so the worker step exits immediately with zero persistent process. General lesson: when a skill's design deliberately avoids starting some component, verify what a shared deploy helper ACTUALLY launches by inspecting real running processes, don't assume your own new code is the only thing determining what ends up running. -
bug-1578 (FIXED 2026-08-18): controller SIGSEGVs on worker disconnect if a scheduler ever connected AND that worker's resvals were pushed at least once. Fix applied:
sched_worker_change()'s dead#if 0 ... #endifblock replaced withw->host.nresvals_to_sched = 0; w->host.resvals_to_sched = NULL;beforexlist_fini(&resvalist);-- exactly mirrorsapiserver_worker_change(). Verified two ways: (1)xce-build.sh controllerclean build, 1102/1104 tests pass (2 failures are pre-existing bug-1561 overlayfs/fdatasync, unrelated); (2) live repro viarun-resource-verify.sh --keep-running-- deployed full stack, joined synthetic worker, ran 9resupdates, disconnected (quit), confirmed the exact crash-trigger log sequence fired (handle_worker_leave->sched_worker_changepushing resvals to scheduler twice) and the controller stayed alive ~2 minutes past disconnect with zero SEGV/ASAN/core-file (previously died within 1-10s every time). UPDATE 2026-08-18 (follow-up task) -- the "no testable-static-function harness pattern exists" claim below was wrong; corrected so it isn't trusted stale in a future session. Addedsrc/controller/testsuite/test_sched_worker_change.c(new standalone binarysched_worker_change_unit_test, wired into meson.build mirroringsched_push_unit_test's real-sched.c+dataex.c+egress.clinking strategy -- the exact same "drive a static hook function through the real installedhooksysviaxce_run_hooks()" patterntest_job_array_sched_push.calready proved for the JOB hook works identically for the WORKER hook:on_scheduler_join()installssched_worker_hook_fun, thenxce_run_hooks(&c.hooksys, XCE_CONTROLLER_HOOK_WORKER, HOOK_AFTER_EVENT, HOOK_DETAIL_WORKER_DEAD, &c, w)reachessched_worker_change()exactly ashandle_worker_leave()does in production). Test 1 assertsw->host.resvals_to_sched==NULL && nresvals_to_sched==0after the hook fires. Test 2 is the stronger ASAN-strength proof: it calls the REAL production encoderencode_Worker()(controller.capnp.c, linked for free vialibxce_dep-- no need to linkpersist.cat all, sincepersist.c's owncapnp_encode_worker()is just a 20-line pass-through to it) directly on the worker right after the hook fires, exactly whatpersist_worker_hook_fundoes on disconnect in production. RED/GREEN-verified live: temporarily re-wrapping the fix in the original dead#if 0 ... #endifreproduced a genuine ASAN heap-use-after-free (encode_NameValue_list,controller.capnp.c:3408, freed byxlist_fini<-sched_worker_change<-sched_worker_dead<-sched_worker_hook_fun) -- then the approved fix was restored (confirmed byte-identical viagit diffto the pre-revert state) and both tests went GREEN. Gotcha hit along the way:makeResource()/makeString()(resobj.c/xstring.c) need the global xstring intern table initialized first (xstring_table_init(N), once, before first use) ormakeString()returns an object whose->nameis NULL, and the very nextkey_add()/hash_string()call SIGSEGVs on the NULL string -- easy to miss in a fresh standalone test binary since no other linked test file has already called it process-wide (existing precedent:test_worker_join.c's ownRUN_TESTcall site comments this exact requirement). Original root-cause notes retained below.sched_worker_change()(src/controller/sched.c) aliasesw->host.resvals_to_sched/nresvals_to_scheddirectly to a localxlist_t's backing array, pushes it, thenxlist_fini()s that array WITHOUT resetting the alias first -- the correct reset lives in the SAME function but is wrapped in a dead#if 0 /*FIXME*/ ... #endif(commitacfbec875, 2026-03-03 -- predates resource-value-verification by ~5 months; a later commite5fde7b5"fixed" this but edited code INSIDE the already-dead block, so its fix silently never ran). Leavesw->host.resvals_to_scheddangling for the worker's whole remaining lifetime. On disconnect,handle_worker_leave -> mark_worker_unavail -> xce_run_hooks -> persist_worker_hook_fun -> capnp_encode_worker -> encode_Worker -> encode_NameValue_list -> encode_NameValuedereferences the freed array -> SIGSEGV (si_addr=NULL). Only reachable once a scheduler has connected at least once (on_scheduler_join()registerssched_worker_hook_funon a one-shotstatic hook_installedgate) -- a solo controller or controller+apiserver-only never triggers it, which is why the original A/B isolation matrix (lone controller alive 90s+, full stack + xce_test never run alive 100s+) didn't catch it: the missing variable wasn't "was xce_test run" but "did a scheduler ever join AND did that worker's resvals get pushed." Siblingapiserver_worker_change()(apiserver.c) does the reset correctly (not#if 0-wrapped) -- mirror that exact pattern for the fix, do NOT just uncomment the deadfree_name_val_list()call (it already frees the array AND nulls the field itself; the very nextxlist_fini()line would then double-free the same pointer -- almost certainly why the original author reached for#if 0instead of deleting it). Fully outside resource-value-verification's task boundaries (sched.c, untouched by tasks 2.1/2.2/6.1) -- tasks 2.1/2.2 are innocent, no re-review needed. See buglog.json bug-1578 for the full backtrace and fix diff. -
do_update_resvals()(src/controller/opupd.c) fans out the FULL, UNFILTERED submitted resource list to the scheduler AND apiserver hooks BEFORE (and still, after)update_resval_list()does its own per-item validity check — the controller's ownw->host.resvalswrite is filtered (rejects unregistered names viakey_find(c->resmgr,...)), but the HOOK_AFTER_EVENT payloadsched_resource_hook_fun/apiserver_resource_hook_fun(sched.c/apiserver.c) act on is the SAME raw list regardless. Found live during resource-value-verification task 8.1 (bug-1583, NOT fixed): injecting one deliberately-unregistered resource name showed the scheduler'score_events.cindependently re-validates against its own resource table and discards+WARNs on an unknown name, but apiserver'sOnResourceLocationUpdated(handler.go) has zero such validation and unconditionallystore.ResourceLocations.Put()s it — a genuine 3-way inconsistency (controller rejects, scheduler rejects, apiserver silently stores forever). General lesson: when a controller hook fans a raw request payload out to multiple downstream consumers, don't assume upstream validation (even a REJECT logged elsewhere in the same request) actually filtered what those consumers received — check each consumer's own hook function for whether it re-validates or blindly trusts the payload. -
When a live crash won't reproduce under gdb (even a direct
gdb --argschild launch, which sidesteps this sandbox'sptrace_scope=1attach restriction), suspect gdb's ptrace overhead itself is masking a timing-sensitive bug rather than concluding "not reproducible." bug-1578: a 100%-reproducible (bare launch) controller SIGSEGV did NOT reproduce within 20s under gdb for either the ASAN or debug(-O0) build, for both a plainrunand a--batchlaunch. Fix: skip gdb entirely -- compile a tinyLD_PRELOADshared library (constructor installs asigactionhandler withSA_ONSTACK+a pre-allocated altstack for SIGSEGV/SIGABRT/SIGBUS/SIGILL/SIGFPE that callsbacktrace()+backtrace_symbols_fd()to stderr, thensignal(sig, SIG_DFL); raise(sig)to preserve normal termination semantics) and launch the target withLD_PRELOAD=./crash_handler.so <normal invocation, no wrapper>. Near-zero runtime overhead (one constructor + a couplesigaction()calls), so it does not perturb thread scheduling/timing the way ptrace does -- reproduced the exact same crash reliably and captured a full backtrace. Resolve the raw addresses withaddr2line -e <binary> -f -C -p <offset...>using the(+0xNNN)MODULE-RELATIVE offsetsbacktrace_symbols_fd()prints (not the raw runtime addresses, which include the PIE ASLR base and won't resolve against the on-disk binary directly). -
Testing a bash function that both populates caller-scope globals AND prints via a
log()-style echo (task 8.2,aggregate_verdict()): never capture its output with$(...)command substitution if you also need the globals it set. Command substitution forks a subshell in bash — any associative-array/variable writes the function makes are lost the instant the subshell exits, even though the function's exit code and printed text survive. Fix: call the function directly with plain>file redirection (fn ... > "$tmpfile" 2>&1; rc=$?), which does NOT fork a subshell, then read$tmpfileseparately for text assertions while the just-set globals remain live in the current shell. This is exactly.claude/skills/xce-test-resources/verdict-logic-selftest.sh'srun_agg()helper. -
This codebase's established pattern for a persistent bash-tooling regression test is
.claude/skills/xce-test-ha/soak-verdict-selftest.sh: name it<subject>-selftest.sh,source(not execute) the target script to get its functions in scope, use acheck DESC EXPECTED ACTUALstring-equality helper tallying afailscounter, end with aSELFTEST PASS/SELFTEST FAIL (N failed)line and exit 0/1.run-resource-verify.shitself is written to support this — it has a[[ "${BASH_SOURCE[0]}" == "${0}" ]]guard at the bottom specifically so sourcing it never runsmain()/starts a live deployment. Reused forverdict-logic-selftest.sh(task 8.2). -
Sandbox capability update (2026-08-19):
sudonow works passwordless here (sudo -n truesucceeds) — this unblocks anything previously gated on "this session/skill cannot sudo" (e.g. realxcecd,worker/src/main.c'scheck_user()). Still true, and load-bearing for anything assuming a real production host: this sandbox has no systemd, no dbus, no/runat all (ls /run→ No such file or directory; PID 1 iss6-svscan; nodbus-daemon/systemctleven undernix develop). Root access and a real init/dbus stack are independent axes — don't assume sudo working means systemd-dependent things (job dispatch viaorg.freedesktop.systemd1.Manager.StartTransientUnit, anything needing/run/dbus/system_bus_socket) will also work./run/systemd/systemexisting is the standardsd_booted(3)-style signal for "a real systemd instance is running as this host's manager" — used insrc/tools/deploy-ha.shto auto-pickxcecd(real) vsxcecd_virtualper host (XCE_REAL_WORKER=0|1overrides). -
A root-owned file created by a daemon under
sudois not automatically readable by the invoking non-root user — confirmed live (bug-1592): realxcecd's main log file comes outroot:rootmode640even though the SAME binary explicitlychmod(..., 0666)s its domain socket and itsxcecd_worker.logsibling. Don't assume "the daemon already chmod's some of its output files permissive" generalizes to all of them — check each file's actual mode after a live run before writing a verification command that reads it as the invoking user; prefix withsudowhere it doesn't. -
xce_resource_t (xce/types.h) has a
flagsbitmask (XCE_RESF_BUILTIN/DYNAMIC/GLOBAL/SHARED/EXTERNAL/RELEASE/DEFAULT_HOST/CONSUMABLE/LIMIT) distinguishing a genuinely cluster-wide resource (GLOBAL/SHARED, stored ONCE incore->sharedInst, a zarray_t indexed by the resource'sidx-- the same pool RESVALS_FULL/RESVALS_DELTA event handling and snapshot save/load already treat as authoritative) from a host-based/per-worker-distributed resource (stored per-worker inw->resvals/w->resInUse). Before this session,repl_info_resource_one()(scheduler REPL) conflated the two -- aggregated total/available across every worker's resvals for EVERY resource regardless of kind, a fabricated number for a host-based resource (cpus/mem) and redundant withinfo worker's own correct per-host display. When adding any new resource-value display/log code, checkr->flags & (XCE_RESF_GLOBAL|XCE_RESF_SHARED)first to decide which pool (core->sharedInstvs per-workerresvals) is the correct source of truth -- see bug-1593. -
repl_info.c(scheduler REPL state-inspection dumps) was already OVER this project's 800-line cap (883 lines) before this session even started -- accumulated from three prior sessions' bug fixes (bug-1587/1590/1591) each adding a little without ever triggering a new sibling-file split. A task-12.5 rewrite of the resource-display functions brought it down to 856, still over. Flag this to the user rather than silently ignoring it or unilaterally doing a 4th-generation file split (repl.c -> repl_break.c/repl_info.c -> repl_params.c precedent) without being asked -- a split touches meson.build, test_sim_isolation.c's per-file scan macros, AND every white-box test TU's #include list (real, mechanical work, not worth taking on speculatively). -
A
repl_split_tokens()-style whitespace tokenizer with zero quote-awareness silently breaks any downstream parser that requires a whole-string-anchored regex match (e.g.parse_jobid()'spmatch[0].rm_so==0 && pmatch[0].rm_eo==lencheck) when a user quotes an argument out of habit (common when copy-pasting a value from another command's own output). The numeric fallback path (strtoull()) then silently parses the leading quote character as "not a digit" and returns 0 rather than erroring -- producing a confusing wrong-answer, not a clear parse failure. Worth checking for in any REPL/CLI tokenizer this codebase adds. See bug-1596. -
A pointer returned by
makeString()(rtti-managed,lib/xstring.c) must always be released viadereference(), neverFREEUP()/plainfree()—makeInstance()/objAlloc()returns an offset into a combined header+data block, not the block's ownmalloc()-returned base address, and the string is refcounted (freed only when the refcount hits zero), not directly owned. bug-1600 (2026-08-19, production, not a test fixture — see also bug-1503's earlier test-fixture instance of the identical mismatch):lib/group.c'smakeGroup()"existing group" update branch (hit every time a config-push re-applies a group name that already has members, e.g. any retried/duplicate config push — no thread concurrency required) calledFREEUP(m->u.name)on amakeString()-allocated field, while the SAME FILE'sgroup_killer()destructor released the identical field correctly viadereference(m->u.name). This caused the real, reproducible (8 confirmed core dumps)xce_schedulerfree(): invalid pointerSIGABRT crash during controller-failover config-push retries. When adding or auditing any free/release path for a field populated bymakeString(), grep the same file/struct for an existing destructor and match its release call — don't assumeFREEUP()is safe just because it's used for adjacent plain-calloc'd fields in the same struct. -
lib/group.c'smakeGroup()"existing group" update path takes onlyRTTI_LOCK_READ(a genuine sharedpthread_rwlock_rdlock, confirmed viakvmgr.c) while mutating shared group member-list state, and the scheduler's entire config-push handler chain (sched_init_config()→plugin_config_update()→ ... →makeGroup()) holds no serializing lock at all — whilescheduler_req_handler()genuinely runs on whichever of the scheduler's 4 vcpu worker pthreads picked up that vtask (vtaskmgr_init(..., 4)).xce_ctx_reconnect()reuses the samectx->epstruct andendpoint_init()unconditionally resetsep->busy=0, so a reconnect racing with a still-running config-push handler can let a second, concurrently-dispatched config-push runmakeGroup()on the same group object at the same time as the first. This is a REAL latent concurrency bug distinct from bug-1600's allocator mismatch (which alone was sufficient to explain the observed crash and was the one fixed) — flagged as a follow-up, not yet fixed; would need a write-lock scope redesign sinceinit_group_by_config()'s callees (get_group()) take their own internal read lock, so naively holding a write lock across the whole function would self-deadlock on the non-recursive rwlock. -
apply_committed_entry()'s shared WAL_JOB_START/FINISH/STOP/RESUME/RUSAGE/CKPT/PREASON dispatch case (persist.c) never stampedstart_time/finish_time/run_time— it only ever called the generic, state-onlyapply_job_update_transition(j, state)(2026-08-19,xcecli joblistshowedStartTime=0 for every RUN/DONE/EXIT job,FinishTime=0 for DONE jobs). Fixed additively (user's explicit steering: "don't change the logic, just add extra information") by keying atime(NULL)stamp onwal_typeright afterapply_job_update_transition()succeeds, still under the samelock(j, RTTI_LOCK_WRITE)—WAL_JOB_START→start_time,WAL_JOB_FINISH→finish_time+run_time = finish_time - start_time. No change toapply_job_update_transition()'s signature or the dispatch structure. Mirrors what the richer (currently-unreached-on-this-path)apply_job_start_transition()/apply_job_finish_transition()cores injob.calready do for their own callers. -
test_config_repl.c'stest_conf_trim_keeps_only_n_versions/test_conf_get_saved_tag_no_configfailing with the exact same Expected/Was values plus a burst ofpersist: flusher fdatasync FAILED (errno=5 Input/output error)lines is bug-1561, a confirmed overlayfs-sandboxfdatasyncartifact — 6 occurrences now across unrelated sessions/diffs, never once traced to a real code change. If a/xce-build controllerrun shows exactly these 2 failures with that exact error pattern, it's environment noise, not something your change caused — don't spend time re-investigating, just note it and move on (though still bump bug-1561'soccurrences/last_seenper buglog protocol). -
Testing an "on a clean tree" scenario against a shared repo that's under continuous concurrent background editing (other agent sessions, OpenWolf hooks, etc.) cannot rely on the ambient working tree's
git statusever actually being clean. dirty-content-fingerprint task 6.1 (src/tools/test-dirty-fingerprint-distinguishability.sh, 2026-08-21) solved this by creating its own throwaway, fully-isolatedgit worktree add --detach <tmp-dir> HEADbefore doing anything else — a fresh linked worktree checkout is clean by construction (zero uncommitted changes) and is a completely separate directory tree, so concurrent activity in the original shared worktree can never touch it. Bonus:src/tools/xce-build.shresolves its ownSRC_DIRfrom$0's location andcds there itself before running anygitcommand — so simply invoking the ISOLATED worktree's own copy ofxce-build.sh(not the shared tree's copy, and regardless of the caller's own cwd) automatically scopes every git command inside it (rev-parse/status/diff/ls-files) to the isolated worktree, with zero extra-C/cdbookkeeping needed by the caller. Clean up withgit worktree remove --force <dir>(plainrm -rfalone leaves stale worktree metadata — needs agit worktree prunefallback too). General pattern: reach for an isolatedgit worktree(notgit stash, not hoping the ambient tree happens to be clean) any time a test genuinely needs to observe a controlled clean/dirty state transition in a repo that isn't exclusively yours for the run. -
A
local a="$1" b="$a/something"— two assignments in ONElocalstatement where the second references the first — is a real bug underset -u, not just bad style (bug-1615, found live writing the script above). Bash expands every word of a singlelocalcommand before ANY of that command's assignments take effect, so$ain the second word's value expands against the OLD (not-yet-declared)a, producingiso_src: unbound variable(or silent empty-string under plainset -ewithout-u). Fix: split into two separatelocalstatements on their own lines. Same family as the earlier-loggedfp="$(cmd)"underset -egotcha (cerebrum,xce-build.shdirty_fingerprint note) — another case where a single-line-looking assignment has a non-obvious evaluation-order trap under bash's strict-mode flags. -
builtins.currentTimeis entirely unavailable ("attribute 'currentTime' missing") during a flake's default pure evaluation — not merely fixed to a dummy value, the attribute is removed frombuiltinsoutright. Confirmed vianix evalboth ways: a barenix eval .#pkg.someAttr(ornix build) referencingbuiltins.currentTimeanywhere it gets forced fails at eval time;nix eval --impure .#pkg.someAttrsucceeds and returns the real epoch. This is unrelated to the derivation build sandbox (sandbox = falsein this machine's nix.conf) — it's Nix's flake-level pure-eval restriction on impure builtins, and it applies regardless of where in the file the reference sits (laziness only delays the error until the value is actually forced, e.g. by string-concatenating it intomesonFlags).self.shortRev/self.dirtyShortRev(the existingcommit_idmechanism) are NOT affected — those come from flake input/git introspection that Nix computes specially even in pure mode, not from an impure builtin. RESOLVED (bug-1603, 2026-08-20): task 2.2's first attempt usedbuiltins.currentTimeinsrc/flake.nixper research.md's original decision, and was REJECTED by review becausenix build .#xcecore_debug(no flag, the documented canonical command) failed at evaluation exactly as predicted above. Fixed by moving the computation entirely out of Nix evaluation and into each derivation's own build phase instead — see thepreConfigure/mesonFlagsArrayentry below. Nix-eval-time impure builtins should be treated as generally unusable for anything that must survive a plainnix build/nix eval(no--impure), full stop — don't reach forbuiltins.currentTime(or similar) in a flake output again; use a build-phase shell hook. -
nixpkgs'
meson.hook/setup-hook.sh (mesonConfigurePhase, confirmed by reading the actual hook source in the locked nixpkgs tree atpkgs/by-name/me/meson/setup-hook.sh) runsrunHook preConfigureFIRST, then builds itsmeson setupinvocation viaconcatTo flagsArray mesonFlags mesonFlagsArray— so a Nix derivation'spreConfigureshell-hook attribute can compute a value at BUILD time (inside the sandbox, via stdenv's own bundled coreutils — no extranativeBuildInputsneeded) andmesonFlagsArray+=("-Dfoo=$val")it, and that flag reaches the realmeson setupcommand line, all within the same shell process (stdenv's generic builder runs every phase/hook in one continuous bash script, no subshells between them) — confirmedfoo+=(...)on a variable never declared as a Nix attribute (so genuinely unset, not just empty) still works fine even under stdenv'sset -eu(bash -c 'set -eu; foo+=("x"); echo "${foo[@]}"'succeeds, auto-vivifies as an indexed array). This is the general pattern for "a nix package needs a value only knowable at build time, not eval time" (e.g. build-time-versioning task 2.2'sbuild_time, fixed via this exact mechanism inxce.nix/xcecli.nixafterbuiltins.currentTimebroke pure-eval — see the entry above). Live-verified:nix build .#xcecore_debug's build log (nix log <drv>) showedmesonConfigurePhase flags: ... -Dbuild_time=2026-08-20T09:13:29Zand meson's own summary printingbuild_time : 2026-08-20T09:13:29Z. -
nixpkgs.lib has no epoch-seconds→ISO8601 formatter (checked
lib/*.nixin the locked nixpkgs source tree directly — nostrings.nix/trivial.nix/etc. function does this). This is now moot forbuild_timespecifically (see above — it's computed via shelldate -uin a build-phase hook, not in Nix expression code at all), but still true in general for any future nix-side ISO8601 need. -
xce-build.shdefaultsBUILD_DIRto the same path (xce.build) regardless of component, and its non---incrementalsetup_build()doesrm -rf "$BUILD_DIR"+ freshmeson setupon every invocation — two concurrentxce-build.shruns for DIFFERENT components in the SAME working directory race on that shared path. (bug-1604, 2026-08-20). Live-confirmed twice in one session: (1) ascheduler asanrun's initialrm -rfhitrm: cannot remove '.../controller_unit_test.p': Directory not emptybecause a second, independently-runningxce-build.sh controller asanprocess (same cwd, different session) was actively writing intoxce.build/at that instant — simply retrying once the other process's own clean pass finished resolved it. (2) minutes later, the freshly-verifiedxce_schedulerbinary (checked present + fresh mtime,--versionrun successfully) had VANISHED fromsrc/xce.build/scheduler/— the same concurrent controller build's ownrm -rfhad wiped and was regeneratingxce.build/for its component, silently invalidating the just-verified scheduler binary out from under the caller. Before trusting any non-incrementalxce-build.shbinary/mtime to still be valid, or before starting a clean build in a worktree another session might also be using, checkps aux | grep xce-build.shfor a concurrent run — different components sharing one worktree's defaultxce.buildis a real, reproducible race, not environment flakiness (this was initially misdiagnosed as an overlayfs artifact before the concurrent process was found). -
Live smoke-testing apiserver's
-version/startup-log output (build-time-versioning task 4.4) needs a real topdir, but a fullxce-deploy-hadeployment is overkill. Recipe:mkdir -p $TOPDIR/config $TOPDIR/logsthen copy the four shipped templatessrc/frontend/apiserver/config/{app,logger,auth,rbac}.yamlinto$TOPDIR/config/verbatim, thentimeout 10 xce_apiserver -d $TOPDIR. The shippedapp.yamltemplate has a livebackend: {address: localhost, port: 9901}block with no controller actually running there, so the process logsAttempting backend connection→WARN All configured backend candidates failed→ERROR Failed to connect to backendand exits 1 within ~10ms — this is fine and expected for verifying only the startup log's FIRST lines (logger init, before backend connect is even attempted); no live controller needed. Log lands at$TOPDIR/logs/apiserver_out.log(fromlogger.yaml'soutputPath: apiserver_out.log, joined with$TOPDIR/logs/byInitLogger()). Separately,xce_apiserver -version(no-dat all) exits 0 with zero filesystem side effects (nologs/dir, no config read) — confirms the-versionearly-exit genuinely runs beforePromptForTopDir()/InitLogger(), not just before the visible log line. -
This codebase's apiserver Go code has ONE idiomatic zap-logging style: structured fields via
zap.String(...)/zap.Error(...)appended to thelogger.Info/Error/Debug/Warn(msg, fields...)call, never Sprintf-style interpolated messages — confirmed by grepping everylogger.Info/Error/Debug/Warncall site acrosscontrollers/,middleware/,router/(files.go, auth.go, rbac_check.go, validatehandler.go, routers.go, permissions.go all exclusively use this pattern). Even thoughencoding: consoleis configured inlogger.yaml, the fields still render as trailing JSON on the log line (already documented above) — that's fine, it's still the right convention to follow for any new log call site in this package, don't reach forfmt.Sprintfinto the message string instead. -
gofmt -l/gofmt -donapiserver/cmd/main.goreports a PRE-EXISTING import-ordering violation (_ "apiserver/docs"sorted before"apiserver/backend"instead of after, alphabetically) that predates build-time-versioning task 4.4 and is unrelated to it — confirmed viagit show HEAD:.../main.go | gofmt -l -on the pre-edit blob, same violation. Don't "fix" it as a drive-by inside a task whose boundary is a single file with no mandate to touch unrelated pre-existing formatting — flag it, don't silently reformat, since an unrelated reformat in the same diff makes the real change harder to review (mirrors the existing Do-Not-Repeat entry about not runningclang-format -ion whole existing C files). -
In any script running under
set -euo pipefail(e.g.xce-build.sh), a bare assignment whose RHS is solely a command substitution (fp="$(cmd)") is NOT exempt from-e— ifcmdfails, that assignment's own exit status equalscmd's, and since a standalone assignment statement isn't a context-etreats as "tested" (unlike being the condition ofif/while/&&/||/!), a failure there aborts the WHOLE script, not just that value's computation. Onlyif var="$(cmd)"; then ... fi(orcmd || true) is actually exempt. This bit dirty-content-fingerprint task 2.1'sdirty_fingerprintcomputation (sha256 overgit diff HEAD+ sorted untracked file content) inxce-build.sh: every intermediate command (mktemp,git diff, thegit ls-files | sortpipe, eachcatin the untracked-file loop, and the finalsha256sum | cut) had to be wrapped in its ownif/elif ... else fp_ok=0check rather than trusted to propagate failure naturally, specifically so a failure (e.g.sha256summissing) degrades to an empty fingerprint (Requirement 5.1's "never fabricate") instead of crashing the entire build invocation. Verified live by temporarily hidingsha256sumfromPATHin an isolated scratch repo — script printeddirty_fingerprint=and exited 0, not aborted.
Do-Not-Repeat
-
When translating a
fp_ok-tracked, per-step-gated failure-detection pattern (likexce-build.sh's dirty-fingerprint computation) into a Make$(shell sh -c '...')one-liner, do NOT collapse two commands into{ cmd1; cmd2; } >"$$fp_tmp"and gate the whole group with oneif— a POSIX sequential group's exit status reflects only its LAST command, socmd1's failure is silently discarded whenevercmd2still succeeds (2026-08-21, bug-1612:git diff HEADfailing was swallowed because the trailinggit ls-files | sort | xargs catpipe still exited 0, producing a fabricated fingerprint instead of degrading to empty). Give each step its own explicitif ! step; then fp_ok=0; fi(or&&-chain), exactly mirroring the reference script's discipline, even inside a cramped one-liner. Caught by adversarial code review with a targeted failure-injection test (wrappergitonPATHthat fails only the targeted subcommand) — that test pattern is the reusable way to verify this class of fix. -
Don't run
clang-format -ion whole existing files here — the repo isn't clang-format-clean at baseline, so a full reformat buries the real diff; recovering viagit checkout HEAD -- <file>on a file with other uncommitted work destroys that work irrecoverably. -
Before citing a bug as "still open" or a spec as "blocked," cross-check
.wolf/buglog.json's actual fix status and the spec's own tasks.md/commit history — blocked_on notes and prior narrative claims (including this file's own past entries) can be stale. Self-caught recurrence (2026-08-19): while reconciling OTHER stale doc references, wrote a new tasks.md status line asserting "tasks 2.1-2.6 still carry no_Verified:annotations" by trusting a 2026-08-07 validation finding's own wording verbatim, without re-checking the file — they'd actually been backfilled the very next day (commitd7b49690, 2026-08-08). A dispatched verification agent caught it viagit log/direct read. Lesson holds even for a claim you are ABOUT to write, not just one you're citing from memory: grep/read the actual current state of the specific lines before asserting their status, every time, no exceptions for "this one's probably still true." -
Before trusting an "all tests pass, GO" claim on a stale/uncommitted tree, re-run the suite yourself — a buglog "FIXED" note can describe the intended fix while the code on disk is mid-revert from RED-phase construction.
-
A generic retry/failover classifier that judges retriable-vs-terminal by a raw return value's magnitude (comparing against known errno values) is unsafe unless every wrapped call site shares the same success convention — a call that legitimately returns a variable count on success can numerically collide with an error code.
-
When two independent "is it ready" signals exist server-side, a wait/convergence helper gating on only one does not imply the other is satisfied — check what the actual raced precondition depends on.
-
Nix fixed-output-derivation hash mismatches from an upstream input pinning a mutable branch: re-locking flake.lock is a dead end once already at the latest commit; fix via a local
overrideAttrspinningsrcto an explicit immutable commit in the consuming repo. -
pkill/pgrepby bare process name (unscoped) can kill or match a different concurrent invocation's processes, including a sibling session's build/soak — always scope process matching to something unique to the current run (e.g. a workdir path). -
Stacked/masking bugs in never-before-reached code paths: when a bug prevents a code path from EVER executing, fixing it can immediately expose 1+ MORE bugs that were always there but never triggered. bug-1569 thread B was "no job ever gets scheduled" -- fixing cause #1 (scheduler.c's sched_init_queues() never calling picker_iface->on_queue_update() for builtin_fcfs, so its candidate registry stayed empty forever) let a job reach the allocator for the first time ever, which immediately SIGSEGV'd on cause #2 (core_events.c's core_build_job() never constructing job->schedobj, a documented-but-wrong assumption from the scheduler-core rewrite). Fixing #2 let a job reach genuine dispatch+resource-charge accounting for the first time ever, which immediately SIGSEGV'd on cause #3 (resource.c's put_resvals() had an off-by-one,
idxs[i] <= 0treating resource idx 0 -- "slots" -- as an invalid sentinel). Lesson: after fixing a "nothing ever happens" bug, don't declare victory on the first crash/error that surfaces -- it may be the SECOND (or third) bug the first one was masking, not a regression from your own fix. Verify via gdbbt fullon the actual live crash, not guesswork from reading code alone. -
xce_scheduler -i/--sim(the interactive REPL) starts PAUSED at the initial snapshot and never advances the simulated clock past a recordedReplayEvent/ReplaySessionuntil you send an explicitstep [N]orcontinue. Piping"info worker <name>\nquit"with nostep/continuefirst only ever shows the pre-replay baseline state — this cost a large chunk of bug-1569 investigation, wrongly appearing to show a second "periodic resources still 0.00 after the host-mismatch fix" bug when the fix was already fully correct and sufficient;step N(N large enough to pass the relevant event, confirm viaxceadmin scheduler dump <file>first if unsure of event ordering) revealed the true, correct values. Before concluding a replay-derived state is wrong, alwaysstep/continuefirst. -
A dead
#if 0 /*FIXME*/ ... #endifblock is a signal the disabled code is unsafe as written, not merely "not yet wired in" — don't just uncomment it. bug-1578:sched_worker_change()'s disabled block calledfree_name_val_list(&w->host.resvals_to_sched, &w->host.nresvals_to_sched)right beforexlist_fini(&resvalist)— butresvalist.dataandw->host.resvals_to_schedare the SAME pointer (the earlier line aliased one to the other's backing array), andfree_name_val_list()already frees that array itself; uncommenting as-is would double-free. The safe fix null-and-reset the aliased fields directly (w->host.resvals_to_sched = NULL; w->host.nresvals_to_sched = 0;) and letxlist_fini()be the sole owner of the free — the pattern already proven correct in the siblingapiserver_worker_change()(apiserver.c). General lesson: when re-enabling dead code, first work out WHY it was disabled (git blame + read what it actually does to shared/aliased memory), don't assume#if 0means "harmless, just needs a flip." Other call sites still doingfree_name_val_list(&(w->resvals_to_sched), ...)on this same field (dataex.c:435, opget.c:128, reply.c:66, apiserver.c:51) were NOT audited for the identical aliasing hazard as part of this fix — flagged, not yet checked. -
xce_test's!<shell-command>escape (preprocess_and_run(), single call site inmain()'s top-level REPL loop,test.c~line 950-998, backed by a plain blockingsystem()) works IDENTICALLY in every REPL context, includingworker— noleave_ctx()/disconnect happens, unlike moving between contexts via../cmd_up. This is the general pattern for "run an out-of-band check while a stateful REPL session must stay connected": bake a!-prefixed line into the script fed to the session (before itsquit) that shells out to ANOTHER invocation of your own driver script in a hidden internal mode (e.g.! bash "$0" --internal-<mode> <args>), intercepted via a dispatch check placed BEFORE the normal arg-parsing entry point at the very bottom of the file. Used to fix bug-1579 (resource-value-verification): the controller-side resval check now runs nested inside the injecting worker session's own!escape instead of as a separate xce_test process launched afterquitalready disconnected the worker (which reset host-attrs resources to baseline first, an always-false MISMATCH). Gotchas: (1) the nested process must generally return exit 0 even on partial/expected failure conditions — a nonzero exit becomes the outer session'sg_last_status/$?, and in non-interactive/batch modepreprocess_and_run()ABORTS the REPL loop before any later command (includingquit) runs; surface real failures via a sentinel/marker file the OUTER script checks AFTER the whole session completes, not via the nested process's own exit code. (2)system()'s child inherits the invoking process's environment but NOT its parent bash's local (non-exported) shell variables — bake every value the nested invocation needs (paths, host lists, names) as literal,printf '%q'-quoted arguments directly into the!line's command string, don't rely on env-var passthrough through thenix develop/ASAN-wrapped intermediate hops. (3) since accept/reject-style bookkeeping computed by the REPL session itself is only visible as TEXT PRINTED to that session's own stdout — not accessible to a freshly-spawned nested process — have the nested step collect RAW, unfiltered data for every candidate (not just ones later known to be "accepted") and defer accept/reject filtering to the outer script, after it has parsed the whole session's captured output post-quit. (4) live-verified no orphan/zombie processes result even when a SIGTERM interrupts the outer driver script WHILE the nested!-escape's own sub-session is actively running — bash defers a pending trap until the current foreground command (the whole piped xce_test invocation, nested check included) returns, so the child process tree either completes and exits cleanly on its own or the trap fires right after; confirmed via a full/proc/[0-9]*/cmdlinescan, not justpgrep. -
Piping scripted commands into
xce_test(the controller REPL/testsuite binary) with defaultASAN_OPTIONSloses ALL stdout output when redirected to a file/pipe.xce_testis an ASAN build;detect_leaks=1is the default, and this binary has small pre-existing intentional leaks (e.g.set_resval'scalloc,cmd_resupdate'sstrdupforresname— never freed by design, REPL-lifetime scratch data). LeakSanitizer's exit-time report appears to bypass/precede the normal stdio flush when stdout is non-interactive (fully block-buffered), so a redirected-output smoke test showed ONLY the ASAN leak report and none of the actual REPL command output (join/resupdate/resval results), even though the commands genuinely executed (confirmed via the leak stack trace itself). Fix: always runxce_testwithASAN_OPTIONS=detect_leaks=0(matching the meson test harness's own invocation, which already sets this) whenever piping/redirecting its stdout for a live smoke test — e.g.nix develop ./src --command env ASAN_OPTIONS=detect_leaks=0 xce_test < cmds.txt. -
A fork/subagent dispatched in a prior session that claimed "build/tests in progress, will report back" is NOT reachable in a new session —
ListAgentswill not show it, and its self-report (if logged to memory before the session ended) describes an intent, not a completed result. 2026-08-19: a fork agent from the previous session was recorded as "actively writing tests... then building via xce-build skill and reporting final metrics," but the session ended before it reported. On resuming ("continue"), the scheduler test binaries insrc/xce.buildwere still dated Aug 18 14:27 while the source edits were Aug 19 09:18-09:27 — proof the claimed build never actually happened in this environment. Always verify via binary/sourcestatmtime comparison (or just re-run the build) before trusting a cross-session "in progress"/"dispatched" claim, same discipline as the existing "stale/uncommitted tree GO claim" entry above but for cross-session fork continuity specifically, not just tree staleness. -
Go's
-ldflags -X importpath.name=valueis silently a no-op (not a build error, not even a printed warning) when the targetmainpackage has no such package-level string var declared — confirmed live (build-time-versioning task 4.1, 2026-08-20): builtxcecli/cmd/main.go(which does NOT yet declareGitCommit/BuildTime, those land in task 4.4/4.5) with-ldflags "-X main.GitCommit=abc123 -X main.BuildTime=..."via both a directgo_buildinvocation and the fullxce-build.sh xceclimeson path — exit 0 both times, working ELF binary produced,grep -i "warning\|no such"on the full captured output found nothing beyond an unrelated nix git-dirty-tree line. This means task 4.1 (the-ldflagsinjection ingo_build) has NO real ordering dependency on tasks 4.4/4.5 (the consuming vars) — safe to land and validate standalone, contrary to what a cautious reading of Go linker docs might suggest. -
A REPL/replay test fixture that reuses the SAME jobid for both a "real" event (job push) and a "cheap padding" event (job state change, added purely to exercise a second event type) accidentally mutates the real job's state, not just decorates the log. bug-1595 test regression (task 12.5, 2026-08-19):
test_step_echoes_events_before_session_decisionspushed job 6161 then sent a JOBSTATECHANGE event for the SAME jobid 6161 (PEND->RUN) purely to get a second event type echoed — this genuinely transitioned the real job to RUNNING before the session ran, so the picker'snext_job()never offered it and the session's own PEND decision (which the test also asserted on) was never produced. The sibling testtest_event_breakpoint_pauses_repl_at_matching_eventalready documents the correct pattern in its own comment (append_jobstatechange_event() establishes: core_events.c WARN+skips an unknown jobid rather than fail, so ... below needs no real job to exist) — it deliberately used unrelated jobids (111/222) precisely to keep the padding event inert. When adding a "just need any event of type X to be logged" filler event to a fixture that also has a real job in flight, always target an unrelated/nonexistent jobid unless the state transition itself is the thing under test. -
[ -n "${arr[key]+x}" ](associative-array key-EXISTENCE) is NOT a safe proxy for "the value is meaningful/reachable" when the producer unconditionally sets that key even on failure. bug-1582 (resource-value-verification task 7.1, round-1 REJECTED, round-2 fixed):main()'s record-building loop derivedsched_ok/api_okfrom whetherSCHEDULER_OBSERVED[$vname]/APISERVER_OBSERVED[$vname]existed — butquery_scheduler_resvals()/query_apiserver_resvals()(already-approved tasks 6.3/6.4) always set that key, setting it to""on a genuine UNREACHABLE/timeout rather than leaving it unset. Key-existence was therefore always true, silently masking every real UNREACHABLE as a MISMATCH (comparing the injected value against an empty string). Fix: derive the "is this layer reachable" signal from the layer's own pre-classified status string (SCHEDULER_CHECK_RESULTS[$vname]/APISERVER_CHECK_RESULTS[$vname], which DOES distinguishUNREACHABLE:*fromMATCH/MISMATCH:*) instead of from a sibling data array's key presence. General lesson: before using${arr[k]+x}/-v arr[k]as a "was this checked / did this succeed" signal, verify the producer actually leaves the key UNSET on failure — if it sets it to an empty/placeholder value instead (a common pattern for "always populate every requested key so downstream code doesn't need existence-checks"), key-existence collapses to "was this key in the requested set" a wholly different, weaker signal than "did this succeed". Also: a synthetic test that only calls the pure aggregation function directly with hand-built records (task 8.2's original approach) cannot catch a bug living in the data-marshaling code that BUILDS those records — this class of bug needs the marshaling code itself extracted into a directly-callable function (build_verdict_records_from_tsv()) and exercised by its own test. -
This coding-agent harness's interactive shell aliases plain
grepto a PCRE-capable (ugrep-backed) wrapper via a.bashrc-sourced shell FUNCTION — but that function is interactive-shell-only and is NOT inherited by a script invoked asbash script.sh, which falls back to whatever the realgrepbinary on PATH is (in this environment: BusyBox, no-Psupport at all). (2026-08-20, build-time-versioning task 6.2):echo x | grep -oP '(?<=x)y'succeeded fine when typed directly as a Bash-tool command, but the identicalgrep -oPcall inside a standalone.shfile, run viabash thefile.sh, failed withgrep: invalid option -- 'P'(BusyBox usage dump). Confirmed viatype grepin an interactive call (shows a_cc_a-prefixed shell function shelling out to the Claude Code binary itself acting as ugrep) vs.which -a grep//sbin/grep --versionshowing BusyBox as the real underlying binary. Any shell script file meant to be run standalone (not just typed inline as a Bash-tool command) must assume POSIX-only grep/sed (BRE,-E,-F,-o) — no-P/PCRE, no lookbehind/\K. Usesed -n 's/.../\1/p'(POSIX BRE, works under BusyBox) instead ofgrep -oP '...\K...'for field extraction inside any committed script. -
A direct
go build(even a real, working one) without-mod=readonlycan silently rewrite a COMMITTEDgo.sum, adding unrelated indirect-dependency checksum lines as a side effect of resolving the full module graph — even thoughgo env GOFLAGSwas empty and go.mod itself was never touched. (2026-08-20, build-time-versioning task 6.2): buildingapiserver/cmd/main.godirectly (bypassing the network-hunggo_buildwrapper, see below) added ~65 new/go.mod-hash-only lines tosrc/frontend/apiserver/go.sumon the first attempt — caught only via a post-hocgit status --porcelainsweep, not by the build itself (exit 0, no warning). Go 1.16+'s-mod=readonlydefault blocks go.mod EDITS but does NOT by itself block go.sum EXTENSION for modules already implied by go.mod's requirements. Fix: pass-mod=readonlyEXPLICITLY on every ad-hocgo buildinvocation that isn't supposed to touch repo state — confirmed live that the same build still succeeds under explicit-mod=readonlywith zero go.sum diff, so nothing was genuinely missing; the extra entries were pure side effect. Any script/agent that runsgo builddirectly against a checked-out repo (not via the project's own wrapped build path) must always pass-mod=readonlyand verifygit status --porcelainon go.sum/go.mod afterward, every time, no exceptions. -
src/tools/go_build's hardcodedGOPROXY=https://goproxy.cn+ a fresh-per-invocationGOCACHE/GOPATHunder meson's own$TMPDIRsandbox can hang indefinitely in this environment — not fail fast, HANG: an established (not refused/reset) TCP connection to goproxy.cn:443 sits infutex_do_waitwith near-zero CPU time for 8-10+ minutes across repeated attempts. (2026-08-20, build-time-versioning task 6.2):xce-build.sh apiserver <profile> <dir>(which builds apiserver AND xcecli together via this wrapper) reliably hung on xcecli's fresh module downloads; confirmed viass -tnpshowingESTABto8.45.176.179:443(=goproxy.cn, independently reachable fine via plaincurl//dev/tcpfrom the SAME shell) with thegoprocess's CPU time frozen — a genuinely stuck data path, not slowness, since it never progressed no matter how long left running. Root cause isolated togo_build's own env overrides (export GOCACHE=$TMPDIR/go-cache; export GOPATH=$TMPDIR/go; export GOPROXY=https://goproxy.cn), which bypass the ALREADY-POPULATED default$GOPATH/pkg/modcache (go list -m allfrom an ordinarynix developshell, no wrapper, resolved apiserver's full module graph in under a second, zero downloads). Workaround (do NOT modify go_build/Makefile — this is this specific sandbox's networking quirk, not a real bug in those files): invokego builddirectly with the default module cache (GOPROXY=offis fine since everything needed is already cached) plus the same CGO_CFLAGS/CGO_LDFLAGS pkg-config derivationtest-backend/apiserver's own meson.build already uses (see bug-1597's documented fix) whenever a real apiserver/xcecli build is needed standalone in this sandbox andxce-build.sh apiserver/make build-serverhang or fail. Do not blindly increase the timeout and retry — a truly stuck TCP data path does not resolve itself no matter how long you wait; diagnose viass -tnp//proc/<pid>/wchanfirst. -
Refinement to the above (dirty-content-fingerprint task 4.4, 2026-08-21): when the Go-side change under test lives ONLY in
apiserver/cmd/main.go(or anothercmd-level file) and doesn't need the real cgo backend, skip bug-1597's full CGO_CFLAGS/CGO_LDFLAGS pkg-config reconstruction entirely —apiserver/backend/already ships a//go:build !cgostub (stub.go) alongside every//go:build cgofile, soCGO_ENABLED=0 GOPATH=/home/claude/go GOPROXY=off go build ./cmd/main.go(matching the Makefile's owntesttarget convention,GOFLAGS := CGO_ENABLED=0) compiles cleanly with zero C dependencies and produces a real, runnable binary — confirmed live acrossgo vet,go test, and 5 distinct-ldflags-injected-versionscenarios plus a real (if CGO-stub) daemon-start log capture. Only reach for the full CGO reconstruction when the task actually needs the real backend/libxce integration exercised (e.g. bug-1597's ownbuild-serverscenario).-mod=readonlywas NOT needed this time (checkedgit status --porcelainon go.sum/go.mod after every build — zero diff both times), likely because the module graph was already fully resolved in/home/claude/go/pkg/modfrom prior sessions; still worth checking every time per the entry above, since whether it triggers depends on cache state, not code. -
This sandbox's
nix build(notnix develop) dispatches to a REMOTE builder over SSH (ssh://rshen@172.31.109.18), which is NOT reachable directly via SSH from inside this sandbox (connection times out — same network restriction family as the goproxy.cn DNS failures). (2026-08-21, dirty-content-fingerprint task 6.3): confirmed vianix build's own stderr ("The failed build directory was kept on the remote builder due to--keep-failed... re-run with--builders ''to disable remote building"). Practical consequence:--keep-failed's leftover build directory (containing real, successfully-linked binaries from a partially-failed multi-target derivation) is NOT locally inspectable/runnable without either--builders ''(forces a full local rebuild from scratch — expensive, full ASAN tree) or SSH access to that remote host (unavailable here). When a task needs evidence from anix buildthat can't fully succeed (e.g. the known bcctool/goproxy.cn limitation), prefernix eval(fast, eval-time, no builder involved) cross-checked against the real build LOG'smesonConfigurePhase flags:line (via-L) rather than trying to extract-and-run an actual compiled artifact — this is also literally what task 2.2 already did. -
This sandbox's
mktempis BusyBox's implementation, not GNU coreutils — it requires the TEMPLATE to literally END inXXXXXXwith nothing after it (no--suffixflag, no trailing literal suffix like.XXXXXX.log). (2026-08-21, dirty-content-fingerprint task 6.3):mktemp "path/name.XXXXXX.log"fails with a baremktemp: Invalid argument(no other explanation) under BusyBox;mktemp --helpconfirms ("TEMPLATE must end with XXXXXX"). Always end mktemp templates in this repo's scripts withXXXXXXand nothing else — append any desired suffix to the returned path afterward if truly needed, don't rely on GNU's suffix support. -
A self-check that greps a script's OWN SOURCE for a literal flag string (e.g. confirming
--impureis never used) will false-positive on the script's own comments/log messages if those comments discuss the flag by name (which good documentation often does). (2026-08-21, dirty-content-fingerprint task 6.3): a blindgrep -q -- '--impure' "$0"matched this script's own header prose explaining why--impureis deliberately avoided. Narrow such self-checks to lines that begin an actual invocation of the relevant command (e.g.grep -A2 -E '^[[:space:]]*nix (eval|build|develop|log)\b' "$0" | grep -q -- '--impure'), not a whole-file grep — this generalizes to any "assert we never do X" self-check in a script whose own documentation legitimately mentions X. -
Reinforcement of the bug-1615 same-statement
local a=... b="$a..."gotcha: recurred independently in a brand-new file (extract_flag_from_json(), dirty-content-fingerprint task 6.3, logged as bug-1616) less than a day after being first documented — this pattern is easy to reach for out of habit when writing a "compute one derived value from a parameter" helper. When writing ANY new bash function withlocal x="$1" y="...$x...", default to splitting the dependent assignment onto its ownlocalstatement, don't rely on remembering the gotcha in the moment.
Decision Log
- HA/consistency model follows Raft + CP strictly: majority ACK is the hard commit barrier for all state-changing writes (reject on timeout, never local-apply-and-degrade); the own-term commit rule (not a 4th "COMMITTING" state) is what gives a new leader safety.
- A controller process must NEVER self-exit/self-abort as a designed response to an operational condition (only a genuine crash or admin/supervisor kill) — an unrecoverable/fenced member logs loudly, stays permanently non-promotable, stays alive, and keeps retrying.
- Commit-first-then-reply: job/queue/host control ops validate → mutate(provisional) → WAL append → commit_submit(WAIT) → reply; no success reply before commit. Worker-reported fact entries instead follow pure Raft semantics — retained/retried indefinitely, no commit timeout.
- No client reply-wait timeout as a fix for a hung request — fail loud at the real transport/source instead of masking with a deadline backstop.
- Product is pre-release: no backward/mixed-version wire compatibility required; wire format changes may be made freely.
resource-value-verificationtask 7.1 (2026-08-18):aggregate_verdict()/build_verdict_record()(run-resource-verify.sh) re-derive MATCH/MISMATCH/UNREACHABLE from raw*_OBSERVEDvalues viacontroller_values_match()at aggregation time, rather than trusting each layer's already-renderedCONTROLLER_CHECK_RESULTS/SCHEDULER_CHECK_RESULTS/APISERVER_CHECK_RESULTSstrings from tasks 6.2-6.4 -- deliberate, so the SAME classification code path is exercised by both the live-run wiring and task 8.2's synthetic-record tests (a synthetic test that only fed pre-classified strings would just be testing string formatting, not the comparison logic). A rejected resource name is modeled as its own failure category (REJECTED, layer=injection) distinct from a per-layerMISMATCH/UNREACHABLE, and always forces overall FAIL, per design.md's Error Handling ("unrecognized resource name is a run-level failure") -- this is NOT implied by Requirement 6.2/6.3 alone (those only speak to "checked layers"), it's a deliberate design-level extension. The script's bottom dispatch block is now guarded ([[ "${BASH_SOURCE[0]}" == "${0}" ]]) so it can besourced to getaggregate_verdict()et al. in scope with zero side effects (nomain()/deployment triggered) -- this is the intended integration point for task 8.2's dedicated test harness.resource-value-verificationtask 7.1 round 2 (2026-08-18, bug-1582, round-1 REJECTED -- see Do-Not-Repeat entry for the mechanism):main()'s OWN record-building loop (feedingaggregate_verdict(), distinct fromaggregate_verdict()/build_verdict_record()themselves, which were and remain correct) had the actual bug --sched_ok/api_okderived from*_OBSERVEDarray-key existence instead of the*_CHECK_RESULTSclassification strings, masking every genuine scheduler/apiserver UNREACHABLE as MISMATCH. Fixed by switching to a leading-UNREACHABLE:check onSCHEDULER_CHECK_RESULTS/APISERVER_CHECK_RESULTS(the controller layer'sctrl_okderivation fromCONTROLLER_OBSERVEDarray-key existence was independently confirmed fine and left untouched -- that layer has no separate UNREACHABLE concept). Also extracted the loop into a standalonebuild_verdict_records_from_tsv()function (populates globalVERDICT_RECORDS) specifically so a synthetic test can exercisemain()'s actual data-marshaling code, not justaggregate_verdict()called with hand-built records -- the round-1 gap was that no test exercised the code that BUILDS records from the*_OBSERVED/*_CHECK_RESULTSglobals, only the pure aggregation function itself. Live-reproduced by killing the scheduler process right afterconfirm_deployment_up()returns (beforeinject_resources()/query_scheduler_resvals()ever run) -- deterministic, no race window, and confirmed the controller/apiserver layers are unaffected by an isolated scheduler kill (each layer's check is independent).build-time-versioningtask 4.2 (2026-08-20):apiserver/meson.build/xcecli/meson.build's existingCURRENT_SOURCE_DIR="@CURRENT_SOURCE_DIR@"/BUILD_ROOT="@BUILD_ROOT@"command-array entries (passed toenv_program = find_program('env'), no shell involved) put literal double-quote characters INTO the env var value seen by the child process — meson'scommand:list is exec'd directly, so shell-style quoting around a placeholder is not stripped by anything;go_build's ownfix_input_envs()explicitlysed -e 's@"@@g's those two vars to compensate, proving this empirically. When adding new KEY=VALUE entries to this SAME mechanism (XCE_GIT_COMMIT/XCE_BUILD_TIME, sourced fromget_option('commit_id')/get_option('build_time'), task 1's options — no meson placeholder substitution needed since they're already resolved strings), deliberately did NOT wrap them in quotes ('XCE_GIT_COMMIT=' + get_option('commit_id'), not'XCE_GIT_COMMIT="..."') —go_build's task-4.1 code reads$XCE_GIT_COMMIT/$XCE_BUILD_TIMEdirectly with no quote-stripping, so quoting these would have embedded literal"characters into the linked-X main.GitCommit=...value. Live-verified viaDEBUG=1(go_build's ownset -xtrace mode) meson-driven build: clean values (18ae0cc3, ISO8601 timestamp) reachedgo build -ldflags, andxce-build.sh apiserver/xcecliend-to-end produced binaries with-X main.GitCommit=<hash>-dirty -X main.BuildTime=<ts>in theirgo version -mbuild info, no stray quotes. General lesson: "mirror the existing mechanism" doesn't mean copy-paste every byte of an existing established pattern — check whether the DOWNSTREAM consumer (here,go_build) actually expects/strips the same decoration before reusing it verbatim.resource-value-verificationspec (2026-08-17): verify scheduler/apiserver resource-value propagation via a one-line trace/debug log at each layer's point of application (core_events.c's RESVALS_DELTA case; apiserver'sOnResourceLocationUpdated), grepped live, instead of record+replay+REPL or a REST/CLI query — matches how bug-1568/1569 were actually root-caused, and is a stronger read of "the scheduler's own resource state" than a replayed reconstruction. Trade-off accepted: doesn't exercise the real query/REST path, only storage correctness. Load-bearing gotcha:TRACE=tlog_debug3needs-vvv; apiserver'slogger.Debugneedslogger.yaml'slogging.level: debug— both silently no-op otherwise, producing false timeouts. Also: extendxce-deploy-ha'sdeploy-ha.sh(opt-in, conditional-on-binary-present, mirroring its existing worker/scheduler pattern) plus a generatedstart-all.sh, rather than building a parallel standalone deploy script — avoids re-implementing the same deploy conventions twice.- This project's existing home for a standalone, CLI-runnable regression/integration check that needs a REAL build or live deployment (not a meson
test()) issrc/tools/test-<topic>.sh—test-commit-durability.shandtest-heartbeat-tolerance.share the established precedent (shared header-comment style documenting the invariant under test + its spec,green()/red()/yellow()colour helpers, apass()/fail()counter convention). Followed this forbuild-time-versioningtask 6.1'stest-build-version-regression.shrather than inventing a meson test() (two fullrm -rf+meson setup+compile cycles per profile is far too expensive formeson test) or a new top-level test-framework directory. When a task explicitly says "use judgment / follow existing convention if the design doc doesn't pin down an exact path," checksrc/tools/first for this class of check before reaching fortestsuite/or inventing something new. xce-build.shhasset -euo pipefail, and every profile'sRUN_TESTSblock (asan only, currently) runs the FULL component meson test suite unconditionally as the LAST step of the invocation — so ANY single failing test in that suite (even a pre-existing, unrelated one, e.g. bug-1560's scheduler symlink-escape flake) makes the WHOLExce-build.sh <component> <profile> ...invocation exit non-zero, even thoughmeson compilealready fully succeeded and the real binary exists on disk. A caller/wrapper script that treats a non-zeroxce-build.shexit as "the build failed, binary unusable" will incorrectly skip/abort real post-build work (e.g. checking--versionoutput, astest-build-version-regression.shneeds to). Fix pattern: never bare-call it under your ownset -e— capture the exit code viacmd || rc=$?(NOTif cmd; then ...; fiwith no else, which loses the real nonzero code — POSIX defines anifwith a false condition and noelseas exiting 0, discovered live re-deriving this), print a WARNING distinguishing "compile succeeded, only the bundled test run failed" from a genuine failure, and let a SEPARATE binary-existence check be the actual pass/fail signal for "did the build produce something real."