53 lines
2.2 KiB
Markdown
53 lines
2.2 KiB
Markdown
---
|
|
id: "bug-1960"
|
|
status: "open"
|
|
status_updated: "2026-10-10"
|
|
status_note: "newly logged"
|
|
component: "controller"
|
|
severity: "wrong-result"
|
|
timestamp: "2026-10-10T10:16:02Z"
|
|
last_seen: "2026-10-10T10:16:02Z"
|
|
occurrences: 1
|
|
files: ["src/controller/job.c", "src/frontend/apiserver/controllers/jobs.go"]
|
|
tags: ["controller", "apiserver", "queue", "admin-control"]
|
|
related: ["bug-1938"]
|
|
gitea_issue: 391
|
|
gitea_synced_status: "open"
|
|
gitea_synced_hash: "e86054beb851"
|
|
---
|
|
|
|
# bug-1960: closed queues accept submissions: controller never checks, apiserver skips the default queue
|
|
|
|
## Description
|
|
**Observed:** (source reading; follow-up of the 2026-10-10 P0 fixes (bug-1936..1957))
|
|
Reported by the bug-1938 fix: `handle_jobsubmit()` (`src/controller/job.c`) never checks `QUEUE_STAT_CLOSED`; the apiserver's check in `preCheckJobRequest()` runs only when a queue name is given, so a submission without one goes to `normal` unchecked, and non-REST submit paths (libxce, harness) are not checked at all.
|
|
|
|
**Expected:** A submission to a closed queue (explicit or default) is rejected with a clear error on every submit path.
|
|
**Impact:** Admin queue close silently ignored for default-queue and non-REST submissions.
|
|
**Found by:** follow-up of the 2026-10-10 P0 fixes (bug-1936..1957)
|
|
## Environment
|
|
- OS: no /etc/os-release; Docker container; NixOS kernel; kernel Linux 6.18.33 x86_64
|
|
- libc: glibc 2.42-47 (interpreter /nix/store/wb6rhpznjfczwlwx23zmdrrw74bayxw4-glibc-2.42-47/lib/ld-linux-x86-64.so.2)
|
|
- Toolchain: gcc (GCC) 15.2.0, meson 1.9.1
|
|
- Build: asan (xce.build)
|
|
- Code: scheduler-framework @ 19be145d-dirty
|
|
- Deployment: any (found by source reading; confirmed by the RED test of the fix)
|
|
|
|
## Reproduction
|
|
1. Close queue `normal`.
|
|
2. Submit a job without a queue (REST) or through xce_test: it is accepted.
|
|
- Frequency: deterministic (by code reading; confirmed by the RED test of the fix)
|
|
- Evidence: the code sites quoted in Description; no logs kept.
|
|
## Root cause
|
|
TODO: required for fixed/partial
|
|
|
|
## Fix
|
|
TODO: required for fixed/partial
|
|
|
|
## Verification
|
|
- Test: TODO: name + file; RED before the fix, GREEN after
|
|
- Suites: TODO: suite results and build profile
|
|
- Live: TODO: soak/deploy run, or n/a and why
|
|
|
|
## References
|
|
- Related: none
|