Rongsong Shen
d26ff8870d
The buglog was one 27K-line JSON file whose fields covered only symptom,
root cause and fix, as free text: 2% of entries named the code version a
bug was found on, 12% the build profile, 36% a way to reproduce, and 58% of
the file was OpenWolf hook auto-detections ("Missing guard clause",
"Function not marked async" on .md files).
- .claude/skills/buglog/bug-record.md: the record standard. Eight
sections (Summary as the title, Description, Environment, Reproduction;
Root cause, Fix, Verification, References once fixed), each with the
content it must contain -- e.g. Environment needs the OS, the libc the
failing binary loads (from its ELF interpreter: glibc 2.42 in the nix
shell vs 2.40 on the host), toolchain, build profile and commit.
- .wolf/bugs/<id>.md: 500 records migrated from buglog.json; every field
verified to round-trip. They carry legacy: true and an explicit "not
recorded" where the old log had no such field; component derived from
file paths, severity from keywords (else unknown), fix_commits from
hashes in status_note/fix that git resolves (91 of 463 fixed).
- .wolf/buglog-archive.json: the 710 hook auto-detections, verbatim.
- .wolf/buglog.json is now an index generated from the records, keeping
the fields OpenWolf's hooks and `openwolf bug search` read.
- scripts/buglog.py rewritten: new (template + Environment collected from
the machine and --binary), check, status (refuses a status the record
doesn't support; fixed needs Root cause, Fix, Verification and
--commit hashes git resolves), note, recur, set, show, list, triage,
env, index. 29 unittest cases in scripts/tests/test_buglog.py.
- scripts/git-hooks/pre-commit runs `check --staged`: incomplete staged
records, a legacy record hand-changed to fixed without the fix-time
sections, a new record claiming legacy: true, or a stale index refuse
the commit.
- scripts/gitea-sync.py reads the records: issue body = the record's
sections plus linked fix commits (origin remote, GITEA_COMMIT_REPO to
override), and a body hash so an issue's text is refreshed when the
record changes.
- bug-1866 rewritten to the full standard as the worked example.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
38 lines
2.3 KiB
Markdown
38 lines
2.3 KiB
Markdown
---
|
|
id: "bug-1514"
|
|
status: "fixed"
|
|
status_updated: "2026-09-24"
|
|
status_note: ""
|
|
component: "scheduler"
|
|
severity: "unknown"
|
|
timestamp: "2026-08-10T18:46:00.000Z"
|
|
last_seen: "2026-09-19T09:00:00Z"
|
|
occurrences: 1
|
|
files: [".kiro/specs/component-failover-adoption/design.md", "tasks.md", "research.md"]
|
|
tags: ["design-review", "thread-model", "kiro-validate-design", "scheduler", "critical-issue"]
|
|
related: []
|
|
legacy: true
|
|
---
|
|
|
|
# bug-1514: kiro-validate-design Critical Issue 1: design.md claims sched_job_picker/sched_allocator are…
|
|
|
|
## Description
|
|
kiro-validate-design Critical Issue 1: design.md claims sched_job_picker/sched_allocator are 'unaffected' by a blocked xcecli_jobdispatch call, violating Req 3 AC1
|
|
|
|
## Environment
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Reproduction
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Root cause
|
|
design.md/tasks.md/research.md all wrongly claimed xcecli_jobdispatch executes on the sched_allocator thread. Verified against source: it actually runs on scheduler.c's main driver-loop thread (main.c while(1) -> xce_sched_driver_run_normal_mode_round -> driver.c on_decision -> sched_publish_dispatch, scheduler.c:1257), reached only after draining the decisions cbuf (capacity 5). sched_allocator only produces into decisions; it never calls xcecli_jobdispatch. jbuf (picker->allocator handoff) is a fixed capacity-1 scheduler-core invariant (core.c:161, never resizable). So a blocked dispatch call backpressures through decisions (5 slots) then jbuf (1 slot) -- picker/allocator get a bounded ~6-job grace window, then both stall. Not full isolation as originally claimed.
|
|
|
|
## Fix
|
|
Corrected thread attribution and rejoin-call placement in design.md (SchedulerControllerClient section, sequence diagram note, traceability table) and tasks.md (task 3.1/3.2) to point at sched_publish_dispatch/main-loop thread instead of sched_allocator. Documented the real bounded-buffering model (jbuf cap 1 + decisions cap 5 = ~6-job grace window). Added a Req 3 AC1 scope-narrowing note as a Validation Hook -- flagged for human sign-off on requirements.md, not edited directly (requirements phase already approved). Corrected the same wrong claim at its source in research.md (lines 22, 30, 84).
|
|
|
|
## Verification
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## References
|
|
_Not recorded (migrated from buglog.json)._
|